link_thumbnailer 3.0.3 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42c12677181ae4f47f9809a31f3b857e90b6de3f
-  data.tar.gz: d6e394503da26997c9c5cf67c58f0d9c2bea62ea
+  metadata.gz: f47134a149128a2df4c2a4e91fb3857b2f38d4be
+  data.tar.gz: 4dfb35562b6ecc861c2948cfc7e2bfb41c1b3705
 SHA512:
-  metadata.gz: 6d29145f60542d6a5b7b8a8ba1fddc76587823348e78bf38830b3b6d75772c53e37bda89281a0586f2a56b1a0869df9ea964cc0f58d925e8d8ef2a3a067207d5
-  data.tar.gz: 1980e7240d0c7fbe42a652ac7c1e29feceb90579dd3a6e46526cfb12d381c67e4ef55bcfd13a6d55a37a00f20cc8b37647fef6595e1bd18ca26f10e2ea56d52b
+  metadata.gz: dde01e9975a4da2c2044b5d6f203fbca53b04ce018dd1c5f70096fec040902a6fcd972d1fb054869572a37b74d6cdbc2281f6d93bb6f66328cb2388f6131df42
+  data.tar.gz: 03af8d1474d4443646a458902c9114677a71c5cfac8ef3b6e0c01964b474b3e4780001460a22b88050395a0019b818a8afbe2cefc42a39ad2edef2cf0a2a6931

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+# 3.1.0
+
+- Fix an issue when image sizes could not be retrieved.
+- Grapers now accepts an optional parameter to customize the weigth of the grader in the probablity computation.
+
+```ruby
+LinkThumbnailer::Graders::Position.new(description, weigth: 3)
+```
+
+Will give a 3 times more weigth to the `Position` grader compare to other graders.
+By default all graders have a weigth of `1`.
+
 # 3.0.3
 
 - Fix an issue when dealing with absolute urls. https://github.com/gottfrois/link_thumbnailer/issues/68

data/README.md

@@ -129,7 +129,7 @@ LinkThumbnailer.configure do |config|
   #   ->(description) { ::LinkThumbnailer::Graders::Length.new(description) },
   #   ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :class) },
   #   ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :id) },
-  #   ->(description) { ::LinkThumbnailer::Graders::Position.new(description) },
+  #   ->(description) { ::LinkThumbnailer::Graders::Position.new(description, weight: 3) },
   #   ->(description) { ::LinkThumbnailer::Graders::LinkDensity.new(description) }
   # ]
 

data/lib/generators/templates/initializer.rb

@@ -40,7 +40,7 @@ LinkThumbnailer.configure do |config|
   #   ->(description) { ::LinkThumbnailer::Graders::Length.new(description) },
   #   ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :class) },
   #   ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :id) },
-  #   ->(description) { ::LinkThumbnailer::Graders::Position.new(description) },
+  #   ->(description) { ::LinkThumbnailer::Graders::Position.new(description, weight: 3) },
   #   ->(description) { ::LinkThumbnailer::Graders::LinkDensity.new(description) }
   # ]
 

data/lib/link_thumbnailer/configuration.rb

@@ -50,7 +50,7 @@ module LinkThumbnailer
         ->(description) { ::LinkThumbnailer::Graders::Length.new(description) },
         ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :class) },
         ->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :id) },
-        ->(description) { ::LinkThumbnailer::Graders::Position.new(description) },
+        ->(description) { ::LinkThumbnailer::Graders::Position.new(description, weigth: 3) },
         ->(description) { ::LinkThumbnailer::Graders::LinkDensity.new(description) },
       ]
       @description_min_length = 50

data/lib/link_thumbnailer/grader.rb

@@ -25,7 +25,7 @@ module LinkThumbnailer
 
       graders.each do |lambda|
         instance = lambda.call(description)
-        probability *= instance.call.to_f
+        probability *= instance.call.to_f ** instance.weight
       end
 
       probability

data/lib/link_thumbnailer/graders/base.rb

@@ -4,11 +4,12 @@ module LinkThumbnailer
   module Graders
     class Base < ::SimpleDelegator
 
-      attr_reader :config, :description
+      attr_reader :config, :description, :options
 
-      def initialize(description)
+      def initialize(description, options = {})
         @config      = ::LinkThumbnailer.page.config
         @description = description
+        @options     = options
 
         super(config)
       end
@@ -17,6 +18,10 @@ module LinkThumbnailer
         fail NotImplementedError
       end
 
+      def weight
+        options.fetch(:weigth, 1)
+      end
+
       private
 
       def node

data/lib/link_thumbnailer/image_comparators/size.rb

@@ -3,7 +3,7 @@ module LinkThumbnailer
     class Size < ::LinkThumbnailer::ImageComparators::Base
 
       def call(other)
-        (other.size.min ** 2) <=> (image.size.min ** 2)
+        (other.size.min.to_i ** 2) <=> (image.size.min.to_i ** 2)
       end
 
     end

data/lib/link_thumbnailer/version.rb

@@ -1,3 +1,3 @@
 module LinkThumbnailer
-  VERSION = '3.0.3'
+  VERSION = '3.1.0'
 end

data/spec/grader_spec.rb

@@ -8,7 +8,8 @@ describe LinkThumbnailer::Grader do
   describe '#call' do
 
     let(:probability)   { 0.5 }
-    let(:grader)  { double('grader', call: probability) }
+    let(:weight) { 2 }
+    let(:grader)  { double('grader', call: probability, weight: weight) }
     let(:lambda)  { ->(_) { grader } }
     let(:graders) { [lambda, lambda] }
     let(:action)  { instance.call }
@@ -17,7 +18,7 @@ describe LinkThumbnailer::Grader do
       instance.stub(:graders).and_return(graders)
     end
 
-    it { expect(action).to eq(0.5 * 0.5) }
+    it { expect(action).to eq((0.5 * 0.5) ** weight) }
 
   end
 

data/spec/image_comparators/size_spec.rb

@@ -34,6 +34,23 @@ describe LinkThumbnailer::ImageComparators::Size do
 
     end
 
+    context 'when other image size could not be computed' do
+
+      let(:other_size) { [] }
+
+      it { expect(action).to eq(-1) }
+
+    end
+
+    context 'when self image size could not be computed' do
+
+      let(:image) { double(size: []) }
+      let(:other_size) { [10, 10] }
+
+      it { expect(action).to eq(1) }
+
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.1.0
 platform: ruby
 authors:
 - Pierre-Louis Gottfrois
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-23 00:00:00.000000000 Z
+date: 2015-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport