link_thumbnailer 1.1.2 → 2.0.0

data/spec/scrapers/base_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe LinkThumbnailer::Scrapers::Base do
+
+  let(:document) { double('document') }
+  let(:instance) { described_class.new(document) }
+
+  describe '#call' do
+
+    let(:website) { LinkThumbnailer::Models::Website.new }
+    let(:attr)    { :title }
+    let(:value)   { 'foo' }
+    let(:action)  { instance.call(website, attr) }
+
+    before do
+      instance.stub(:value).and_return(value)
+    end
+
+    it { expect { action }.to change { website.title }.from(nil).to(value) }
+
+  end
+
+  describe '#model_class' do
+
+    let(:action) { instance.send(:model_class) }
+
+    before do
+      instance.stub(:attribute_name).and_return(attr)
+    end
+
+    context 'when internal class exists' do
+
+      let(:attr) { :title }
+
+      it { expect(action).to eq(::LinkThumbnailer::Models::Title) }
+
+    end
+
+    context 'when internal class does not exists' do
+
+      let(:attr) { :foo }
+
+      it { expect { action }.to raise_exception }
+
+    end
+
+  end
+
+  describe '#modelize' do
+
+    let(:node)        { double('node') }
+    let(:text)        { 'foo' }
+    let(:model_class) { double('model_class') }
+    let(:action)      { instance.send(:modelize, node, text) }
+
+    before do
+      instance.stub(:model_class).and_return(model_class)
+    end
+
+    it 'instantiates a new model' do
+      expect(model_class).to receive(:new).with(node, text)
+      action
+    end
+
+  end
+
+end

data/spec/scrapers/opengraph/base_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+
+describe LinkThumbnailer::Scrapers::Opengraph::Base do
+
+  let(:node)      { double('node') }
+  let(:document)  { double('document') }
+  let(:instance)  { described_class.new(document) }
+
+  describe '#applicable?' do
+
+    let(:meta)    { [node, node] }
+    let(:action)  { instance.applicable? }
+
+    before do
+      instance.stub(:meta).and_return(meta)
+    end
+
+    context 'when all node is an opengraph' do
+
+      before do
+        instance.stub(:opengraph_node?).and_return(true, true)
+      end
+
+      it { expect(action).to be_true }
+
+    end
+
+    context 'when any node is an opengraph' do
+
+      before do
+        instance.stub(:opengraph_node?).and_return(true, false)
+      end
+
+      it { expect(action).to be_true }
+
+    end
+
+    context 'when no node is an opengraph' do
+
+      before do
+        instance.stub(:opengraph_node?).and_return(false, false)
+      end
+
+      it { expect(action).to be_false }
+
+    end
+
+  end
+
+  describe '#opengraph_node?' do
+
+    let(:action) { instance.send(:opengraph_node?, node) }
+
+    before do
+      node.stub(:attribute).with('name').and_return(attribute_from_name)
+    end
+
+    context 'with attribute from name valid' do
+
+      let(:attribute_from_name) { 'og:foo' }
+
+      it { expect(action).to be_true }
+
+    end
+
+    context 'with attribute from name not valid' do
+
+      let(:attribute_from_name) { 'foo' }
+
+      before do
+        node.stub(:attribute).with('property').and_return(attribute_from_property)
+      end
+
+      context 'and attribute from property valid' do
+
+        let(:attribute_from_property) { 'og:bar' }
+
+        it { expect(action).to be_true }
+
+      end
+
+      context 'and attribute from property not valid' do
+
+        let(:attribute_from_property) { 'bar' }
+
+        it { expect(action).to be_false }
+
+      end
+
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,13 +1,15 @@
-require 'simplecov'
-require 'coveralls'
-Coveralls.wear!
-
-require 'link_thumbnailer'
-require 'rspec'
-require 'webmock/rspec'
-require 'json'
-
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-
-RSpec.configure do |config|
-end
+require 'simplecov'
+require 'coveralls'
+Coveralls.wear!
+
+require 'link_thumbnailer'
+require 'rspec'
+require 'webmock/rspec'
+
+SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,153 +1,105 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Pierre-Louis Gottfrois
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-04 00:00:00.000000000 Z
+date: 2014-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.5.5
-    - - <
+        version: 1.7.7
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.5.5
-    - - <
+        version: 1.7.7
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
-  name: hashie
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: net-http-persistent
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: fastimage
+  name: net-http-persistent
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.5.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.5.5
-- !ruby/object:Gem::Dependency
-  name: json
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.7.6
-    - - <
-      - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '2.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.7.6
-    - - <
-      - !ruby/object:Gem::Version
-        version: '1.9'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.9'
 - !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.14'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.14'
-- !ruby/object:Gem::Dependency
-  name: pry
+  name: fastimage
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
+        version: '1.5'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '1.5'
 description: Ruby gem generating thumbnail images from a given URL.
 email:
 - pierrelouis.gottfrois@gmail.com
@@ -160,44 +112,80 @@ files:
 - .travis.yml
 - CHANGELOG.md
 - Gemfile
-- LICENSE
+- LICENSE.txt
 - README.md
 - Rakefile
-- app/controllers/link_thumbnailer/application_controller.rb
-- app/controllers/link_thumbnailer/previews_controller.rb
 - lib/generators/link_thumbnailer/install_generator.rb
 - lib/generators/templates/initializer.rb
 - lib/link_thumbnailer.rb
 - lib/link_thumbnailer/configuration.rb
-- lib/link_thumbnailer/doc.rb
-- lib/link_thumbnailer/doc_parser.rb
-- lib/link_thumbnailer/engine.rb
-- lib/link_thumbnailer/fetcher.rb
-- lib/link_thumbnailer/img_comparator.rb
-- lib/link_thumbnailer/img_parser.rb
-- lib/link_thumbnailer/img_url_filter.rb
-- lib/link_thumbnailer/object.rb
-- lib/link_thumbnailer/opengraph.rb
-- lib/link_thumbnailer/rails/routes.rb
-- lib/link_thumbnailer/rails/routes/mapper.rb
-- lib/link_thumbnailer/rails/routes/mapping.rb
+- lib/link_thumbnailer/exceptions.rb
+- lib/link_thumbnailer/grader.rb
+- lib/link_thumbnailer/graders/base.rb
+- lib/link_thumbnailer/graders/html_attribute.rb
+- lib/link_thumbnailer/graders/length.rb
+- lib/link_thumbnailer/graders/link_density.rb
+- lib/link_thumbnailer/graders/position.rb
+- lib/link_thumbnailer/image_comparator.rb
+- lib/link_thumbnailer/image_comparators/base.rb
+- lib/link_thumbnailer/image_comparators/size.rb
+- lib/link_thumbnailer/image_parser.rb
+- lib/link_thumbnailer/image_parsers/size.rb
+- lib/link_thumbnailer/image_parsers/type.rb
+- lib/link_thumbnailer/image_validator.rb
+- lib/link_thumbnailer/model.rb
+- lib/link_thumbnailer/models/description.rb
+- lib/link_thumbnailer/models/image.rb
+- lib/link_thumbnailer/models/title.rb
+- lib/link_thumbnailer/models/website.rb
+- lib/link_thumbnailer/page.rb
+- lib/link_thumbnailer/parser.rb
+- lib/link_thumbnailer/processor.rb
 - lib/link_thumbnailer/railtie.rb
+- lib/link_thumbnailer/scraper.rb
+- lib/link_thumbnailer/scrapers/base.rb
+- lib/link_thumbnailer/scrapers/default/base.rb
+- lib/link_thumbnailer/scrapers/default/description.rb
+- lib/link_thumbnailer/scrapers/default/images.rb
+- lib/link_thumbnailer/scrapers/default/title.rb
+- lib/link_thumbnailer/scrapers/opengraph/base.rb
+- lib/link_thumbnailer/scrapers/opengraph/description.rb
+- lib/link_thumbnailer/scrapers/opengraph/image.rb
+- lib/link_thumbnailer/scrapers/opengraph/images.rb
+- lib/link_thumbnailer/scrapers/opengraph/title.rb
 - lib/link_thumbnailer/version.rb
-- lib/link_thumbnailer/web_image.rb
 - link_thumbnailer.gemspec
-- spec/doc_parser_spec.rb
-- spec/doc_spec.rb
-- spec/examples/empty_example.html
-- spec/examples/example.html
-- spec/examples/og_example.html
-- spec/fetcher_spec.rb
-- spec/img_comparator_spec.rb
-- spec/img_url_filter_spec.rb
-- spec/link_thumbnailer_spec.rb
-- spec/object_spec.rb
-- spec/opengraph_spec.rb
+- spec/configuration_spec.rb
+- spec/examples/empty_og_image_example.html
+- spec/fixture_spec.rb
+- spec/fixtures/bar.png
+- spec/fixtures/default_from_body.html
+- spec/fixtures/default_from_meta.html
+- spec/fixtures/example.html
+- spec/fixtures/foo.png
+- spec/fixtures/og_not_valid_example.html
+- spec/fixtures/og_valid_example.html
+- spec/fixtures/og_valid_multi_image_example.html
+- spec/grader_spec.rb
+- spec/graders/base_spec.rb
+- spec/graders/html_attribute_spec.rb
+- spec/graders/length_spec.rb
+- spec/graders/link_density_spec.rb
+- spec/image_comparators/size_spec.rb
+- spec/image_parsers/size_spec.rb
+- spec/image_parsers/type_spec.rb
+- spec/image_validator_spec.rb
+- spec/model_spec.rb
+- spec/models/description_spec.rb
+- spec/models/image_spec.rb
+- spec/models/title_spec.rb
+- spec/models/website_spec.rb
+- spec/page_spec.rb
+- spec/processor_spec.rb
+- spec/scraper_spec.rb
+- spec/scrapers/base_spec.rb
+- spec/scrapers/opengraph/base_spec.rb
 - spec/spec_helper.rb
-- spec/web_image_spec.rb
 homepage: https://github.com/gottfrois/link_thumbnailer
 licenses: []
 metadata: {}
@@ -207,32 +195,50 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby gem ranking images from a given URL returning an object containing images
   and website informations.
 test_files:
-- spec/doc_parser_spec.rb
-- spec/doc_spec.rb
-- spec/examples/empty_example.html
-- spec/examples/example.html
-- spec/examples/og_example.html
-- spec/fetcher_spec.rb
-- spec/img_comparator_spec.rb
-- spec/img_url_filter_spec.rb
-- spec/link_thumbnailer_spec.rb
-- spec/object_spec.rb
-- spec/opengraph_spec.rb
+- spec/configuration_spec.rb
+- spec/examples/empty_og_image_example.html
+- spec/fixture_spec.rb
+- spec/fixtures/bar.png
+- spec/fixtures/default_from_body.html
+- spec/fixtures/default_from_meta.html
+- spec/fixtures/example.html
+- spec/fixtures/foo.png
+- spec/fixtures/og_not_valid_example.html
+- spec/fixtures/og_valid_example.html
+- spec/fixtures/og_valid_multi_image_example.html
+- spec/grader_spec.rb
+- spec/graders/base_spec.rb
+- spec/graders/html_attribute_spec.rb
+- spec/graders/length_spec.rb
+- spec/graders/link_density_spec.rb
+- spec/image_comparators/size_spec.rb
+- spec/image_parsers/size_spec.rb
+- spec/image_parsers/type_spec.rb
+- spec/image_validator_spec.rb
+- spec/model_spec.rb
+- spec/models/description_spec.rb
+- spec/models/image_spec.rb
+- spec/models/title_spec.rb
+- spec/models/website_spec.rb
+- spec/page_spec.rb
+- spec/processor_spec.rb
+- spec/scraper_spec.rb
+- spec/scrapers/base_spec.rb
+- spec/scrapers/opengraph/base_spec.rb
 - spec/spec_helper.rb
-- spec/web_image_spec.rb

data/app/controllers/link_thumbnailer/application_controller.rb

@@ -1,4 +0,0 @@
-module LinkThumbnailer
-  class ApplicationController < ActionController::Base
-  end
-end

data/app/controllers/link_thumbnailer/previews_controller.rb

@@ -1,11 +0,0 @@
-module LinkThumbnailer
-  class PreviewsController < ApplicationController
-
-    respond_to :json
-
-    def create
-      @preview = LinkThumbnailer.generate(params[:url])
-      render json: @preview.to_json
-    end
-  end
-end

data/lib/link_thumbnailer/doc.rb

@@ -1,65 +0,0 @@
-require 'uri'
-
-module LinkThumbnailer
-
-  module Doc
-
-    def doc_base_href
-      base = at('//head/base')
-      base['href'] if base
-    end
-
-    def img_srcs
-      search('//img').map { |i| i['src'] }.compact
-    end
-
-    def img_abs_urls(base_url = nil)
-      result = []
-
-      img_srcs.each do |i|
-        begin
-          u = URI(i)
-        rescue URI::InvalidURIError
-          next
-        end
-
-        result << if u.is_a?(URI::HTTP)
-                    u
-                  else
-                    URI.join(base_url || doc_base_href || source_url, i)
-                  end
-      end
-
-      result
-    end
-
-    def title
-      css('title').text.strip
-    end
-
-    def description
-      if element = xpath("//meta[translate(@name,'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz') = 'description' and @content]").first
-        return element.attributes['content'].value.strip
-      end
-
-      css('body p').each do |node|
-        if !node.has_attribute?('style') && node.first_element_child.nil?
-          return node.text.strip
-        end
-      end
-
-      nil
-    end
-
-    def canonical_url
-      if element = xpath("//link[translate(@rel, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz') = 'canonical' and @href]").first
-        return element.attributes['href'].value.strip
-      end
-      nil
-    end
-
-    attr_accessor :source_url
-
-  end
-
-end

data/lib/link_thumbnailer/doc_parser.rb

@@ -1,15 +0,0 @@
-require 'nokogiri'
-
-module LinkThumbnailer
-
-  class DocParser
-
-    def parse(doc_string, source_url = nil)
-      doc = Nokogiri::HTML(doc_string).extend(LinkThumbnailer::Doc)
-      doc.source_url = source_url
-      doc
-    end
-
-  end
-
-end

data/lib/link_thumbnailer/engine.rb

@@ -1,4 +0,0 @@
-module LinkThumbnailer
-  class Engine < ::Rails::Engine
-  end
-end

data/lib/link_thumbnailer/fetcher.rb

@@ -1,34 +0,0 @@
-require 'net/http/persistent'
-
-module LinkThumbnailer
-
-  class Fetcher
-
-    attr_accessor :url
-
-    def fetch(url, redirect_count = 0)
-      if redirect_count > LinkThumbnailer.configuration.redirect_limit
-        raise ArgumentError, "too many redirects (#{redirect_count})"
-      end
-
-      self.url = url.is_a?(URI) ? url : URI(url)
-
-      if self.url.is_a?(URI::HTTP)
-        http                        = Net::HTTP::Persistent.new('linkthumbnailer')
-        http.headers['User-Agent']  = LinkThumbnailer.configuration.user_agent
-        http.verify_mode            = OpenSSL::SSL::VERIFY_NONE unless LinkThumbnailer.configuration.verify_ssl
-        http.open_timeout           = LinkThumbnailer.configuration.http_timeout
-        resp                        = http.request(self.url)
-        case resp
-        when Net::HTTPSuccess     then resp.body
-        when Net::HTTPRedirection
-          location = resp['location'].start_with?('http') ? resp['location'] : "#{self.url.scheme}://#{self.url.host}#{resp['location']}"
-          fetch(location, redirect_count + 1)
-        else resp.error!
-        end
-      end
-    end
-
-  end
-
-end