link_thumbnailer 1.0.4 → 1.0.5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.0.5
+
+- Thanks to [phlegx](https://github.com/phlegx), support for timeout http connection through configurations.
+
 # 1.0.4
 
 - Fix issue #7: nil img was returned when exception is raised. Now skiping nil images in results.

data/README.md

@@ -143,6 +143,9 @@ In `config/initializers/link_thumbnailer.rb`
 
 	  # Enable or disable SSL verification
   	# config.verify_ssl = true
+  	
+	  # HTTP open_timeout: The amount of time in seconds to wait for a connection to be opened.
+	  # config.http_timeout = 5
 	end
 
 ## Features

data/lib/generators/templates/initializer.rb

@@ -35,4 +35,7 @@ LinkThumbnailer.configure do |config|
   
   # Enable or disable SSL verification 
   # config.verify_ssl = true
+  
+  # HTTP open_timeout: The amount of time in seconds to wait for a connection to be opened.
+  # config.http_timeout = 5
 end

data/lib/link_thumbnailer.rb

@@ -37,7 +37,8 @@ module LinkThumbnailer
         :limit                => 10,
         :top                  => 5,
         :user_agent           => 'linkthumbnailer',
-        :verify_ssl           => true
+        :verify_ssl           => true,
+        :http_timeout         => 5
       )
     end
 

data/lib/link_thumbnailer/fetcher.rb

@@ -18,6 +18,7 @@ module LinkThumbnailer
         http = Net::HTTP::Persistent.new('linkthumbnailer')
         http.headers['User-Agent'] = LinkThumbnailer.configuration.user_agent
         http.verify_mode = OpenSSL::SSL::VERIFY_NONE unless LinkThumbnailer.configuration.verify_ssl
+        http.open_timeout = LinkThumbnailer.configuration.http_timeout
         resp = http.request(self.url)
         case resp
           when Net::HTTPSuccess; resp.body

data/lib/link_thumbnailer/version.rb

@@ -1,3 +1,3 @@
 module LinkThumbnailer
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 end

data/spec/link_thumbnailer_spec.rb

@@ -29,6 +29,7 @@ describe LinkThumbnailer do
         config.top                  = 10
         config.user_agent           = 'linkthumbnailer'
         config.verify_ssl           = true
+        config.http_timeout         = 5
       }
     end
 
@@ -45,6 +46,7 @@ describe LinkThumbnailer do
     specify { LinkThumbnailer.configuration.top.should                  eq(10) }
     specify { LinkThumbnailer.configuration.user_agent.should           eq('linkthumbnailer') }
     specify { LinkThumbnailer.configuration.verify_ssl.should           be_true }
+    specify { LinkThumbnailer.configuration.http_timeout.should         eq(5) }
 
   end
 
@@ -68,6 +70,7 @@ describe LinkThumbnailer do
     specify { LinkThumbnailer.configuration.top.should                  eq(5) }
     specify { LinkThumbnailer.configuration.user_agent.should           eq('linkthumbnailer') }
     specify { LinkThumbnailer.configuration.verify_ssl.should           be_true }
+    specify { LinkThumbnailer.configuration.http_timeout.should         eq(5) }
 
   end
 
@@ -117,6 +120,11 @@ describe LinkThumbnailer do
         it "should set verify_ssl option" do
           expect { LinkThumbnailer.generate('foo', verify_ssl: false).to change(LinkThumbnailer.configuration.verify_ssl).from(true).to(false) }
         end
+
+        it "should set http_timeout option" do
+          expect { LinkThumbnailer.generate('foo', http_timeout: 2).to change(LinkThumbnailer.configuration.http_timeout).from(5).to(2) }
+        end
+
       end
 
       context "when strict" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-01 00:00:00.000000000 Z
+date: 2013-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri