link_oracle 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31d4f4ed9576a0db912307886f56ee7c908c2508
-  data.tar.gz: a20c3f61a0b7c02e1d7cd0c3b1e310264cbdb7b9
+  metadata.gz: ffdf6cdb72710f8ec487c1118d15a031c79958ab
+  data.tar.gz: ab1a3ea91f64b826fac48953777124f4c33c4e02
 SHA512:
-  metadata.gz: 2796582749c379e8e86f1b48025f9be30de7da7d615b146e1ec1733ada8ecf1b77d4cc5b463e927dbb6238e8a6171217c5e65c8ad79830d6ecc4556d657119e6
-  data.tar.gz: fbd4ce096e982d9b9bdc9e4b84f5992a7686554836b78ee8140f00a09dfbd71450967291c112752385174d4aa889a39b7ce43ae29ab57e9cda1a79c29c310e6d
+  metadata.gz: ff1d2bf9b3b49cc242f60810186e4bfe08108de08481d2e4d6d9cf37a7f6baa93b0b5a50eea6070a5232b27e428a555c82f3d35d9fa5c7ba8074a0a1497f784d
+  data.tar.gz: 3e33d251e92a0c7b5bf1a45e9bbc33abc61d1c12c87230b34dfb7cae45d63077b6e2177246f9290135a1994868cbe722468b62597bfafb0d7e7f6c25fc30d525

data/lib/link_oracle/Utils/image_url_formatter.rb

@@ -8,7 +8,12 @@ module Utils
     end
 
     def perform
-      invalid_url? ? "#{scheme}://#{host}#{image_url}" : image_url
+      return unless image_url
+      invalid_url? ? "#{scheme}://#{host}#{encoded_image_url}" : encoded_image_url
+    end
+
+    def encoded_image_url
+      URI.encode(image_url)
     end
 
     def host
@@ -23,8 +28,12 @@ module Utils
       @parsed_url ||= URI.parse(url)
     end
 
+    def parsed_image_url
+      @parsed_image_url ||= URI.parse(encoded_image_url)
+    end
+
     def invalid_url?
-      image_url[0] == '/'
+      !parsed_image_url.host
     end
   end
-end
+end

data/lib/link_oracle/version.rb

@@ -1,4 +1,4 @@
 class LinkOracle
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end
 

data/spec/link_oracle/Utils/image_url_formatter_spec.rb

@@ -17,4 +17,17 @@ describe Utils::ImageUrlFormatter do
       formatted_url.should == 'https://berkin.com/some/stupid/path'
     end
   end
+
+  context 'image_url is nil' do
+    let(:image_url) { nil }
+    it 'fails silently' do
+      expect {
+        formatted_url
+      }.not_to raise_error
+    end
+
+    it 'returns nil' do
+      formatted_url.should == nil
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Ian Cooper