link_oracle 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MWY2ODU0YmEyOWEyOGQwMTM4ZmNiNTE4OGIyNDNhNDYwMjQ3MjdiYQ==
-  data.tar.gz: !binary |-
-    NzEwODVkNDg0NmVlZjRlYjQzY2JhY2ViYmJmNzhjZWZjY2RmNDcwMg==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    MTYyNDAxNjJhMjliOGFiNjQwM2IxM2Y1ZDk4ZmNhMTRjNmRkM2YyOGIzMDFh
-    ZjZkNjE2ODA1Y2E3MGYwYjQzYzdmZmUwMTViMmEyMTk0OGI4N2QxMjllZWZj
-    OTdhOTEyNTcyYjJkYjlkYTg3YmQ5YTZkYmZhN2JjMDNjNmJmYTc=
-  data.tar.gz: !binary |-
-    M2Y5OGM3ZmRmNTBkYmI2ZWQ2NjlhYmVkZjhjZDkzOGRmNzE4NDRjYThhYzA4
-    YmM0MDNlMzYwNzkwY2Q1NDgwY2IxYjI0NDNmNDEwOWE2NDI3NmQzNDE5ZmM2
-    YWRhZmM5YWY2NjVkYzI3ZGZiOWQ1YzUwYWU0MTY3OWRkOTNkNjg=
+SHA1:
+  metadata.gz: 31d4f4ed9576a0db912307886f56ee7c908c2508
+  data.tar.gz: a20c3f61a0b7c02e1d7cd0c3b1e310264cbdb7b9
+SHA512:
+  metadata.gz: 2796582749c379e8e86f1b48025f9be30de7da7d615b146e1ec1733ada8ecf1b77d4cc5b463e927dbb6238e8a6171217c5e65c8ad79830d6ecc4556d657119e6
+  data.tar.gz: fbd4ce096e982d9b9bdc9e4b84f5992a7686554836b78ee8140f00a09dfbd71450967291c112752385174d4aa889a39b7ce43ae29ab57e9cda1a79c29c310e6d

data/lib/link_oracle.rb

@@ -10,7 +10,7 @@ Dir["#{File.dirname(__FILE__)}/link_oracle/**/*.rb"].each {|f| require f}
 
 class LinkOracle
   def self.extract_from(url)
-    parsed_data = LinkOracle::Request.new(url).parsed_data
-    LinkData.new(parsed_data)
+    parsed_url = LinkOracle::Request.new(url).parsed_url
+    LinkData.new(parsed_url)
   end
 end

data/lib/link_oracle/Utils/image_url_formatter.rb

@@ -0,0 +1,30 @@
+module Utils
+  class ImageUrlFormatter
+    attr_reader :url, :image_url
+
+    def initialize(url, image_url)
+      @url = url
+      @image_url = image_url
+    end
+
+    def perform
+      invalid_url? ? "#{scheme}://#{host}#{image_url}" : image_url
+    end
+
+    def host
+      parsed_url.host
+    end
+
+    def scheme
+      parsed_url.scheme
+    end
+
+    def parsed_url
+      @parsed_url ||= URI.parse(url)
+    end
+
+    def invalid_url?
+      image_url[0] == '/'
+    end
+  end
+end

data/lib/link_oracle/link_data.rb

@@ -1,9 +1,10 @@
 class LinkOracle
   class LinkData
-    attr_reader :parsed_data
+    attr_reader :parsed_data, :url
 
-    def initialize(parsed_data)
-      @parsed_data = parsed_data
+    def initialize(parsed_url)
+      @parsed_data = parsed_url[:parsed_data]
+      @url = parsed_url[:url]
     end
 
     #TODO: Need to write tests for these
@@ -16,7 +17,7 @@ class LinkOracle
     end
 
     def image_url
-      og.image_url || meta.image_url || body.image_url
+      Utils::ImageUrlFormatter.new(url, og.image_url || meta.image_url || body.image_url).perform
     end
 
     def og

data/lib/link_oracle/request.rb

@@ -6,10 +6,17 @@ class LinkOracle
       @url = url
     end
 
-    def parsed_data
+    def parsed_url
       validate_url
       validate_request
-      parsed_body
+      results
+    end
+
+    def results
+      {
+        parsed_data: parsed_data,
+        url: url
+      }
     end
 
     def validate_request
@@ -38,7 +45,7 @@ class LinkOracle
       }[response.code] || BadThingsHappened
     end
 
-    def parsed_body
+    def parsed_data
       ::Nokogiri::HTML.parse(response.body)
     rescue
       raise ParsingError

data/lib/link_oracle/version.rb

@@ -1,4 +1,4 @@
 class LinkOracle
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end
 

data/link_preview.gemspec

@@ -7,7 +7,7 @@ require 'link_oracle/version'
 Gem::Specification.new do |spec|
   spec.name          = "link_oracle"
   spec.version       = LinkOracle::VERSION
-  spec.authors       = ["Ian Cooper", 'Fito von Zastrow', 'Kane Baccigalupi']
+  spec.authors       = ["Ian Cooper", 'Fito von Zastrow', 'Kane Baccigalupi', 'Sowjanya Mudunuri']
   spec.email         = ["developers@socialchorus.com"]
   spec.description   = %q{Scrapes pages for open graph, meta, and lastly, body preview data}
   spec.summary       = %q{Scrapes pages for open graph, meta, and lastly, body preview data}

data/spec/link_oracle/Utils/image_url_formatter_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Utils::ImageUrlFormatter do
+  let(:url) { "http://berkin.com/whatever/else/is/here" }
+  let(:image_url) { "/some/stupid/path" }
+  let(:formatted_url) { Utils::ImageUrlFormatter.new(url, image_url).perform }
+
+  context 'scheme is http' do
+    it 'should return the image as a full url using the host as domain' do
+      formatted_url.should == 'http://berkin.com/some/stupid/path'
+    end
+  end
+
+  context 'scheme is https' do
+    let(:url) { "https://berkin.com/whatever/else/is/here" }
+    it 'should return the image as a full url using the host as domain' do
+      formatted_url.should == 'https://berkin.com/some/stupid/path'
+    end
+  end
+end

data/spec/link_oracle/request_spec.rb

@@ -42,7 +42,7 @@ describe LinkOracle::Request do
 
         it 'should raise PageNotFound' do
           expect {
-            requester.parsed_data
+            requester.parsed_url
           }.to raise_error(LinkOracle::PageNotFound)
         end
       end
@@ -52,7 +52,7 @@ describe LinkOracle::Request do
 
         it 'should raise PermissionDenied' do
           expect {
-            requester.parsed_data
+            requester.parsed_url
           }.to raise_error(LinkOracle::PermissionDenied)
         end
       end
@@ -62,7 +62,7 @@ describe LinkOracle::Request do
 
         it 'should raise BadThingsHappened' do
           expect {
-            requester.parsed_data
+            requester.parsed_url
           }.to raise_error(LinkOracle::BadThingsHappened)
         end
       end
@@ -72,7 +72,7 @@ describe LinkOracle::Request do
 
         it 'should raise InvalidUrl' do
           expect {
-            requester.parsed_data
+            requester.parsed_url
           }.to raise_error(LinkOracle::InvalidUrl)
         end
       end
@@ -84,7 +84,7 @@ describe LinkOracle::Request do
 
         it 'should raise ParsingError' do
           expect {
-            requester.parsed_data
+            requester.parsed_url
           }.to raise_error(LinkOracle::ParsingError)
         end
       end

data/spec/link_preview_spec.rb

@@ -59,5 +59,4 @@ describe LinkOracle do
       link_data.description.should == 'A description for your face'
     end
   end
-
 end

metadata

@@ -1,43 +1,44 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ian Cooper
 - Fito von Zastrow
 - Kane Baccigalupi
+- Sowjanya Mudunuri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-28 00:00:00.000000000 Z
+date: 2013-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -58,28 +59,28 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Scrapes pages for open graph, meta, and lastly, body preview data
@@ -95,6 +96,7 @@ files:
 - README.md
 - Rakefile
 - lib/link_oracle.rb
+- lib/link_oracle/Utils/image_url_formatter.rb
 - lib/link_oracle/extractor/base.rb
 - lib/link_oracle/extractor/body.rb
 - lib/link_oracle/extractor/meta.rb
@@ -104,6 +106,7 @@ files:
 - lib/link_oracle/request.rb
 - lib/link_oracle/version.rb
 - link_preview.gemspec
+- spec/link_oracle/Utils/image_url_formatter_spec.rb
 - spec/link_oracle/extractor/body_spec.rb
 - spec/link_oracle/extractor/meta_spec.rb
 - spec/link_oracle/extractor/og_spec.rb
@@ -120,12 +123,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -135,6 +138,7 @@ signing_key:
 specification_version: 4
 summary: Scrapes pages for open graph, meta, and lastly, body preview data
 test_files:
+- spec/link_oracle/Utils/image_url_formatter_spec.rb
 - spec/link_oracle/extractor/body_spec.rb
 - spec/link_oracle/extractor/meta_spec.rb
 - spec/link_oracle/extractor/og_spec.rb