linecounter 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9826e951ee479ac0be77163811c7bcd4e6b37489ce40c2ab4090348760e51c1b
-  data.tar.gz: 3a0ffeab5b6d22b4c768e8bbfd69387b161df1774ae6b4e4bb59a1c62bf3cfc1
+  metadata.gz: 98e5cacd90c7df107053970b93d250d554f6220d2929569271f391205ed731c7
+  data.tar.gz: d2693bf65a29b6af2e8e8c374013f611a4724eed9af679bb1c1a33af8bd8cff5
 SHA512:
-  metadata.gz: d8ef5a38346f6def7c34c43bd6d32fbb6c79ea89da0c793323bfe9084917e2f9c370fb3ca3a86252ef72fde8cbaadf48776ec86f82ebc2ac04965615c9627232
-  data.tar.gz: dc631e326efb57ad2bc33ef730c2593558c46af66f2371c3a5d11d6e7a54f36c7feb044a1331c779bff47ed78bcfe643ff468309f8bbcc6e009ab93ae323931a
+  metadata.gz: 1c3d2a41191872cc1198591b2f668bd59bdfcbc7170e2aab00b9f9ab536f57ddbf6d0b1454cd968637e964ce8b2c347b69c85df0d055f93bac166f33de4f4ec2
+  data.tar.gz: 2b4192f5a738fa6ea680823360eb99fc791c3991f04fcff8fb129c7cda2d2e48096acc4cd106eee45edb2268c8a7ec52a66c93738419e6aed1be28a7a7901dc6

data/CHANGELOG.md

@@ -6,6 +6,19 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [0.1.3] - 2026-07-02
+
+### Added
+- `--crud-only-controllers` lists Rails controllers whose public actions are all
+  standard RESTful actions (index/show/new/create/edit/update/destroy). Private
+  and protected helpers are ignored; a single non-CRUD public action excludes a
+  controller. Available in both text and JSON output.
+- `--non-crud-controllers` lists the inverse of `--crud-only-controllers`:
+  controllers that expose at least one custom (non-RESTful) public action, with
+  those extra actions shown. Available in both text and JSON output.
+- `--no-churn` skips the per-file git churn computation, which dominates runtime
+  on large repositories (one `git log` per file). The Churn column reports 0.
+
 ## [0.1.2] - 2026-05-24
 
 ### Changed
@@ -33,7 +46,8 @@ release is the intended patch following 0.1.1.
 - AST-based analysis via Prism for accurate structure and branch signals
   (no false positives from keywords in strings, comments, or method bodies).
 
-[Unreleased]: https://github.com/roberthopman/linecounter/compare/v0.1.2...HEAD
+[Unreleased]: https://github.com/roberthopman/linecounter/compare/v0.1.3...HEAD
+[0.1.3]: https://github.com/roberthopman/linecounter/compare/v0.1.2...v0.1.3
 [0.1.2]: https://github.com/roberthopman/linecounter/compare/v0.1.1...v0.1.2
 [0.1.1]: https://github.com/roberthopman/linecounter/compare/v0.1.0...v0.1.1
 [0.1.0]: https://github.com/roberthopman/linecounter/releases/tag/v0.1.0

data/README.md

@@ -39,6 +39,9 @@ linecounter [options]
 - `--show-structure-overview` Show a summary of class structure counts across all files, including `avg_loc_per_item` (avg statement lines per item).
 - `--show-interaction-overview` Alias for `--show-structure-overview`.
 - `--detailed-structure` Show overall structure averages (avg lines per item) for each regex item across all files.
+- `--crud-only-controllers` List Rails controllers (files matching `app/controllers/**/*_controller.rb`) whose public actions are all standard RESTful actions (`index`, `show`, `new`, `create`, `edit`, `update`, `destroy`). Private and protected methods are ignored; a single non-CRUD public action excludes the controller.
+- `--non-crud-controllers` The inverse: list controllers that expose at least one custom (non-RESTful) public action, showing those extra actions. Useful for spotting controllers that have grown beyond plain resourceful routing.
+- `--no-churn` Skip git churn computation. Churn runs one `git log` per file, so on large repos it dominates runtime; skipping it makes runs near-instant at the cost of a `0` Churn column. Useful with `--crud-only-controllers`, which does not need churn.
 - `-h`, `--help` Show help.
 
 ## Examples
@@ -57,6 +60,8 @@ linecounter --repo /path/to/repo --min-loc 50
 linecounter --repo /path/to/repo --show-branch-count
 linecounter --repo /path/to/repo --show-structure-overview
 linecounter --repo /path/to/repo --detailed-structure
+linecounter --repo /path/to/repo --crud-only-controllers
+linecounter --repo /path/to/repo --non-crud-controllers --no-churn
 linecounter --repo /path/to/repo --json
 linecounter --repo /path/to/repo --top 30 --since 3.months.ago --show-structure-overview
 ```

data/lib/linecounter/analyzer.rb

@@ -13,9 +13,11 @@ module Linecounter
   )
 
   module Analyzer
+    CONTROLLER_PATH = %r{app/controllers/.*_controller\.rb\z}
+
     module_function
 
-    def run(repo_path:, min_loc:, since:)
+    def run(repo_path:, min_loc:, since:, churn: true)
       rows = []
       structure_overview = Hash.new(0)
       structure_item_loc_overview = Hash.new(0)
@@ -28,12 +30,14 @@ module Linecounter
 
         breakdown = BranchAnalyzer.breakdown(content)
         b = breakdown.values.sum
-        c = Git.churn(repo_path, file, since)
+        c = churn ? Git.churn(repo_path, file, since) : 0
         structures, structure_item_counts, structure_item_loc = StructureAnalyzer.counts(content)
         structures.each { |k, v| structure_overview[k] += v }
         structure_item_loc.each { |k, v| structure_item_loc_overview[k] += v }
         structure_item_counts.each { |k, v| structure_item_counts_overview[k] += v }
 
+        crud_profile = file.match?(CONTROLLER_PATH) ? StructureAnalyzer.crud_profile(content) : nil
+
         rows << {
           file: file,
           loc: size,
@@ -42,6 +46,7 @@ module Linecounter
           structures: structures,
           structure_item_counts: structure_item_counts,
           structure_item_loc: structure_item_loc,
+          crud_profile: crud_profile,
           churn: c
         }
       end

data/lib/linecounter/cli.rb

@@ -13,6 +13,9 @@ module Linecounter
       show_branch_count: false,
       show_structure_overview: false,
       show_detailed_structure: false,
+      crud_only_controllers: false,
+      non_crud_controllers: false,
+      no_churn: false,
       repo: nil
     }.freeze
 
@@ -28,7 +31,7 @@ module Linecounter
       repo_path = File.expand_path(options[:repo])
       abort "Not inside a git repository: #{repo_path}" unless Git.repo?(repo_path)
 
-      result = Analyzer.run(repo_path: repo_path, min_loc: options[:min_loc], since: options[:since])
+      result = Analyzer.run(repo_path: repo_path, min_loc: options[:min_loc], since: options[:since], churn: !options[:no_churn])
       Report.render(result, options)
     end
 
@@ -46,6 +49,9 @@ module Linecounter
         o.on("--show-structure-overview", "Show a summary of class structure counts across all files, including avg_loc_per_item (avg statement lines per item).") { options[:show_structure_overview] = true }
         o.on("--show-interaction-overview", "Alias for --show-structure-overview.") { options[:show_structure_overview] = true }
         o.on("--detailed-structure", "Show overall structure averages (avg lines per item) for each regex item across all files.") { options[:show_detailed_structure] = true }
+        o.on("--crud-only-controllers", "List Rails controllers whose public actions are all standard RESTful actions (index/show/new/create/edit/update/destroy).") { options[:crud_only_controllers] = true }
+        o.on("--non-crud-controllers", "List Rails controllers that expose custom (non-RESTful) public actions, showing those extra actions.") { options[:non_crud_controllers] = true }
+        o.on("--no-churn", "Skip git churn computation (much faster on large repos; the Churn column reports 0).") { options[:no_churn] = true }
         o.on("-h", "--help", "Show this help.") { puts o; exit }
         o.separator ""
         o.separator "Examples:"
@@ -58,6 +64,8 @@ module Linecounter
         o.separator "  linecounter --repo /path/to/repo --show-branch-count"
         o.separator "  linecounter --repo /path/to/repo --show-structure-overview"
         o.separator "  linecounter --repo /path/to/repo --detailed-structure"
+        o.separator "  linecounter --repo /path/to/repo --crud-only-controllers"
+        o.separator "  linecounter --repo /path/to/repo --non-crud-controllers"
         o.separator "  linecounter --repo /path/to/repo --json"
         o.separator "  linecounter --repo /path/to/repo --top 30 --since 3.months.ago"
       end

data/lib/linecounter/report.rb

@@ -36,6 +36,17 @@ module Linecounter
       unless options[:show_detailed_structure]
         payload[:top] = payload[:top].map { |r| r.reject { |k, _| k == :structure_item_loc || k == :structure_item_counts } }
       end
+      payload[:top] = payload[:top].map { |r| r.reject { |k, _| k == :crud_profile } }
+      if options[:crud_only_controllers]
+        payload[:crud_only_controllers] = crud_only_controllers(rows).map do |r|
+          { file: r[:file], actions: r[:crud_profile][:actions] }
+        end
+      end
+      if options[:non_crud_controllers]
+        payload[:non_crud_controllers] = non_crud_controllers(rows).map do |r|
+          { file: r[:file], actions: r[:crud_profile][:actions], extra_actions: r[:crud_profile][:extra_actions] }
+        end
+      end
       puts JSON.pretty_generate(payload)
     end
 
@@ -88,6 +99,48 @@ module Linecounter
           lines.each { |line| puts line }
         end
       end
+
+      if options[:crud_only_controllers]
+        controllers = rows.select { |r| r[:crud_profile] }
+        crud_only = crud_only_controllers(rows)
+        puts
+        puts "CRUD-only controllers:"
+        puts "Controllers scanned: #{controllers.size}"
+        puts "CRUD-only: #{crud_only.size}"
+        puts
+        crud_only.each do |r|
+          puts "  %s  %s" % [r[:file], r[:crud_profile][:actions].join(", ")]
+        end
+      end
+
+      if options[:non_crud_controllers]
+        controllers = rows.select { |r| r[:crud_profile] }
+        non_crud = non_crud_controllers(rows)
+        puts
+        puts "Non-CRUD controllers:"
+        puts "Controllers scanned: #{controllers.size}"
+        puts "Non-CRUD: #{non_crud.size}"
+        puts
+        non_crud.each do |r|
+          puts "  %s  %s" % [r[:file], r[:crud_profile][:extra_actions].join(", ")]
+        end
+      end
+    end
+
+    # Rows for controllers whose public actions are all standard RESTful
+    # actions, sorted by path for stable output.
+    def crud_only_controllers(rows)
+      rows
+        .select { |r| r[:crud_profile]&.fetch(:crud_only) }
+        .sort_by { |r| r[:file] }
+    end
+
+    # Rows for controllers that expose at least one custom (non-RESTful) public
+    # action, sorted by path for stable output.
+    def non_crud_controllers(rows)
+      rows
+        .select { |r| r[:crud_profile] && !r[:crud_profile][:crud_only] }
+        .sort_by { |r| r[:file] }
     end
 
     # Total statement LOC for a structure type, summed from its items. The

data/lib/linecounter/structure_analyzer.rb

@@ -82,13 +82,16 @@ module Linecounter
     # macro, and constant is attributed accurately at the structure level only
     # (declarations inside method bodies are not miscounted).
     class StructureVisitor < Prism::Visitor
-      attr_reader :type_counts, :item_counts, :item_loc_sums
+      attr_reader :type_counts, :item_counts, :item_loc_sums,
+                  :public_instance_method_names, :class_names
 
       def initialize
         super
         @type_counts = Hash.new(0)
         @item_counts = Hash.new(0)
         @item_loc_sums = Hash.new(0)
+        @public_instance_method_names = []
+        @class_names = []
         @visibility = [:public]
         @method_depth = 0
         @singleton_depth = 0
@@ -96,6 +99,7 @@ module Linecounter
       end
 
       def visit_class_node(node)
+        @class_names << node.constant_path.slice
         with_scope { super }
       end
 
@@ -177,7 +181,9 @@ module Linecounter
         elsif node.name == :initialize
           record(:initializer_def, node)
         else
-          record(VISIBILITY_DEF_KEYS.fetch(current_visibility), node)
+          key = VISIBILITY_DEF_KEYS.fetch(current_visibility)
+          @public_instance_method_names << node.name if key == :public_instance_method_def
+          record(key, node)
         end
       end
 
@@ -212,6 +218,9 @@ module Linecounter
       end
     end
 
+    # The seven standard Rails RESTful actions.
+    CRUD_ACTIONS = %i[index show new create edit update destroy].freeze
+
     module_function
 
     def counts(content)
@@ -219,5 +228,25 @@ module Linecounter
       Prism.parse(content).value.accept(visitor)
       [visitor.type_counts, visitor.item_counts, visitor.item_loc_sums]
     end
+
+    # Classifies a Ruby source as a Rails controller by CRUD coverage. Returns
+    # nil unless the source defines a class named *Controller with at least one
+    # public action; otherwise a hash describing how its public actions relate
+    # to the standard RESTful set.
+    def crud_profile(content)
+      visitor = StructureVisitor.new
+      Prism.parse(content).value.accept(visitor)
+      return nil unless visitor.class_names.any? { |name| name.end_with?("Controller") }
+
+      actions = visitor.public_instance_method_names
+      return nil if actions.empty?
+
+      extra = actions - CRUD_ACTIONS
+      {
+        actions: actions & CRUD_ACTIONS,
+        extra_actions: extra,
+        crud_only: extra.empty?
+      }
+    end
   end
 end

data/lib/linecounter/version.rb

@@ -1,3 +1,3 @@
 module Linecounter
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: linecounter
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Robert Hopman