lightspeed_pos 0.4.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b42db3649e13304941c1fb7770b350bccb22d5751c1f8277c290df0134ea468
-  data.tar.gz: b2f9b9005019a428f673e7d6999fbc3f4900f2923b13342c9050d0deb88dbc51
+  metadata.gz: 698710d57a5ef3c30c022c2f050b9df04976227b2482a3075c851b27db3642fe
+  data.tar.gz: 6abdc460a2cd345883c2cb853c9c6c16051273606914d7ba5fcaa72089402dae
 SHA512:
-  metadata.gz: 34f6532de1edfe8417970b7b255557b7882d2bc4df373bdf69631f29bed3b941f7db5eb4a38a1a074bebc539b5e3c6e192d47d3d6db8a5294b6aa4d156fc1c10
-  data.tar.gz: 78455dc05e80e7246e13dd858bcb30d40956a75967ed9e8bb516e24b122be63287b8678d508d29c25483615be7ad7488395cb7a2f1a3c93631c6f819dddef06f
+  metadata.gz: 03f3b9db98a4145a9751b2990beabccf96d79a78fece26a40a3163ffe0d8604ea41ad0316b52ce9a3e27f77fea1e6cb0ce708438bc37c22cacef0a0401ef9245
+  data.tar.gz: 3c8f3710b4f8e76bda81e5e02265115c0252c38b8c177ff707c9dab53026da1d8598504d77ae9d31c3a17a0cfa2796d5cd293355b25b7c8aeca4e44762e26830

data/.rubocop.yml

@@ -1,70 +1,73 @@
 inherit_from: .rubocop_todo.yml
 
-AlignHash:
+AllCops:
+  NewCops: enable
+  SuggestExtensions:
+    rubocop-rake: false
+    rubocop-rspec: false
+
+Layout/HashAlignment:
   EnforcedLastArgumentHashStyle: always_ignore
 
-AlignParameters:
+Layout/ParameterAlignment:
   Enabled: false
 
-LineLength:
+Layout/LineLength:
   Max: 180
 
-ClassLength:
+Metrics/ClassLength:
   Enabled: true
   Severity: refactor
   Max: 300
 
-MethodLength:
+Metrics/MethodLength:
   Enabled: true
   Max: 30
   Severity: refactor
 
-CyclomaticComplexity:
+Metrics/CyclomaticComplexity:
   Max: 10
   Severity: refactor
 
-EndAlignment:
+Layout/EndAlignment:
   Enabled: false
 
-StringLiterals:
+Style/StringLiterals:
   Enabled: false
 
-Documentation:
+Style/Documentation:
   Enabled: false
 
-PercentLiteralDelimiters:
+Style/PercentLiteralDelimiters:
   PreferredDelimiters:
     '%w': '{}'
 
-MethodDefParentheses:
+Style/MethodDefParentheses:
   Enabled: false
 
-PredicateName:
-  NamePrefixBlacklist:
+Naming/PredicateName:
+  ForbiddenPrefixes:
     - is_
     - have_
 
-IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 # breaks using if blocks with assignments
-IndentationWidth:
+Layout/IndentationWidth:
   Enabled: false
 
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-FormatString:
-  Enabled: false
-
-ActionFilter:
+Style/FormatString:
   Enabled: false
 
 # different methods calls that do exactly the same thing are a smell, regardless of semantics
-SignalException:
+Style/SignalException:
   EnforcedStyle: only_raise
 
-DoubleNegation:
+Style/DoubleNegation:
   Enabled: false
 
 Style/TrailingCommaInArrayLiteral:

data/.rubocop_todo.yml

@@ -68,12 +68,6 @@ Layout/EmptyLinesAroundClassBody:
     - 'lib/lightspeed/sale_line.rb'
     - 'lib/lightspeed/vendor.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/LeadingBlankLines:
-  Exclude:
-    - 'lib/lightspeed/item.rb'
-
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -108,7 +102,7 @@ Layout/SpaceInsideHashLiteralBraces:
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Exclude:
     - 'lib/lightspeed/customer.rb'
     - 'lib/lightspeed/customers.rb'
@@ -174,7 +168,7 @@ Metrics/BlockLength:
 # Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Exclude:
     - 'lib/lightspeed/accounts.rb'
     - 'lib/lightspeed/collection.rb'
@@ -199,14 +193,6 @@ Style/Alias:
     - 'lib/lightspeed/vendor.rb'
     - 'lib/lightspeed/vendors.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'spec/lightspeed/sales_spec.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: Keywords.

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
 rvm:
-  - 2.3
-  - 2.4
   - 2.5
+  - 2.6
+  - 2.7
+  - 3.0
 script:
   - 'bundle exec rubocop'
   - 'bundle exec rspec spec'

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in lightspeed-pos.gemspec

data/Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'dotenv'

data/lib/lightspeed/account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'uri'
 require_relative 'categories'
 require_relative 'employees'

data/lib/lightspeed/accounts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 require_relative 'account'
 
@@ -11,7 +13,7 @@ module Lightspeed
       first_loaded || first
     end
 
-    def page(n, *args)
+    def page(n, **args)
       # turns out lightspeed doesn't respect pagination for accounts.
       # so page(1) is identical to page(0).
       # they should be different, thus.

data/lib/lightspeed/categories.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'category'
 require_relative 'collection'
 

data/lib/lightspeed/category.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/array/wrap'
 
 require_relative 'accounts'
@@ -21,19 +23,19 @@ module Lightspeed
     end
 
     def get(**args)
-      perform_request(args.merge(method: :get))
+      perform_request(**args, method: :get)
     end
 
     def post(**args)
-      perform_request(args.merge(method: :post))
+      perform_request(**args, method: :post)
     end
 
     def put(**args)
-      perform_request(args.merge(method: :put))
+      perform_request(**args, method: :put)
     end
 
     def delete(**args)
-      perform_request(args.merge(method: :delete))
+      perform_request(**args, method: :delete)
     end
 
     def oauth_token

data/lib/lightspeed/collection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/string'
 require 'active_support/core_ext/array/wrap'
 
@@ -174,7 +176,7 @@ module Lightspeed
       params = { load_relations: load_relations_default }
         .merge(context_params)
         .merge(params)
-        .reject { |_, v| v.nil? }
+        .compact
       client.get(
         path: collection_path,
         params: params

data/lib/lightspeed/customer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/customers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'customer'

data/lib/lightspeed/employee.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/employees.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'employee'

data/lib/lightspeed/error.rb

@@ -1,10 +1,17 @@
+# frozen_string_literal: true
+
 module Lightspeed
   class Error < Exception
     class BadRequest < Lightspeed::Error; end # 400
+
     class Unauthorized < Lightspeed::Error; end # 401
+
     class NotAuthorized < Lightspeed::Error; end # 403
+
     class NotFound < Lightspeed::Error; end # 404
+
     class InternalServerError < Lightspeed::Error; end # 500
+
     class Throttled < Lightspeed::Error; end # 503
   end
 end

data/lib/lightspeed/image.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 require_relative 'item'

data/lib/lightspeed/images.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'image'

data/lib/lightspeed/inventories.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'inventory'

data/lib/lightspeed/inventory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 require_relative 'item'

data/lib/lightspeed/item.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 require_relative 'resource'
 

data/lib/lightspeed/item_attribute_set.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/item_attribute_sets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'item_attribute_set'

data/lib/lightspeed/item_matrices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'item_matrix'

data/lib/lightspeed/item_matrix.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 require_relative 'item_attribute_set'

data/lib/lightspeed/items.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'item'

data/lib/lightspeed/order.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/orders.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'order'

data/lib/lightspeed/price_level.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/price_levels.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'price_level'

data/lib/lightspeed/prices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/string'
 require 'bigdecimal'
 
@@ -8,7 +10,7 @@ module Lightspeed
     end
 
     def prices
-      @prices ||= @attributes["ItemPrice"].map { |v| [v["useType"].parameterize.underscore.to_sym, BigDecimal.new(v["amount"])] }.to_h
+      @prices ||= @attributes["ItemPrice"].map { |v| [v["useType"].parameterize.underscore.to_sym, BigDecimal(v["amount"])] }.to_h
     end
 
     def as_json

data/lib/lightspeed/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pp'
 require 'net/http'
 
@@ -106,7 +108,7 @@ module Lightspeed
 
     def uri
       uri = self.class.base_path + @path
-      uri += "?" + URI.encode_www_form(@params) if @params && @method == :get
+      uri += "?#{URI.encode_www_form(@params)}" if @params && @method == :get
       uri
     end
 

data/lib/lightspeed/request_throttler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Lightspeed
   class RequestThrottler
     attr_accessor :bucket_level, :bucket_max, :units_per_second

data/lib/lightspeed/resource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bigdecimal'
 require 'active_support/core_ext/string'
 require 'active_support/core_ext/hash/slice'
@@ -6,7 +8,7 @@ require_relative 'collection'
 
 module Lightspeed
   class ID < Integer; end
-  class Link; end
+  class Link; end # rubocop:disable Lint/EmptyClass
   class Resource
     attr_accessor :id, :attributes, :client, :context, :account
 
@@ -32,6 +34,7 @@ module Lightspeed
     def self.fields(fields = {})
       @fields ||= []
       attr_writer(*fields.keys)
+
       fields.each do |name, klass|
         @fields << define_method(name) do
           get_transformed_value(name, klass)
@@ -45,11 +48,10 @@ module Lightspeed
       if value.is_a?(String)
         case kind
         when :string then value
-        when :integer then value.to_i
-        when :id then value.to_i
+        when :id, :integer then value.to_i
         when :datetime then DateTime.parse(value)
         when :boolean then value == 'true'
-        when :decimal then BigDecimal.new(value)
+        when :decimal then BigDecimal(value)
         when :hash then Hash.new(value)
         else
           raise ArgumentError, "Could not transform value #{value} to a #{kind}"

data/lib/lightspeed/sale.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 require_relative 'sale_lines'

data/lib/lightspeed/sale_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 require_relative 'item'
 

data/lib/lightspeed/sale_lines.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 require_relative 'sale_line'
 

data/lib/lightspeed/sales.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'sale'

data/lib/lightspeed/shop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/shops.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'shop'

data/lib/lightspeed/special_order.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/special_orders.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'special_order'

data/lib/lightspeed/vendor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 
 module Lightspeed

data/lib/lightspeed/vendors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'collection'
 
 require_relative 'vendor'

data/lib/lightspeed/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Lightspeed
-  VERSION = "0.4.0"
+  VERSION = "0.6.0"
 end

data/lib/lightspeed_pos.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yajl'
 
 module Lightspeed

data/lightspeed_pos.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'lightspeed/version'
@@ -19,6 +20,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.license       = "MIT"
 
+  spec.required_ruby_version = '>= 2.5'
+
   spec.add_dependency "activesupport"
   spec.add_dependency "yajl-ruby"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lightspeed_pos
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ryan Bigg
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-05 00:00:00.000000000 Z
+date: 2021-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -225,15 +225,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: A gem for interacting with Lightspeed's Point of Sale system