lighthouse-matchers 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b73401322398ad659f111555923e60f2859c90e1e24893c209686842340de06
-  data.tar.gz: 2fec0776316b961004e8254ab49f374dc56eff5096a3336d2216294b10cbe13c
+  metadata.gz: e47d9c8b9ac4ff8fe209317f9054fafd3c5d7c81f1f241cb61be6035940ea50a
+  data.tar.gz: 6627e960001bad68703a9a0d5eb2a20691f97f137b8293fcd24f70813c1df6d9
 SHA512:
-  metadata.gz: f847e1a748e9097df8a7345e60f3249f15ae9c3031885a756c9ce2a6bf582032d4de281c2f2b6c088a73baca86a7158f3101f637f9c376298b665848d1f9f7c2
-  data.tar.gz: f461dd4cc3b146228986c833857421a9861b9b65d0b1095b90f10dae40bed454009c83fc5b1dadb60ca246a43768fec984226933fd980abe81aa990681c3c715
+  metadata.gz: 2628e449c6d825aea0eed45bfbd2a3e9f3c63d925495033003f4c3eae649a6a4686f72ca90e388e61131aacd893a491733ed23b4762698b21bfd8c31ef7cbb04
+  data.tar.gz: 6da50b69d8d31d21ab669c3b7e1de4d74f731af703d9bae63ee8082836fa6be0a92d53bf1a64bef0bcf21c2598edaef58f6b153f3c716da3fe3a45f753f78a26

data/CHANGELOG.md

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.3.0] - 2025-08-13
+### Added
+- Write audit results to disk on failure so they can be viewed using the browser viewer ([#68](https://github.com/ackama/lighthouse-matchers/pull/68))
+
+### Changed
+- Prefix warnings with the full example description ([#69](https://github.com/ackama/lighthouse-matchers/pull/69))
+
 ## [1.2.0] - 2024-07-13
 ### Changed
 - Raise an explict error when the audit category is not found ([#56](https://github.com/ackama/lighthouse-matchers/pull/56))

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lighthouse-matchers (1.2.0)
+    lighthouse-matchers (1.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -14,8 +14,7 @@ GEM
     rainbow (3.0.0)
     rake (13.0.1)
     regexp_parser (2.2.0)
-    rexml (3.2.8)
-      strscan (>= 3.0.9)
+    rexml (3.3.9)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -43,9 +42,8 @@ GEM
     rubocop-ast (1.15.1)
       parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
-    strscan (3.1.0)
     unicode-display_width (2.1.0)
-    webrick (1.7.0)
+    webrick (1.8.2)
 
 PLATFORMS
   ruby

data/README.md

@@ -103,6 +103,9 @@ All configuration keys are accessible against the `Lighthouse::Matchers` object.
 * **`minimum_score`:** The default minimum score that audits must meet for the matcher to pass.
   The default value of this configuration setting is '100' - e.g. audits must fully comply to pass.
 * **`chrome_flags`:** Any additional flags that should be passed to Chrome when Lighthouse launches a browser instance. As an example, running Lighthouse in Docker requires the normal headless Chrome flags (`--headless`, `--no-sandbox`) for Chrome to successfully start. Chrome flags can either be specified as an array (`["headless", "no-sandbox"]`) or as a string (`--headless --no-sandbox`).
+* **`results_directory`:** Directory to write lighthouse results on failure
+  * Defaults to `<RSpec.configuration.default_path>/lighthouse` if `RSpec` is defined, otherwise a temporary directory prefixed with `lighthouse-matchers-`
+  * For Rails applications, we recommend setting this to `Rails.root.join('/tmp/lighthouse')` in your `rails_helper.rb`
 
 ## Compatibility
 

data/lib/lighthouse/audit_service.rb

@@ -29,6 +29,10 @@ class AuditService
     results['runWarnings']
   end
 
+  def results
+    @results ||= JSON.parse(output)
+  end
+
   private
 
   def category
@@ -54,8 +58,4 @@ class AuditService
   def output
     @output ||= @runner.call("#{@cmd} #{opts}")
   end
-
-  def results
-    @results ||= JSON.parse(output)
-  end
 end

data/lib/lighthouse/matchers/rspec.rb

@@ -4,28 +4,35 @@ require 'rspec/expectations'
 require 'lighthouse/matchers'
 require 'lighthouse/audit_service'
 require 'json'
+require 'digest'
+require 'fileutils'
 
-RSpec::Matchers.define :pass_lighthouse_audit do |audit, args = {}|
+RSpec::Matchers.define :pass_lighthouse_audit do |audit, args = {}| # rubocop:disable Metrics/BlockLength
   score ||= args.fetch(:score, Lighthouse::Matchers.minimum_score)
 
   match do |target|
-    audit_service = AuditService.new(url(target), audit, score)
+    @audit_service = AuditService.new(url(target), audit, score)
 
-    audit_service.run_warnings.each do |warning|
+    @audit_service.run_warnings.each do |warning|
       RSpec.configuration.reporter.message(
-        "#{RSpec.current_example.location}: [lighthouse] #{warning}"
+        "#{RSpec.current_example.full_description}: [lighthouse] #{warning}"
       )
     end
 
-    @measured_score = audit_service.measured_score
+    @measured_score = @audit_service.measured_score
 
-    audit_service.passing_score?
+    @audit_service.passing_score?
   end
 
   failure_message do |target|
     <<~FAIL
       expected #{url(target)} to pass Lighthouse #{audit} audit
       with a minimum score of #{score}, but only scored #{@measured_score.to_i}
+
+      Full report:
+       #{save_audit_results}
+
+       To view this report, load this file into https://googlechrome.github.io/lighthouse/viewer/
     FAIL
   end
 
@@ -34,4 +41,15 @@ RSpec::Matchers.define :pass_lighthouse_audit do |audit, args = {}|
   def url(target)
     target.respond_to?(:current_url) ? target.current_url : target
   end
+
+  def save_audit_results
+    body = JSON.pretty_generate(@audit_service.results)
+
+    path = File.join(Lighthouse::Matchers.results_directory, "#{Digest::SHA1.hexdigest(body)}.json")
+
+    FileUtils.mkdir_p(Lighthouse::Matchers.results_directory)
+    File.write(path, body)
+
+    path
+  end
 end

data/lib/lighthouse/matchers/version.rb

@@ -2,6 +2,6 @@
 
 module Lighthouse
   module Matchers
-    VERSION = '1.2.0'
+    VERSION = '1.3.0'
   end
 end

data/lib/lighthouse/matchers.rb

@@ -9,7 +9,7 @@ module Lighthouse
   module Matchers # rubocop:disable Style/Documentation
     class Error < StandardError; end
     class << self
-      attr_writer :minimum_score, :lighthouse_cli, :runner, :chrome_flags
+      attr_writer :minimum_score, :lighthouse_cli, :runner, :chrome_flags, :results_directory
       attr_accessor :remote_debugging_port
 
       def minimum_score
@@ -31,6 +31,14 @@ module Lighthouse
         @chrome_flags.map { |f| "--#{f}" }.join(' ')
       end
 
+      def results_directory
+        @results_directory ||= if defined?(RSpec)
+                                 File.join(RSpec.configuration.default_path, 'lighthouse')
+                               else
+                                 Dir.mktmpdir('lighthouse-matchers-')
+                               end
+      end
+
       private
 
       def guess_lighthouse_cli