light_service_object 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a4e68067319da840f48462ed29d2fdb32314e14c78c543f6e978b345d2d87b7
-  data.tar.gz: 0fb567f252a98e5bef84d9d2b7db469e86b6b9bdce13038dd701f703c5be474d
+  metadata.gz: e700271db3a2b52514ce8b2174a4f955c1926c70b60f370ecdcd69e71698b4dc
+  data.tar.gz: d13ece90b9a57c819b6b028ec19a0dc88d60af261883c8862bffe7d856b09986
 SHA512:
-  metadata.gz: edb266a2036ce57aba328e8c7fe3925b1955accd7537c4cdf7ff8ea14111eaa1234c33c974d611909031869998a648277abff83f4e3431e4391e14443da172f3
-  data.tar.gz: 9e6faf7bd3f116726ab2260401f7d5e9b03c41135c377bf46f37a498ad6c57026928590c147feb442c3b681cbf8c755e4207dbc00b2981869bb70a7ccafb20e0
+  metadata.gz: '095296979110b150d06f473690212b2a9085e6595367622649b01eea8b3f4a1df6be9d56b3d9288ac2e60a40fe72faa997197ed34cf3cfc92dc06ed6e86be8c1'
+  data.tar.gz: 6dac101c8261634d7c099d9ba73505e539021b91a26c9c4f6d7685345bf99eb93197d1772015a359decbfd60c6818a0e775ad62088a577172bee6db248c9fa7a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    light_service_object (0.1.6)
+    light_service_object (0.1.7)
       dry-initializer (~> 2.0)
       dry-monads (~> 1.0)
 

data/lib/light_service_object/version.rb

@@ -1,3 +1,3 @@
 module LightServiceObject
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

data/lib/light_service_object.rb

@@ -30,11 +30,12 @@ if defined?(Ensurance)
 end
 
 module LightServiceObject
+  class ServiceError < StandardError; end
+
   class Base
     extend Dry::Initializer
     include Dry::Monads::Result::Mixin
 
-
     ## — CLASS METHODS
     class << self
       def result_class
@@ -71,16 +72,10 @@ module LightServiceObject
       def call(**options)
         begin
           obj = self.new(**options)
-        rescue KeyError => e
-          return  Dry::Monads.Failure(e.message)
+          obj.call
+        rescue KeyError => error
+          Dry::Monads.Failure(error.message)
         end
-
-        # Identify incoming params that weren't specified
-        # set_params = obj.instance_variables.map{|e| e.to_s.tr("@","").to_sym }
-        # unknown_params = (options.keys - set_params)
-        # ap("#{self.name} > Unknown Parameters #{unknown_params}") if unknown_params.present?
-
-        result = obj.call
       end
     end
 
@@ -103,15 +98,15 @@ module LightServiceObject
         end
       end
       Dry::Monads.Success(result)
-    rescue StandardError => error
-      fail!(error)
+    rescue Exception => error
+      Dry::Monads.Failure(error.message)
     end
 
     def fail!(error)
-      error = ::StandardError.new(error.to_s) if !error.is_a?(::StandardError)
+      error = ServiceError.new(error.to_s) if !error.is_a?(ServiceError)
       reason = self.error_reason(error)
       self.class.failed(error)
-      Dry::Monads.Failure(reason)
+      raise error
     end
 
     def error_reason(error)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light_service_object
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Ben Sharpe