light-services 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eaf377a62c2b05d82860527f64df11bb2239745d2e3b6ab1bc060cddc153effc
-  data.tar.gz: 86eb6a64e0744e6fe2f80b1b4fc06e9d38a740911f88c2b076da9e9a2aab082b
+  metadata.gz: c2d31f74eaaa7add84302e90f4d2748c5c099f34ea44e1be0d8eb6faa286ec37
+  data.tar.gz: 7bb83450e6be42ab27938df758644820476138684712f7d015694b4d1f675d92
 SHA512:
-  metadata.gz: b11918fed0617837cd922a9c7c2181a855844d359bce30aa7f523a828e77e3605522cff64440cf200f90732cb17bbee901305a01920bde54a3cb4777b748a760
-  data.tar.gz: aa78896f8cf22b7e2cf17853700bbe347d0dd364409ee4033064d7c4c5fa57d9377620e5ab6b29473cf15c2894e29b189aa8634e7d71ffda9ad2ca6fa6fce792
+  metadata.gz: e2cf4be4b70f330c77d53b104b4f4c36686a6a1aaeba1cee0478d25941c06c5ff7e31d9bc0d4998710dd8a4b811e06f39794d54b9102663480d5d32adfbca45a
+  data.tar.gz: 56134a214344e9a3c7448b4cca8becdb05d03df864962faa5c1f9412cf65ce774a5245ac1a5eda2127e86bdc5b41d01a5ab2893109b401d8259f3dc704420220

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 
-## 3.2.0 (2025-12-14)
+## 3.2.1 (2025-12-15)
+
+### Added
+
+- Add RuboCop cop `ReservedName`
+
+## 3.2.0 (2025-12-15)
 
 ### Added
 
@@ -12,7 +18,7 @@
 
 - Service runs steps with `always: true` after `fail_immediately!` was called
 
-## 3.1.2 (2025-12-13)
+## 3.1.2 (2025-12-14)
 
 ### Added
 
@@ -22,7 +28,7 @@
 
 - Split `config.require_type` into `config.require_arg_type` and `config.require_output_type`
 
-## 3.1.1 (2025-12-13)
+## 3.1.1 (2025-12-14)
 
 ### Added
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    light-services (3.2.0)
+    light-services (3.2.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/light/services/rubocop/cop/light_services/reserved_name.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require_relative "../../../../../light/services/constants"
+
+module RuboCop
+  module Cop
+    module LightServices
+      # Ensures that `arg`, `step`, and `output` declarations do not use reserved names
+      # that would conflict with Light::Services methods.
+      #
+      # @example
+      #   # bad
+      #   arg :errors, type: Array
+      #   arg :outputs, type: Hash
+      #   step :call
+      #   output :success?, type: [TrueClass, FalseClass]
+      #
+      #   # good
+      #   arg :validation_errors, type: Array
+      #   arg :result_outputs, type: Hash
+      #   step :execute
+      #   output :succeeded, type: [TrueClass, FalseClass]
+      #
+      class ReservedName < Base
+        include RuboCop::Cop::RangeHelp
+
+        MSG = "`%<name>s` is a reserved name and cannot be used as %<field_type>s. " \
+              "It conflicts with Light::Services methods."
+
+        SEVERITY = :error
+
+        RESTRICT_ON_SEND = [:arg, :step, :output].freeze
+
+        FIELD_TYPE_NAMES = {
+          arg: "an argument",
+          step: "a step",
+          output: "an output",
+        }.freeze
+
+        # @!method dsl_call?(node)
+        def_node_matcher :dsl_call?, <<~PATTERN
+          (send nil? ${:arg :step :output} (sym $_) ...)
+        PATTERN
+
+        def on_send(node)
+          dsl_call?(node) do |method_name, name|
+            return unless Light::Services::ReservedNames::ALL.include?(name)
+
+            field_type = FIELD_TYPE_NAMES[method_name]
+            add_offense(node, message: format(MSG, name: name, field_type: field_type), severity: SEVERITY)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/light/services/rubocop.rb

@@ -10,4 +10,5 @@ require_relative "rubocop/cop/light_services/missing_private_keyword"
 require_relative "rubocop/cop/light_services/no_direct_instantiation"
 require_relative "rubocop/cop/light_services/output_type_required"
 require_relative "rubocop/cop/light_services/prefer_fail_method"
+require_relative "rubocop/cop/light_services/reserved_name"
 require_relative "rubocop/cop/light_services/step_method_exists"

data/lib/light/services/version.rb

@@ -2,6 +2,6 @@
 
 module Light
   module Services
-    VERSION = "3.2.0"
+    VERSION = "3.2.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light-services
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Andrew Kodkod
@@ -99,6 +99,7 @@ files:
 - lib/light/services/rubocop/cop/light_services/no_direct_instantiation.rb
 - lib/light/services/rubocop/cop/light_services/output_type_required.rb
 - lib/light/services/rubocop/cop/light_services/prefer_fail_method.rb
+- lib/light/services/rubocop/cop/light_services/reserved_name.rb
 - lib/light/services/rubocop/cop/light_services/step_method_exists.rb
 - lib/light/services/settings/field.rb
 - lib/light/services/settings/step.rb