light-services 2.2.1 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb172e14ae0c846d5e445299d63383fc3855d3f021f3642e64f3f0b25b2f96db
-  data.tar.gz: da0ec0d32a82f2f6d245f58f9c4c4549b65af47f06d34241c684dd3ff038f107
+  metadata.gz: 14b80318915db3dc20bd40365dc9ad00160938bb6836c1cda14bfba5301c7d7a
+  data.tar.gz: 80515890786ed055972e5b52bbc6cdee8e79b85d4fa1227b217f4b746c9fb899
 SHA512:
-  metadata.gz: 27dc9088b5726a0a35cb799c0e4dadaded2135ab8599dc630b2d84c483264a76ba478a86106300866c7c6d99e82a97e4fc6eebfbf88ebdf2215e6a0d0d08efe3
-  data.tar.gz: d64ed30327e04f8b8895c59534db1e04e5649ae4f06bdb420abe40667917ad6a94321717ee5c8e76f24a00dd940b55234cf9f88ee6606e225d0a673d1e790b47
+  metadata.gz: 454b6f2cd8fdf8615bc29c6b69e16fe704a3b19abd8f7e48fbd1e848505038db013e41396399dd5caa721d7179ae1bc3a6a99989a3adfc0f6868e9fe49a63c85
+  data.tar.gz: 50dbf071f72a242c0c36daeb83db94db5826dca4e3e2bbe7a47f9c81006b4d2c2266731715e1948b6528df86633735839f6eee525abde302a76b7a046e484b72

data/.github/config/rubocop_linter_action.yml

@@ -1,5 +1,5 @@
 versions:
-  - rubocop: "1.64"
-  - rubocop-performance: "1.21"
-  - rubocop-rake: "0.6"
-  - rubocop-rspec: "2.31"
+  - rubocop: "1.81.7"
+  - rubocop-performance: "1.26.1"
+  - rubocop-rake: "0.7.1"
+  - rubocop-rspec: "3.8.0"

data/.github/workflows/ci.yml

@@ -2,24 +2,24 @@ name: CI
 on: push
 
 jobs:
-#  rubocop:
-#    name: Rubocop
-#    runs-on: ubuntu-latest
-#    steps:
-#      - name: Git Checkout
-#        uses: actions/checkout@v2
-#
-#      - name: Rubocop
-#        uses: andrewmcodes/rubocop-linter-action@v3.2.0
-#        env:
-#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  rubocop:
+    name: Rubocop
+    runs-on: ubuntu-latest
+    steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
+
+      - name: Rubocop
+        uses: andrewmcodes/rubocop-linter-action@v3.2.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   rspec:
     name: RSpec
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [3.0, 3.1, 3.2, 3.3, head, debug]
+        ruby: [3.2, 3.3, 3.4, head, debug]
     steps:
       - name: Git Checkout
         uses: actions/checkout@v2

data/.gitignore

@@ -15,6 +15,7 @@
 # Ignore IDE files
 /.idea
 *.iml
+.vscode/settings.json
 
 # Ignore gem files
 *.gem

data/.rubocop.yml

@@ -1,34 +1,110 @@
-require:
+plugins:
   - rubocop-rake
   - rubocop-rspec
   - rubocop-performance
 
 AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
   NewCops: enable
+  TargetRubyVersion: 3
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
 
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+Layout/SpaceInsideArrayLiteralBrackets:
+  EnforcedStyle: no_space
+
+Lint/EmptyFile:
+  Enabled: true
+
+Metrics/AbcSize:
+  Exclude:
+    - lib/light/services/dsl/steps_dsl.rb
+    - lib/light/services/messages.rb
+  Max: 20
+
 Metrics/BlockLength:
   Exclude:
     - spec/**/*_spec.rb
 
+Metrics/ClassLength:
+  Max: 150
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/MethodLength:
+  Max: 20
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
+Naming/PredicatePrefix:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Max: 20
+
+RSpec/MultipleDescribes:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Max: 10
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+RSpec/NestedGroups:
+  Max: 5
+
 Security/Eval:
   Exclude:
     - spec/light/services/error_spec.rb
 
-Style/Documentation:
-  Enabled: false
+Style/ClassAndModuleChildren:
+  Exclude:
+    - spec/data/services/**/*.rb
 
 Style/ClassVars:
   Enabled: false
 
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
+Style/ConditionalAssignment:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
 
 Style/GuardClause:
   Enabled: false
 
-Style/ClassAndModuleChildren:
+Style/OptionalBooleanParameter:
   Exclude:
-    - spec/data/services/**/*.rb
+    - lib/light/services/rspec/matchers/**/*.rb
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: diff_comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/WordArray:
+  EnforcedStyle: brackets
+
+Style/NumericPredicate:
+  Enabled: false

data/CHANGELOG.md

@@ -1 +1,39 @@
 # Changelog
+
+## 3.1.0 (2025-12-13)
+
+### Breaking changes
+
+- Enforce arguments and output types by default. Add `config.require_type = false` to your config to disable this behavior.
+
+### Added
+
+- `stop!` and `stopped?` methods for early exit (renamed from `done!` and `done?`)
+- `stop_immediately!` method for immediate execution halt within the current step
+- `done!` and `done?` are deprecated, but remain available as aliases for backward compatibility
+- Ruby LSP support with step navigation and indexing
+- Rubocop cops `StepMethodExists`, `ConditionMethodExists`, `DslOrder`, `MissingPrivateKeyword`, `NoDirectInstantiation`, `ArgumentTypeRequired`, `OutputTypeRequired`, `DeprecatedMethods`
+- Comprehensive YARD documentation
+
+## 3.0.0 (2025-12-12)
+
+### Breaking changes
+
+- Removed support for symbol types (e.g., `:array`, `:hash`, `:boolean`). Use Ruby classes (e.g., `Array`, `Hash`, `[TrueClass, FalseClass]`) or dry-types
+- Removed `benchmark: true` option
+- Removed `verbose: true` option
+- Bumped minimum supported Ruby version to **3.0**.
+- Removed `errors.copy_to`
+
+### Added
+
+- Output type validation
+- dry-types support for arguments and outputs (with coercion and constraints)
+- Callback system (service + step callbacks)
+- Built-in RSpec matchers for services
+- Name validation for arguments, steps, and outputs
+- `run` method fallback when no steps are defined
+
+### Documentation
+
+- Documentation moved into this repository and refreshed to match v3 behavior

data/CLAUDE.md

@@ -0,0 +1,139 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## About Light Services
+
+Light Services is a Ruby gem providing a service architecture pattern for organizing business logic. Services are defined as classes with `arguments`, `steps`, and `outputs`, featuring transactions, inheritance, error handling, and context sharing.
+
+## Development Commands
+
+### Testing
+```bash
+# Run all tests
+bundle exec rspec
+
+# Run specific test file
+bundle exec rspec spec/path/to/file_spec.rb
+
+# Run with coverage (uses SimpleCov)
+bundle exec rspec
+```
+
+### Linting
+```bash
+# Run RuboCop linter
+bundle exec rubocop
+
+# Auto-fix RuboCop issues
+bundle exec rubocop -a
+```
+
+### Build and Release
+```bash
+# Build gem
+bundle exec rake build
+
+# Default task (runs tests)
+bundle exec rake
+```
+
+## Architecture
+
+### Core Components
+
+1. **Base Service (`lib/light/services/base.rb:15`)**
+   - Main service class that all services inherit from
+   - Handles service lifecycle: initialization, execution, callbacks, error management
+   - Provides DSL for defining arguments, steps, and outputs
+   - Manages transactions and error propagation to parent services
+
+2. **Callbacks System (`lib/light/services/callbacks.rb:5`)**
+   - Supports service and step-level callbacks
+   - Events: `before_service_run`, `after_service_run`, `around_service_run`, `on_service_success`, `on_service_failure`
+   - Step events: `before_step_run`, `after_step_run`, `around_step_run`, `on_step_success`, `on_step_failure`
+
+3. **Settings**
+   - **Step (`lib/light/services/settings/step.rb:7`)**: Handles step execution with conditional logic (`if`, `unless`, `always`)
+   - **Field (`lib/light/services/settings/field.rb`)**: Manages argument and output validation and type checking
+
+4. **Messages System (`lib/light/services/messages.rb`)**
+   - Collects errors and warnings with options for breaking, raising, or rolling back
+   - Supports copying messages between parent and child services
+
+5. **Collection (`lib/light/services/collection.rb`)**
+   - Manages arguments and outputs as collections with validation and defaults
+   - Supports dry-types for advanced type validation and coercion
+
+### Service DSL
+
+Services use a declarative DSL:
+```ruby
+class ExampleService < Light::Services::Base
+  # Define input arguments
+  arg :name, type: String
+  arg :age, type: Integer, optional: true, default: 25
+
+  # Define execution steps
+  step :validate_input
+  step :process_data, if: :should_process?
+  step :cleanup, always: true
+
+  # Define outputs
+  output :result, type: Hash
+
+  private
+
+  def validate_input
+    errors.add(:name, "required") if name.nil? || name.strip.empty?
+  end
+
+  def process_data
+    self.result = { name: name, age: age }
+  end
+
+  def cleanup
+    # Runs regardless of errors/warnings, unless stop! was called
+  end
+
+  def should_process?
+    !(name.nil? || name.strip.empty?)
+  end
+end
+```
+
+### Service Execution
+
+- Services can be run with `.run(args)` or `.run!(args)` (raises on error)
+- Use `.with(service_or_context)` to chain services with shared context
+- Transactions automatically rollback on errors when `use_transactions: true`
+- Steps run sequentially, stopping on errors unless `always: true`
+
+### Error Handling
+
+- Errors collected in `@errors` message collection
+- Supports `break_on_error`, `raise_on_error`, `rollback_on_error` configuration
+- Warnings work similarly with `@warnings` collection
+- Parent services can inherit child errors/warnings based on configuration
+
+### Testing Patterns
+
+- Services are tested using RSpec with database transactions
+- Use `DatabaseCleaner` for test isolation
+- Mock database models and external dependencies
+- Test both success and failure scenarios
+- Validate arguments, outputs, and error conditions
+
+## Configuration
+
+### RuboCop Rules
+- Target Ruby version: 2.7+
+- Method length max: 20 lines
+- Uses double quotes for strings
+- Enables trailing commas for multiline structures
+- Disables documentation requirements and guard clauses
+
+### Database Support
+- Optional ActiveRecord integration for transactions
+- Uses SQLite3 for testing
+- Database cleaner ensures test isolation

data/Gemfile

@@ -5,17 +5,22 @@ source "https://rubygems.org"
 gemspec
 
 group :test do
-  gem "activerecord", "~> 8.1"
-  gem "database_cleaner-active_record", "~> 2.2"
-  gem "sqlite3", "~> 2.8"
+  # Optional type system support
+  gem "dry-types", "~> 1.0"
 
-  gem "codecov", "~> 0.6.0"
-  gem "rake", "~> 13.3"
-  gem "rspec", "~> 3.13"
-  gem "simplecov", "~> 0.21"
+  gem "activerecord", "< 8"
+  gem "connection_pool", "< 3"
+  gem "database_cleaner-active_record"
+  gem "sqlite3"
 
-  gem "rubocop", "~> 1.81",             require: false
-  gem "rubocop-performance", "~> 1.26", require: false
-  gem "rubocop-rake", "~> 0.7.0",       require: false
-  gem "rubocop-rspec", "~> 3.8",        require: false
+  gem "codecov"
+  gem "rake"
+  gem "rspec"
+  gem "rspec-benchmark"
+  gem "simplecov"
+
+  gem "rubocop"
+  gem "rubocop-performance"
+  gem "rubocop-rake"
+  gem "rubocop-rspec"
 end

data/Gemfile.lock

@@ -1,39 +1,40 @@
 PATH
   remote: .
   specs:
-    light-services (2.2.1)
-      benchmark (>= 0.5)
+    light-services (3.1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (8.1.1)
-      activesupport (= 8.1.1)
-    activerecord (8.1.1)
-      activemodel (= 8.1.1)
-      activesupport (= 8.1.1)
+    activemodel (7.2.3)
+      activesupport (= 7.2.3)
+    activerecord (7.2.3)
+      activemodel (= 7.2.3)
+      activesupport (= 7.2.3)
       timeout (>= 0.4.0)
-    activesupport (8.1.1)
+    activesupport (7.2.3)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
-      json
       logger (>= 1.4.2)
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
-      uri (>= 0.13.1)
     ast (2.4.3)
     base64 (0.3.0)
     benchmark (0.5.0)
+    benchmark-malloc (0.2.0)
+    benchmark-perf (0.6.0)
+    benchmark-trend (0.4.0)
     bigdecimal (3.3.1)
     codecov (0.6.0)
       simplecov (>= 0.15, < 0.22)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.4)
+    connection_pool (2.5.5)
     database_cleaner-active_record (2.2.2)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0)
@@ -41,14 +42,31 @@ GEM
     diff-lcs (1.6.2)
     docile (1.4.1)
     drb (2.2.3)
+    dry-core (1.1.0)
+      concurrent-ruby (~> 1.0)
+      logger
+      zeitwerk (~> 2.6)
+    dry-inflector (1.2.0)
+    dry-logic (1.6.0)
+      bigdecimal
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 1.1)
+      zeitwerk (~> 2.6)
+    dry-types (1.8.3)
+      bigdecimal (~> 3.0)
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 1.0)
+      dry-inflector (~> 1.0)
+      dry-logic (~> 1.4)
+      zeitwerk (~> 2.6)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.16.0)
+    json (2.18.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
     mini_portile2 (2.8.9)
-    minitest (5.26.1)
+    minitest (5.27.0)
     parallel (1.27.0)
     parser (3.3.10.0)
       ast (~> 2.4.1)
@@ -62,6 +80,11 @@ GEM
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
+    rspec-benchmark (0.6.0)
+      benchmark-malloc (~> 0.2)
+      benchmark-perf (~> 0.6)
+      benchmark-trend (~> 0.4)
+      rspec (>= 3.0)
     rspec-core (3.13.6)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.5)
@@ -103,32 +126,35 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
-    sqlite3 (2.8.0)
+    sqlite3 (2.8.1)
       mini_portile2 (~> 2.8.0)
-    timeout (0.4.4)
+    timeout (0.5.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (3.2.0)
       unicode-emoji (~> 4.1)
     unicode-emoji (4.1.0)
-    uri (1.1.1)
+    zeitwerk (2.7.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (~> 8.1)
-  codecov (~> 0.6.0)
-  database_cleaner-active_record (~> 2.2)
+  activerecord (< 8)
+  codecov
+  connection_pool (< 3)
+  database_cleaner-active_record
+  dry-types (~> 1.0)
   light-services!
-  rake (~> 13.3)
-  rspec (~> 3.13)
-  rubocop (~> 1.81)
-  rubocop-performance (~> 1.26)
-  rubocop-rake (~> 0.7.0)
-  rubocop-rspec (~> 3.8)
-  simplecov (~> 0.21)
-  sqlite3 (~> 2.8)
+  rake
+  rspec
+  rspec-benchmark
+  rubocop
+  rubocop-performance
+  rubocop-rake
+  rubocop-rspec
+  simplecov
+  sqlite3
 
 BUNDLED WITH
    2.5.10