light-services 2.0.0.rc8 → 2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 033745e056484b3cb06dd7047bde7aa8f57d3e7a831f5f9eb2495aec0f9f96e9
-  data.tar.gz: 6927b650f82197c0ee0403487f18f71015096d244785ae947d0b8ea4dd56373f
+  metadata.gz: e8a693c78f413c2ca03c2381e2bf4ae82355d3546eb8c4a2418181ed6c0a2205
+  data.tar.gz: 68dd61477720f1c5ec6f5702b088c3a1a7251e3ee008b963e27924ec1d6142aa
 SHA512:
-  metadata.gz: c87c5af17cccc1cce0514a65dd8f87b84d21599fcafec91ea92fa9f5d068842bfb01f0055b98c62340809a47e4eb3721a974b5958c7cd6b6410249251cf4cdca
-  data.tar.gz: a48e79125c81939dd5967ea08e6fcafcb6474f9a13edbc07f1e1d4ec69fc83b23e2bc43a660bf978d999d4b97a57c4f543f5f14b65219c555f2266ce3d06b51f
+  metadata.gz: 76b9503f757f4135648f02a7ce128bd2a82b3eb4350fd42fb6abf12867e8321d1930d77936983925441e2aed28bef65a976e147853290076b1314ad2a2ebb8bb
+  data.tar.gz: 96646aa52768b79fb0255a5a9209444171ccd10b4a42d761888e7e51ca417e254bef4668a216ac389eeec0d7133a42343ae26714cddb8ee6150a341c601d16d1

data/.github/config/rubocop_linter_action.yml

@@ -1,4 +1,4 @@
 versions:
-  - rubocop: "0.86"
-  - rubocop-rspec: "1.40"
-  - rubocop-performance: "1.6"
+  - rubocop: "1.63"
+  - rubocop-rspec: "2.29"
+  - rubocop-performance: "1.21"

data/.github/workflows/ci.yml

@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [2.5, 2.6, 2.7, head, debug]
+        ruby: [3.0, 3.1, 3.2, head, debug]
     steps:
       - name: Git Checkout
         uses: actions/checkout@v2
@@ -28,7 +28,7 @@ jobs:
         run: sudo apt-get install libsqlite3-dev
 
       - name: Setup Ruby
-        uses: ruby/setup-ruby@v1.38.0
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
@@ -49,7 +49,7 @@ jobs:
         run: sudo apt-get install libsqlite3-dev
 
       - name: Setup Ruby
-        uses: ruby/setup-ruby@v1.38.0
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: head
           bundler-cache: true

data/.ruby-version

@@ -0,0 +1 @@
+3.3.1

data/Gemfile

@@ -5,16 +5,16 @@ source "https://rubygems.org"
 gemspec
 
 group :test do
-  gem "activerecord", "~> 6.0"
-  gem "database_cleaner-active_record", "~> 1.8"
-  gem "sqlite3", "~> 1.4"
+  gem "activerecord", "~> 7.0"
+  gem "database_cleaner-active_record", "~> 2.1"
+  gem "sqlite3", "~> 1.7"
 
   gem "codecov", "~> 0.6.0"
-  gem "rake", "~> 13.0"
-  gem "rspec", "~> 3.11"
+  gem "rake", "~> 13.2"
+  gem "rspec", "~> 3.13"
   gem "simplecov", "~> 0.21"
 
-  gem "rubocop", "~> 1.27",             require: false
-  gem "rubocop-performance", "~> 1.13", require: false
-  gem "rubocop-rspec", "~> 2.9",        require: false
+  gem "rubocop", "~> 1.63",             require: false
+  gem "rubocop-rspec", "~> 2.29",       require: false
+  gem "rubocop-performance", "~> 1.21", require: false
 end

data/Gemfile.lock

@@ -1,99 +1,126 @@
 PATH
   remote: .
   specs:
-    light-services (2.0.0.rc8)
+    light-services (2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.1.5)
-      activesupport (= 6.1.5)
-    activerecord (6.1.5)
-      activemodel (= 6.1.5)
-      activesupport (= 6.1.5)
-    activesupport (6.1.5)
+    activemodel (7.1.3.2)
+      activesupport (= 7.1.3.2)
+    activerecord (7.1.3.2)
+      activemodel (= 7.1.3.2)
+      activesupport (= 7.1.3.2)
+      timeout (>= 0.4.0)
+    activesupport (7.1.3.2)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
     ast (2.4.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.7)
     codecov (0.6.0)
       simplecov (>= 0.15, < 0.22)
-    concurrent-ruby (1.1.10)
-    database_cleaner (1.99.0)
-    database_cleaner-active_record (1.99.0)
-      activerecord
-      database_cleaner (~> 1.99.0)
-    diff-lcs (1.5.0)
+    concurrent-ruby (1.2.3)
+    connection_pool (2.4.1)
+    database_cleaner-active_record (2.1.0)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
+    diff-lcs (1.5.1)
     docile (1.4.0)
-    i18n (1.10.0)
+    drb (2.2.1)
+    i18n (1.14.4)
       concurrent-ruby (~> 1.0)
-    minitest (5.15.0)
-    parallel (1.22.1)
-    parser (3.1.2.0)
+    json (2.7.2)
+    language_server-protocol (3.17.0.3)
+    mini_portile2 (2.8.6)
+    minitest (5.22.3)
+    mutex_m (0.2.0)
+    parallel (1.24.0)
+    parser (3.3.1.0)
       ast (~> 2.4.1)
+      racc
+    racc (1.7.3)
     rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.3.0)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rake (13.2.1)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.27.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.63.4)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.16.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.17.0)
-      parser (>= 3.1.1.0)
-    rubocop-performance (1.13.3)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.9.0)
-      rubocop (~> 1.19)
-    ruby-progressbar (1.11.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
+    rubocop-capybara (2.20.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-performance (1.21.0)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (2.29.2)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+      rubocop-rspec_rails (~> 2.28)
+    rubocop-rspec_rails (2.28.3)
+      rubocop (~> 1.40)
+    ruby-progressbar (1.13.0)
     simplecov (0.21.2)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    sqlite3 (1.4.2)
-    tzinfo (2.0.4)
+    sqlite3 (1.7.3)
+      mini_portile2 (~> 2.8.0)
+    timeout (0.4.1)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.1.0)
-    zeitwerk (2.5.4)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (~> 6.0)
+  activerecord (~> 7.0)
   codecov (~> 0.6.0)
-  database_cleaner-active_record (~> 1.8)
+  database_cleaner-active_record (~> 2.1)
   light-services!
-  rake (~> 13.0)
-  rspec (~> 3.11)
-  rubocop (~> 1.27)
-  rubocop-performance (~> 1.13)
-  rubocop-rspec (~> 2.9)
+  rake (~> 13.2)
+  rspec (~> 3.13)
+  rubocop (~> 1.63)
+  rubocop-performance (~> 1.21)
+  rubocop-rspec (~> 2.29)
   simplecov (~> 0.21)
-  sqlite3 (~> 1.4)
+  sqlite3 (~> 1.7)
 
 BUNDLED WITH
-   2.1.4
+   2.5.10

data/README.md

@@ -1,6 +1,6 @@
-# 🚀 Light Services <sup>BETA</sup>
+# 🚀 Light Services
 
-Implementation of Service Object pattern for Ruby/Rails applications.
+An implementation of the Service Object pattern for Ruby and Rails applications.
 
 ## 👀 Table of Contents
 1. [Simple Example](#simple-example)
@@ -14,35 +14,34 @@ Implementation of Service Object pattern for Ruby/Rails applications.
 
 ## 💪 Features
 
-1. Ability to define `arguments`, `steps` and `outputs`
-2. Isolated behaviour of each service object
-3. Raising of errors to stop processing next steps
-4. Wrapping actions into database transactions
-5. Ability to pass context to child service object
-6. Framework agnostic
-7. 100% test coverage
+1. Ability to define `arguments`, `steps`, and `outputs`
+1. Isolated behavior of each service object
+1. Errors raise to stop processing subsequent steps
+1. Wrapping actions in database transactions
+1. Ability to pass context to child service objects
+1. Framework agnostic
+1. 100% test coverage
 
 ## ❌ Problems
 
-As this gem was just for internal usage, it has some problems:
+This gem was initially intended for internal use and has several issues:
 
-1. Gem isn't documented well
-2. Code doesn't have any comments
-3. Repo doesn't have any CI/CD
+1. The gem is not well-documented
+1. The code lacks comments
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'light-services', '~> 2.0.0.rc7' 
+gem "light-services", "~> 2.0" 
 ```
 
 ## Simple Example
 
-### Send notification
+### Send Notification
 
-Let's create an elementary service object that sends a notification to the user. 
+Create a basic service object that sends a notification to a user. 
 
 ```ruby
 class User::SendNotification < ApplicationService
@@ -84,7 +83,7 @@ end
 
 ### Arguments
 
-You may send some arguments into the service object.
+Pass arguments into the service object as shown:
 
 **How to define arguments:**
 ```ruby
@@ -106,7 +105,7 @@ class User::SendNotification < ApplicationService
 end
 ```
 
-**How to pass arguments in controller:**
+**How to pass arguments from a controller:**
 ```ruby
 class UsersController
   def send_notification
@@ -116,7 +115,7 @@ class UsersController
 end
 ```
 
-**How to pass arguments and context from parent to child service object:**
+**Passing arguments and context from parent to child service object:**
 ```ruby
 class User::Update
   # Arguments
@@ -132,15 +131,15 @@ class User::Update
 
   def send_notification
     User::SendNotification
-      .with(self) # This line specifies the current service object as a parent and passes all context arguments into a child service object
-      .run(text: "Your profile was updated") # We don't need to pass `user` here as it's a context argument
+      .with(self) # Specifies the current service object as parent, passing all context arguments to a child service object
+      .run(text: "Your profile was updated") # No need to pass `user` as it's a context argument
   end
 end
 ```
 
 ### Steps
 
-Steps are a bit more powerful than you think.
+Steps are a bit more powerful than they appear.
 
 ```ruby
 class User::Charge
@@ -160,7 +159,7 @@ end
 
 ### Outputs
 
-Outputs are pretty straightforward.
+Outputs are straightforward.
 
 ```ruby
 class User::Charge
@@ -176,9 +175,9 @@ end
 
 The context specifies the relationship between parent and child service objects.
 
-What context does:
-1. It tells the parent service object to pass context arguments into a child service object
-2. When the child service object fails, it tells the parent service object to fail too (customizable)
+What the context does:
+1. Tells the parent service object to pass context arguments to a child service object.
+1. Informs the parent service object to also fail when the child service object fails (this is customizable).
 
 ```ruby
 class User::Charge
@@ -216,9 +215,9 @@ end
 
 ## Complex Example
 
-### Creation of records
+### Record Creation
 
-Let's investigate a more exciting example where we create a wrapper to create database records.
+Explore a more intricate example of creating database records.
 
 **Here is an example of controller (pretty thin, yeah? but we can make it even thinner):**
 ```ruby
@@ -319,7 +318,7 @@ end
 ## More examples
 
 You can find more examples here:
-[https://github.com/light-ruby/light-services/tree/v2/spec/data/services](https://github.com/light-ruby/light-services/tree/v2/spec/data/services)
+[https://github.com/light-ruby/light-services/tree/spec/data/services](https://github.com/light-ruby/light-services/tree/v2/spec/data/services)
 
 # Happy coding!
 

data/lib/light/services/base.rb

@@ -89,6 +89,9 @@ module Light
 
         log "🟢 Finished #{self.class} in #{time}ms"
         puts
+      rescue StandardError => e
+        run_steps_with_always
+        raise e
       end
 
       class << self

data/lib/light/services/class_based_collection/base.rb

@@ -76,7 +76,7 @@ module Light
 
         def insert_item(klass, name, opts, item)
           index = find_index(klass, opts[:before] || opts[:after])
-          index = opts[:before] ? index : index + 1
+          index += 1 unless opts[:before]
 
           @collection[klass] = @collection[klass].to_a.insert(index, [name, item]).to_h
         end

data/lib/light/services/class_based_collection/mount.rb

@@ -13,18 +13,18 @@ module Light
     module ClassBasedCollection
       module Mount
         def mount_class_based_collection(collection_name, item_class:, shortcut:, allow_redefine: false)
-          class_variable_set("@@#{collection_name}", ClassBasedCollection::Base.new(item_class, allow_redefine))
+          class_variable_set(:"@@#{collection_name}", ClassBasedCollection::Base.new(item_class, allow_redefine))
 
           define_singleton_method shortcut do |item_name, opts = {}|
-            class_variable_get("@@#{collection_name}").add(self, item_name, opts)
+            class_variable_get(:"@@#{collection_name}").add(self, item_name, opts)
           end
 
-          define_singleton_method "remove_#{shortcut}" do |item_name|
-            class_variable_get("@@#{collection_name}").remove(self, item_name)
+          define_singleton_method :"remove_#{shortcut}" do |item_name|
+            class_variable_get(:"@@#{collection_name}").remove(self, item_name)
           end
 
           define_singleton_method collection_name do
-            class_variable_get("@@#{collection_name}").all(self)
+            class_variable_get(:"@@#{collection_name}").all(self)
           end
         end
       end

data/lib/light/services/collection/base.rb

@@ -41,7 +41,7 @@ module Light
             next if !settings.default_exists || key?(name)
 
             if settings.default.is_a?(Proc)
-              set(name, settings.default.call)
+              set(name, @instance.instance_exec(&settings.default))
             else
               set(name, deep_dup(settings.default))
             end

data/lib/light/services/config.rb

@@ -38,11 +38,11 @@ module Light
       end
 
       def set(key, value)
-        instance_variable_set("@#{key}", value)
+        instance_variable_set(:"@#{key}", value)
       end
 
       def get(key)
-        instance_variable_get("@#{key}")
+        instance_variable_get(:"@#{key}")
       end
 
       def reset_to_defaults!
@@ -52,7 +52,7 @@ module Light
       end
 
       def to_h
-        DEFAULTS.keys.map { |key| [key, get(key)] }.to_h
+        DEFAULTS.keys.to_h { |key| [key, get(key)] }
       end
 
       def merge(config)

data/lib/light/services/settings/argument.rb

@@ -46,7 +46,7 @@ module Light
 
           @arg_types_cache[klass] ||= klass
             .name
-            .gsub(/::/, "/")
+            .gsub("::", "/")
             .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
             .gsub(/([a-z\d])([A-Z])/, '\1_\2')
             .tr("-", "_")
@@ -58,8 +58,8 @@ module Light
           name = @name
 
           @service_class.define_method(@name) { @arguments.get(name) }
-          @service_class.define_method("#{@name}?") { !!@arguments.get(name) } # rubocop:disable Style/DoubleNegation
-          @service_class.define_method("#{@name}=") { |value| @arguments.set(name, value) }
+          @service_class.define_method(:"#{@name}?") { !!@arguments.get(name) }
+          @service_class.define_method(:"#{@name}=") { |value| @arguments.set(name, value) }
           @service_class.send(:private, "#{@name}=")
         end
       end

data/lib/light/services/settings/output.rb

@@ -24,8 +24,8 @@ module Light
           name = @name
 
           @service_class.define_method(@name) { @outputs.get(name) }
-          @service_class.define_method("#{@name}?") { !!@outputs.get(name) } # rubocop:disable Style/DoubleNegation
-          @service_class.define_method("#{@name}=") { |value| @outputs.set(name, value) }
+          @service_class.define_method(:"#{@name}?") { !!@outputs.get(name) }
+          @service_class.define_method(:"#{@name}=") { |value| @outputs.set(name, value) }
           @service_class.send(:private, "#{@name}=")
         end
       end

data/lib/light/services/version.rb

@@ -2,6 +2,6 @@
 
 module Light
   module Services
-    VERSION = "2.0.0.rc8"
+    VERSION = "2.0"
   end
 end

data/light-services.gemspec

@@ -5,11 +5,11 @@ require_relative "lib/light/services/version"
 Gem::Specification.new do |spec|
   spec.name          = "light-services"
   spec.version       = Light::Services::VERSION
-  spec.authors       = ["Andrew Emelianenko"]
-  spec.email         = ["emelianenko.web@gmail.com"]
+  spec.authors       = ["Andrew Kodkod"]
+  spec.email         = ["andrew@kodkod.me"]
 
-  spec.summary       = "Powerful implementation of Service Object pattern for Ruby and Rails"
-  spec.description   = "Powerful implementation of Service Object pattern for Ruby and Rails"
+  spec.summary       = "Streamlined Service Object Implementation for Ruby and Rails"
+  spec.description   = "Streamlined Service Object Implementation for Ruby and Rails"
   spec.homepage      = "https://github.com/light-ruby/light-services"
   spec.license       = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")

metadata

@@ -1,18 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: light-services
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc8
+  version: '2.0'
 platform: ruby
 authors:
-- Andrew Emelianenko
-autorequire: 
+- Andrew Kodkod
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-19 00:00:00.000000000 Z
+date: 2024-05-04 00:00:00.000000000 Z
 dependencies: []
-description: Powerful implementation of Service Object pattern for Ruby and Rails
+description: Streamlined Service Object Implementation for Ruby and Rails
 email:
-- emelianenko.web@gmail.com
+- andrew@kodkod.me
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -22,6 +22,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -57,7 +58,7 @@ metadata:
   source_code_uri: https://github.com/light-ruby/light-services
   changelog_uri: https://github.com/light-ruby/light-services/blob/master/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -68,12 +69,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.5.9
+signing_key:
 specification_version: 4
-summary: Powerful implementation of Service Object pattern for Ruby and Rails
+summary: Streamlined Service Object Implementation for Ruby and Rails
 test_files: []