light-service 0.8.3 → 0.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd457f452026a64465b3d6da771be7ed69547580
-  data.tar.gz: d330c6b02f86878cb314786b36fff478dfa3fa20
+  metadata.gz: fa927bdc5eaab0a8eed9f198bf61c28c042dc530
+  data.tar.gz: 6855d34240f37a93ef2ece590074eabd30ff901d
 SHA512:
-  metadata.gz: f054267b74b35a40a6f0a9f007e2144d375c9574b593a7f116a252df196e413e2b90476222d31ae11f92fe5b08847a3956f970d16e5ca09d8fc6f15809ae8bf1
-  data.tar.gz: '018c3672a0eaf6a526495607066ea499d3488608cd855694f5d2053583a2a62618b11f0b3b30cd50fe09e6e3ec60f5172546de7834c7f11319d4236f72c935a2'
+  metadata.gz: 5bb0724f04a18663620795c3f53fa048e88a6a07d441dd2250f1e0121f68f5b7f3d108aeb4ff64155ec83f6151756efc2f695df071d2f77dc14c3519380abddb
+  data.tar.gz: be037dc8236f1d38b860e912226e28a951db55be761c6b3f8591adf4404c1d61b367538ee4bd9c6595d546e50d206604529b71ed6ddefe59cd93e0a7a68cb5e6

data/.rubocop.yml

@@ -18,7 +18,7 @@ Style/Encoding:
 Style/StringLiterals:
   Enabled: false
 
-Style/TrailingBlankLines:
+Style/FormatStringToken:
   Enabled: false
 
 Style/RedundantReturn:
@@ -30,11 +30,19 @@ Style/SignalException:
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 
-Style/PredicateName:
-  Enabled: false
-
 Style/TrivialAccessors:
   AllowPredicates: true
 
+Naming/PredicateName:
+  Enabled: false
+
 Metrics/MethodLength:
   Max: 15
+
+Metrics/BlockLength:
+  Max: 35
+  Exclude:
+    - 'spec/**/*.rb'
+
+Layout/TrailingBlankLines:
+  Enabled: false

data/RELEASES.md

@@ -1,5 +1,8 @@
 A brief list of new features and changes introduced with the specified version.
 
+### 0.8.4
+* Only pass [default argument](https://github.com/adomokos/light-service/pull/123) to Hash#fetch in context if no block given.
+
 ### 0.8.3
 * Make logging more [efficient](https://github.com/adomokos/light-service/pull/120) the context.
 

data/Rakefile

@@ -1,4 +1,3 @@
-#!/usr/bin/env rake
 require "bundler/gem_tasks"
 
 require "rubygems"
@@ -10,4 +9,4 @@ RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
 
 task(:default).clear
-task :default => [:spec, :rubocop]
+task :default => %i[spec rubocop]

data/lib/light-service/context.rb

@@ -19,7 +19,6 @@ module LightService
       @error_code = error_code
       @skip_remaining = false
       context.to_hash.each { |k, v| self[k] = v }
-      self
     end
 
     def self.make(context = {})
@@ -140,8 +139,12 @@ module LightService
       return super(key)
     end
 
-    def fetch(key, default_or_block = nil)
-      self[key] ||= super(key, default_or_block)
+    def fetch(key, default = nil, &blk)
+      self[key] ||= if block_given?
+                      super(key, &blk)
+                    else
+                      super
+                    end
     end
 
     def inspect

data/lib/light-service/context/key_verifier.rb

@@ -10,7 +10,7 @@ module LightService
 
       def are_all_keys_in_context?(keys)
         not_found_keys = keys_not_found(keys)
-        !not_found_keys.any?
+        not_found_keys.none?
       end
 
       def keys_not_found(keys)
@@ -111,7 +111,7 @@ module LightService
       end
 
       def reserved_keys
-        [:message, :error_code, :current_action].freeze
+        %i[message error_code current_action].freeze
       end
     end
   end

data/lib/light-service/organizer.rb

@@ -17,7 +17,7 @@ module LightService
     # In case this module is included
     module ClassMethods
       def with(data = {})
-        VerifyCallMethodExists.call(self, caller.first)
+        VerifyCallMethodExists.call(self, caller(1..1).first)
         data[:_aliases] = @aliases if @aliases
         WithReducerFactory.make(self).with(data)
       end

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.8.3".freeze
+  VERSION = "0.8.4".freeze
 end

data/light-service.gemspec

@@ -20,6 +20,6 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency("rspec", "~> 3.0")
   gem.add_development_dependency("simplecov", "~> 0.14.1")
-  gem.add_development_dependency("rubocop", "0.46")
+  gem.add_development_dependency("rubocop", "~> 0.51")
   gem.add_development_dependency("pry", "~> 0.10")
 end

data/spec/action_spec.rb

@@ -74,7 +74,7 @@ describe LightService::Action do
       result = TestDoubles::AddsTwoActionWithFetch.execute(ctx)
 
       expect(result).to be_success
-      expect(result.keys).to eq([:some_key, :number])
+      expect(result.keys).to eq(%i[some_key number])
     end
   end
 

data/spec/context_spec.rb

@@ -162,6 +162,14 @@ RSpec.describe LightService::Context do
     expect(context[:foo]).to eq false
   end
 
+  it "allows a default value for #fetch" do
+    expect(context.fetch(:madeup, :default)).to eq(:default)
+  end
+
+  it "allows a default block value for #fetch" do
+    expect(context.fetch(:madeup) { :default }).to eq(:default)
+  end
+
   context "when aliases are included via .make" do
     let(:context) do
       LightService::Context.make(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.4
 platform: ruby
 authors:
 - Attila Domokos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-10 00:00:00.000000000 Z
+date: 2017-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -56,16 +56,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement