light-service 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25a715c986fab5133c64ef50160f93524bfdcca2
-  data.tar.gz: 1034f64ec7c50288024a15cce41b29082983941a
+  metadata.gz: 20a9e0cfd0b42cb8c0fb35b808f099c50a7ca32f
+  data.tar.gz: d8d76249eafe1e4cdeb1830b8b13453905941b7a
 SHA512:
-  metadata.gz: 1781b4242bb655bf55e257d65f97a4e4d6bf2d7eb0899bbfc509e10f62fce25d594de73bdcf426490052e3ca54a764c5ae1da049d107693c5a23d69dbe704867
-  data.tar.gz: 4009c8844215156df49a668a6c953cb60ae577438d35fb3452309fb005084d64b24317de65f4544a4a93af3ebc058edf9174adbbed58c5f227b791d99577bf5c
+  metadata.gz: d117cd24d38771a808e1210877387d167a74ad9588c314e34db5903c7b86ded6fdf1760a8a11467051626ea286c017729f82b5f4fe70198d125973b8eb0cc011
+  data.tar.gz: e6aaf6e9b0605ad347ad290ef35c2fb9f9afb5a47676b3be01473dd9b57c54ca337c8a5ea5add5541363fecb1c06a187f93a156bb39bc5d72a5082b33172715b

data/.rubocop.yml

@@ -9,6 +9,9 @@ AllCops:
 Documentation:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/Encoding:
   Enabled: false
 
@@ -21,6 +24,9 @@ Style/TrailingBlankLines:
 Style/RedundantReturn:
   Enabled: false
 
+Style/SignalException:
+  Enabled: true
+
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 

data/.travis.yml

@@ -3,7 +3,7 @@ language: ruby
 rvm:
   - 2.0.0
   - 2.1.2
-  - 2.2.0
+  - 2.2.2
   - 2.3.0
 
 before_install:
@@ -18,4 +18,12 @@ script:
 
 gemfile:
   - gemfiles/activesupport_3.gemfile
-  - gemfiles/activesupport_4.gemfileset
+  - gemfiles/activesupport_4.gemfile
+  - gemfiles/activesupport_5.gemfile
+
+matrix:
+  exclude:
+  - rvm: 2.0.0
+    gemfile: gemfiles/activesupport_5.gemfile
+  - rvm: 2.1.2
+    gemfile: gemfiles/activesupport_5.gemfile

data/Appraisals

@@ -5,3 +5,7 @@ end
 appraise "activesupport-4" do
   gem "activesupport", "~> 4.0"
 end
+
+appraise "activesupport-5" do
+  gem "activesupport", "~> 5.0"
+end

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,22 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, or nationality.
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery
+* Personal attacks
+* Trolling or insulting/derogatory comments
+* Public or private harassment
+* Publishing other's private information, such as physical or electronic addresses, without explicit permission
+* Other unethical or unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.
+
+This code of conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+
+This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.2.0, available at [http://contributor-covenant.org/version/1/2/0/](http://contributor-covenant.org/version/1/2/0/)

data/README.md

@@ -1,4 +1,4 @@
-![LightService](resources/light-service.png)
+![LightService](https://raw.github.com/adomokos/light-service/master/resources/light-service.png)
 
 [![Gem Version](https://img.shields.io/gem/v/light-service.svg)](https://rubygems.org/gems/light-service)
 [![Build Status](https://secure.travis-ci.org/adomokos/light-service.png)](http://travis-ci.org/adomokos/light-service)
@@ -62,13 +62,13 @@ and executes them one-by-one. Then you need to create the actions which will onl
 
 This is how the organizer and actions interact with eachother:
 
-![LightService](resources/organizer_and_actions.png)
+![LightService](https://raw.github.com/adomokos/light-service/master/resources/organizer_and_actions.png)
 
 ```ruby
 class CalculatesTax
   extend LightService::Organizer
 
-  def self.for_order(order)
+  def self.call(order)
     with(:order => order).reduce(
         LooksUpTaxPercentageAction,
         CalculatesOrderTaxAction,
@@ -201,7 +201,7 @@ class SubmitsOrderAction
   end
 end
 ```
-![LightService](resources/fail_actions.png)
+![LightService](https://raw.github.com/adomokos/light-service/master/resources/fail_actions.png)
 
 In the example above the organizer called 4 actions. The first 2 actions got executed successfully. The 3rd had a failure, that pushed the context into a failure state and the 4th action was skipped.
 
@@ -221,7 +221,7 @@ class ChecksOrderStatusAction
   end
 end
 ```
-![LightService](resources/skip_actions.png)
+![LightService](https://raw.github.com/adomokos/light-service/master/resources/skip_actions.png)
 
 In the example above the organizer called 4 actions. The first 2 actions got executed successfully. The 3rd decided to skip the rest, the 4th action was not invoked. The context was successful.
 
@@ -251,7 +251,7 @@ end
 class CalculatesTax
   extend LightService::Organizer
 
-  def self.for_order(order)
+  def self.call(order)
     with(:order => order).around_each(LogDuration).reduce(
         LooksUpTaxPercentageAction,
         CalculatesOrderTaxAction,
@@ -316,7 +316,7 @@ class FooAction
 end
 ```
 
-Take a look at [this spec](spec/action_expects_and_promises_spec.rb) to see the refactoring in action.
+Take a look at [this spec](https://github.com/adomokos/light-service/blob/master/spec/action_expects_and_promises_spec.rb) to see the refactoring in action.
 
 ## Key Aliases
 The `aliases` macro sets up pairs of keys and aliases in an organizer. Actions can access the context using the aliases.
@@ -331,7 +331,7 @@ class AnOrganizer
 
   aliases my_key: :key_alias
 
-  def self.for_order(order)
+  def self.call(order)
     with(:order => order).reduce(
         AnAction,
         AnotherAction,
@@ -492,7 +492,7 @@ Using the `rolled_back` macro is optional for the actions in the chain. You shou
 
 The actions are rolled back in reversed order from the point of failure starting with the action that triggered it.
 
-See [this](spec/acceptance/rollback_spec.rb) acceptance test to learn more about this functionality.
+See [this](https://github.com/adomokos/light-service/blob/master/spec/acceptance/rollback_spec.rb) acceptance test to learn more about this functionality.
 
 ## Localizing Messages
 By default LightService provides a mechanism for easily translating your error or success messages via I18n.  You can also provide your own custom localization adapter if your application's logic is more complex than what is shown here.

data/RELEASES.md

@@ -1,5 +1,8 @@
 A brief list of new features and changes introduced with the specified version.
 
+### 0.7.0
+* Organizers should have a public method [call](https://github.com/adomokos/light-service/pull/98) in preparation of orchestrators.
+
 ### 0.6.1
 * Introducing [around_each](https://github.com/adomokos/light-service/pull/79) for AOP style logging and code execution
 * Introducing [Rubocop](https://github.com/adomokos/light-service/commit/39aa7ea39f69a16c2df66b213fb6d638796e25f2) to the project, forcing consistant style

data/Rakefile

@@ -3,3 +3,11 @@ require "bundler/gem_tasks"
 
 require "rubygems"
 require "bundler/setup"
+
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new
+RSpec::Core::RakeTask.new(:spec)
+
+task(:default).clear
+task :default => [:spec, :rubocop]

data/gemfiles/activesupport_3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    light-service (0.6.0)
+    light-service (0.6.1)
       activesupport (>= 3.0)
 
 GEM
@@ -14,15 +14,22 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    coderay (1.0.9)
+    ast (2.3.0)
+    coderay (1.1.1)
     diff-lcs (1.2.5)
+    docile (1.1.5)
     i18n (0.7.0)
+    json (2.0.2)
     method_source (0.8.2)
     multi_json (1.11.2)
-    pry (0.9.12.2)
-      coderay (~> 1.0.5)
-      method_source (~> 0.8)
+    parser (2.3.1.2)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
       slop (~> 3.4)
+    rainbow (2.1.0)
     rake (10.4.2)
     rspec (3.3.0)
       rspec-core (~> 3.3.0)
@@ -33,19 +40,25 @@ GEM
     rspec-expectations (3.3.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
-    rspec-its (1.2.0)
-      rspec-core (>= 3.0.0)
-      rspec-expectations (>= 3.0.0)
     rspec-mocks (3.3.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
-    simplecov (0.7.1)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.7.1)
-    simplecov-html (0.7.1)
+    rubocop (0.42.0)
+      parser (>= 2.3.1.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    simplecov (0.12.0)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
     slop (3.6.0)
     thor (0.19.1)
+    unicode-display_width (1.1.1)
 
 PLATFORMS
   ruby
@@ -54,10 +67,10 @@ DEPENDENCIES
   activesupport (~> 3.0)
   appraisal (~> 2.0)
   light-service!
-  pry (= 0.9.12.2)
+  pry (~> 0.10)
   rspec (~> 3.0)
-  rspec-its (~> 1.0)
-  simplecov (~> 0.7.1)
+  rubocop (~> 0.36)
+  simplecov (~> 0.11)
 
 BUNDLED WITH
-   1.10.6
+   1.12.5

data/gemfiles/activesupport_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    light-service (0.6.0)
+    light-service (0.6.1)
       activesupport (>= 3.0)
 
 GEM
@@ -17,17 +17,22 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    coderay (1.0.9)
+    ast (2.3.0)
+    coderay (1.1.1)
     diff-lcs (1.2.5)
+    docile (1.1.5)
     i18n (0.7.0)
     json (1.8.3)
     method_source (0.8.2)
     minitest (5.7.0)
-    multi_json (1.11.2)
-    pry (0.9.12.2)
-      coderay (~> 1.0.5)
-      method_source (~> 0.8)
+    parser (2.3.1.2)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
       slop (~> 3.4)
+    rainbow (2.1.0)
     rake (10.4.2)
     rspec (3.3.0)
       rspec-core (~> 3.3.0)
@@ -38,22 +43,28 @@ GEM
     rspec-expectations (3.3.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
-    rspec-its (1.2.0)
-      rspec-core (>= 3.0.0)
-      rspec-expectations (>= 3.0.0)
     rspec-mocks (3.3.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
-    simplecov (0.7.1)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.7.1)
-    simplecov-html (0.7.1)
+    rubocop (0.42.0)
+      parser (>= 2.3.1.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    simplecov (0.12.0)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
     slop (3.6.0)
     thor (0.19.1)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (1.1.1)
 
 PLATFORMS
   ruby
@@ -62,10 +73,10 @@ DEPENDENCIES
   activesupport (~> 4.0)
   appraisal (~> 2.0)
   light-service!
-  pry (= 0.9.12.2)
+  pry (~> 0.10)
   rspec (~> 3.0)
-  rspec-its (~> 1.0)
-  simplecov (~> 0.7.1)
+  rubocop (~> 0.36)
+  simplecov (~> 0.11)
 
 BUNDLED WITH
-   1.10.6
+   1.12.5

data/gemfiles/activesupport_5.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", "~> 2.0"
+gem "activesupport", "~> 5.0"
+
+gemspec :path => "../"

data/gemfiles/activesupport_5.gemfile.lock

@@ -0,0 +1,82 @@
+PATH
+  remote: ../
+  specs:
+    light-service (0.6.1)
+      activesupport (>= 3.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (5.0.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.1.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    ast (2.3.0)
+    coderay (1.1.1)
+    concurrent-ruby (1.0.2)
+    diff-lcs (1.2.5)
+    docile (1.1.5)
+    i18n (0.7.0)
+    json (2.0.2)
+    method_source (0.8.2)
+    minitest (5.9.0)
+    parser (2.3.1.2)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rainbow (2.1.0)
+    rake (11.2.2)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.2)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rubocop (0.42.0)
+      parser (>= 2.3.1.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    simplecov (0.12.0)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
+    slop (3.6.0)
+    thor (0.19.1)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.1.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activesupport (~> 5.0)
+  appraisal (~> 2.0)
+  light-service!
+  pry (~> 0.10)
+  rspec (~> 3.0)
+  rubocop (~> 0.36)
+  simplecov (~> 0.11)
+
+BUNDLED WITH
+   1.12.5

data/lib/light-service/action.rb

@@ -1,3 +1,5 @@
+require 'active_support/deprecation'
+
 module LightService
   module Action
     def self.extended(base_class)
@@ -13,13 +15,11 @@ module LightService
 
     module Macros
       def expects(*args)
-        @_expected_keys ||= []
-        @_expected_keys.concat(args)
+        expected_keys.concat(args)
       end
 
       def promises(*args)
-        @_promised_keys ||= []
-        @_promised_keys.concat(args)
+        promised_keys.concat(args)
       end
 
       def expected_keys
@@ -48,7 +48,7 @@ module LightService
 
       def rolled_back
         msg = "`rolled_back` macro can not be invoked again"
-        fail msg if respond_to?(:rollback)
+        raise msg if respond_to?(:rollback)
 
         define_singleton_method :rollback do |context = {}|
           yield(context)

data/lib/light-service/context.rb

@@ -1,3 +1,5 @@
+require 'active_support/deprecation'
+
 module LightService
   module Outcomes
     SUCCESS = 0
@@ -22,7 +24,7 @@ module LightService
     def self.make(context = {})
       unless context.is_a?(Hash) || context.is_a?(LightService::Context)
         msg = 'Argument must be Hash or LightService::Context'
-        fail ArgumentError, msg
+        raise ArgumentError, msg
       end
 
       context = new(context) unless context.is_a?(Context)
@@ -81,7 +83,7 @@ module LightService
 
     def fail_with_rollback!(message = nil, error_code = nil)
       fail!(message, error_code)
-      fail(FailWithRollbackError)
+      raise FailWithRollbackError
     end
 
     def skip_all!(message = nil)
@@ -115,7 +117,8 @@ module LightService
     end
 
     def [](key)
-      super(key) || super(aliases.key(key))
+      key = aliases.key(key) || key
+      return super(key)
     end
 
     def fetch(key, default_or_block = nil)

data/lib/light-service/context/key_verifier.rb

@@ -28,7 +28,7 @@ module LightService
       end
 
       def throw_error_predicate(_keys)
-        fail NotImplementedError, 'Sorry, you have to override length'
+        raise NotImplementedError, 'Sorry, you have to override length'
       end
 
       def verify
@@ -36,7 +36,7 @@ module LightService
 
         if throw_error_predicate(keys)
           Configuration.logger.error error_message
-          fail error_to_throw, error_message
+          raise error_to_throw, error_message
         end
 
         context

data/lib/light-service/organizer.rb

@@ -1,3 +1,5 @@
+require 'active_support/deprecation'
+
 module LightService
   module Organizer
     def self.extended(base_class)
@@ -9,13 +11,13 @@ module LightService
       warning_msg = "including LightService::Organizer is deprecated. " \
                     "Please use `extend LightService::Organizer` instead"
       ActiveSupport::Deprecation.warn(warning_msg)
-      base_class.extend ClassMethods
-      base_class.extend Macros
+      extended(base_class)
     end
 
     # In case this module is included
     module ClassMethods
       def with(data = {})
+        VerifyCallMethodExists.call(self, caller.first)
         data[:_aliases] = @aliases if @aliases
         WithReducerFactory.make(self).with(data)
       end
@@ -23,6 +25,31 @@ module LightService
       def reduce(*actions)
         with({}).reduce(actions)
       end
+
+      # We need to make sure existing users will
+      # use `call` method name going forward.
+      # This should be removed eventually.
+      class VerifyCallMethodExists
+        def self.call(klass, first_caller = '')
+          invoker_method = caller_method(first_caller)
+          return if invoker_method == 'call'
+
+          call_method_exists = klass.methods.include?(:call)
+          return if call_method_exists
+
+          warning_msg = "The <#{klass.name}> class is an organizer, " \
+                        "its entry method (the one that calls with & reduce) " \
+                        "should be named `call`. " \
+                        "Please use #{klass}.call going forward."
+          ActiveSupport::Deprecation.warn(warning_msg)
+        end
+
+        def self.caller_method(first_caller)
+          return nil unless first_caller =~ /`(.*)'/
+
+          Regexp.last_match[1]
+        end
+      end
     end
 
     module Macros

data/lib/light-service/organizer/with_reducer.rb

@@ -14,7 +14,7 @@ module LightService
       end
 
       def reduce(*actions)
-        fail "No action(s) were provided" if actions.empty?
+        raise "No action(s) were provided" if actions.empty?
         actions.flatten!
 
         actions.reduce(context) do |current_context, action|

data/lib/light-service/version.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module LightService
-  VERSION = "0.6.1".freeze
+  VERSION = "0.7.0".freeze
 end

data/spec/acceptance/add_numbers_spec.rb

@@ -3,7 +3,7 @@ require 'test_doubles'
 
 describe TestDoubles::AdditionOrganizer do
   it "Adds 1, 2 and 3 to the initial value of 1" do
-    result = TestDoubles::AdditionOrganizer.add_numbers 1
+    result = TestDoubles::AdditionOrganizer.call(1)
     number = result.fetch(:product)
 
     expect(number).to eq(7)

data/spec/acceptance/around_each_spec.rb

@@ -19,7 +19,7 @@ describe "Executing arbitrary code around each action" do
     assert_before_action_execute_log
     assert_after_action_execute_log
 
-    result = TestDoubles::AroundEachOrganizer.add(context)
+    result = TestDoubles::AroundEachOrganizer.call(context)
 
     expect(result.fetch(:number)).to eq(2)
   end

data/spec/acceptance/message_localization_spec.rb

@@ -4,7 +4,7 @@ require "test_doubles"
 class TestsLocalizationAdapter
   extend LightService::Organizer
 
-  def self.with_message(pass_or_fail, message_or_key, i18n_options = {})
+  def self.call(pass_or_fail, message_or_key, i18n_options = {})
     with(
       :pass_or_fail => pass_or_fail,
       :message_or_key => message_or_key,
@@ -27,18 +27,19 @@ class TestsLocalizationInvocationOptionsAction
 end
 
 def pass_with(message_or_key, i18n_options = {})
-  TestsLocalizationAdapter.with_message(true, message_or_key, i18n_options)
+  TestsLocalizationAdapter.call(true, message_or_key, i18n_options)
 end
 
 def fail_with(message_or_key, i18n_options = {})
-  TestsLocalizationAdapter.with_message(false, message_or_key, i18n_options)
+  TestsLocalizationAdapter.call(false, message_or_key, i18n_options)
 end
 
 describe "Localization Adapter" do
   before do
     I18n.backend.store_translations(
       :en,
-      :tests_localization_invocation_options_action => {
+      :tests_localization_invocation_options_action =>
+      {
         :light_service => {
           :failures => {
             :some_failure_reason => "This has failed",
@@ -49,7 +50,8 @@ describe "Localization Adapter" do
             :success_with_interpolation => "Passed with %{reason}"
           }
         }
-      })
+      }
+    )
   end
 
   describe "passing a simple string message" do

data/spec/acceptance/not_having_call_method_warning_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require 'test_doubles'
+
+describe "Organizer should invoke with/reduce from a call method" do
+  context "when the organizer does not have a `call` method" do
+    it "gives warning" do
+      expect(ActiveSupport::Deprecation)
+        .to receive(:warn)
+        .with(/^The <OrganizerWithoutCallMethod> class is an organizer/)
+
+      class OrganizerWithoutCallMethod
+        extend LightService::Organizer
+
+        def self.do_something
+          reduce([])
+        end
+      end
+
+      OrganizerWithoutCallMethod.do_something
+    end
+  end
+
+  context "when the organizer has the `call` method" do
+    it "does not issue a warning" do
+      expect(ActiveSupport::Deprecation)
+        .not_to receive(:warn)
+
+      class OrganizerWithCallMethod
+        extend LightService::Organizer
+
+        def self.call
+          reduce([])
+        end
+      end
+
+      OrganizerWithCallMethod.call
+    end
+  end
+end

data/spec/acceptance/rollback_spec.rb

@@ -4,7 +4,7 @@ require 'test_doubles'
 class RollbackOrganizer
   extend LightService::Organizer
 
-  def self.for(number)
+  def self.call(number)
     with(:number => number).reduce(
       AddsOneWithRollbackAction,
       TestDoubles::AddsTwoAction,
@@ -19,7 +19,7 @@ class AddsOneWithRollbackAction
   promises :number
 
   executed do |context|
-    context.fail_with_rollback! if context.number == 0
+    context.fail_with_rollback! if context.number.zero?
 
     context.number += 1
   end
@@ -47,7 +47,7 @@ end
 class RollbackOrganizerWithNoRollback
   extend LightService::Organizer
 
-  def self.for(number)
+  def self.call(number)
     with(:number => number).reduce(
       TestDoubles::AddsOneAction,
       TestDoubles::AddsTwoAction,
@@ -70,7 +70,7 @@ end
 class RollbackOrganizerWithMiddleRollback
   extend LightService::Organizer
 
-  def self.for(number)
+  def self.call(number)
     with(:number => number).reduce(
       TestDoubles::AddsOneAction,
       AddsTwoActionWithRollback,
@@ -96,7 +96,7 @@ end
 
 describe "Rolling back actions when there is a failure" do
   it "Adds 1, 2, 3 to 1 and rolls back " do
-    result = RollbackOrganizer.for 1
+    result = RollbackOrganizer.call 1
     number = result.fetch(:number)
 
     expect(result).to be_failure
@@ -105,7 +105,7 @@ describe "Rolling back actions when there is a failure" do
   end
 
   it "won't error out when actions don't define rollback" do
-    result = RollbackOrganizerWithNoRollback.for 1
+    result = RollbackOrganizerWithNoRollback.call 1
     number = result.fetch(:number)
 
     expect(result).to be_failure
@@ -114,7 +114,7 @@ describe "Rolling back actions when there is a failure" do
   end
 
   it "rolls back properly when triggered with an action in the middle" do
-    result = RollbackOrganizerWithMiddleRollback.for 1
+    result = RollbackOrganizerWithMiddleRollback.call 1
     number = result.fetch(:number)
 
     expect(result).to be_failure
@@ -123,7 +123,7 @@ describe "Rolling back actions when there is a failure" do
   end
 
   it "rolls back from the first action" do
-    result = RollbackOrganizer.for 0
+    result = RollbackOrganizer.call 0
     number = result.fetch(:number)
 
     expect(result).to be_failure

data/spec/context_spec.rb

@@ -157,14 +157,20 @@ describe LightService::Context do
     expect(context.outcome).to eq(::LightService::Outcomes::SUCCESS)
   end
 
+  it "can contain false values" do
+    context = LightService::Context.make(:foo => false)
+    expect(context[:foo]).to eq false
+  end
+
   context "when aliases are included via .make" do
     let(:context) do
       LightService::Context.make(
         :foo => "foobar",
+        :foo2 => false,
         :_aliases => aliases
       )
     end
-    let(:aliases) { { :foo => :bar } }
+    let(:aliases) { { :foo => :bar, :foo2 => :bar2 } }
 
     it "contains the aliases" do
       expect(context.aliases).to eq(aliases)
@@ -175,5 +181,9 @@ describe LightService::Context do
       expect(context[:bar]).to eq context[:foo]
       expect(context.fetch(:bar)).to eq context[:foo]
     end
+
+    it "can contain false values" do
+      expect(context[:bar2]).to eq false
+    end
   end
 end

data/spec/organizer/with_reducer_spec.rb

@@ -36,7 +36,7 @@ describe LightService::Organizer::WithReducer do
     it "reduces the rollback" do
       expect(action1).to receive(:execute).with(context).and_return(context)
       expect(action2).to receive(:execute).with(context) do
-        fail LightService::FailWithRollbackError
+        raise LightService::FailWithRollbackError
       end
       expect(action1).to receive(:rollback).with(context).and_return(context)
       expect(action2).to receive(:rollback).with(context).and_return(context)
@@ -49,7 +49,7 @@ describe LightService::Organizer::WithReducer do
     it "reduces the rollback with an action without `rollback`" do
       expect(action1).to receive(:execute).with(context).and_return(context)
       expect(action2).to receive(:execute).with(context) do
-        fail LightService::FailWithRollbackError
+        raise LightService::FailWithRollbackError
       end
       expect(action2).to receive(:rollback).with(context).and_return(context)
 

data/spec/organizer_key_aliases_spec.rb

@@ -8,19 +8,20 @@ describe "organizer aliases macro" do
 
       aliases :promised_key => :expected_key
 
-      def self.do_something(ctx = {})
+      def self.call(ctx = {})
         with(ctx).reduce(
           [
             TestDoubles::PromisesPromisedKeyAction,
             TestDoubles::ExpectsExpectedKeyAction
-          ])
+          ]
+        )
       end
     end
   end
 
   context "when aliases is invoked" do
     it "makes aliases available to the actions" do
-      result = organizer_with_alias.do_something
+      result = organizer_with_alias.call
       expect(result[:expected_key]).to eq(result[:promised_key])
       expect(result.expected_key).to eq(result[:promised_key])
     end

data/spec/organizer_spec.rb

@@ -16,7 +16,7 @@ describe LightService::Organizer do
     end
 
     it "implicitly creates a Context" do
-      result = TestDoubles::AnOrganizer.do_something(:user => user)
+      result = TestDoubles::AnOrganizer.call(:user => user)
       expect(result).to eq(ctx)
     end
   end
@@ -32,7 +32,7 @@ describe LightService::Organizer do
     end
 
     it "uses that Context without recreating it" do
-      result = TestDoubles::AnOrganizer.do_something(ctx)
+      result = TestDoubles::AnOrganizer.call(ctx)
       expect(result).to eq(ctx)
     end
   end
@@ -64,7 +64,7 @@ describe LightService::Organizer do
         extend LightService::Organizer
         aliases :foo => :bar
 
-        def self.do_stuff
+        def self.call
           with.reduce(TestDoubles::AnAction)
         end
       end
@@ -80,7 +80,7 @@ describe LightService::Organizer do
         .with(hash_including(:_aliases => { :foo => :bar }))
         .and_return(with_reducer)
 
-      organizer.do_stuff
+      organizer.call
     end
   end
 end

data/spec/sample/calculates_tax_spec.rb

@@ -26,7 +26,7 @@ describe CalculatesTax do
       .with(ctx)
       .and_return(ctx)
 
-    result = CalculatesTax.for_order(order)
+    result = CalculatesTax.call(order)
 
     expect(result).to eq(ctx)
   end

data/spec/sample/tax/calculates_tax.rb

@@ -1,7 +1,7 @@
 class CalculatesTax
   extend LightService::Organizer
 
-  def self.for_order(order)
+  def self.call(order)
     with(:order => order).reduce(
       LooksUpTaxPercentageAction,
       CalculatesOrderTaxAction,

data/spec/test_doubles.rb

@@ -19,7 +19,7 @@ module TestDoubles
 
   class AroundEachOrganizer
     extend LightService::Organizer
-    def self.add(action_arguments)
+    def self.call(action_arguments)
       with(action_arguments)
         .around_each(AroundEachLoggerHandler)
         .reduce([AddsTwoActionWithFetch])
@@ -41,7 +41,7 @@ module TestDoubles
   class AnOrganizer
     extend LightService::Organizer
 
-    def self.do_something(action_arguments)
+    def self.call(action_arguments)
       with(action_arguments).reduce([AnAction, AnotherAction])
     end
 
@@ -163,7 +163,7 @@ module TestDoubles
   class AdditionOrganizer
     extend LightService::Organizer
 
-    def self.add_numbers(number)
+    def self.call(number)
       with(:number => number).reduce(
         AddsOneAction,
         AddsTwoAction,
@@ -248,7 +248,7 @@ module TestDoubles
     end
 
     def self.make_product
-      fail "Fail"
+      raise "Fail"
     end
     private_class_method :make_product
   end

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Attila Domokos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-25 00:00:00.000000000 Z
+date: 2017-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.36'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.36'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
 description: A service skeleton with an emphasis on simplicity
@@ -87,11 +87,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Appraisals
+- CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE
 - README.md
@@ -101,6 +102,8 @@ files:
 - gemfiles/activesupport_3.gemfile.lock
 - gemfiles/activesupport_4.gemfile
 - gemfiles/activesupport_4.gemfile.lock
+- gemfiles/activesupport_5.gemfile
+- gemfiles/activesupport_5.gemfile.lock
 - lib/light-service.rb
 - lib/light-service/action.rb
 - lib/light-service/configuration.rb
@@ -123,6 +126,7 @@ files:
 - spec/acceptance/include_warning_spec.rb
 - spec/acceptance/log_from_organizer_spec.rb
 - spec/acceptance/message_localization_spec.rb
+- spec/acceptance/not_having_call_method_warning_spec.rb
 - spec/acceptance/rollback_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
@@ -153,17 +157,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity
@@ -173,6 +177,7 @@ test_files:
 - spec/acceptance/include_warning_spec.rb
 - spec/acceptance/log_from_organizer_spec.rb
 - spec/acceptance/message_localization_spec.rb
+- spec/acceptance/not_having_call_method_warning_spec.rb
 - spec/acceptance/rollback_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb