light-service 0.17.0 → 0.19.0

data/spec/localization_adapter_spec.rb

@@ -5,6 +5,21 @@ describe LightService::LocalizationAdapter do
   let(:action_class) { TestDoubles::AnAction }
   let(:adapter) { described_class.new }
 
+  before do
+    LightService::LocalizationMap.instance[:en] = {
+      :'test_doubles/an_action' => {
+        :light_service => {
+          :failures => {
+            :not_found => "failure message"
+          },
+          :successes => {
+            :not_found => "success message"
+          }
+        }
+      }
+    }
+  end
+
   describe "#failure" do
     subject { adapter.failure(message_or_key, action_class) }
 
@@ -12,25 +27,7 @@ describe LightService::LocalizationAdapter do
       let(:message_or_key) { :not_found }
 
       it "translates the message" do
-        expected_scope = "test_doubles/an_action.light_service.failures"
-
-        expect(I18n).to receive(:t)
-          .with(message_or_key, :scope => expected_scope)
-          .and_return("message")
-
-        expect(subject).to eq("message")
-      end
-
-      it "allows passing interpolation options to I18n layer" do
-        expect(I18n).to receive(:t)
-          .with(message_or_key, hash_including(:i18n_variable => "value"))
-          .and_return("message")
-
-        subject = adapter.failure(message_or_key,
-                                  action_class,
-                                  :i18n_variable => "value")
-
-        expect(subject).to eq("message")
+        expect(subject).to eq("failure message")
       end
     end
 
@@ -50,25 +47,7 @@ describe LightService::LocalizationAdapter do
       let(:message_or_key) { :not_found }
 
       it "translates the message" do
-        expected_scope = "test_doubles/an_action.light_service.successes"
-
-        expect(I18n).to receive(:t)
-          .with(message_or_key, :scope => expected_scope)
-          .and_return("message")
-
-        expect(subject).to eq("message")
-      end
-
-      it "allows passing interpolation options to I18n layer" do
-        expect(I18n).to receive(:t)
-          .with(message_or_key, hash_including(:i18n_variable => "value"))
-          .and_return("message")
-
-        subject = adapter.success(message_or_key,
-                                  action_class,
-                                  :i18n_variable => "value")
-
-        expect(subject).to eq("message")
+        expect(subject).to eq("success message")
       end
     end
 

data/spec/sample/calculates_tax_spec.rb

@@ -10,7 +10,6 @@ describe CalculatesTax do
 
   it "calls the actions in order" do
     allow(LightService::Context).to receive(:make)
-      .with(:order => order)
       .and_return(ctx)
 
     allow(LooksUpTaxPercentageAction).to receive(:execute)

data/spec/sample/looks_up_tax_percentage_action_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 require_relative 'tax/looks_up_tax_percentage_action'
 
-class TaxRange; end
+class TaxRange
+  extend LightService::Action
+end
 
 describe LooksUpTaxPercentageAction do
   let(:region) { double('region') }

data/spec/support.rb

@@ -1,6 +1,6 @@
 RSpec.shared_context 'expect orchestrator warning' do
   before do
-    expect(ActiveSupport::Deprecation)
+    expect(LightService::Deprecation)
       .to receive(:warn)
       .with(/^`Orchestrator#/)
       .at_least(:once)

data/spec/test_doubles.rb

@@ -45,6 +45,7 @@ module TestDoubles
 
   class TestLogger
     attr_accessor :logs
+
     def initialize
       @logs = []
     end
@@ -93,8 +94,13 @@ module TestDoubles
     end
   end
 
-  class AnAction; end
-  class AnotherAction; end
+  class AnAction
+    extend LightService::Action
+  end
+
+  class AnotherAction
+    extend LightService::Action
+  end
 
   class AnOrganizer
     extend LightService::Organizer
@@ -112,6 +118,15 @@ module TestDoubles
     end
   end
 
+  class NamedArgumentOrganiser
+    extend LightService::Organizer
+
+    def self.call(number:)
+      with(number: number) # rubocop:disable Style/HashSyntax
+        .reduce([AddsTwoAction])
+    end
+  end
+
   class NotExplicitlyReturningContextOrganizer
     extend LightService::Organizer
 
@@ -176,9 +191,7 @@ module TestDoubles
     promises :latte
 
     executed do |context|
-      if context.milk == :very_hot
-        context.fail!("Can't make a latte from a milk that's very hot!")
-      end
+      context.fail!("Can't make a latte from a milk that's very hot!") if context.milk == :very_hot
 
       if context.milk == :super_hot
         error_message = "Can't make a latte from a milk that's super hot!"
@@ -488,7 +501,9 @@ module TestDoubles
   class NullAction
     extend LightService::Action
 
+    # rubocop:disable Lint/EmptyBlock
     executed { |_ctx| }
+    # rubocop:enable Lint/EmptyBlock
   end
 
   class TestIterate

data/spec/testing/context_factory_spec.rb

@@ -60,3 +60,18 @@ describe 'ContextFactory - used with AdditionOrganizer' do
     end
   end
 end
+
+describe 'ContextFactory - used with NamedArgumentOrganiser' do
+  let(:organizer) { TestDoubles::NamedArgumentOrganiser }
+
+  # it's relevant to test this as handling of named arguments changed between ruby 2.7 and 3.0
+  it 'pass named arguments to the organiser' do
+    ctx =
+      LightService::Testing::ContextFactory
+      .make_from(organizer)
+      .for(TestDoubles::AddsTwoAction)
+      .with(number: 2) # rubocop:disable Style/HashSyntax
+
+    expect(ctx[:number]).to eq(2)
+  end
+end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Attila Domokos
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-14 00:00:00.000000000 Z
+date: 2024-09-08 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: generator_spec
   requirement: !ruby/object:Gem::Requirement
@@ -52,20 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: '0.14'
 description: A service skeleton with an emphasis on simplicity
 email:
 - adomokos@gmail.com
@@ -162,15 +134,12 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
-- Appraisals
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE
 - README.md
 - RELEASES.md
 - Rakefile
-- gemfiles/activesupport_5.gemfile
-- gemfiles/activesupport_6.gemfile
 - lib/generators/light_service/action_generator.rb
 - lib/generators/light_service/generator_utils.rb
 - lib/generators/light_service/organizer_generator.rb
@@ -183,12 +152,16 @@ files:
 - lib/light-service/configuration.rb
 - lib/light-service/context.rb
 - lib/light-service/context/key_verifier.rb
+- lib/light-service/deprecation_warning.rb
 - lib/light-service/errors.rb
+- lib/light-service/i18n/localization_adapter.rb
 - lib/light-service/localization_adapter.rb
+- lib/light-service/localization_map.rb
 - lib/light-service/orchestrator.rb
 - lib/light-service/organizer.rb
 - lib/light-service/organizer/execute.rb
 - lib/light-service/organizer/iterate.rb
+- lib/light-service/organizer/reduce_case.rb
 - lib/light-service/organizer/reduce_if.rb
 - lib/light-service/organizer/reduce_if_else.rb
 - lib/light-service/organizer/reduce_until.rb
@@ -230,6 +203,7 @@ files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
 - spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
@@ -244,6 +218,7 @@ files:
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb
 - spec/context_spec.rb
+- spec/i18n_localization_adapter_spec.rb
 - spec/lib/generators/action_generator_advanced_spec.rb
 - spec/lib/generators/action_generator_simple_spec.rb
 - spec/lib/generators/full_generator_test_blobs.rb
@@ -273,7 +248,7 @@ homepage: https://github.com/adomokos/light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -281,15 +256,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.5.3
+signing_key:
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity
 test_files:
@@ -317,6 +292,7 @@ test_files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
 - spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
@@ -331,6 +307,7 @@ test_files:
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb
 - spec/context_spec.rb
+- spec/i18n_localization_adapter_spec.rb
 - spec/lib/generators/action_generator_advanced_spec.rb
 - spec/lib/generators/action_generator_simple_spec.rb
 - spec/lib/generators/full_generator_test_blobs.rb

data/Appraisals

@@ -1,11 +0,0 @@
-appraise "activesupport-4" do
-  gem "activesupport", "~> 4.0"
-end
-
-appraise "activesupport-5" do
-  gem "activesupport", "~> 5.0"
-end
-
-appraise "activesupport-6" do
-  gem "activesupport", "~> 6.0"
-end

data/gemfiles/activesupport_5.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 5.0"
-
-gemspec :path => "../"

data/gemfiles/activesupport_6.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 6.0"
-
-gemspec :path => "../"