light-service 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b37602f04d4539ba8d8622f9e226c916071760ee37e21c7add4e1972f9c5175f
-  data.tar.gz: f55175d1a477c78896522f4bdca07697ceb80c7b62fca80e4c6803ff06bb2ec7
+  metadata.gz: d713cae791654b29dfc20e3cbffe16094badcc49b8221ccff0765dbd479b40c2
+  data.tar.gz: 1e2d61c708b70466a904f8e07aa4ba4aa383bd405342efeb51014286209b2ebb
 SHA512:
-  metadata.gz: d087df4f8d16b2e4f2611ac9e026906d2c7bb40cbe19b31052a71ed87e7ed5d70016bfc6ccfff363a4a04df7e9ff676c495d5246a7f69a142897cede456e99f4
-  data.tar.gz: 2317cff4254ae4bb6a20f481f042e2e63785fa015f130e4d01acb799f65e1e1db5f1f8fe1ebe9fdc973617925c456f8e4d024fe20ba0af98204a65a0c0f81b78
+  metadata.gz: c1d3f210ecbc0430bae9f573a945d599fcbf36a4acf26f5a49b9997c735dea8eba14f367e7c7a639d5cb8ff458feb5945ecd0078986140f763bb17b967947389
+  data.tar.gz: d2715e9fe494e4163efd52b4e2ce32011c3e275e8bdd1ba45e8ef1c2aff8705f2d2c994e02de0b8e20896ea5067ec75fb6a7ca333ac7f9b333544fcd82d2c7ca

data/.github/workflows/project-build.yml

@@ -13,7 +13,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu, macos]
-        ruby: [2.5.3, 2.6.6, 2.7.2]
+        ruby: [2.7.4, 3.0.2, 3.1.0]
         gemfile: [activesupport_5, activesupport_6]
     continue-on-error: ${{ endsWith(matrix.ruby, 'head') || matrix.ruby == 'debug' }}
     env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps

data/.rubocop.yml

@@ -1,7 +1,7 @@
-require: rubocop-performance
+# require: rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.7
   Exclude:
     - 'lib/light-service.rb'
     - 'vendor/bundle/**/*'
@@ -47,8 +47,122 @@ Metrics/BlockLength:
   Exclude:
     - 'spec/**/*.rb'
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: false
 
 Layout/EndOfLine:
   EnforcedStyle: lf
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Lint/EmptyClass:
+  Exclude:
+    - 'spec/**/*.rb'
+
+# Defaults after the Rubocop upgrade
+Gemspec/DateAssignment: # new in 1.10
+  Enabled: true
+Layout/LineEndStringConcatenationIndentation: # new in 1.18
+  Enabled: true
+Layout/SpaceBeforeBrackets: # new in 1.7
+  Enabled: true
+Lint/AmbiguousAssignment: # new in 1.7
+  Enabled: true
+Lint/AmbiguousOperatorPrecedence: # new in 1.21
+  Enabled: true
+Lint/AmbiguousRange: # new in 1.19
+  Enabled: true
+Lint/DeprecatedConstants: # new in 1.8
+  Enabled: true
+Lint/DuplicateBranch: # new in 1.3
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement: # new in 1.1
+  Enabled: true
+Lint/EmptyBlock: # new in 1.1
+  Enabled: true
+Lint/EmptyClass: # new in 1.3
+  Enabled: true
+Lint/EmptyInPattern: # new in 1.16
+  Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock: # new in 1.8
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks: # new in 1.2
+  Enabled: true
+Lint/NumberedParameterAssignment: # new in 1.9
+  Enabled: true
+Lint/OrAssignmentToConstant: # new in 1.9
+  Enabled: true
+Lint/RedundantDirGlobSort: # new in 1.8
+  Enabled: true
+Lint/SymbolConversion: # new in 1.9
+  Enabled: true
+Lint/ToEnumArguments: # new in 1.1
+  Enabled: true
+Lint/TripleQuotes: # new in 1.9
+  Enabled: true
+Lint/UnexpectedBlockArity: # new in 1.5
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # new in 1.1
+  Enabled: true
+Style/ArgumentsForwarding: # new in 1.1
+  Enabled: true
+Style/CollectionCompact: # new in 1.2
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # new in 1.1
+  Enabled: true
+Style/EndlessMethod: # new in 1.8
+  Enabled: true
+Style/HashConversion: # new in 1.10
+  Enabled: true
+Style/HashExcept: # new in 1.7
+  Enabled: true
+Style/IfWithBooleanLiteralBranches: # new in 1.9
+  Enabled: true
+Style/InPatternThen: # new in 1.16
+  Enabled: true
+Style/MultilineInPatternThen: # new in 1.16
+  Enabled: true
+Style/NegatedIfElseCondition: # new in 1.2
+  Enabled: true
+Style/NilLambda: # new in 1.3
+  Enabled: true
+Style/QuotedSymbols: # new in 1.16
+  Enabled: true
+Style/RedundantArgument: # new in 1.4
+  Enabled: true
+Style/RedundantSelfAssignmentBranch: # new in 1.19
+  Enabled: true
+Style/StringChars: # new in 1.12
+  Enabled: true
+Style/SwapValues: # new in 1.1
+  Enabled: true
+Gemspec/RequireMFA: # new in 1.23
+  Enabled: true
+Lint/RequireRelativeSelfPath: # new in 1.22
+  Enabled: true
+Lint/UselessRuby2Keywords: # new in 1.23
+  Enabled: true
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+Security/IoMethods: # new in 1.22
+  Enabled: true
+Style/FileRead: # new in 1.24
+  Enabled: true
+Style/FileWrite: # new in 1.24
+  Enabled: true
+Style/MapToHash: # new in 1.24
+  Enabled: true
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+Style/NumberedParameters: # new in 1.22
+  Enabled: true
+Style/NumberedParametersLimit: # new in 1.22
+  Enabled: true
+Style/OpenStructUse: # new in 1.23
+  Enabled: true
+Style/SelectByRegexp: # new in 1.22
+  Enabled: true

data/README.md

@@ -959,16 +959,17 @@ end
 
 This code is much easier to reason about, it's less noisy and it captures the goal of LightService well: simple, declarative code that's easy to understand.
 
-The 7 different orchestrator constructs an organizer can have:
+The 9 different orchestrator constructs an organizer can have:
 
 1. `reduce_until`
 2. `reduce_if`
 3. `reduce_if_else`
-4. `iterate`
-5. `execute`
-6. `with_callback`
-7. `add_to_context`
-8. `add_aliases`
+4. `reduce_case`
+5. `iterate`
+6. `execute`
+7. `with_callback`
+8. `add_to_context`
+9. `add_aliases`
 
 `reduce_until` behaves like a while loop in imperative languages, it iterates until the provided predicate in the lambda evaluates to true. Take a look at [this acceptance test](spec/acceptance/organizer/reduce_until_spec.rb) to see how it's used.
 
@@ -976,6 +977,8 @@ The 7 different orchestrator constructs an organizer can have:
 
 `reduce_if_else` takes three arguments, a condition lambda, a first set of "if true" steps, and a second set of "if false" steps. If the lambda evaluates to true, the "if true" steps are executed, otherwise the "else steps" are executed. [This acceptance test](spec/acceptance/organizer/reduce_if_else_spec.rb) describes this functionality.
 
+`reduce_case` behaves like a Ruby `case` statement. The first parameter `value` is the key of the value within the context that will be worked with. The second parameter `when` is a hash where the keys are conditional values and the values are steps to take if the condition matches. The final parameter `else` is a set of steps to take if no conditions within the `when` parameter are met. [This acceptance test](spec/acceptance/organizer/reduce_case_spec.rb) describes this functionality.
+
 `iterate` gives your iteration logic, the symbol you define there has to be in the context as a key. For example, to iterate over items you will use `iterate(:items)` in your steps, the context needs to have `items` as a key, otherwise it will fail. The organizer will singularize the collection name and will put the actual item into the context under that name. Remaining with the example above, each element will be accessible by the name `item` for the actions in the `iterate` steps. [This acceptance test](spec/acceptance/organizer/iterate_spec.rb) should provide you with an example.
 
 To take advantage of another organizer or action, you might need to tweak the context a bit. Let's say you have a hash, and you need to iterate over its values in a series of action. To alter the context and have the values assigned into a variable, you need to create a new action with 1 line of code in it. That seems a lot of ceremony for a simple change. You can do that in a `execute` method like this `execute(->(ctx) { ctx[:some_values] = ctx.some_hash.values })`. [This test](spec/acceptance/organizer/execute_spec.rb) describes how you can use it.

data/RELEASES.md

@@ -1,5 +1,11 @@
 A brief list of new features and changes introduced with the specified version.
 
+### 0.18.0
+* [Remove Ruby 2.6, add 3.1 to build](https://github.com/adomokos/light-service/pull/233)
+* [Add reduce_when](https://github.com/adomokos/light-service/pull/232)
+* [Drop Ruby 2.5 version support, add 3.0 build](https://github.com/adomokos/light-service/pull/225)
+* [Support for named argument in Ruby](https://github.com/adomokos/light-service/pull/224)
+
 ### 0.17.0
 * [Fix around_action hook for nested actions](https://github.com/adomokos/light-service/pull/217)
 * [Add ReduceIfElse macro](https://github.com/adomokos/light-service/pull/218)

data/lib/generators/light_service/generator_utils.rb

@@ -25,7 +25,6 @@ module LightService
         options.tests? && test_framework_supported?
       end
 
-      # rubocop:disable Metrics/AbcSize
       def create_required_gen_vals_from(name)
         path_parts = name.underscore.split('/')
 
@@ -39,7 +38,6 @@ module LightService
           :full_class_name => name.classify
         }
       end
-      # rubocop:enable Metrics/AbcSize
     end
   end
 end

data/lib/light-service/context/key_verifier.rb

@@ -24,7 +24,7 @@ module LightService
 
       def error_message
         "#{type_name} #{format_keys(keys_not_found(keys))} " \
-        "to be in the context during #{action}"
+          "to be in the context during #{action}"
       end
 
       def throw_error_predicate(_keys)
@@ -95,7 +95,7 @@ module LightService
 
       def error_message
         "promised or expected keys cannot be a " \
-        "reserved key: [#{format_keys(violated_keys)}]"
+          "reserved key: [#{format_keys(violated_keys)}]"
       end
 
       def keys
@@ -116,9 +116,11 @@ module LightService
     end
 
     class ReservedKeysViaOrganizerVerifier < ReservedKeysVerifier
+      # rubocop:disable Lint/MissingSuper
       def initialize(context_data)
         @context = LightService::Context.make(context_data)
       end
+      # rubocop:enable Lint/MissingSuper
 
       def violated_keys
         context.keys.map(&:to_sym) & reserved_keys

data/lib/light-service/context.rb

@@ -6,11 +6,12 @@ module LightService
     FAILURE = 1
   end
 
-  # rubocop:disable ClassLength
+  # rubocop:disable Metrics/ClassLength
   class Context < Hash
     attr_accessor :message, :error_code, :current_action, :around_actions,
                   :organized_by
 
+    # rubocop:disable Metrics/ParameterLists, Lint/MissingSuper
     def initialize(context = {},
                    outcome = Outcomes::SUCCESS,
                    message = '',
@@ -22,6 +23,7 @@ module LightService
 
       context.to_hash.each { |k, v| self[k] = v }
     end
+    # rubocop:enable Metrics/ParameterLists, Lint/MissingSuper
 
     def self.make(context = {})
       unless context.is_a?(Hash) || context.is_a?(LightService::Context)
@@ -152,13 +154,8 @@ module LightService
     end
 
     def inspect
-      "#{self.class}(#{self}, " \
-      + "success: #{success?}, " \
-      + "message: #{check_nil(message)}, " \
-      + "error_code: #{check_nil(error_code)}, " \
-      + "skip_remaining: #{@skip_remaining}, " \
-      + "aliases: #{@aliases}" \
-      + ")"
+      "#{self.class}(#{self}, success: #{success?}, message: #{check_nil(message)}, error_code: " \
+        "#{check_nil(error_code)}, skip_remaining: #{@skip_remaining}, aliases: #{@aliases})"
     end
 
     private
@@ -169,5 +166,5 @@ module LightService
       "'#{value}'"
     end
   end
-  # rubocop:enable ClassLength
+  # rubocop:enable Metrics/ClassLength
 end

data/lib/light-service/errors.rb

@@ -1,7 +1,11 @@
 module LightService
   class FailWithRollbackError < StandardError; end
+
   class ExpectedKeysNotInContextError < StandardError; end
+
   class PromisedKeysNotInContextError < StandardError; end
+
   class ReservedKeysInContextError < StandardError; end
+
   class UnusableExpectKeyDefaultError < StandardError; end
 end

data/lib/light-service/orchestrator.rb

@@ -115,7 +115,7 @@ module LightService
 
       def issue_deprecation_warning_for(method_name)
         msg = "`Orchestrator##{method_name}` is DEPRECATED and will be " \
-          "removed, please switch to `Organizer##{method_name} instead. "
+              "removed, please switch to `Organizer##{method_name} instead. "
         ActiveSupport::Deprecation.warn(msg)
       end
     end

data/lib/light-service/organizer/reduce_case.rb

@@ -0,0 +1,48 @@
+module LightService
+  module Organizer
+    class ReduceCase
+      extend ScopedReducable
+
+      class Arguments
+        attr_reader :value, :when, :else
+
+        def initialize(**args)
+          validate_arguments(**args)
+          @value = args[:value]
+          @when = args[:when]
+          @else = args[:else]
+        end
+
+        private
+
+        # rubocop:disable Style/MultilineIfModifier
+        def validate_arguments(**args)
+          raise(
+            ArgumentError,
+            "Expected keyword arguments: [:value, :when, :else]. Given: #{args.keys}"
+          ) unless args.keys.intersection(mandatory_arguments).count == mandatory_arguments.count
+        end
+        # rubocop:enable Style/MultilineIfModifier
+
+        def mandatory_arguments
+          %i[value when else]
+        end
+      end
+
+      def self.run(organizer, **args)
+        arguments = Arguments.new(**args)
+
+        lambda do |ctx|
+          return ctx if ctx.stop_processing?
+
+          matched_case = arguments.when.keys.find { |k| k.eql?(ctx[arguments.value]) }
+          steps = arguments.when[matched_case] || arguments.else
+
+          ctx = scoped_reduce(organizer, ctx, steps)
+
+          ctx
+        end
+      end
+    end
+  end
+end

data/lib/light-service/organizer/with_reducer.rb

@@ -34,14 +34,12 @@ module LightService
         actions.flatten!
 
         actions.each_with_object(context) do |action, current_context|
-          begin
-            invoke_action(current_context, action)
-          rescue FailWithRollbackError
-            reduce_rollback(actions)
-          ensure
-            # For logging
-            yield(current_context, action) if block_given?
-          end
+          invoke_action(current_context, action)
+        rescue FailWithRollbackError
+          reduce_rollback(actions)
+        ensure
+          # For logging
+          yield(current_context, action) if block_given?
         end
       end
 

data/lib/light-service/organizer/with_reducer_log_decorator.rb

@@ -5,7 +5,7 @@ module LightService
 
       alias logged? logged
 
-      def initialize(organizer, decorated: WithReducer.new, logger:)
+      def initialize(organizer, logger:, decorated: WithReducer.new)
         @decorated = decorated
         @organizer = organizer
 
@@ -22,7 +22,7 @@ module LightService
 
         logger.info do
           "[LightService] -     keys in context: " \
-          "#{extract_keys(decorated.context.keys)}"
+            "#{extract_keys(decorated.context.keys)}"
         end
         self
       end

data/lib/light-service/organizer.rb

@@ -49,6 +49,10 @@ module LightService
         ReduceUntil.run(self, condition_block, steps)
       end
 
+      def reduce_case(**args)
+        ReduceCase.run(self, **args)
+      end
+
       def iterate(collection_key, steps)
         Iterate.run(self, collection_key, steps)
       end

data/lib/light-service/testing/context_factory.rb

@@ -26,11 +26,13 @@ module LightService
 
       # More than one arguments can be passed to the
       # Organizer's #call method
+      # rubocop:disable Style/ArgumentsForwarding
       def with(*args, &block)
         catch(:return_ctx_from_execution) do
           @organizer.call(*args, &block)
         end
       end
+      # rubocop:enable Style/ArgumentsForwarding
 
       def initialize(organizer)
         @organizer = organizer

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.17.0".freeze
+  VERSION = "0.18.0".freeze
 end

data/lib/light-service.rb

@@ -15,6 +15,7 @@ require 'light-service/organizer/with_reducer_factory'
 require 'light-service/organizer/reduce_if'
 require 'light-service/organizer/reduce_if_else'
 require 'light-service/organizer/reduce_until'
+require 'light-service/organizer/reduce_case'
 require 'light-service/organizer/iterate'
 require 'light-service/organizer/execute'
 require 'light-service/organizer/with_callback'

data/light-service.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.name          = "light-service"
   gem.require_paths = ["lib"]
   gem.version       = LightService::VERSION
-  gem.required_ruby_version = '>= 2.5.0'
+  gem.required_ruby_version = '>= 2.6.0'
 
   gem.add_runtime_dependency("activesupport", ">= 4.0.0")
 
@@ -25,7 +25,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency("rspec", "~> 3.0")
   gem.add_development_dependency("simplecov", "~> 0.17")
   gem.add_development_dependency("codecov", "~> 0.1")
-  gem.add_development_dependency("rubocop", "~> 0.68.0")
+  gem.add_development_dependency("rubocop", "~> 1.26.0")
   gem.add_development_dependency("rubocop-performance", "~> 1.2.0")
   gem.add_development_dependency("pry", "~> 0.12.2")
 end

data/spec/acceptance/after_actions_spec.rb

@@ -34,14 +34,10 @@ RSpec.describe 'Action after_actions' do
       class AdditionOrganizer
         extend LightService::Organizer
         after_actions (lambda do |ctx|
-                         if ctx.current_action == TestDoubles::AddsOneAction
-                           ctx.number -= 2
-                         end
+                         ctx.number -= 2 if ctx.current_action == TestDoubles::AddsOneAction
                        end),
                       (lambda do |ctx|
-                         if ctx.current_action == TestDoubles::AddsThreeAction
-                           ctx.number -= 3
-                         end
+                         ctx.number -= 3 if ctx.current_action == TestDoubles::AddsThreeAction
                        end)
 
         def self.call(number)
@@ -69,9 +65,7 @@ RSpec.describe 'Action after_actions' do
     it 'ensures the correct :current_action is set' do
       TestDoubles::TestWithCallback.after_actions = [
         lambda do |ctx|
-          if ctx.current_action == TestDoubles::IterateCollectionAction
-            ctx.total -= 1000
-          end
+          ctx.total -= 1000 if ctx.current_action == TestDoubles::IterateCollectionAction
         end
       ]
 

data/spec/acceptance/before_actions_spec.rb

@@ -34,14 +34,10 @@ RSpec.describe 'Action before_actions' do
       class AdditionOrganizer
         extend LightService::Organizer
         before_actions (lambda do |ctx|
-                          if ctx.current_action == TestDoubles::AddsOneAction
-                            ctx.number -= 2
-                          end
+                          ctx.number -= 2 if ctx.current_action == TestDoubles::AddsOneAction
                         end),
                        (lambda do |ctx|
-                          if ctx.current_action == TestDoubles::AddsThreeAction
-                            ctx.number -= 3
-                          end
+                          ctx.number -= 3 if ctx.current_action == TestDoubles::AddsThreeAction
                         end)
 
         def self.call(number)
@@ -69,9 +65,7 @@ RSpec.describe 'Action before_actions' do
     it 'can interact with actions from the outside' do
       TestDoubles::TestWithCallback.before_actions = [
         lambda do |ctx|
-          if ctx.current_action == TestDoubles::AddToTotalAction
-            ctx.total -= 1000
-          end
+          ctx.total -= 1000 if ctx.current_action == TestDoubles::AddToTotalAction
         end
       ]
       result = TestDoubles::TestWithCallback.call

data/spec/acceptance/organizer/reduce_case_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+require 'test_doubles'
+
+RSpec.describe LightService::Organizer do
+  class TestReduceCase
+    extend LightService::Organizer
+
+    def self.call(context)
+      with(context).reduce(actions)
+    end
+
+    def self.actions
+      [
+        reduce_case(
+          :value => :incr_num,
+          :when => {
+            :one => [TestDoubles::AddsOneAction],
+            :two => [TestDoubles::AddsTwoAction],
+            :three => [TestDoubles::AddsThreeAction]
+          },
+          :else => [TestDoubles::FailureAction]
+        )
+      ]
+    end
+  end
+
+  it 'adds one if the incr_num is one' do
+    result = TestReduceCase.call(:number => 0, :incr_num => :one)
+
+    expect(result).to be_success
+    expect(result[:number]).to eq(1)
+  end
+
+  it 'adds two if the incr_num is two' do
+    result = TestReduceCase.call(:number => 0, :incr_num => :two)
+
+    expect(result).to be_success
+    expect(result[:number]).to eq(2)
+  end
+
+  it 'adds three if the incr_num is three' do
+    result = TestReduceCase.call(:number => 0, :incr_num => :three)
+
+    expect(result).to be_success
+    expect(result[:number]).to eq(3)
+  end
+
+  it 'will fail if the incr_num is neither one, two, or three' do
+    result = TestReduceCase.call(:number => 0, :incr_num => :four)
+
+    expect(result).to be_failure
+  end
+end

data/spec/acceptance/organizer/reduce_if_spec.rb

@@ -63,6 +63,7 @@ RSpec.describe LightService::Organizer do
         reduce(actions)
       end
 
+      # rubocop:disable Metrics/AbcSize
       def self.actions
         [
           reduce_if(
@@ -76,6 +77,7 @@ RSpec.describe LightService::Organizer do
           execute(->(c) { c[:last_outside] = true })
         ]
       end
+      # rubocop:enable Metrics/AbcSize
     end
 
     result = org.call

data/spec/context/inspect_spec.rb

@@ -13,13 +13,7 @@ RSpec.describe LightService::Context do
   describe '#inspect' do
     it 'inspects the hash with all the fields' do
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: true, message: '', error_code: nil, skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -28,13 +22,8 @@ RSpec.describe LightService::Context do
       context.fail!('There was an error')
 
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: false, ' \
-        + 'message: \'There was an error\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: false, message: 'There was an error', error_code: nil, " \
+        "skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -43,13 +32,8 @@ RSpec.describe LightService::Context do
       context.skip_remaining!('No need to process')
 
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'No need to process\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: true, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: true, message: 'No need to process', error_code: nil, " \
+        "skip_remaining: true, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end

data/spec/context_spec.rb

@@ -167,7 +167,7 @@ RSpec.describe LightService::Context do
   end
 
   it "allows a default block value for #fetch" do
-    expect(context.fetch(:madeup) { :default }).to eq(:default)
+    expect(context.fetch(:madeup, :default)).to eq(:default)
   end
 
   context "when aliases are included via .make" do

data/spec/lib/generators/action_generator_advanced_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/action_generator.rb'
+require_relative '../../../lib/generators/light_service/action_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::ActionGenerator, :type => :generator do

data/spec/lib/generators/action_generator_simple_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/action_generator.rb'
+require_relative '../../../lib/generators/light_service/action_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::ActionGenerator, :type => :generator do

data/spec/lib/generators/organizer_generator_advanced_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/organizer_generator.rb'
+require_relative '../../../lib/generators/light_service/organizer_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::OrganizerGenerator, :type => :generator do

data/spec/lib/generators/organizer_generator_simple_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/organizer_generator.rb'
+require_relative '../../../lib/generators/light_service/organizer_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::OrganizerGenerator, :type => :generator do

data/spec/sample/calculates_tax_spec.rb

@@ -10,7 +10,6 @@ describe CalculatesTax do
 
   it "calls the actions in order" do
     allow(LightService::Context).to receive(:make)
-      .with(:order => order)
       .and_return(ctx)
 
     allow(LooksUpTaxPercentageAction).to receive(:execute)

data/spec/sample/looks_up_tax_percentage_action_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 require_relative 'tax/looks_up_tax_percentage_action'
 
-class TaxRange; end
+class TaxRange
+  extend LightService::Action
+end
 
 describe LooksUpTaxPercentageAction do
   let(:region) { double('region') }

data/spec/test_doubles.rb

@@ -45,6 +45,7 @@ module TestDoubles
 
   class TestLogger
     attr_accessor :logs
+
     def initialize
       @logs = []
     end
@@ -93,8 +94,13 @@ module TestDoubles
     end
   end
 
-  class AnAction; end
-  class AnotherAction; end
+  class AnAction
+    extend LightService::Action
+  end
+
+  class AnotherAction
+    extend LightService::Action
+  end
 
   class AnOrganizer
     extend LightService::Organizer
@@ -176,9 +182,7 @@ module TestDoubles
     promises :latte
 
     executed do |context|
-      if context.milk == :very_hot
-        context.fail!("Can't make a latte from a milk that's very hot!")
-      end
+      context.fail!("Can't make a latte from a milk that's very hot!") if context.milk == :very_hot
 
       if context.milk == :super_hot
         error_message = "Can't make a latte from a milk that's super hot!"
@@ -488,7 +492,9 @@ module TestDoubles
   class NullAction
     extend LightService::Action
 
+    # rubocop:disable Lint/EmptyBlock
     executed { |_ctx| }
+    # rubocop:enable Lint/EmptyBlock
   end
 
   class TestIterate

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Attila Domokos
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-14 00:00:00.000000000 Z
+date: 2022-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -189,6 +189,7 @@ files:
 - lib/light-service/organizer.rb
 - lib/light-service/organizer/execute.rb
 - lib/light-service/organizer/iterate.rb
+- lib/light-service/organizer/reduce_case.rb
 - lib/light-service/organizer/reduce_if.rb
 - lib/light-service/organizer/reduce_if_else.rb
 - lib/light-service/organizer/reduce_until.rb
@@ -230,6 +231,7 @@ files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
 - spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
@@ -273,7 +275,7 @@ homepage: https://github.com/adomokos/light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -281,15 +283,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.12
+signing_key:
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity
 test_files:
@@ -317,6 +319,7 @@ test_files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
 - spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb