light-service 0.16.0 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d41ecb22a4b0d3cd9779c1e5726c8f34e6f186a34f04ec97ea5928f682f08fd8
-  data.tar.gz: 64f4d7f52607048313e9f39bea158899ef804deb32ae9744715e5969cc7b1567
+  metadata.gz: b37602f04d4539ba8d8622f9e226c916071760ee37e21c7add4e1972f9c5175f
+  data.tar.gz: f55175d1a477c78896522f4bdca07697ceb80c7b62fca80e4c6803ff06bb2ec7
 SHA512:
-  metadata.gz: 2345b72e3d9581aecaea2fe5eca1bd3c538cdb0cfcd2d943ac021ca4f3ef31913ac4b06011944c017df330f3ee8dc385793e8185f3e79cba6c51fbe6ee6acba6
-  data.tar.gz: 703b9608edfa42bf0d73135fa5b4eafa789e8a31c4239056fd8b7397d6f0a212f8c5c69d66834f1f5b9fe2431b234f8c0373ccaaa86f286d82671bfe8d8b705b
+  metadata.gz: d087df4f8d16b2e4f2611ac9e026906d2c7bb40cbe19b31052a71ed87e7ed5d70016bfc6ccfff363a4a04df7e9ff676c495d5246a7f69a142897cede456e99f4
+  data.tar.gz: 2317cff4254ae4bb6a20f481f042e2e63785fa015f130e4d01acb799f65e1e1db5f1f8fe1ebe9fdc973617925c456f8e4d024fe20ba0af98204a65a0c0f81b78

data/README.md

@@ -21,6 +21,8 @@ LightService is a powerful and flexible service skeleton framework with an empha
     * [Skipping the Rest of the Actions](#skipping-the-rest-of-the-actions)
 * [Benchmarking Actions with Around Advice](#benchmarking-actions-with-around-advice)
 * [Before and After Action Hooks](#before-and-after-action-hooks)
+* [Expects and Promises](#expects-and-promises)
+    * [Default values for optional Expected keys](#default-values-for-optional-expected-keys)
 * [Key Aliases](#key-aliases)
 * [Logging](#logging)
 * [Error Codes](#error-codes)
@@ -529,9 +531,11 @@ These ideas are originally from Aspect Oriented Programming, read more about the
 ## Expects and Promises
 The `expects` and `promises` macros are rules for the inputs/outputs of an action.
 `expects` describes what keys it needs to execute, and `promises` makes sure the keys are in the context after the
-action is reduced. If either of them are violated, a custom exception is thrown.
+action is reduced. If either of them are violated, a `LightService::ExpectedKeysNotInContextError` or
+`LightService::PromisedKeysNotInContextError` exception respectively will be thrown.
 
 This is how it's used:
+
 ```ruby
 class FooAction
   extend LightService::Action
@@ -539,46 +543,78 @@ class FooAction
   promises :bar
 
   executed do |context|
-    baz = context.fetch :baz
-
-    bar = baz + 2
-    context[:bar] = bar
+    context.bar = context.baz + 2
   end
 end
 ```
 
-The `expects` macro does a bit more for you: it pulls the value with the expected key from the context, and
-makes it available to you through a reader. You can refactor the action like this:
+The `expects` macro will pull the value with the expected key from the context, and
+makes it available to you through a reader.
+
+The `promises` macro will not only check if the context has the promised keys, it
+also sets them for you in the context if you use the accessor with the same name,
+much the same way as the expects macro works.
+
+The context object is essentially a smarter-than-normal Hash. Take a look at [this spec](spec/action_expects_and_promises_spec.rb)
+to see expects and promises used with and without accessors.
+
+### Default values for optional Expected keys
+
+When you have an expected key that has a sensible default which should be used everywhere and
+only overridden on an as-needed basis, you can specify a default value. An example use-case
+is a flag that allows a failure from a service under most circumstances to avoid failing an
+entire workflow because of a non-critical action.
+
+LightService provides two mechanisms for specifying default values:
+
+1. A static value that is used as-is
+2. A callable that takes the current context as a param
+
+Using the above use case, consider an action that sends a text message. In most cases,
+if there is a problem sending the text message, it might be OK for it to fail. We will
+`expect` an `allow_failure` key, but set it with a default, like so:
 
 ```ruby
-class FooAction
+class SendSMS
   extend LightService::Action
-  expects :baz
-  promises :bar
+  expects :message, :user
+  expects :allow_failure, default: true
 
   executed do |context|
-    bar = context.baz + 2
-    context[:bar] = bar
+    sms_api = SMSService.new(key: ENV["SMS_API_KEY"])
+    status  = sms_api.send(ctx.user.mobile_number, ctx.message)
+
+    if !status.sent_ok?
+      ctx.fail!(status.err_msg) unless ctx.allow_failure
+    end
   end
 end
 ```
 
-The `promises` macro will not only check if the context has the promised keys, it also sets it for you in the context if
-you use the accessor with the same name. The code above can be further simplified:
+Default values can also be processed dynamically by providing a callable. Any values already
+specified in the context are available to it via Hash key lookup syntax. e.g.
 
 ```ruby
-class FooAction
+class SendSMS
   extend LightService::Action
-  expects :baz
-  promises :bar
+  expects :message, :user
+  expects :allow_failure, default: ->(ctx) { !ctx[:user].admin? } # Admins must always get SMS'
 
   executed do |context|
-    context.bar = context.baz + 2
+    sms_api = SMSService.new(key: ENV["SMS_API_KEY"])
+    status  = sms_api.send(ctx.user.mobile_number, ctx.message)
+
+    if !status.sent_ok?
+      ctx.fail!(status.err_msg) unless ctx.allow_failure
+    end
   end
 end
 ```
 
-Take a look at [this spec](spec/action_expects_and_promises_spec.rb) to see the refactoring in action.
+**Note** that default values must be specified one at a time on their own line.
+
+You can then call an action or organizer that uses an action with defaults without specifying
+the expected key that has a default.
 
 ## Key Aliases
 The `aliases` macro sets up pairs of keys and aliases in an organizer. Actions can access the context using the aliases.
@@ -927,16 +963,19 @@ The 7 different orchestrator constructs an organizer can have:
 
 1. `reduce_until`
 2. `reduce_if`
-3. `iterate`
-4. `execute`
-5. `with_callback`
-6. `add_to_context`
-7. `add_aliases`
+3. `reduce_if_else`
+4. `iterate`
+5. `execute`
+6. `with_callback`
+7. `add_to_context`
+8. `add_aliases`
 
 `reduce_until` behaves like a while loop in imperative languages, it iterates until the provided predicate in the lambda evaluates to true. Take a look at [this acceptance test](spec/acceptance/organizer/reduce_until_spec.rb) to see how it's used.
 
 `reduce_if` will reduce the included organizers and/or actions if the predicate in the lambda evaluates to true. [This acceptance test](spec/acceptance/organizer/reduce_if_spec.rb) describes this functionality.
 
+`reduce_if_else` takes three arguments, a condition lambda, a first set of "if true" steps, and a second set of "if false" steps. If the lambda evaluates to true, the "if true" steps are executed, otherwise the "else steps" are executed. [This acceptance test](spec/acceptance/organizer/reduce_if_else_spec.rb) describes this functionality.
+
 `iterate` gives your iteration logic, the symbol you define there has to be in the context as a key. For example, to iterate over items you will use `iterate(:items)` in your steps, the context needs to have `items` as a key, otherwise it will fail. The organizer will singularize the collection name and will put the actual item into the context under that name. Remaining with the example above, each element will be accessible by the name `item` for the actions in the `iterate` steps. [This acceptance test](spec/acceptance/organizer/iterate_spec.rb) should provide you with an example.
 
 To take advantage of another organizer or action, you might need to tweak the context a bit. Let's say you have a hash, and you need to iterate over its values in a series of action. To alter the context and have the values assigned into a variable, you need to create a new action with 1 line of code in it. That seems a lot of ceremony for a simple change. You can do that in a `execute` method like this `execute(->(ctx) { ctx[:some_values] = ctx.some_hash.values })`. [This test](spec/acceptance/organizer/execute_spec.rb) describes how you can use it.
@@ -1049,10 +1088,12 @@ When specifying `promises`, specs will be created testing for their existence af
 
 ## Other implementations
 
-| Language | Repo                                                              | Author                                                 |
-| :------- |:------------------------------------------------------------------| :------------------------------------------------------|
-| Python   | [pyservice](https://github.com/adomokos/pyservice)                | [@adomokos](https://github.com/adomokos)               |
-| PHP      | [light-service](https://github.com/douglasgreyling/light-service) | [@douglasgreyling](https://github.com/douglasgreyling) |
+| Language   | Repo                                                                    | Author                                                 |
+| :--------- |:------------------------------------------------------------------------| :------------------------------------------------------|
+| Python     | [pyservice](https://github.com/adomokos/pyservice)                      | [@adomokos](https://github.com/adomokos)               |
+| PHP        | [light-service](https://github.com/douglasgreyling/light-service)       | [@douglasgreyling](https://github.com/douglasgreyling) |
+| JavaScript | [light-service.js](https://github.com/douglasgreyling/light-service.js) | [@douglasgreyling](https://github.com/douglasgreyling) |
+
 
 ## Contributing
 1. Fork it

data/RELEASES.md

@@ -1,5 +1,11 @@
 A brief list of new features and changes introduced with the specified version.
 
+### 0.17.0
+* [Fix around_action hook for nested actions](https://github.com/adomokos/light-service/pull/217)
+* [Add ReduceIfElse macro](https://github.com/adomokos/light-service/pull/218)
+* [Implement support for default values for optional expected keys](https://github.com/adomokos/light-service/pull/219)
+* [Add light-service.js implementation to README](https://github.com/adomokos/light-service/pull/222)
+
 ### 0.16.0
 * [Drop Ruby 2.4 support](https://github.com/adomokos/light-service/pull/207)
 * [Fix callback current action](https://github.com/adomokos/light-service/pull/209)

data/lib/light-service/action.rb

@@ -15,6 +15,12 @@ module LightService
 
     module Macros
       def expects(*args)
+        if expect_key_having_default?(args)
+          available_defaults[args.first] = args.last[:default]
+
+          args = [args.first]
+        end
+
         expected_keys.concat(args)
       end
 
@@ -30,8 +36,8 @@ module LightService
         @promised_keys ||= []
       end
 
-      def executed
-        define_singleton_method :execute do |context = {}|
+      def executed(*_args, &block)
+        define_singleton_method :execute do |context = Context.make|
           action_context = create_action_context(context)
           return action_context if action_context.stop_processing?
 
@@ -43,7 +49,8 @@ module LightService
 
             catch(:jump_when_failed) do
               call_before_action(action_context)
-              yield(action_context)
+
+              execute_action(action_context, &block)
 
               # Reset the stored action in case it was changed downstream
               action_context.current_action = self
@@ -66,8 +73,34 @@ module LightService
 
       private
 
+      def execute_action(context)
+        if around_action_context?(context)
+          context.around_actions.call(context) do
+            yield(context)
+            context
+          end
+        else
+          yield(context)
+        end
+      end
+
+      def available_defaults
+        @available_defaults ||= {}
+      end
+
+      def expect_key_having_default?(key)
+        return false unless key.size == 2 && key.last.is_a?(Hash)
+        return true if key.last.key?(:default)
+
+        bad_key = key.last.keys.first
+        err_msg = "Specify defaults with a `default` key. You have #{bad_key}."
+        raise UnusableExpectKeyDefaultError, err_msg
+      end
+
       def create_action_context(context)
-        return context if context.is_a? LightService::Context
+        usable_defaults(context).each do |ctx_key, default|
+          context[ctx_key] = extract_default(default, context)
+        end
 
         LightService::Context.make(context)
       end
@@ -76,6 +109,22 @@ module LightService
         expected_keys + promised_keys
       end
 
+      def missing_expected_keys(context)
+        expected_keys - context.keys
+      end
+
+      def usable_defaults(context)
+        available_defaults.slice(
+          *(missing_expected_keys(context) & available_defaults.keys)
+        )
+      end
+
+      def extract_default(default, context)
+        return default unless default.respond_to?(:call)
+
+        default.call(context)
+      end
+
       def call_before_action(context)
         invoke_callbacks(context[:_before_actions], context)
       end
@@ -93,6 +142,11 @@ module LightService
 
         context
       end
+
+      def around_action_context?(context)
+        context.instance_of?(Context) &&
+          context.around_actions.respond_to?(:call)
+      end
     end
   end
 end

data/lib/light-service/context.rb

@@ -8,7 +8,8 @@ module LightService
 
   # rubocop:disable ClassLength
   class Context < Hash
-    attr_accessor :message, :error_code, :current_action, :organized_by
+    attr_accessor :message, :error_code, :current_action, :around_actions,
+                  :organized_by
 
     def initialize(context = {},
                    outcome = Outcomes::SUCCESS,

data/lib/light-service/errors.rb

@@ -3,4 +3,5 @@ module LightService
   class ExpectedKeysNotInContextError < StandardError; end
   class PromisedKeysNotInContextError < StandardError; end
   class ReservedKeysInContextError < StandardError; end
+  class UnusableExpectKeyDefaultError < StandardError; end
 end

data/lib/light-service/organizer/reduce_if_else.rb

@@ -0,0 +1,21 @@
+module LightService
+  module Organizer
+    class ReduceIfElse
+      extend ScopedReducable
+
+      def self.run(organizer, condition_block, if_steps, else_steps)
+        lambda do |ctx|
+          return ctx if ctx.stop_processing?
+
+          ctx = if condition_block.call(ctx)
+                  scoped_reduce(organizer, ctx, if_steps)
+                else
+                  scoped_reduce(organizer, ctx, else_steps)
+                end
+
+          ctx
+        end
+      end
+    end
+  end
+end

data/lib/light-service/organizer/with_reducer.rb

@@ -30,6 +30,7 @@ module LightService
       def reduce(*actions)
         raise "No action(s) were provided" if actions.empty?
 
+        @context.around_actions ||= around_each_handler
         actions.flatten!
 
         actions.each_with_object(context) do |action, current_context|
@@ -59,12 +60,10 @@ module LightService
       private
 
       def invoke_action(current_context, action)
-        around_each_handler.call(current_context) do
-          if action.respond_to?(:call)
-            action.call(current_context)
-          else
-            action.execute(current_context)
-          end
+        if action.respond_to?(:call)
+          action.call(current_context)
+        else
+          action.execute(current_context)
         end
       end
 

data/lib/light-service/organizer.rb

@@ -41,6 +41,10 @@ module LightService
         ReduceIf.run(self, condition_block, steps)
       end
 
+      def reduce_if_else(condition_block, if_steps, else_steps)
+        ReduceIfElse.run(self, condition_block, if_steps, else_steps)
+      end
+
       def reduce_until(condition_block, steps)
         ReduceUntil.run(self, condition_block, steps)
       end

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.16.0".freeze
+  VERSION = "0.17.0".freeze
 end

data/lib/light-service.rb

@@ -13,6 +13,7 @@ require 'light-service/organizer/with_reducer'
 require 'light-service/organizer/with_reducer_log_decorator'
 require 'light-service/organizer/with_reducer_factory'
 require 'light-service/organizer/reduce_if'
+require 'light-service/organizer/reduce_if_else'
 require 'light-service/organizer/reduce_until'
 require 'light-service/organizer/iterate'
 require 'light-service/organizer/execute'

data/spec/acceptance/around_each_spec.rb

@@ -16,4 +16,19 @@ describe 'Executing arbitrary code around each action' do
       }]
     )
   end
+
+  it 'logs data with nested actions' do
+    context = { :number => 1, :logger => TestDoubles::TestLogger.new }
+
+    result = TestDoubles::AroundEachWithReduceIfOrganizer.call(context)
+
+    expect(result.fetch(:number)).to eq(7)
+    expect(result[:logger].logs).to eq(
+      [
+        { :action => TestDoubles::AddsOneAction, :before => 1, :after => 2 },
+        { :action => TestDoubles::AddsTwoAction, :before => 2, :after => 4 },
+        { :action => TestDoubles::AddsThreeAction, :before => 4, :after => 7 }
+      ]
+    )
+  end
 end

data/spec/acceptance/log_from_organizer_spec.rb

@@ -59,7 +59,7 @@ describe "Logs from organizer" do
       expect(log_message).to include(organizer_log_message)
     end
 
-    it "lists the keys in contect after the actions are executed" do
+    it "lists the keys in context after the actions are executed" do
       organizer_log_message = "[LightService] -     keys in context: " \
                               ":tea, :milk, :coffee, :milk_tea, :latte"
       expect(log_message).to include(organizer_log_message)

data/spec/acceptance/organizer/reduce_if_else_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+require 'test_doubles'
+
+RSpec.describe LightService::Organizer do
+  class TestReduceIfElse
+    extend LightService::Organizer
+
+    def self.call(context)
+      with(context).reduce(actions)
+    end
+
+    def self.actions
+      [
+        TestDoubles::AddsOneAction,
+        reduce_if_else(
+          ->(ctx) { ctx.number == 1 },
+          [TestDoubles::AddsOneAction],
+          [TestDoubles::AddsTwoAction]
+        )
+      ]
+    end
+  end
+
+  let(:empty_context) { LightService::Context.make }
+
+  it 'reduces the if_steps if the condition is true' do
+    result = TestReduceIfElse.call(:number => 0)
+
+    expect(result).to be_success
+    expect(result[:number]).to eq(2)
+  end
+
+  it 'reduces the else_steps if the condition is false' do
+    result = TestReduceIfElse.call(:number => 2)
+
+    expect(result).to be_success
+    expect(result[:number]).to eq(5)
+  end
+
+  it 'will not reduce over a failed context' do
+    empty_context.fail!('Something bad happened')
+
+    result = TestReduceIfElse.call(empty_context)
+
+    expect(result).to be_failure
+  end
+
+  it 'does not reduce over a skipped context' do
+    empty_context.skip_remaining!('No more needed')
+
+    result = TestReduceIfElse.call(empty_context)
+    expect(result).to be_success
+  end
+
+  it "knows that it's being conditionally reduced from within an organizer" do
+    result = TestReduceIfElse.call(:number => 2)
+
+    expect(result.organized_by).to eq TestReduceIfElse
+  end
+end

data/spec/action_optional_expected_keys_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+require 'test_doubles'
+
+describe ":expects macro using defaults" do
+  context "when all expected keys are supplied" do
+    it "is expected to ignore default values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :second_number => 5,
+        :third_number => 7
+      )
+
+      expect(outcome.total).to eq 15
+    end
+  end
+
+  context "when defaults are supplied" do
+    it "is expected to use static values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :second_number => 7
+      )
+
+      expect(outcome.total).to eq 20
+    end
+
+    it "is expected to use dynamic values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :third_number => 5
+      )
+
+      expect(outcome.total).to eq 18
+    end
+
+    it "is expected to process defaults in their defined order" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :third_number => 5,
+        :first_number => 3
+      )
+
+      expect(outcome.total).to eq 18
+    end
+
+    it "is expected to use all defaults if required" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3
+      )
+
+      expect(outcome.total).to eq 23
+    end
+  end
+
+  context "when used within an organizer" do
+    it "is expected to process required defaults" do
+      outcome = TestDoubles::OrganizerWithActionsUsingDefaults.call
+
+      expect(outcome.total).to eq 20
+    end
+  end
+
+  context "when defaults are misconfigured" do
+    it "is expected to raise an exception" do
+      expect do
+        # Needs to be specified in the block
+        # as error is raised at define time
+        class AddsNumbersWithIncorrectDefaults
+          extend LightService::Action
+
+          expects  :first,  :default => 10 # This one is fine. Other two arent
+          expects  :second, :defalut => ->(ctx) { ctx[:first] + 7 }
+          expects  :third,  :deafult => 10
+          promises :total
+
+          executed do |ctx|
+            ctx.total = ctx.first + ctx.second + ctx.third
+          end
+        end
+      end.to raise_error(LightService::UnusableExpectKeyDefaultError)
+    end
+  end
+end

data/spec/test_doubles.rb

@@ -74,6 +74,16 @@ module TestDoubles
     end
   end
 
+  class AroundEachWithReduceIfOrganizer
+    extend LightService::Organizer
+
+    def self.call(action_arguments)
+      with(action_arguments)
+        .around_each(AroundEachLoggerHandler)
+        .reduce(ReduceIfOrganizer.actions)
+    end
+  end
+
   class AddsTwoActionWithFetch
     extend LightService::Action
 
@@ -566,6 +576,33 @@ module TestDoubles
     end
   end
 
+  class AddsNumbersWithOptionalDefaults
+    extend LightService::Action
+
+    expects  :first_number
+    expects  :second_number, :default => ->(ctx) { ctx[:first_number] + 7 }
+    expects  :third_number,  :default => 10
+    promises :total
+
+    executed do |ctx|
+      ctx.total = ctx.first_number + ctx.second_number + ctx.third_number
+    end
+  end
+
+  class OrganizerWithActionsUsingDefaults
+    extend LightService::Organizer
+    def self.call
+      with(:first_number => 1, :number => 1).reduce(actions)
+    end
+
+    def self.actions
+      [
+        AddsNumbersWithOptionalDefaults,
+        AddToTotalAction
+      ]
+    end
+  end
+
   class AnOrganizerThatAddsToContext
     extend LightService::Organizer
     def self.call

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.17.0
 platform: ruby
 authors:
 - Attila Domokos
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-05 00:00:00.000000000 Z
+date: 2021-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -190,6 +190,7 @@ files:
 - lib/light-service/organizer/execute.rb
 - lib/light-service/organizer/iterate.rb
 - lib/light-service/organizer/reduce_if.rb
+- lib/light-service/organizer/reduce_if_else.rb
 - lib/light-service/organizer/reduce_until.rb
 - lib/light-service/organizer/scoped_reducable.rb
 - lib/light-service/organizer/verify_call_method_exists.rb
@@ -229,6 +230,7 @@ files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
@@ -237,6 +239,7 @@ files:
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
+- spec/action_optional_expected_keys_spec.rb
 - spec/action_promised_keys_spec.rb
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb
@@ -270,7 +273,7 @@ homepage: https://github.com/adomokos/light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -285,8 +288,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity
 test_files:
@@ -314,6 +317,7 @@ test_files:
 - spec/acceptance/organizer/execute_spec.rb
 - spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
@@ -322,6 +326,7 @@ test_files:
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
+- spec/action_optional_expected_keys_spec.rb
 - spec/action_promised_keys_spec.rb
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb