light-service 0.15.0 → 0.18.0

data/spec/action_optional_expected_keys_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+require 'test_doubles'
+
+describe ":expects macro using defaults" do
+  context "when all expected keys are supplied" do
+    it "is expected to ignore default values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :second_number => 5,
+        :third_number => 7
+      )
+
+      expect(outcome.total).to eq 15
+    end
+  end
+
+  context "when defaults are supplied" do
+    it "is expected to use static values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :second_number => 7
+      )
+
+      expect(outcome.total).to eq 20
+    end
+
+    it "is expected to use dynamic values" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3,
+        :third_number => 5
+      )
+
+      expect(outcome.total).to eq 18
+    end
+
+    it "is expected to process defaults in their defined order" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :third_number => 5,
+        :first_number => 3
+      )
+
+      expect(outcome.total).to eq 18
+    end
+
+    it "is expected to use all defaults if required" do
+      outcome = TestDoubles::AddsNumbersWithOptionalDefaults.execute(
+        :first_number => 3
+      )
+
+      expect(outcome.total).to eq 23
+    end
+  end
+
+  context "when used within an organizer" do
+    it "is expected to process required defaults" do
+      outcome = TestDoubles::OrganizerWithActionsUsingDefaults.call
+
+      expect(outcome.total).to eq 20
+    end
+  end
+
+  context "when defaults are misconfigured" do
+    it "is expected to raise an exception" do
+      expect do
+        # Needs to be specified in the block
+        # as error is raised at define time
+        class AddsNumbersWithIncorrectDefaults
+          extend LightService::Action
+
+          expects  :first,  :default => 10 # This one is fine. Other two arent
+          expects  :second, :defalut => ->(ctx) { ctx[:first] + 7 }
+          expects  :third,  :deafult => 10
+          promises :total
+
+          executed do |ctx|
+            ctx.total = ctx.first + ctx.second + ctx.third
+          end
+        end
+      end.to raise_error(LightService::UnusableExpectKeyDefaultError)
+    end
+  end
+end

data/spec/context/inspect_spec.rb

@@ -13,13 +13,7 @@ RSpec.describe LightService::Context do
   describe '#inspect' do
     it 'inspects the hash with all the fields' do
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: true, message: '', error_code: nil, skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -28,13 +22,8 @@ RSpec.describe LightService::Context do
       context.fail!('There was an error')
 
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: false, ' \
-        + 'message: \'There was an error\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: false, message: 'There was an error', error_code: nil, " \
+        "skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -43,13 +32,8 @@ RSpec.describe LightService::Context do
       context.skip_remaining!('No need to process')
 
       inspected_context =
-        'LightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'No need to process\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: true, ' \
-        + 'aliases: {}' \
-        + ')'
+        "LightService::Context({}, success: true, message: 'No need to process', error_code: nil, " \
+        "skip_remaining: true, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end

data/spec/context_spec.rb

@@ -167,7 +167,7 @@ RSpec.describe LightService::Context do
   end
 
   it "allows a default block value for #fetch" do
-    expect(context.fetch(:madeup) { :default }).to eq(:default)
+    expect(context.fetch(:madeup, :default)).to eq(:default)
   end
 
   context "when aliases are included via .make" do

data/spec/lib/generators/action_generator_advanced_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/action_generator.rb'
+require_relative '../../../lib/generators/light_service/action_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::ActionGenerator, :type => :generator do

data/spec/lib/generators/action_generator_simple_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/action_generator.rb'
+require_relative '../../../lib/generators/light_service/action_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::ActionGenerator, :type => :generator do

data/spec/lib/generators/organizer_generator_advanced_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/organizer_generator.rb'
+require_relative '../../../lib/generators/light_service/organizer_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::OrganizerGenerator, :type => :generator do

data/spec/lib/generators/organizer_generator_simple_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-require_relative '../../../lib/generators/light_service/organizer_generator.rb'
+require_relative '../../../lib/generators/light_service/organizer_generator'
 require_relative './full_generator_test_blobs'
 
 describe LightService::Generators::OrganizerGenerator, :type => :generator do

data/spec/sample/calculates_tax_spec.rb

@@ -10,7 +10,6 @@ describe CalculatesTax do
 
   it "calls the actions in order" do
     allow(LightService::Context).to receive(:make)
-      .with(:order => order)
       .and_return(ctx)
 
     allow(LooksUpTaxPercentageAction).to receive(:execute)

data/spec/sample/looks_up_tax_percentage_action_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 require_relative 'tax/looks_up_tax_percentage_action'
 
-class TaxRange; end
+class TaxRange
+  extend LightService::Action
+end
 
 describe LooksUpTaxPercentageAction do
   let(:region) { double('region') }

data/spec/test_doubles.rb

@@ -45,6 +45,7 @@ module TestDoubles
 
   class TestLogger
     attr_accessor :logs
+
     def initialize
       @logs = []
     end
@@ -74,6 +75,16 @@ module TestDoubles
     end
   end
 
+  class AroundEachWithReduceIfOrganizer
+    extend LightService::Organizer
+
+    def self.call(action_arguments)
+      with(action_arguments)
+        .around_each(AroundEachLoggerHandler)
+        .reduce(ReduceIfOrganizer.actions)
+    end
+  end
+
   class AddsTwoActionWithFetch
     extend LightService::Action
 
@@ -83,8 +94,13 @@ module TestDoubles
     end
   end
 
-  class AnAction; end
-  class AnotherAction; end
+  class AnAction
+    extend LightService::Action
+  end
+
+  class AnotherAction
+    extend LightService::Action
+  end
 
   class AnOrganizer
     extend LightService::Organizer
@@ -166,9 +182,7 @@ module TestDoubles
     promises :latte
 
     executed do |context|
-      if context.milk == :very_hot
-        context.fail!("Can't make a latte from a milk that's very hot!")
-      end
+      context.fail!("Can't make a latte from a milk that's very hot!") if context.milk == :very_hot
 
       if context.milk == :super_hot
         error_message = "Can't make a latte from a milk that's super hot!"
@@ -478,7 +492,9 @@ module TestDoubles
   class NullAction
     extend LightService::Action
 
+    # rubocop:disable Lint/EmptyBlock
     executed { |_ctx| }
+    # rubocop:enable Lint/EmptyBlock
   end
 
   class TestIterate
@@ -566,6 +582,33 @@ module TestDoubles
     end
   end
 
+  class AddsNumbersWithOptionalDefaults
+    extend LightService::Action
+
+    expects  :first_number
+    expects  :second_number, :default => ->(ctx) { ctx[:first_number] + 7 }
+    expects  :third_number,  :default => 10
+    promises :total
+
+    executed do |ctx|
+      ctx.total = ctx.first_number + ctx.second_number + ctx.third_number
+    end
+  end
+
+  class OrganizerWithActionsUsingDefaults
+    extend LightService::Organizer
+    def self.call
+      with(:first_number => 1, :number => 1).reduce(actions)
+    end
+
+    def self.actions
+      [
+        AddsNumbersWithOptionalDefaults,
+        AddToTotalAction
+      ]
+    end
+  end
+
   class AnOrganizerThatAddsToContext
     extend LightService::Organizer
     def self.call

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Attila Domokos
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-28 00:00:00.000000000 Z
+date: 2022-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: generator_spec
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.0
+        version: 1.26.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -157,6 +157,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/project-build.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -168,7 +169,6 @@ files:
 - README.md
 - RELEASES.md
 - Rakefile
-- gemfiles/activesupport_4.gemfile
 - gemfiles/activesupport_5.gemfile
 - gemfiles/activesupport_6.gemfile
 - lib/generators/light_service/action_generator.rb
@@ -189,7 +189,9 @@ files:
 - lib/light-service/organizer.rb
 - lib/light-service/organizer/execute.rb
 - lib/light-service/organizer/iterate.rb
+- lib/light-service/organizer/reduce_case.rb
 - lib/light-service/organizer/reduce_if.rb
+- lib/light-service/organizer/reduce_if_else.rb
 - lib/light-service/organizer/reduce_until.rb
 - lib/light-service/organizer/scoped_reducable.rb
 - lib/light-service/organizer/verify_call_method_exists.rb
@@ -203,7 +205,6 @@ files:
 - light-service.gemspec
 - resources/fail_actions.png
 - resources/light-service.png
-- resources/orchestrators_deprecated.svg
 - resources/organizer_and_actions.png
 - resources/skip_actions.png
 - spec/acceptance/add_numbers_spec.rb
@@ -228,7 +229,10 @@ files:
 - spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
 - spec/acceptance/organizer/context_failure_and_skipping_spec.rb
 - spec/acceptance/organizer/execute_spec.rb
+- spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
+- spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
@@ -237,6 +241,7 @@ files:
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
+- spec/action_optional_expected_keys_spec.rb
 - spec/action_promised_keys_spec.rb
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb
@@ -270,7 +275,7 @@ homepage: https://github.com/adomokos/light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -278,15 +283,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.3.12
+signing_key:
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity
 test_files:
@@ -312,7 +317,10 @@ test_files:
 - spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
 - spec/acceptance/organizer/context_failure_and_skipping_spec.rb
 - spec/acceptance/organizer/execute_spec.rb
+- spec/acceptance/organizer/execute_with_add_to_context_spec.rb
 - spec/acceptance/organizer/iterate_spec.rb
+- spec/acceptance/organizer/reduce_case_spec.rb
+- spec/acceptance/organizer/reduce_if_else_spec.rb
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
@@ -321,6 +329,7 @@ test_files:
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
+- spec/action_optional_expected_keys_spec.rb
 - spec/action_promised_keys_spec.rb
 - spec/action_spec.rb
 - spec/context/inspect_spec.rb

data/gemfiles/activesupport_4.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 4.0"
-
-gemspec :path => "../"

data/resources/orchestrators_deprecated.svg

@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<svg version="1.1" 
-     xmlns="http://www.w3.org/2000/svg"
-     xmlns:xlink="http://www.w3.org/1999/xlink"
-     width="350" height="20"
->
-  <text font-size="20" x="0" y="20" font-family="Verdana">
-    <tspan fill="red">Orchestrators are DEPRECATED!</tspan>
-  </text>
-</svg>