light-service 0.0.11 → 0.0.12

data/lib/light-service/context.rb

@@ -10,10 +10,12 @@ module LightService
     def initialize(context={}, outcome=::LightService::Outcomes::SUCCESS, message='')
       @outcome, @message = outcome, message
       context.to_hash.each {|k,v| self[k] = v}
+      self
     end
 
     def self.make(context={})
-      Context.new(context, ::LightService::Outcomes::SUCCESS, '')
+      return context if context.is_a?(Context)
+      self.new(context, ::LightService::Outcomes::SUCCESS, '')
     end
 
     def add_to_context(values)

data/lib/light-service/organizer.rb

@@ -15,7 +15,13 @@ module LightService
       self
     end
 
-    def reduce(actions=[])
+    def reduce(*actions)
+      raise "No action(s) were provided" if actions.empty?
+
+      if actions.is_a? Array
+        actions.flatten!
+      end
+
       actions.reduce(@context) { |context, action| action.execute(context) }
     end
   end

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.0.11"
+  VERSION = "0.0.12"
 end

data/light-service.gemspec

@@ -7,6 +7,7 @@ Gem::Specification.new do |gem|
   gem.description   = %q{A service skeleton with an emphasis on simplicity}
   gem.summary       = %q{A service skeleton with an emphasis on simplicity}
   gem.homepage      = ""
+  gem.license       = "MIT"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

data/spec/context_spec.rb

@@ -6,24 +6,27 @@ module LightService
 
     it "initializes the object with default arguments" do
       service_result = Context.new({test: 1})
-      service_result.should be_success
-      service_result.message.should eq ""
-      service_result[:test].should eq 1
+
+      expect(service_result).to be_success
+      expect(service_result.message).to eq ''
+      expect(service_result[:test]).to eq 1
     end
 
     it "initializes the object with the context" do
-      service_result = Context.new.tap { |o| o.add_to_context({:test => 1})}
-      service_result.should be_success
-      service_result.message.should eq ""
-      service_result[:test].should eq 1
+      service_result = Context.new.tap { |o| o.add_to_context({test: 1})}
+
+      expect(service_result).to be_success
+      expect(service_result.message).to eq ''
+      expect(service_result[:test]).to eq 1
     end
 
     describe ".make" do
       it "initializes the object with make" do
-        service_result = Context.make({:test => 1})
-        service_result.should be_success
-        service_result.message.should eq ""
-        service_result[:test].should eq 1
+        service_result = Context.make({test: 1})
+
+        expect(service_result).to be_success
+        expect(service_result.message).to eq ""
+        expect(service_result[:test]).to eq 1
       end
 
       context "when passing valid parameters" do
@@ -45,6 +48,15 @@ module LightService
         let(:invalid_params) { [] }
         it { should raise_error(NoMethodError) }
       end
+
+      context "data is a context" do
+        let(:original_context) { Context.new }
+
+        it "returns the same context object" do
+          new_context = Context.make(original_context)
+          expect(new_context.object_id).to eq(original_context.object_id)
+        end
+      end
     end
 
     describe "#to_hash" do
@@ -59,31 +71,39 @@ module LightService
     end
 
     it "allows to set success" do
-      subject.set_success!("the success")
-      subject.should be_success
-      subject.message.should == "the success"
-    end
+      subject.set_success!('the success')
 
-    specify "evaluates failure?" do
-      subject.set_success!("the success")
-      subject.should_not be_failure
+      expect(subject).to be_success
+      expect(subject).not_to be_failure
+      expect(subject.message) == 'the success'
     end
 
     it "allows to set failure" do
-      subject.set_failure!("the failure")
-      subject.should_not be_success
-      subject.message.should == "the failure"
+      subject.set_failure!('the failure')
+
+      expect(subject).not_to be_success
+      expect(subject).to be_failure
+      expect(subject.message).to eq('the failure')
+    end
+
+    it "allows to set skip_all" do
+      subject.skip_all!('the reason to skip')
+
+      expect(subject).to be_skip_all
+      expect(subject).to be_success
+      expect(subject).not_to be_failure
+      expect(subject.message).to eq('the reason to skip')
     end
 
     it "lets setting a group of context values" do
-      subject.to_hash.should include(:test => 1)
+      subject.to_hash.should include(test: 1)
       subject.to_hash.keys.length.should == 1
 
-      subject.add_to_context(:test => 1, :two => 2)
+      subject.add_to_context(test: 1, two: 2)
 
-      subject.to_hash.keys.length.should == 2
-      subject.to_hash.should include(:test => 1)
-      subject.to_hash.should include(:two => 2)
+      expect(subject.to_hash.keys.length).to eq(2)
+      expect(subject.to_hash).to include(test: 1)
+      expect(subject.to_hash).to include(two: 2)
     end
   end
 

data/spec/organizer_spec.rb

@@ -2,21 +2,27 @@ require 'spec_helper'
 
 describe LightService::Organizer do
   class AnAction; end
+  class AnotherAction; end
 
   class AnOrganizer
     include LightService::Organizer
 
     def self.some_method(user)
-      with(user: user).reduce [AnAction]
+      with(user: user).reduce([AnAction, AnotherAction])
     end
 
     def self.some_method_with(user)
-      context = LightService::Context.new(user: user)
-      with(context).reduce [AnAction]
+      context = LightService::Context.make(user: user)
+      with(context).reduce(AnAction, AnotherAction)
+    end
+
+    def self.some_method_with_no_actions(user)
+      context = LightService::Context.make(user: user)
+      with(context).reduce
     end
   end
 
-  let!(:context) { ::LightService::Context.new(user: user) }
+  let(:context) { ::LightService::Context.make(user: user) }
   let(:user) { double(:user) }
 
   context "when #with is called with hash" do
@@ -24,11 +30,37 @@ describe LightService::Organizer do
       AnAction.should_receive(:execute) \
               .with(context) \
               .and_return context
+      AnotherAction.should_receive(:execute) \
+              .with(context) \
+              .and_return context
     end
+
     it "creates a Context" do
-      LightService::Context.should_receive(:make).and_return context
+      result = AnOrganizer.some_method(user)
+      expect(result).to eq(context)
+    end
+  end
+
+  context "when #with is called with Context" do
+    before do
+      AnAction.should_receive(:execute) \
+              .with(context) \
+              .and_return context
+      AnotherAction.should_receive(:execute) \
+              .with(context) \
+              .and_return context
+    end
+
+    it "creates a Context" do
+      result = AnOrganizer.some_method_with(user)
+      expect(result).to eq(context)
+    end
+  end
 
-      AnOrganizer.some_method(user)
+  context "when no Actions are specified" do
+    it "throws a Runtime error" do
+      expect { AnOrganizer.some_method_with_no_actions(user) }.to \
+              raise_error RuntimeError, "No action(s) were provided"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-27 00:00:00.000000000 Z
+date: 2013-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -95,7 +95,8 @@ files:
 - spec/sample/tax/provides_free_shipping_action.rb
 - spec/spec_helper.rb
 homepage: ''
-licenses: []
+licenses:
+- MIT
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -106,18 +107,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -863764600829619710
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -863764600829619710
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23