lifen 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06e6dfcf106062c1fb84355a92286dd8a150adea
-  data.tar.gz: 6ecef6ecc87eeceb42e1a44e693ec061ca7109ac
+  metadata.gz: 5c313933ddbf8bc22bfb69240a8447044cb03fd4
+  data.tar.gz: 3ec79fe55b174797095f8bda5a01a8df52e5272f
 SHA512:
-  metadata.gz: a57cb90c9249979d227e2b9a704572609022a280b37f79901dc83382e2331b87c865c5ecd56333bbfa525bdd029e736bfb1f594a01d1af751e8f5a356e79183d
-  data.tar.gz: e7386eb960f36c4fb240c993b4c2251f58bc67ff2cc06d30ceb52576cce4bf0e50914a43b26a0a52709b548defe4876a6e630080e9d0e686615d47401d8441c0
+  metadata.gz: b0f42ad92dcdbfba42102b977b2b9437c5c8ba29da1549b75b513e0322d13f56586c2884a68d918d25772b95dc3f05c27cc8af6d4f88f9748d3a4357357dd39c
+  data.tar.gz: 73fadebb9cb5d67dff05d0587f49f3c3d44d04fac5f7410d40919760aedf67fa0c605d15e0a42da34ee33987b73df347d615f001a99be58acefbbc889e0a131a

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+1.5.1
+-----
+
+- Threadsafe strategy needed to included the persistence strategy
+
 1.5.0
 -----
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lifen (1.5.0)
+    lifen (1.5.1)
       faraday (>= 0.9)
       inflecto
       virtus (>= 1.0)

data/lib/lifen/token.rb

@@ -10,6 +10,9 @@ module Lifen
     attribute :value, String
     attribute :expires_at, Integer
 
+    attribute :load_from_db, Proc
+    attribute :save_to_db, Proc
+
     def to_s
       value
     end
@@ -44,12 +47,13 @@ module Lifen
     def refresh_once_if_needed
       @@lock.synchronize do
 
-        yield(self) if block_given?
+        load_from_db.call(self) if load_from_db.is_a? Proc
 
         return if active?
-
         refresh
 
+        save_to_db.call(self) if save_to_db.is_a? Proc
+
         raise Error, "Token can't be refreshed" if !active?
       end
     end

data/lib/lifen/version.rb

@@ -1,3 +1,3 @@
 module Lifen
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/spec/token_spec.rb

@@ -78,20 +78,47 @@ describe Lifen::Token do
 
   describe 'thread safe' do
 
-    let(:user)                    { Lifen::User.new }
+    class PersistedUser < Struct.new(:token_value, :token_expires_at) ; end
 
-    let(:expired_token)           { Lifen::Token.new(user: user, value: "valid_token", expires_at: Time.now.to_i - 60) }
-    let(:other_expired_token)     { Lifen::Token.new(user: user, value: "valid_token", expires_at: Time.now.to_i - 60) }
+    let(:user)                    { Lifen::User.new }
+    let(:persisted_user)          { PersistedUser.new("expired_token", Time.now.to_i - 60) }
+
+    let(:expired_token)           {
+      Lifen::Token.new( user: user,
+                        value: persisted_user.token_value,
+                        expires_at: persisted_user.token_expires_at,
+                        load_from_db: ->(token) {
+                          # Loading data from DB
+
+                          token.value = persisted_user.token_value
+                          token.expires_at = persisted_user.token_expires_at
+                        },
+                        save_to_db: ->(token) {
+                          # Loading data from DB
+
+                          persisted_user.token_value = token.value
+                          persisted_user.token_expires_at = token.expires_at
+                        }
+                      )           }
+
+
+    let(:other_expired_token)     {
+      Lifen::Token.new( user: user,
+                        value: persisted_user.token_value,
+                        expires_at: persisted_user.token_expires_at,
+                        load_from_db: ->(token) {
+                          # Loading data from DB
+
+                          token.value = persisted_user.token_value
+                          token.expires_at = persisted_user.token_expires_at
+                        }
+                      )            }
 
     before do
       allow(expired_token).to receive(:refresh) do
-        sleep 1
+        expired_token.value = "valid_token"
         expired_token.expires_at = Time.now.to_i + 60
       end
-
-      allow(other_expired_token).to receive(:refresh) do
-        sleep 1
-      end
     end
 
     it 'queues refresh calls' do
@@ -101,17 +128,13 @@ describe Lifen::Token do
       threads = []
 
       threads << Thread.new do
-        expired_token.refresh_once_if_needed do |token|
-          token.value = "expired_token"
-          token.expires_at = Time.now.to_i - 60
-        end
+        expired_token.refresh_once_if_needed
       end
 
+      sleep 0.1 # Making sure the mocked call is received first
+
       threads << Thread.new do
-        other_expired_token.refresh_once_if_needed do |token|
-          token.value = "valid_token"
-          token.expires_at = Time.now.to_i + 60
-        end
+        other_expired_token.refresh_once_if_needed
       end
 
       threads.map { |t| t.join } # waiting for all threads to finish

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lifen
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Etienne Depaulis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-11 00:00:00.000000000 Z
+date: 2017-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler