lifen-ruby-style 1.0.6 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20241f5f06c6ce3ee92e87f234e659542f0565687e1e7102a79f837226c912fc
-  data.tar.gz: 7e58e92ccb1990f69f7aa22dacf6cdba5b3e95de1768a2b7b0213be9b7df3c8d
+  metadata.gz: 3374ee51e9eee20e43a1c54a4241aebe4b20d66d2f490a8cfee3c76a8445321b
+  data.tar.gz: 83ae89fe92da78cfe5ae1c343b97de2410b5d852068c8e8c7af34b5179bef4b6
 SHA512:
-  metadata.gz: 4bbb9623066e0401253254f700006ea14d257f3aa3e0e2a2be563015d3a18a837f0844abb073558e2277825ddddaa46b9582caf107e26b85776faf10ae8d7f08
-  data.tar.gz: 5987a28429905604738cd997de2cd3e505069dba0bd26744bc25b7e6314dc25b80db503a92c28e95307418e5ce5995116abc0fb98bdb706e99014aca95394cba
+  metadata.gz: 8005cebbe5c14bd4921e6835a8ab0c4bad2ed59a88818108cc0143626c0bc299b892f39aaf57cadcadbbfd4508e56a98c6744625e14db6755ceda3de8ae417e5
+  data.tar.gz: 0f32bd0d3f114e7a09b1cb4f79070b80650f7718522b019cc460017d7a562d7585e4a8c6c7e43d2cf7e7387075e5508f2909159b3e3f48a895f06f1e8e511245

data/.overcommit.yml

@@ -16,37 +16,47 @@
 # Uncomment the following lines to make the configuration take effect.
 
 PreCommit:
+  RubocopDaemonStart:
+    enabled: true
+    command: ['bundle', 'exec', 'rubocop-daemon', 'start']
+    parallelize: false
+
   RuboCop:
     enabled: true
-    command: ["bundle", "exec", "rubocop"]
+    command: ['bundle', 'exec', 'rubocop-daemon', 'exec', '--', '--format=emacs', '--auto-correct']
+    required_executable: 'rubocop-daemon'
+    flags: []
+    install_command: 'gem install rubocop-daemon'
     problem_on_unmodified_line: ignore
 
   GoFmt:
     enabled: false
 
+  AuthorEmail:
+    enabled: false
+  AuthorName:
+    enabled: false
+  BrokenSymlinks:
+    enabled: false
+  CaseConflicts:
+    enabled: false
+  MergeConflicts:
+    enabled: false
+
 CommitMsg:
   CapitalizedSubject:
     enabled: false
 
+  EmptyMessage:
+    enabled: false
+
   SingleLineSubject:
-    enabled: true
+    enabled: false
     on_warn: fail
 
   TextWidth:
-    enabled: true
+    enabled: false
 
   TrailingPeriod:
-    enabled: true
+    enabled: false
     on_warn: fail
-#PreCommit:
-#  TrailingWhitespace:
-#    enabled: true
-#    exclude:
-#      - '**/db/structure.sql' # Ignore trailing whitespace in generated files
-#
-#PostCheckout:
-#  ALL: # Special hook name that customizes all hooks of this type
-#    quiet: true # Change all post-checkout hooks to only display output on failure
-#
-#  IndexTags:
-#    enabled: true # Generate a tags file with `ctags` each time HEAD changes

data/README.md

@@ -20,6 +20,7 @@
   - [Overcommit](#commandes-overcommit)
 - [Utilisation d'une version locale](#utilisation-dune-version-locale)
 - [Contributions](#contributions)
+- [Publier une nouvelle version](#publier-une-nouvelle-version)
 - [TODO](#todo)
 - [Archives](#archives)
 
@@ -288,11 +289,12 @@ $ bundle exec rubocop --fail-fast # inspect files in order of modification time
 Pour de la correction automatique :
 
 ```bash
-$ bundle exec rubocop -a                  # auto-correct offenses.
 $ bundle exec rubocop --safe              # run only safe cops.
-$ bundle exec rubocop --safe-auto-correct # run auto-correct only when it's safe.
+$ bundle exec rubocop --auto-correct      # run auto-correct only when it's safe.
+$ bundle exec rubocop --auto-correct-all  # run auto-correct (safe and unsafe).
 $ bundle exec rubocop --lint              # run only lint cops.
 $ bundle exec rubocop --fix-layout        # run only layout cops, with auto-correct on.
+$ bundle exec rubocop --auto-correct-all --only "Style/AccessModifierDeclarations,Style/Alias,Style/AndOr,Style/ArrayJoin" # run autocorrect on listed cops
 ```
 
 Liste des commandes disponibles :
@@ -368,15 +370,19 @@ Vous allez vouloir tester localement les modifications de règle de style que vo
 
 **ATTENTION : La configuration d'overcommit n'est pas liée automatiquement au projet, il faut la copier/coller dans le projet cible après avoir effectué des changements.**
 
+## Publier une nouvelle version
+
+Suivre les instructions du [guide de release](RELEASING.md).
+
 ## TODO
 
-[ ] Ajouter rubocop-daemon (arriver à faire une bonne intégration aux IDE)
-[ ] Ajouter le hook de pre-commit au CI
-[ ] Ajouter un hook de pre-push ?
-[ ] Ajouter `fasterer` si pertinent
-[ ] Ajouter `reek` si pertinent
-[ ] Ajouter `slim_lint` si pertinent
-[ ] Ajouter `scss` si pertinent
+- [ ] Ajouter rubocop-daemon (arriver à faire une bonne intégration aux IDE)
+- [ ] Ajouter le hook de pre-commit au CI
+- [ ] Ajouter un hook de pre-push ?
+- [ ] Ajouter `fasterer` si pertinent
+- [ ] Ajouter `reek` si pertinent
+- [ ] Ajouter `slim_lint` si pertinent
+- [ ] Ajouter `scss` si pertinent
 
 ## Archives
 

data/default_overcommit.yml

@@ -16,37 +16,47 @@
 # Uncomment the following lines to make the configuration take effect.
 
 PreCommit:
+  RubocopDaemonStart:
+    enabled: true
+    command: ['bundle', 'exec', 'rubocop-daemon', 'start']
+    parallelize: false
+
   RuboCop:
     enabled: true
-    command: ["bundle", "exec", "rubocop"]
+    command: ['bundle', 'exec', 'rubocop-daemon', 'exec', '--', '--format=emacs', '--auto-correct']
+    required_executable: 'rubocop-daemon'
+    flags: []
+    install_command: 'gem install rubocop-daemon'
     problem_on_unmodified_line: ignore
 
   GoFmt:
     enabled: false
 
+  AuthorEmail:
+    enabled: false
+  AuthorName:
+    enabled: false
+  BrokenSymlinks:
+    enabled: false
+  CaseConflicts:
+    enabled: false
+  MergeConflicts:
+    enabled: false
+
 CommitMsg:
   CapitalizedSubject:
     enabled: false
 
+  EmptyMessage:
+    enabled: false
+
   SingleLineSubject:
-    enabled: true
+    enabled: false
     on_warn: fail
 
   TextWidth:
-    enabled: true
+    enabled: false
 
   TrailingPeriod:
-    enabled: true
+    enabled: false
     on_warn: fail
-#PreCommit:
-#  TrailingWhitespace:
-#    enabled: true
-#    exclude:
-#      - '**/db/structure.sql' # Ignore trailing whitespace in generated files
-#
-#PostCheckout:
-#  ALL: # Special hook name that customizes all hooks of this type
-#    quiet: true # Change all post-checkout hooks to only display output on failure
-#
-#  IndexTags:
-#    enabled: true # Generate a tags file with `ctags` each time HEAD changes

data/default_rubocop.yml

@@ -5,6 +5,7 @@ require:
 
 AllCops:
   DisplayStyleGuide: true
+  NewCops: enable
   TargetRubyVersion: 2.5
   Exclude:
     - "test/**/*.rb"
@@ -16,70 +17,6 @@ AllCops:
     - "spec/rails_helper.rb"
     - "node_modules/**/*"
 
-# Waiting for default config
-Lint/RaiseException:
-  Enabled: true
-Lint/StructNewOverride:
-  Enabled: true
-Style/HashEachMethods:
-  Enabled: true
-Style/HashTransformKeys:
-  Enabled: true
-Style/HashTransformValues:
-  Enabled: true
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-Lint/DuplicateElsifCondition:
-  Enabled: true
-Lint/MixedRegexpCaptureTypes:
-  Enabled: true
-Style/AccessorGrouping:
-  Enabled: true
-Style/ArrayCoercion:
-  Enabled: true
-Style/BisectedAttrAccessor:
-  Enabled: true
-Style/CaseLikeIf:
-  Enabled: true
-Style/ExponentialNotation:
-  Enabled: true
-Style/HashAsLastArrayItem:
-  Enabled: true
-Style/HashLikeCase:
-  Enabled: true
-Style/RedundantAssignment:
-  Enabled: true
-Style/RedundantFetchBlock:
-  Enabled: true
-Style/RedundantFileExtensionInRequire:
-  Enabled: true
-Style/RedundantRegexpCharacterClass:
-  Enabled: true
-Style/RedundantRegexpEscape:
-  Enabled: true
-Style/SlicingWithRange:
-  Enabled: true
-Performance/AncestorsInclude:
-  Enabled: true
-Performance/BigDecimalWithNumericArgument:
-  Enabled: true
-Performance/RedundantSortBlock:
-  Enabled: true
-Performance/RedundantStringChars:
-  Enabled: true
-Performance/ReverseFirst:
-  Enabled: true
-Performance/SortReverse:
-  Enabled: true
-Performance/Squeeze:
-  Enabled: true
-Performance/StringInclude:
-  Enabled: true
-
 Layout/ArgumentAlignment:
   EnforcedStyle: with_fixed_indentation
 
@@ -108,7 +45,7 @@ Layout/IndentationConsistency:
   EnforcedStyle: indented_internal_methods
 
 Layout/LineLength:
-  Max: 120
+  Enabled: false
 
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
@@ -132,20 +69,22 @@ Metrics/CyclomaticComplexity:
   Enabled: false
 
 Metrics/MethodLength:
-  Max: 40
+  Enabled: false
 
 Metrics/ModuleLength:
   Max: 250
 
+Metrics/ParameterLists:
+  Enabled: false
+
 Metrics/PerceivedComplexity:
   Enabled: false
 
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
-RSpec/DescribeClass:
-  Exclude:
-    - spec/lib/tasks/deployment/**/*
+Naming/VariableNumber:
+  Enabled: false
 
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
@@ -153,16 +92,35 @@ Style/BlockDelimiters:
 Style/ClassAndModuleChildren:
   Enabled: false
 
+Style/ExplicitBlockArgument:
+  AutoCorrect: false
+
 Style/Documentation:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - spec/lib/tasks/deployment/**/*
+
 Style/IfUnlessModifier:
-  Enabled: true
-  AutoCorrect: false
+  Enabled: false
 
 Style/NumericLiterals:
   Strict: true
 
+Style/TrailingCommaInArguments:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+
 Style/RegexpLiteral:
   AllowInnerSlashes: true
 
@@ -181,16 +139,26 @@ Rails/DynamicFindBy:
 
 Rails/UnknownEnv:
   Environments:
-    - production
     - development
-    - test
+    - production
+    - review
     - staging
+    - test
 
 RSpec/AnyInstance:
   Enabled: false
 
+RSpec/DescribeClass:
+  Exclude:
+    - spec/lib/tasks/deployment/**/*
+
 RSpec/DescribedClass:
   EnforcedStyle: explicit
+  Exclude:
+    - spec/lib/tasks/deployment/**/*
+
+RSpec/EmptyExampleGroup:
+  Enabled: false
 
 RSpec/ExampleLength:
   Enabled: false
@@ -198,14 +166,21 @@ RSpec/ExampleLength:
 RSpec/HookArgument:
   EnforcedStyle: each
 
+RSpec/LeadingSubject:
+  Exclude:
+    - spec/support/pundit.rb
+
 RSpec/LetSetup:
   Enabled: false
 
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
-  Max: 5
+  Enabled: false
 
 RSpec/NotToNot:
   EnforcedStyle: to_not

data/lib/lifen/ruby_style/version.rb

@@ -3,7 +3,7 @@
 module Lifen
   module RubyStyle
 
-    VERSION = '1.0.6'
+    VERSION = '1.1.3'
 
   end
 end

data/lifen-ruby-style.gemspec

@@ -30,10 +30,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'overcommit'
-  spec.add_dependency 'rubocop', '0.88'
+  spec.add_dependency 'rubocop', '~> 1.5'
+  spec.add_dependency 'rubocop-daemon'
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.4'
-  spec.add_dependency 'rubocop-rspec', '~> 1.38'
+  spec.add_dependency 'rubocop-rspec', '~> 2.0'
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 10.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lifen-ruby-style
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.1.3
 platform: ruby
 authors:
 - Team Lifen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-16 00:00:00.000000000 Z
+date: 2020-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: overcommit
@@ -28,16 +28,30 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: rubocop-daemon
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -150,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Lifen style guides and shared style configs.