lifen-ruby-style 1.0.2 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8611124008c5537cb23d55f58dc2f6119cb43a5eb1bd073b0e938100a094e439
-  data.tar.gz: 997ac45632aaac79deed3031a7470b20d0146a9ff335bdcf2098b18165a89b9d
+  metadata.gz: a9ae91d8b6be61444ed549376d44e7f8e0b3ac8fe4c60b5e3ba80ce0c84d3d1b
+  data.tar.gz: 3368e3ef8bd97fab3df455249b1844fd4a688bbcb7e5057e0078fa18dd394181
 SHA512:
-  metadata.gz: 5e3a5f1659b0afd9f7f2a3c74215af21c6873d350a3cbd4508086a6e02039f1df9d22e0dffcc1f7d7ebebff27e5529392e291bbe7868dd9ecb27e753910a56ff
-  data.tar.gz: 2fe07fb3c0d99834984f4856fe9c7e1da37608cdea90325d464a1a78e0248078fb1a74250688709f18a6fd05d35953170fee25ef74627a9a5f74499921c982e0
+  metadata.gz: aefe6e1a1d0cabfea933a8fc8831d173e33f62a2b0512e87fbbe0b0b531d7f3d0369c623ca809ec3a9cf7878c9fbd213931c40bfdd3c83fc51732c1667d71e62
+  data.tar.gz: d6f6482c2ba5333667208e14dd9d0a395f01cd6d8aa97a2dc3c574989d795b34919b17754453089cbeeadf7d4171db1c05228726af631e6d519cdf1fa56d0f26

data/.overcommit.yml

@@ -19,6 +19,7 @@ PreCommit:
   RuboCop:
     enabled: true
     command: ["bundle", "exec", "rubocop"]
+    problem_on_unmodified_line: ignore
 
   GoFmt:
     enabled: false

data/README.md

@@ -61,7 +61,7 @@ $ echo '--force-exclusion' > .rubocop
 ### 3. Config Overcommit
 
 ```bash
-$ curl https://raw.githubusercontent.com/honestica/lifen-ruby-style/master/default_overcommit.yml > .overcommit_test.yml
+$ curl https://raw.githubusercontent.com/honestica/lifen-ruby-style/master/default_overcommit.yml > .overcommit.yml
 ```
 
 ### 4. Installer les dépendances
@@ -123,17 +123,20 @@ $ bundle exec overcommit --install
 - Paramétrage recommandé pour l'auto-formatting :
 
   ```json
+    "editor.formatOnPaste": true,  // global auto-format code when pasting
+    "editor.formatOnSave": true,   // global auto-format code when saving
     "[ruby]": {
-      "editor.formatOnPaste": true,       // auto-format ruby code when pasting
-      "editor.formatOnSave": true         // auto-format ruby code when saving
+      "editor.formatOnSave": false // disable auto-format on save only for ruby files
     },
   ```
 
   ou
 
   ```json
-    "editor.formatOnPaste": true,  // auto-format code when pasting
-    "editor.formatOnSave": true,   // auto-format code when saving
+    "[ruby]": {
+      "editor.formatOnPaste": true,       // auto-format ruby code when pasting
+      "editor.formatOnSave": false         // auto-format ruby code when saving
+    },
   ```
 
 ### 3. Bonus - Autres extensions utiles :
@@ -267,6 +270,11 @@ https://github.com/dense-analysis/ale
   - Si je veux bypasser les hooks (déconseillé) : `OVERCOMMIT_DISABLE=1 git commit ...`
 - Je push (pas de hooks de pre-push paramétrés pour l'instant)
 
+Attention :
+
+- si vous faites "Ctrl+C" pendant qu'un hook overcommit tourne, overcommit fait un `git stash save` et vous pouvez retrouver ce qui a disparu avec `git stast list / show / pop`
+- dans le même registre, ne faites pas de `watch .git/hooks/pre-commit`, si vous éditez vos fichiers dans une autre fenêtre, overcommit va régulièrement stasher vos modifs, et vous allez tourner en rond à éditer des fichiers qui changent sous vos pieds.
+
 ### Commandes Rubocop
 
 Pour de la vérification :
@@ -362,6 +370,7 @@ Vous allez vouloir tester localement les modifications de règle de style que vo
 
 ## TODO
 
+[ ] Ajouter rubocop-daemon (arriver à faire une bonne intégration aux IDE)
 [ ] Ajouter le hook de pre-commit au CI
 [ ] Ajouter un hook de pre-push ?
 [ ] Ajouter `fasterer` si pertinent

data/default_overcommit.yml

@@ -19,6 +19,7 @@ PreCommit:
   RuboCop:
     enabled: true
     command: ["bundle", "exec", "rubocop"]
+    problem_on_unmodified_line: ignore
 
   GoFmt:
     enabled: false

data/default_rubocop.yml

@@ -5,6 +5,7 @@ require:
 
 AllCops:
   DisplayStyleGuide: true
+  NewCops: enable
   TargetRubyVersion: 2.5
   Exclude:
     - "test/**/*.rb"
@@ -16,14 +17,6 @@ AllCops:
     - "spec/rails_helper.rb"
     - "node_modules/**/*"
 
-# Waiting for default config
-Style/HashEachMethods:
-  Enabled: true
-Style/HashTransformKeys:
-  Enabled: true
-Style/HashTransformValues:
-  Enabled: true
-
 Layout/ArgumentAlignment:
   EnforcedStyle: with_fixed_indentation
 
@@ -87,6 +80,13 @@ Metrics/PerceivedComplexity:
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
+RSpec/DescribeClass:
+  Exclude:
+    - spec/lib/tasks/deployment/**/*
+
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining
+
 Style/ClassAndModuleChildren:
   Enabled: false
 
@@ -116,6 +116,13 @@ Rails/DynamicFindBy:
   Enabled: true
   AutoCorrect: false
 
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - development
+    - test
+    - staging
+
 RSpec/AnyInstance:
   Enabled: false
 
@@ -128,11 +135,14 @@ RSpec/ExampleLength:
 RSpec/HookArgument:
   EnforcedStyle: each
 
+RSpec/LetSetup:
+  Enabled: false
+
 RSpec/MultipleExpectations:
   Enabled: false
 
 RSpec/NestedGroups:
-  Max: 4
+  Max: 5
 
 RSpec/NotToNot:
   EnforcedStyle: to_not

data/lib/lifen/ruby_style/version.rb

@@ -3,7 +3,7 @@
 module Lifen
   module RubyStyle
 
-    VERSION = '1.0.2'
+    VERSION = '1.0.7'
 
   end
 end

data/lifen-ruby-style.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'overcommit'
-  spec.add_dependency 'rubocop', '~> 0.8'
+  spec.add_dependency 'rubocop', '~> 0.88'
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.4'
   spec.add_dependency 'rubocop-rspec', '~> 1.38'

data/style_guide.md

@@ -619,6 +619,12 @@ before(:each) do
 end
 ```
 
+#### LetSetup
+
+```yaml
+Enabled: false //  does not check unreferenced let! calls being used for test setup
+```
+
 #### MultipleExpectations
 
 ```yaml
@@ -651,6 +657,22 @@ end
 Enabled: false // example groups can have the same description string.
 ```
 
+#### Block Delimiters
+
+##### EnforcedStyle: braces_for_chaining
+
+```ruby
+# bad
+words.each do |word|
+  word.flip.flop
+end.join("-")
+
+# good
+words.each { |word|
+  word.flip.flop
+}.join("-")
+```
+
 </details>
 
 ### Default rules

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lifen-ruby-style
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.7
 platform: ruby
 authors:
 - Team Lifen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-09 00:00:00.000000000 Z
+date: 2020-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: overcommit
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.88'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.88'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement