licensee 9.12.0 → 9.14.1

data/spec/licensee/matchers/cabal_matcher_spec.rb

@@ -1,18 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Cabal do
+  subject { described_class.new(file) }
+
   let(:content) { 'license: mit' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:no_license) { Licensee::License.find('no-license') }
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {
@@ -31,6 +32,7 @@ RSpec.describe Licensee::Matchers::Cabal do
 
   context 'non-standard license format' do
     let(:content) { "license: #{cabal_license}" }
+
     context 'GPL-3' do
       let(:cabal_license) { 'GPL-3' }
 

data/spec/licensee/matchers/cargo_matcher_spec.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Cargo do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { 'license = "MIT"' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'Cargo.toml') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   it 'matches' do

data/spec/licensee/matchers/copyright_matcher_spec.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Copyright do
+  subject { described_class.new(file) }
+
   let(:content) { 'Copyright 2015 Ben Balter'.dup }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:no_license) { Licensee::License.find('no-license') }
 
-  subject { described_class.new(file) }
-
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
@@ -17,7 +17,7 @@ RSpec.describe Licensee::Matchers::Copyright do
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   {

data/spec/licensee/matchers/cran_matcher_spec.rb

@@ -1,12 +1,13 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Cran do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:gpl2) { Licensee::License.find('gpl-2.0') }
   let(:gpl3) { Licensee::License.find('gpl-3.0') }
   let(:content) { "License: MIT + file LICENSE\nPackage: test" }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'DESCRIPTION') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -17,7 +18,7 @@ RSpec.describe Licensee::Matchers::Cran do
   end
 
   it 'is confident' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/dice_matcher_spec.rb

@@ -1,14 +1,16 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Dice do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:gpl) { Licensee::License.find('gpl-3.0') }
   let(:agpl) { Licensee::License.find('agpl-3.0') }
+  let(:lgpl) { Licensee::License.find('lgpl-2.1') }
   let(:cc_by) { Licensee::License.find('cc-by-4.0') }
   let(:cc_by_sa) { Licensee::License.find('cc-by-sa-4.0') }
   let(:content) { sub_copyright_info(gpl) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -18,44 +20,36 @@ RSpec.describe Licensee::Matchers::Dice do
     expect(subject.match).to eql(gpl)
   end
 
-  it 'builds a list of potential licenses' do
-    expect(subject.potential_matches).to eql([agpl, gpl])
-  end
-
   it 'sorts licenses by similarity' do
     expect(subject.matches_by_similarity[0]).to eql([gpl, 100.0])
-    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.67966280295047])
-  end
-
-  it 'returns a list of licenses above the confidence threshold' do
-    expect(subject.matches_by_similarity[0]).to eql([gpl, 100.0])
-    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.67966280295047])
+    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.28301886792453])
+    expect(subject.matches_by_similarity[2]).to eql([lgpl, 39.33253873659118])
   end
 
   it 'returns the match confidence' do
-    expect(subject.confidence).to eql(100.0)
+    expect(subject.confidence).to be(100.0)
   end
 
   context 'without a match' do
     let(:content) { 'Not really a license' }
 
     it "doesn't match" do
-      expect(subject.match).to eql(nil)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
   context 'stacked licenses' do
     let(:content) do
-      sub_copyright_info(mit) + "\n\n" + sub_copyright_info(gpl)
+      "#{sub_copyright_info(mit)}\n\n#{sub_copyright_info(gpl)}"
     end
 
     it "doesn't match" do
-      expect(content).to_not be_detected_as(gpl)
-      expect(subject.match).to eql(nil)
+      expect(content).not_to be_detected_as(gpl)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
@@ -74,11 +68,11 @@ RSpec.describe Licensee::Matchers::Dice do
       let(:content) { File.read(license_path) }
 
       it "doesn't match" do
-        expect(content).to_not be_detected_as(cc_by)
-        expect(content).to_not be_detected_as(cc_by_sa)
+        expect(content).not_to be_detected_as(cc_by)
+        expect(content).not_to be_detected_as(cc_by_sa)
         expect(subject.match).to be_nil
         expect(subject.matches).to be_empty
-        expect(subject.confidence).to eql(0)
+        expect(subject.confidence).to be(0)
       end
     end
   end

data/spec/licensee/matchers/dist_zilla_matcher_spec.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::DistZilla do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { 'license = MIT' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'dist.ini') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   it 'matches' do

data/spec/licensee/matchers/exact_matcher_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Exact do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -15,7 +16,7 @@ RSpec.describe Licensee::Matchers::Exact do
   end
 
   it 'is confident' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   context 'with extra words added' do

data/spec/licensee/matchers/gemspec_matcher_spec.rb

@@ -1,19 +1,20 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Gemspec do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { "s.license = 'mit'" }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/matcher_spec.rb

@@ -1,27 +1,29 @@
 # frozen_string_literal: true
 
+class MatcherSpecFixture < Licensee::Matchers::Matcher
+  def confidence
+    0
+  end
+end
+
 RSpec.describe Licensee::Matchers::Matcher do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'returns its name' do
-    expect(subject.name).to eql(:matcher)
+    expect(subject.name).to be(:matcher)
   end
 
   context 'to_h' do
-    class MatcherSpecFixture < Licensee::Matchers::Matcher
-      def confidence
-        0
-      end
-    end
-
     subject { MatcherSpecFixture.new(file) }
+
     let(:hash) { subject.to_h }
     let(:expected) do
       {

data/spec/licensee/matchers/npm_bower_matcher_spec.rb

@@ -1,19 +1,20 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::NpmBower do
+  subject { described_class.new(file) }
+
   let(:content) { '"license": "mit"' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:other) { Licensee::License.find('other') }
-
-  subject { described_class.new(file) }
+  let(:no_license) { Licensee::License.find('no-license') }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {
@@ -56,4 +57,12 @@ RSpec.describe Licensee::Matchers::NpmBower do
       expect(subject.match).to eql(other)
     end
   end
+
+  context 'UNLICENSED' do
+    let(:content) { "'license': 'UNLICENSED'" }
+
+    it 'returns none' do
+      expect(subject.match).to eql(no_license)
+    end
+  end
 end

data/spec/licensee/matchers/nu_get_matcher_spec.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+RSpec.describe Licensee::Matchers::NuGet do
+  subject { described_class.new(file) }
+
+  let(:content) { '<license type="expression">mit</license>' }
+  let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'foo.nuspec') }
+  let(:mit) { Licensee::License.find('mit') }
+  let(:apache2) { Licensee::License.find('apache-2.0') }
+  let(:other) { Licensee::License.find('other') }
+
+  it 'matches' do
+    expect(subject.match).to eql(mit)
+  end
+
+  it 'has a confidence' do
+    expect(subject.confidence).to be(90)
+  end
+
+  {
+    'double quotes'      => '<license type="expression">mit</license>',
+    'single quotes'      => "<license type='expression'>mit</license>",
+    'whitespace'         => '<license  type = "expression" >mit</license >',
+    'leading whitespace' => ' <license type="expression">mit</license>'
+  }.each do |description, license_declaration|
+    context "with a #{description} license element" do
+      let(:content) { license_declaration }
+
+      it 'matches' do
+        expect(subject.match).to eql(mit)
+      end
+    end
+  end
+
+  context 'no license field' do
+    let(:content) { '<file>wrongelement</file>' }
+
+    it 'returns nil' do
+      expect(subject.match).to be_nil
+    end
+  end
+
+  context 'an unknown license' do
+    let(:content) { '<license type="expression">foo</license>' }
+
+    it 'returns other' do
+      expect(subject.match).to eql(other)
+    end
+  end
+
+  context 'a license expression' do
+    let(:content) { '<license type="expression">BSD-2-Clause OR MIT</license>' }
+
+    it 'returns other' do
+      expect(subject.match).to eql(other)
+    end
+  end
+
+  {
+    'nuget'            => '<licenseUrl>https://licenses.nuget.org/Apache-2.0</licenseUrl>',
+    'nuget (http)'     => '<licenseUrl>http://licenses.nuget.org/Apache-2.0</licenseUrl>',
+    'opensource'       => '<licenseUrl>https://opensource.org/licenses/Apache-2.0</licenseUrl>',
+    'opensource (www)' => '<licenseUrl>http://www.opensource.org/licenses/Apache-2.0</licenseUrl>',
+    'spdx'             => '<licenseUrl>https://spdx.org/licenses/Apache-2.0</licenseUrl>',
+    'spdx (www)'       => '<licenseUrl>http://www.spdx.org/licenses/Apache-2.0</licenseUrl>',
+    'spdx (html)'      => '<licenseUrl>https://spdx.org/licenses/Apache-2.0.html</licenseUrl>',
+    'spdx (txt)'       => '<licenseUrl>https://spdx.org/licenses/Apache-2.0.txt</licenseUrl>'
+  }.each do |description, license_declaration|
+    context "with a #{description} licenseUrl element containing SPDX" do
+      let(:content) { license_declaration }
+
+      it 'matches' do
+        expect(subject.match).to eql(apache2)
+      end
+    end
+  end
+
+  {
+    '2.0 (https)'    => '<licenseUrl>https://apache.org/licenses/LICENSE-2.0</licenseUrl>',
+    '2.0 (http/www)' => '<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>',
+    '2.0 (txt)'      => '<licenseUrl>https://apache.org/licenses/LICENSE-2.0.txt</licenseUrl>'
+  }.each do |description, license_declaration|
+    context "with an apache.org #{description} licenseUrl element" do
+      let(:content) { license_declaration }
+
+      it 'matches' do
+        expect(subject.match).to eql(apache2)
+      end
+    end
+  end
+end

data/spec/licensee/matchers/package_matcher_spec.rb

@@ -1,13 +1,15 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Package do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { '' }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
   let(:license_property) { 'mit' }
-  subject { described_class.new(file) }
+
   before do
     allow(subject).to receive(:license_property).and_return(license_property)
   end
@@ -17,7 +19,7 @@ RSpec.describe Licensee::Matchers::Package do
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   context 'with a nil license property' do