licensee 9.12.0 → 9.13.0

data/spec/licensee/matchers/dice_matcher_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Dice do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:gpl) { Licensee::License.find('gpl-3.0') }
   let(:agpl) { Licensee::License.find('agpl-3.0') }
@@ -8,7 +10,6 @@ RSpec.describe Licensee::Matchers::Dice do
   let(:cc_by_sa) { Licensee::License.find('cc-by-sa-4.0') }
   let(:content) { sub_copyright_info(gpl) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -33,16 +34,16 @@ RSpec.describe Licensee::Matchers::Dice do
   end
 
   it 'returns the match confidence' do
-    expect(subject.confidence).to eql(100.0)
+    expect(subject.confidence).to be(100.0)
   end
 
   context 'without a match' do
     let(:content) { 'Not really a license' }
 
     it "doesn't match" do
-      expect(subject.match).to eql(nil)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
@@ -52,10 +53,10 @@ RSpec.describe Licensee::Matchers::Dice do
     end
 
     it "doesn't match" do
-      expect(content).to_not be_detected_as(gpl)
-      expect(subject.match).to eql(nil)
+      expect(content).not_to be_detected_as(gpl)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
@@ -74,11 +75,11 @@ RSpec.describe Licensee::Matchers::Dice do
       let(:content) { File.read(license_path) }
 
       it "doesn't match" do
-        expect(content).to_not be_detected_as(cc_by)
-        expect(content).to_not be_detected_as(cc_by_sa)
+        expect(content).not_to be_detected_as(cc_by)
+        expect(content).not_to be_detected_as(cc_by_sa)
         expect(subject.match).to be_nil
         expect(subject.matches).to be_empty
-        expect(subject.confidence).to eql(0)
+        expect(subject.confidence).to be(0)
       end
     end
   end

data/spec/licensee/matchers/dist_zilla_matcher_spec.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::DistZilla do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { 'license = MIT' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'dist.ini') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   it 'matches' do

data/spec/licensee/matchers/exact_matcher_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Exact do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -15,7 +16,7 @@ RSpec.describe Licensee::Matchers::Exact do
   end
 
   it 'is confident' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   context 'with extra words added' do

data/spec/licensee/matchers/gemspec_matcher_spec.rb

@@ -1,19 +1,20 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Gemspec do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { "s.license = 'mit'" }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/matcher_spec.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Matcher do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'returns its name' do
-    expect(subject.name).to eql(:matcher)
+    expect(subject.name).to be(:matcher)
   end
 
   context 'to_h' do
@@ -22,6 +23,7 @@ RSpec.describe Licensee::Matchers::Matcher do
     end
 
     subject { MatcherSpecFixture.new(file) }
+
     let(:hash) { subject.to_h }
     let(:expected) do
       {

data/spec/licensee/matchers/npm_bower_matcher_spec.rb

@@ -1,19 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::NpmBower do
+  subject { described_class.new(file) }
+
   let(:content) { '"license": "mit"' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:other) { Licensee::License.find('other') }
 
-  subject { described_class.new(file) }
-
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/package_matcher_spec.rb

@@ -1,13 +1,15 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Package do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { '' }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
   let(:license_property) { 'mit' }
-  subject { described_class.new(file) }
+
   before do
     allow(subject).to receive(:license_property).and_return(license_property)
   end
@@ -17,7 +19,7 @@ RSpec.describe Licensee::Matchers::Package do
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   context 'with a nil license property' do

data/spec/licensee/matchers/reference_matcher_spec.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Reference do
+  subject { described_class.new(file) }
+
   let(:content) { 'Copyright 2015 Ben Balter' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:license) { Licensee::License.find('gpl-3.0') }
 
-  subject { described_class.new(file) }
-
   %i[title key nickname].each do |variation|
     context "with a license #{variation}" do
       let(:content) { "Licensed under the #{license.send(variation)} license" }

data/spec/licensee/matchers/spdx_matcher_spec.rb

@@ -1,20 +1,21 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::Matchers::Spdx do
+  subject { described_class.new(file) }
+
   let(:content) { 'PackageLicenseDeclared: MIT' }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.spdx')
   end
   let(:mit) { Licensee::License.find('mit') }
   let(:other) { Licensee::License.find('other') }
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   context 'no license field' do

data/spec/licensee/project_files/license_file_spec.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::ProjectFiles::LicenseFile do
+  subject { described_class.new(content, filename) }
+
   let(:filename) { 'LICENSE.txt' }
   let(:gpl) { Licensee::License.find('gpl-3.0') }
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:content_hash) { license_hashes['mit'] }
 
-  subject { described_class.new(content, filename) }
-
   it 'parses the attribution' do
     expect(subject.attribution).to eql('Copyright (c) 2018 Ben Balter')
   end
@@ -47,7 +47,7 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
   end
 
   it 'creates the wordset' do
-    expect(subject.wordset.count).to eql(91)
+    expect(subject.wordset.count).to be(91)
     expect(subject.wordset.first).to eql('permission')
   end
 
@@ -119,11 +119,11 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
       end
 
       it 'does not match .md2' do
-        expect(described_class::PREFERRED_EXT_REGEX).to_not match('.md2')
+        expect(described_class::PREFERRED_EXT_REGEX).not_to match('.md2')
       end
 
       it 'does not match .md/foo' do
-        expect(described_class::PREFERRED_EXT_REGEX).to_not match('.md/foo')
+        expect(described_class::PREFERRED_EXT_REGEX).not_to match('.md/foo')
       end
     end
 
@@ -133,7 +133,7 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
       end
 
       it 'does not match .md/foo' do
-        expect(described_class::OTHER_EXT_REGEX).to_not match('.md/foo')
+        expect(described_class::OTHER_EXT_REGEX).not_to match('.md/foo')
       end
     end
 
@@ -158,8 +158,8 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
     let(:regex) { Licensee::ProjectFiles::LicenseFile::CC_FALSE_POSITIVE_REGEX }
 
     it "knows MIT isn't a potential false positive" do
-      expect(subject.content).to_not match(regex)
-      expect(subject).to_not be_a_potential_false_positive
+      expect(subject.content).not_to match(regex)
+      expect(subject).not_to be_a_potential_false_positive
     end
 
     context 'a CC false positive without creative commons in the title' do
@@ -191,10 +191,10 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
 
     context 'CC-BY-ND with leading instructions' do
       let(:content) do
-        <<-LICENSE
-Creative Commons Corporation ("Creative Commons") is not a law firm
-======================================================================
-Creative Commons Attribution-NonCommercial 4.0
+        <<~LICENSE
+          Creative Commons Corporation ("Creative Commons") is not a law firm
+          ======================================================================
+          Creative Commons Attribution-NonCommercial 4.0
         LICENSE
       end
 
@@ -220,7 +220,7 @@ Creative Commons Attribution-NonCommercial 4.0
         let(:content) { sub_copyright_info(mit) }
 
         it 'is not lgpl' do
-          expect(subject).to_not be_lgpl
+          expect(subject).not_to be_lgpl
         end
       end
     end
@@ -229,7 +229,7 @@ Creative Commons Attribution-NonCommercial 4.0
       let(:filename) { 'COPYING' }
 
       it 'is not lgpl' do
-        expect(subject).to_not be_lgpl
+        expect(subject).not_to be_lgpl
       end
     end
   end
@@ -245,7 +245,7 @@ Creative Commons Attribution-NonCommercial 4.0
       let(:content) { sub_copyright_info(mit) }
 
       it 'is not GPL' do
-        expect(subject).to_not be_gpl
+        expect(subject).not_to be_gpl
       end
     end
   end

data/spec/licensee/project_files/package_info_spec.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::ProjectFiles::PackageManagerFile do
+  subject { described_class.new(content, filename) }
+
   let(:content) { '' }
   let(:filename) { '' }
-  subject { described_class.new(content, filename) }
 
   context 'name scoring' do
     {
@@ -19,6 +20,7 @@ RSpec.describe Licensee::ProjectFiles::PackageManagerFile do
     }.each do |filename, expected_score|
       context "a file named #{filename}" do
         let(:score) { described_class.name_score(filename) }
+
         it 'scores the file' do
           expect(score).to eql(expected_score)
         end

data/spec/licensee/project_files/project_file_spec.rb

@@ -1,16 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::ProjectFiles::ProjectFile do
+  subject { Licensee::ProjectFiles::LicenseFile.new(content, filename) }
+
   let(:filename) { 'LICENSE.txt' }
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { mit.content }
   let(:possible_matchers) { [Licensee::Matchers::Exact] }
 
-  subject { Licensee::ProjectFiles::LicenseFile.new(content, filename) }
   before do
     allow(subject).to receive(:possible_matchers).and_return(possible_matchers)
   end
+
   before { allow(subject).to receive(:length).and_return(mit.length) }
+
   before { allow(subject).to receive(:wordset).and_return(mit.wordset) }
 
   it 'stores the content' do
@@ -26,7 +29,7 @@ RSpec.describe Licensee::ProjectFiles::ProjectFile do
   end
 
   it 'returns the confidence' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   it 'returns the license' do

data/spec/licensee/project_files/readme_file_spec.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
 RSpec.describe Licensee::ProjectFiles::ReadmeFile do
+  subject { described_class.new(content, filename) }
+
   let(:filename) { 'README.md' }
   let(:content) { '' }
-  subject { described_class.new(content, filename) }
 
   context 'scoring names' do
     {

data/spec/licensee/project_spec.rb

@@ -6,13 +6,14 @@
   Licensee::Projects::GitHubProject
 ].each do |project_type|
   RSpec.describe project_type do
+    subject { described_class.new(path) }
+
     let(:stubbed_org) { '_licensee_test_fixture' }
     let(:mit) { Licensee::License.find('mit') }
     let(:other) { Licensee::License.find('other') }
     let(:fixture) { 'mit' }
     let(:path) { fixture_path(fixture) }
     let(:api_base) { 'https://api.github.com/repos' }
-    subject { described_class.new(path) }
 
     if described_class == Licensee::Projects::GitProject
       before do
@@ -46,14 +47,16 @@
             .to_return(status: 200, body: File.read(file))
         end
       end
+
       let(:path) { "https://github.com/#{stubbed_org}/#{fixture}" }
     end
 
     if described_class == Licensee::Projects::GitProject
       context 'when initialized with a repo' do
-        let(:repo) { Rugged::Repository.new(path) }
         subject { described_class.new(repo) }
 
+        let(:repo) { Rugged::Repository.new(path) }
+
         it 'returns the repository' do
           expect(subject.repository).to be_a(Rugged::Repository)
         end
@@ -61,6 +64,7 @@
 
       context 'when initialized with a revision' do
         let(:revision) { subject.repository.last_commit.oid }
+
         before do
           subject.instance_variable_set('@revision', revision)
         end
@@ -98,9 +102,9 @@
       let(:files) { subject.send(:files) }
 
       it 'returns the file list' do
-        expect(files.count).to eql(2)
+        expect(files.count).to be(2)
         license = files.find { |f| f[:name] == 'LICENSE.txt' }
-        expect(license).to_not be_nil
+        expect(license).not_to be_nil
 
         if described_class == Licensee::Projects::GitProject
           expect(files.first).to have_key(:oid)
@@ -123,7 +127,7 @@
 
           it 'looks for licenses in parent directories up to the search root' do
             # should not include the license in 'license-in-parent-folder' dir
-            expect(files.count).to eql(1)
+            expect(files.count).to be(1)
             expect(files.first[:name]).to eql('LICENSE.txt')
           end
         end
@@ -132,7 +136,7 @@
           let(:fixture) { 'license-in-parent-folder/license-folder/package' }
 
           it 'looks for licenses in current directory only' do
-            expect(files.count).to eql(0)
+            expect(files.count).to be(0)
           end
         end
       end
@@ -149,9 +153,10 @@
     end
 
     context 'readme detection' do
-      let(:fixture) { 'readme' }
       subject { described_class.new(path, detect_readme: true) }
 
+      let(:fixture) { 'readme' }
+
       it 'returns the readme' do
         expect(subject.readme_file).to be_a(Licensee::ProjectFiles::ReadmeFile)
         expect(subject.readme_file.filename).to eql('README.md')
@@ -164,6 +169,8 @@
     end
 
     context 'package manager detection' do
+      subject { described_class.new(path, detect_packages: true) }
+
       let(:fixture) { 'gemspec' }
 
       # Using a `.gemspec` extension in the fixture breaks `gem release`
@@ -202,8 +209,6 @@
         FileUtils.rm("#{fixture_path(fixture)}/project.gemspec")
       end
 
-      subject { described_class.new(path, detect_packages: true) }
-
       it 'returns the package file' do
         expected = Licensee::ProjectFiles::PackageManagerFile
         expect(subject.package_file).to be_a(expected)
@@ -232,19 +237,19 @@
       end
 
       it 'returns both licenses' do
-        expect(subject.licenses.count).to eql(2)
+        expect(subject.licenses.count).to be(2)
         expect(subject.licenses.first).to eql(Licensee::License.find('mpl-2.0'))
         expect(subject.licenses.last).to eql(mit)
       end
 
       it 'returns both matched_files' do
-        expect(subject.matched_files.count).to eql(2)
+        expect(subject.matched_files.count).to be(2)
         expect(subject.matched_files.first.filename).to eql('LICENSE')
         expect(subject.matched_files.last.filename).to eql('LICENSE.txt')
       end
 
       it 'returns both license_files' do
-        expect(subject.license_files.count).to eql(2)
+        expect(subject.license_files.count).to be(2)
         expect(subject.license_files.first.filename).to eql('LICENSE')
         expect(subject.license_files.last.filename).to eql('LICENSE.txt')
       end
@@ -260,29 +265,29 @@
       end
 
       it 'matched_file returns copying.lesser' do
-        expect(subject.matched_file).to_not be_nil
+        expect(subject.matched_file).not_to be_nil
         expect(subject.matched_file.filename).to eql('COPYING.lesser')
       end
 
       it 'license_file returns copying.lesser' do
-        expect(subject.license_file).to_not be_nil
+        expect(subject.license_file).not_to be_nil
         expect(subject.license_file.filename).to eql('COPYING.lesser')
       end
 
       it 'returns both licenses' do
-        expect(subject.licenses.count).to eql(2)
+        expect(subject.licenses.count).to be(2)
         expect(subject.licenses.first).to eql(lgpl)
         expect(subject.licenses.last).to eql(gpl)
       end
 
       it 'returns both matched_files' do
-        expect(subject.matched_files.count).to eql(2)
+        expect(subject.matched_files.count).to be(2)
         expect(subject.matched_files.first.filename).to eql('COPYING.lesser')
         expect(subject.matched_files.last.filename).to eql('LICENSE')
       end
 
       it 'returns both license_files' do
-        expect(subject.license_files.count).to eql(2)
+        expect(subject.license_files.count).to be(2)
         expect(subject.license_files.first.filename).to eql('COPYING.lesser')
         expect(subject.license_files.last.filename).to eql('LICENSE')
       end