licensee 9.10.1 → 9.13.2

data/spec/licensee/matchers/cargo_matcher_spec.rb

@@ -1,15 +1,18 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Cargo do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { 'license = "MIT"' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'Cargo.toml') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   it 'matches' do

data/spec/licensee/matchers/copyright_matcher_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Copyright do
-  let(:content) { 'Copyright 2015 Ben Balter' }
+  subject { described_class.new(file) }
+
+  let(:content) { 'Copyright 2015 Ben Balter'.dup }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:no_license) { Licensee::License.find('no-license') }
 
-  subject { described_class.new(file) }
-
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
@@ -15,7 +17,7 @@ RSpec.describe Licensee::Matchers::Copyright do
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   {
@@ -28,7 +30,7 @@ RSpec.describe Licensee::Matchers::Copyright do
     'ASCII-8BIT encoded'    => "Copyright \xC2\xA92015 Ben Balter`",
     'No year'               => 'Copyright Ben Balter',
     'Multiline'             => "Copyright Ben Balter\nCopyright Another Entity"
-      .force_encoding('ASCII-8BIT')
+      .dup.force_encoding('ASCII-8BIT')
   }.each do |description, notice|
     context "with a #{description} notice" do
       let(:content) { notice }

data/spec/licensee/matchers/cran_matcher_spec.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Cran do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:gpl2) { Licensee::License.find('gpl-2.0') }
   let(:gpl3) { Licensee::License.find('gpl-3.0') }
   let(:content) { "License: MIT + file LICENSE\nPackage: test" }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'DESCRIPTION') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -15,7 +18,7 @@ RSpec.describe Licensee::Matchers::Cran do
   end
 
   it 'is confident' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/dice_matcher_spec.rb

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Dice do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:gpl) { Licensee::License.find('gpl-3.0') }
   let(:agpl) { Licensee::License.find('agpl-3.0') }
@@ -6,7 +10,6 @@ RSpec.describe Licensee::Matchers::Dice do
   let(:cc_by_sa) { Licensee::License.find('cc-by-sa-4.0') }
   let(:content) { sub_copyright_info(gpl) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -22,25 +25,25 @@ RSpec.describe Licensee::Matchers::Dice do
 
   it 'sorts licenses by similarity' do
     expect(subject.matches_by_similarity[0]).to eql([gpl, 100.0])
-    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.76581285938317])
+    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.6842105263158])
   end
 
   it 'returns a list of licenses above the confidence threshold' do
     expect(subject.matches_by_similarity[0]).to eql([gpl, 100.0])
-    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.76581285938317])
+    expect(subject.matches_by_similarity[1]).to eql([agpl, 95.6842105263158])
   end
 
   it 'returns the match confidence' do
-    expect(subject.confidence).to eql(100.0)
+    expect(subject.confidence).to be(100.0)
   end
 
   context 'without a match' do
     let(:content) { 'Not really a license' }
 
     it "doesn't match" do
-      expect(subject.match).to eql(nil)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
@@ -50,10 +53,10 @@ RSpec.describe Licensee::Matchers::Dice do
     end
 
     it "doesn't match" do
-      expect(content).to_not be_detected_as(gpl)
-      expect(subject.match).to eql(nil)
+      expect(content).not_to be_detected_as(gpl)
+      expect(subject.match).to be(nil)
       expect(subject.matches).to be_empty
-      expect(subject.confidence).to eql(0)
+      expect(subject.confidence).to be(0)
     end
   end
 
@@ -72,11 +75,11 @@ RSpec.describe Licensee::Matchers::Dice do
       let(:content) { File.read(license_path) }
 
       it "doesn't match" do
-        expect(content).to_not be_detected_as(cc_by)
-        expect(content).to_not be_detected_as(cc_by_sa)
+        expect(content).not_to be_detected_as(cc_by)
+        expect(content).not_to be_detected_as(cc_by_sa)
         expect(subject.match).to be_nil
         expect(subject.matches).to be_empty
-        expect(subject.confidence).to eql(0)
+        expect(subject.confidence).to be(0)
       end
     end
   end

data/spec/licensee/matchers/dist_zilla_matcher_spec.rb

@@ -1,15 +1,18 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::DistZilla do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { 'license = MIT' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'dist.ini') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   it 'matches' do

data/spec/licensee/matchers/exact_matcher_spec.rb

@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Exact do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
@@ -13,7 +16,7 @@ RSpec.describe Licensee::Matchers::Exact do
   end
 
   it 'is confident' do
-    expect(subject.confidence).to eql(100)
+    expect(subject.confidence).to be(100)
   end
 
   context 'with extra words added' do

data/spec/licensee/matchers/gemspec_matcher_spec.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Gemspec do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { "s.license = 'mit'" }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/matcher_spec.rb

@@ -1,15 +1,18 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Matcher do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
-  subject { described_class.new(file) }
 
   it 'stores the file' do
     expect(subject.file).to eql(file)
   end
 
   it 'returns its name' do
-    expect(subject.name).to eql(:matcher)
+    expect(subject.name).to be(:matcher)
   end
 
   context 'to_h' do
@@ -20,6 +23,7 @@ RSpec.describe Licensee::Matchers::Matcher do
     end
 
     subject { MatcherSpecFixture.new(file) }
+
     let(:hash) { subject.to_h }
     let(:expected) do
       {

data/spec/licensee/matchers/npm_bower_matcher_spec.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::NpmBower do
+  subject { described_class.new(file) }
+
   let(:content) { '"license": "mit"' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:mit) { Licensee::License.find('mit') }
   let(:other) { Licensee::License.find('other') }
 
-  subject { described_class.new(file) }
-
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   {

data/spec/licensee/matchers/package_matcher_spec.rb

@@ -1,11 +1,15 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Package do
+  subject { described_class.new(file) }
+
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { '' }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'project.gemspec')
   end
   let(:license_property) { 'mit' }
-  subject { described_class.new(file) }
+
   before do
     allow(subject).to receive(:license_property).and_return(license_property)
   end
@@ -15,7 +19,7 @@ RSpec.describe Licensee::Matchers::Package do
   end
 
   it 'has confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   context 'with a nil license property' do

data/spec/licensee/matchers/reference_matcher_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Reference do
+  subject { described_class.new(file) }
+
   let(:content) { 'Copyright 2015 Ben Balter' }
   let(:file) { Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.txt') }
   let(:license) { Licensee::License.find('gpl-3.0') }
 
-  subject { described_class.new(file) }
-
   %i[title key nickname].each do |variation|
     context "with a license #{variation}" do
       let(:content) { "Licensed under the #{license.send(variation)} license" }

data/spec/licensee/matchers/spdx_matcher_spec.rb

@@ -1,18 +1,21 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::Matchers::Spdx do
+  subject { described_class.new(file) }
+
   let(:content) { 'PackageLicenseDeclared: MIT' }
   let(:file) do
     Licensee::ProjectFiles::LicenseFile.new(content, 'LICENSE.spdx')
   end
   let(:mit) { Licensee::License.find('mit') }
   let(:other) { Licensee::License.find('other') }
-  subject { described_class.new(file) }
 
   it 'matches' do
     expect(subject.match).to eql(mit)
   end
 
   it 'has a confidence' do
-    expect(subject.confidence).to eql(90)
+    expect(subject.confidence).to be(90)
   end
 
   context 'no license field' do

data/spec/licensee/project_files/license_file_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 RSpec.describe Licensee::ProjectFiles::LicenseFile do
+  subject { described_class.new(content, filename) }
+
   let(:filename) { 'LICENSE.txt' }
   let(:gpl) { Licensee::License.find('gpl-3.0') }
   let(:mit) { Licensee::License.find('mit') }
   let(:content) { sub_copyright_info(mit) }
-  let(:content_hash) { '46cdc03462b9af57968df67b450cc4372ac41f53' }
-
-  subject { described_class.new(content, filename) }
+  let(:content_hash) { license_hashes['mit'] }
 
   it 'parses the attribution' do
     expect(subject.attribution).to eql('Copyright (c) 2018 Ben Balter')
@@ -20,7 +22,7 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
   end
 
   context 'with an non-UTF-8-encoded license' do
-    let(:content) { "\x91License\x93".force_encoding('windows-1251') }
+    let(:content) { "\x91License\x93".dup.force_encoding('windows-1251') }
 
     it "doesn't blow up " do
       expect(subject.attribution).to be_nil
@@ -45,7 +47,7 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
   end
 
   it 'creates the wordset' do
-    expect(subject.wordset.count).to eql(91)
+    expect(subject.wordset.count).to be(92)
     expect(subject.wordset.first).to eql('permission')
   end
 
@@ -117,11 +119,11 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
       end
 
       it 'does not match .md2' do
-        expect(described_class::PREFERRED_EXT_REGEX).to_not match('.md2')
+        expect(described_class::PREFERRED_EXT_REGEX).not_to match('.md2')
       end
 
       it 'does not match .md/foo' do
-        expect(described_class::PREFERRED_EXT_REGEX).to_not match('.md/foo')
+        expect(described_class::PREFERRED_EXT_REGEX).not_to match('.md/foo')
       end
     end
 
@@ -131,7 +133,7 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
       end
 
       it 'does not match .md/foo' do
-        expect(described_class::OTHER_EXT_REGEX).to_not match('.md/foo')
+        expect(described_class::OTHER_EXT_REGEX).not_to match('.md/foo')
       end
     end
 
@@ -156,11 +158,11 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
     let(:regex) { Licensee::ProjectFiles::LicenseFile::CC_FALSE_POSITIVE_REGEX }
 
     it "knows MIT isn't a potential false positive" do
-      expect(subject.content).to_not match(regex)
-      expect(subject).to_not be_a_potential_false_positive
+      expect(subject.content).not_to match(regex)
+      expect(subject).not_to be_a_potential_false_positive
     end
 
-    context 'a CC false positive without creative commons in the title' do
+    context 'a CC false positive with creative commons in the title' do
       let(:content) { 'Creative Commons Attribution-NonCommercial 4.0' }
 
       it "knows it's a potential false positive" do
@@ -189,10 +191,10 @@ RSpec.describe Licensee::ProjectFiles::LicenseFile do
 
     context 'CC-BY-ND with leading instructions' do
       let(:content) do
-        <<-LICENSE
-Creative Commons Corporation ("Creative Commons") is not a law firm
-======================================================================
-Creative Commons Attribution-NonCommercial 4.0
+        <<~LICENSE
+          Creative Commons Corporation ("Creative Commons") is not a law firm
+          ======================================================================
+          Creative Commons Attribution-NonCommercial 4.0
         LICENSE
       end
 
@@ -218,7 +220,7 @@ Creative Commons Attribution-NonCommercial 4.0
         let(:content) { sub_copyright_info(mit) }
 
         it 'is not lgpl' do
-          expect(subject).to_not be_lgpl
+          expect(subject).not_to be_lgpl
         end
       end
     end
@@ -227,7 +229,7 @@ Creative Commons Attribution-NonCommercial 4.0
       let(:filename) { 'COPYING' }
 
       it 'is not lgpl' do
-        expect(subject).to_not be_lgpl
+        expect(subject).not_to be_lgpl
       end
     end
   end
@@ -243,7 +245,7 @@ Creative Commons Attribution-NonCommercial 4.0
       let(:content) { sub_copyright_info(mit) }
 
       it 'is not GPL' do
-        expect(subject).to_not be_gpl
+        expect(subject).not_to be_gpl
       end
     end
   end