license_finder 5.4.1 → 5.5.0

data/lib/license_finder/package_utils/license_files.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'license_finder/package_utils/possible_license_file'
 
 module LicenseFinder
   class LicenseFiles
     CANDIDATE_FILE_NAMES = %w[LICENSE License LICENCE Licence COPYING README Readme ReadMe].freeze
-    CANDIDATE_PATH_WILDCARD = "*{#{CANDIDATE_FILE_NAMES.join(',')}}*".freeze
+    CANDIDATE_PATH_WILDCARD = "*{#{CANDIDATE_FILE_NAMES.join(',')}}*"
 
     def self.find(install_path, options = {})
       new(install_path).find(options)
@@ -32,6 +34,7 @@ module LicenseFinder
 
     def candidate_files_and_dirs
       return [] if install_path.nil?
+
       Pathname.glob(install_path.join('**', CANDIDATE_PATH_WILDCARD))
     end
   end

data/lib/license_finder/package_utils/licensing.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'license_finder/package_utils/activation'
 
 module LicenseFinder
@@ -14,17 +16,17 @@ module LicenseFinder
     end
 
     def activations_from_decisions
-      @afd ||= decided_licenses
+      @activations_from_decisions ||= decided_licenses
                .map { |license| Activation::FromDecision.new(package, license) }
     end
 
     def activations_from_spec
-      @afs ||= licenses_from_spec
+      @activations_from_spec ||= licenses_from_spec
                .map { |license| Activation::FromSpec.new(package, license) }
     end
 
     def activations_from_files
-      @aff ||= license_files
+      @activations_from_files ||= license_files
                .group_by(&:license)
                .map { |license, files| Activation::FromFiles.new(package, license, files) }
     end

data/lib/license_finder/package_utils/maven_dependency_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class MavenDependencyFinder
     def initialize(project_path)

data/lib/license_finder/package_utils/possible_license_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class PossibleLicenseFile
     def initialize(path, options = {})

data/lib/license_finder/package_utils/sbt_dependency_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class SbtDependencyFinder
     def initialize(project_path)

data/lib/license_finder/packages/bower_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class BowerPackage < Package
     def initialize(bower_module, options = {})

data/lib/license_finder/packages/bundler_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class BundlerPackage < Package
     def initialize(spec, bundler_def, options = {})

data/lib/license_finder/packages/cargo_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class CargoPackage < Package
     def initialize(crate, options = {})

data/lib/license_finder/packages/carthage_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class CarthagePackage < Package
     def initialize(name, version, license_text, options = {})

data/lib/license_finder/packages/cocoa_pods_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class CocoaPodsPackage < Package
     def initialize(name, version, license_text, options = {})

data/lib/license_finder/packages/conan_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class ConanPackage < Package
     def initialize(name, version, license_text, url, options = {})

data/lib/license_finder/packages/go_package.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'license_finder/package'
+
 module LicenseFinder
   class GoPackage < Package
     def package_manager

data/lib/license_finder/packages/gradle_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class GradlePackage < Package
     def initialize(spec, options = {})

data/lib/license_finder/packages/manual_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class ManualPackage < Package
     def ==(other)

data/lib/license_finder/packages/maven_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class MavenPackage < Package
     def initialize(spec, options = {})

data/lib/license_finder/packages/merged_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class MergedPackage < Package
     extend Forwardable

data/lib/license_finder/packages/mix_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class MixPackage < Package
     def package_manager

data/lib/license_finder/packages/npm_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class NpmPackage < Package
     attr_accessor :identifier, :dependencies, :groups, :json
@@ -36,6 +38,7 @@ module LicenseFinder
           group.package_names.each do |package_name|
             @packages.each_key do |identifier|
               next unless identifier.name == package_name
+
               dependency = @packages[identifier]
               dependency.groups |= [group.name]
               populate_child_groups(dependency, @packages)
@@ -47,6 +50,7 @@ module LicenseFinder
       def populate_child_groups(dependency, packages, populated_ids = [])
         dependency.dependencies.each do |id|
           next if populated_ids.include? id
+
           populated_ids.push id
           packages[id].groups |= dependency.groups
           populate_child_groups(packages[id], packages, populated_ids)
@@ -97,6 +101,7 @@ module LicenseFinder
         name = hash['name']
         version = hash['version']
         return nil if name.nil? || version.nil?
+
         Identifier.new(name, version)
       end
 

data/lib/license_finder/packages/nuget_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class NugetPackage < Package
     def package_manager

data/lib/license_finder/packages/pip_package.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'set'
+
 module LicenseFinder
   class PipPackage < Package
     LICENSE_FORMAT = /^License.*::\s*(.*)$/

data/lib/license_finder/packages/rebar_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class RebarPackage < Package
     def package_manager

data/lib/license_finder/packages/sbt_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class SbtPackage < Package
     def initialize(spec, options = {})

data/lib/license_finder/packages/yarn_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class YarnPackage < Package
     def package_manager

data/lib/license_finder/platform.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   module Platform
     def self.darwin?

data/lib/license_finder/project_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class ProjectFinder
     def initialize(main_project_path, strict_matching = false)
@@ -33,6 +35,7 @@ module LicenseFinder
 
     def remove_nested(pathname, paths)
       return if project_root?(pathname)
+
       paths.reject! { |path| nested_path?(path, pathname) }
     end
 

data/lib/license_finder/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class Report
     def self.of(dependencies, options)

data/lib/license_finder/scanner.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module LicenseFinder
   class Scanner
-    PACKAGE_MANAGERS = [GoDep, GoWorkspace, Go15VendorExperiment, Glide, Gvt, Govendor, Dep, Bundler, NPM, Pip,
+    PACKAGE_MANAGERS = [GoModules, GoDep, GoWorkspace, Go15VendorExperiment, Glide, Gvt, Govendor, Dep, Bundler, NPM, Pip,
                         Yarn, Bower, Maven, Gradle, CocoaPods, Rebar, Nuget, Carthage, Mix, Conan, Sbt, Cargo].freeze
 
     def initialize(config = { project_path: Pathname.new('') })

data/lib/license_finder/shared_helpers/cmd.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open3'
 
 module LicenseFinder

data/lib/license_finder/shared_helpers/common_path.rb

@@ -1,24 +1,26 @@
+# frozen_string_literal: true
+
 module CommonPathHelper
-  def self.shortest_common_paths(paths)
+  def self.longest_common_paths(paths)
     [].tap do |common_paths|
       # organize by matching root paths
       paths_with_roots = paths.group_by { |path| path.split('/').first }
       paths_with_roots.each do |common_root, full_paths|
         # use the shortest path as the 'template'
-        shortest_path = full_paths.sort_by { |path| path.split('/').length }.first
-        shortest_common_path = common_root
+        shortest_path = full_paths.min_by { |path| path.split('/').length }
+        longest_common_path = common_root
 
         # iterate through each subpath of the 'template'
         shortest_path.split('/').each_with_index do |subpath, i|
-          potential_path = i.zero? ? shortest_common_path : [shortest_common_path, subpath].join('/')
+          potential_path = i.zero? ? longest_common_path : [longest_common_path, subpath].join('/')
 
           # check each for the existence of the subsequent subpath
           mismatch = full_paths.any? { |path| !path.start_with?(potential_path) }
           break if mismatch
 
-          shortest_common_path = potential_path
+          longest_common_path = potential_path
         end
-        common_paths << shortest_common_path
+        common_paths << longest_common_path
       end
     end
   end

data/lib/license_finder/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LicenseFinder
-  VERSION = '5.4.1'.freeze
+  VERSION = '5.5.0'
 end

data/license_finder.gemspec

@@ -1,11 +1,13 @@
-lib = File.expand_path('../lib/', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
 
 require 'license_finder/platform'
 require 'license_finder/version'
 
 Gem::Specification.new do |s|
-  s.required_ruby_version = '>= 2.1.0'
+  s.required_ruby_version = '>= 2.3.3'
   s.name        = 'license_finder'
   s.version     = LicenseFinder::VERSION
 
@@ -61,6 +63,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec', '~> 3'
   s.add_development_dependency 'rspec-its'
+  s.add_development_dependency 'rubocop', '~> 0.59.2'
   s.add_development_dependency 'webmock', '~> 1.13'
 
   # to preserve ruby < 2.2.2 support.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 5.4.1
+  version: 5.5.0
 platform: ruby
 authors:
 - Ryan Collins
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-18 00:00:00.000000000 Z
+date: 2018-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -225,6 +225,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.59.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.59.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -295,8 +309,8 @@ files:
 - appveyor.yml
 - bin/license_finder
 - bin/license_finder_pip.py
-- ci/pipelines/pipeline.yml.erb
-- ci/pipelines/release.yml
+- ci/pipelines/pull-request.yml.erb
+- ci/pipelines/release.yml.erb
 - ci/scripts/bump-patch-version.sh
 - ci/scripts/containerize-tests.sh
 - ci/scripts/pushscript.sh
@@ -309,6 +323,7 @@ files:
 - ci/tasks/build.yml
 - ci/tasks/bump-patch-version.yml
 - ci/tasks/rubocop.yml
+- ci/tasks/run-tests.yml
 - ci/tasks/update-changelog.yml
 - dlf
 - lib/license_finder.rb
@@ -367,6 +382,7 @@ files:
 - lib/license_finder/package_managers/glide.rb
 - lib/license_finder/package_managers/go_15vendorexperiment.rb
 - lib/license_finder/package_managers/go_dep.rb
+- lib/license_finder/package_managers/go_modules.rb
 - lib/license_finder/package_managers/go_workspace.rb
 - lib/license_finder/package_managers/govendor.rb
 - lib/license_finder/package_managers/gradle.rb
@@ -436,7 +452,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.3.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/ci/pipelines/release.yml

@@ -1,112 +0,0 @@
-resources:
-- name: lf-git
-  type: git
-  source:
-    uri: git@github.com:pivotal-legacy/LicenseFinder.git
-    private_key: ((CfOslBot.private_key))
-    branch: master
-
-- name: lf-image
-  type: docker-image
-  source:
-    repository: licensefinder/license_finder
-    email: ((LicenseFinderDockerEmail))
-    username: ((LicenseFinderDocker.username))
-    password: ((LicenseFinderDocker.password))
-
-- name: lf-release
-  type: github-release
-  source:
-    owner: pivotal
-    repository: LicenseFinder
-    access_token: ((GithubApiRootToken))
-
-jobs:
-
-- name: patch-version
-  plan:
-  - get: lf-git
-  - get: lf-image
-    params:
-      save: true
-  - task: bump-version
-    params:
-      image: lf-image
-      GIT_USERNAME: ((GithubApiUser))
-      GIT_EMAIL: ((GithubApiEmail))
-    file: lf-git/ci/tasks/bump-patch-version.yml
-  - put: lf-git
-    params:
-      repository: lf-git-changed
-
-- name: release
-  plan:
-  - get: lf-git
-    trigger: true
-    passed: [ patch-version ]
-  - get: lf-image
-    params:
-      save: true
-  - get: lf-release
-  - task: update-changelog
-    image: lf-image
-    params:
-      GIT_USERNAME: ((GithubApiUser))
-      GIT_EMAIL: ((GithubApiEmail))
-    file: lf-git/ci/tasks/update-changelog.yml
-  - put: lf-image
-    params:
-      build: lf-git
-      tag: version/version.txt
-      tag_as_latest: true
-  - put: lf-git
-    params:
-      repository: lf-git-changed
-  - task: build-and-push-gem
-    image: lf-image
-    params:
-      GIT_USERNAME: ((GithubApiUser))
-      GIT_EMAIL: ((GithubApiEmail))
-      GIT_PRIVATE_KEY: ((CfOslBot.private_key))
-      GEM_API_KEY: ((LicenseFinderGemApiKey))
-    file: lf-git/ci/tasks/build-and-push-gem.yml
-  - put: lf-release
-    params:
-      name: version/tag.txt
-      tag: version/tag.txt
-      body: version/changelog.txt
-
-- name: manual-release
-  plan:
-  - get: lf-git
-  - get: lf-image
-    params:
-      save: true
-  - get: lf-release
-  - task: update-changelog
-    image: lf-image
-    params:
-      GIT_USERNAME: ((GithubApiUser))
-      GIT_EMAIL: ((GithubApiEmail))
-    file: lf-git/ci/tasks/update-changelog.yml
-  - put: lf-image
-    params:
-      build: lf-git
-      tag: version/version.txt
-      tag_as_latest: true
-  - task: build-and-push-gem
-    image: lf-image
-    params:
-      GIT_USERNAME: ((GithubApiUser))
-      GIT_EMAIL: ((GithubApiEmail))
-      GIT_PRIVATE_KEY: ((CfOslBot.private_key))
-      GEM_API_KEY: ((LicenseFinderGemApiKey))
-    file: lf-git/ci/tasks/build-and-push-gem.yml
-  - put: lf-git
-    params:
-      repository: lf-git-changed
-  - put: lf-release
-    params:
-      name: version/tag.txt
-      tag: version/tag.txt
-      body: version/changelog.txt