license_finder 2.1.0.rc6 → 2.1.0.rc7

data/spec/fixtures/npm-recursive-dependencies/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "asdf",
+  "version": "0.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "BSD-2-Clause",
+  "dependencies": {
+    "pui-react-alerts": "3.0.0-alpha.2",
+    "pui-react-media": "3.0.0-alpha.2"
+  }
+}

data/spec/lib/license_finder/package_manager_spec.rb

@@ -18,5 +18,45 @@ module LicenseFinder
         ])
       end
     end
+
+    describe "#package_management_command" do
+      it "defaults to nil" do
+        expect(LicenseFinder::PackageManager.package_management_command).to be_nil
+      end
+    end
+
+    describe ".installed?" do
+      context "package_management_command is nil" do
+        before do
+          allow(LicenseFinder::PackageManager).to receive(:package_management_command).and_return(nil)
+        end
+
+        it "returns true" do
+          expect(LicenseFinder::PackageManager.installed?).to be_truthy
+        end
+      end
+
+      context "package_management_command exists" do
+        before do
+          allow(LicenseFinder::PackageManager).to receive(:package_management_command).and_return("foobar")
+          allow(LicenseFinder::PackageManager).to receive(:command_exists?).with("foobar").and_return(true)
+        end
+
+        it "returns true" do
+          expect(LicenseFinder::PackageManager.installed?).to be_truthy
+        end
+      end
+
+      context "package_management_command does not exist" do
+        before do
+          allow(LicenseFinder::PackageManager).to receive(:package_management_command).and_return("foobar")
+          allow(LicenseFinder::PackageManager).to receive(:command_exists?).with("foobar").and_return(false)
+        end
+
+        it "returns false" do
+          expect(LicenseFinder::PackageManager.installed?).to be_falsey
+        end
+      end
+    end
   end
 end

data/spec/lib/license_finder/package_managers/go_vendor_spec.rb

@@ -5,11 +5,25 @@ module LicenseFinder
   describe GoVendor do
     include FakeFS::SpecHelpers
 
-    let(:project_path) { '/app' }
-    let(:options) { {} }
     let(:logger) { double(:logger, active: nil) }
     subject { GoVendor.new(options.merge(project_path: Pathname(project_path), logger: logger)) }
 
+    before do
+      allow(logger).to receive(:installed)
+      allow(logger).to receive(:active)
+    end
+
+    context 'package manager' do
+      before do
+        FileUtils.mkdir_p File.join(fixture_path('all_pms'), 'vendor')
+      end
+
+      it_behaves_like "a PackageManager"
+    end
+
+    let(:project_path) { '/app' }
+    let(:options) { {} }
+
     context 'when there are go files' do
       before do
         FileUtils.mkdir_p project_path

data/spec/lib/license_finder/package_managers/go_workspace_spec.rb

@@ -7,6 +7,19 @@ module LicenseFinder
     let(:project_path) { '/Users/pivotal/workspace/loggregator'}
     subject { GoWorkspace.new(options.merge(project_path: Pathname(project_path), logger: logger)) }
 
+    before do
+      allow(logger).to receive(:installed)
+      allow(logger).to receive(:active)
+    end
+
+    context 'package manager' do
+      before do
+        allow_any_instance_of(GoDep).to receive(:active?).and_return(false)
+      end
+
+      it_behaves_like "a PackageManager"
+    end
+
     describe '#go_list' do
 
       let(:go_list_output) {

data/spec/support/shared_examples_for_package_manager.rb

@@ -8,6 +8,7 @@ module LicenseFinder
     context "logging" do
       it "logs when it checks for active-ness" do
         logger = double(:logger)
+        expect(logger).to receive(:installed)
         expect(logger).to receive(:active)
 
         subject = described_class.new logger: logger, project_path: all_pms
@@ -16,13 +17,35 @@ module LicenseFinder
     end
 
     describe '.active?' do
-      it 'is true when package manager file exists' do
-        expect(described_class.new(project_path: all_pms)).to be_active
+      context 'package manager is installed' do
+        before do
+          allow(described_class).to receive(:installed?).and_return(true)
+          allow_any_instance_of(described_class).to receive(:has_go_files?).and_return(true)
+        end
+
+        it 'is true when package manager file exists' do
+          expect(described_class.new(project_path: all_pms)).to be_active
+        end
+
+        it 'is false without a package manager file' do
+          no_pms = fixture_path("not/a/path")
+          expect(described_class.new(project_path: no_pms)).to_not be_active
+        end
       end
 
-      it 'is false without a package manager file' do
-        no_pms = fixture_path("not/a/path")
-        expect(described_class.new(project_path: no_pms)).to_not be_active
+      context 'package manager is not installed' do
+        before do
+          allow(described_class).to receive(:installed?).and_return(false)
+        end
+
+        it 'is false when package manager file exists' do
+          expect(described_class.new(project_path: all_pms)).to_not be_active
+        end
+
+        it 'is false without a package manager file' do
+          no_pms = fixture_path("not/a/path")
+          expect(described_class.new(project_path: no_pms)).to_not be_active
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 2.1.0.rc6
+  version: 2.1.0.rc7
 platform: ruby
 authors:
 - Jacob Maine
@@ -20,7 +20,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-11 00:00:00.000000000 Z
+date: 2016-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -78,6 +78,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: colorize
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -379,6 +393,7 @@ files:
 - spec/fixtures/all_pms/pom.xml
 - spec/fixtures/all_pms/rebar.config
 - spec/fixtures/all_pms/requirements.txt
+- spec/fixtures/all_pms/vendor/.gitkeep
 - spec/fixtures/composite/Gemfile
 - spec/fixtures/composite/nested_project/.envrc
 - spec/fixtures/composite/nested_project/src/github.com/pivotal/foo/Godeps/Godeps.json
@@ -397,6 +412,8 @@ files:
 - spec/fixtures/license_names/Mit-License
 - spec/fixtures/license_names/README.rdoc
 - spec/fixtures/nested_gem/vendor/LICENSE
+- spec/fixtures/npm-recursive-dependencies/npm-list.json
+- spec/fixtures/npm-recursive-dependencies/package.json
 - spec/fixtures/utf8_gem/README
 - spec/lib/license_finder/cli/approvals_spec.rb
 - spec/lib/license_finder/cli/blacklist_spec.rb