license_finder 1.1.1 → 1.2

data/lib/license_finder/package_managers/bundler_package.rb

@@ -4,12 +4,11 @@ module LicenseFinder
     def_delegators :gem_def, :summary, :description, :name, :homepage
 
     attr_reader :gem_def
-    attr_accessor :children
 
-    def initialize(gem_def, bundler_def)
+    def initialize(gem_def, bundler_def, options={})
+      super options
       @gem_def = gem_def
       @bundler_def = bundler_def
-      @children = []
     end
 
     def groups
@@ -20,6 +19,10 @@ module LicenseFinder
       gem_def.version.to_s
     end
 
+    def children
+      gem_def.dependencies.map(&:name)
+    end
+
     private
 
     def install_path

data/lib/license_finder/package_managers/cocoa_pods.rb

@@ -1,12 +1,11 @@
 require "json"
 
 module LicenseFinder
-  class CocoaPods
-
-    def self.current_packages
+  class CocoaPods < PackageManager
+    def current_packages
       podfile = YAML.load_file(lockfile_path)
 
-      acknowledgements = JSON.parse(`plutil -convert json -o - #{Pathname.new('Pods/Pods-acknowledgements.plist').expand_path}`)["PreferenceSpecifiers"]
+      acknowledgements = read_plist(acknowledgements_path)["PreferenceSpecifiers"]
 
       podfile["PODS"].map do |pod|
         pod = pod.keys.first if pod.is_a?(Hash)
@@ -17,19 +16,28 @@ module LicenseFinder
       end
     end
 
-    def self.active?
-      package_path.exist?
-    end
-
     private
 
-    def self.package_path
+    def package_path
       Pathname.new("Podfile")
     end
 
-    def self.lockfile_path
+    def lockfile_path
       Pathname.new("Podfile.lock")
     end
 
+    def acknowledgements_path
+      filename = 'Pods-acknowledgements.plist'
+      directories = [
+        'Pods',                          # cocoapods < 0.34
+        'Pods/Target Support Files/Pods' # cocoapods >= 0.34
+      ]
+
+      directories.map { |dir| Pathname.new(File.join(dir, filename)) }.find(&:exist?)
+    end
+
+    def read_plist pathname
+      JSON.parse(`plutil -convert json -o - '#{pathname.expand_path}'`)
+    end
   end
 end

data/lib/license_finder/package_managers/cocoa_pods_package.rb

@@ -3,7 +3,8 @@ module LicenseFinder
     attr_reader :name, :version
     attr_reader :summary, :description, :homepage
 
-    def initialize(name, version, license_text)
+    def initialize(name, version, license_text, options={})
+      super options
       @name = name
       @version = version
       @license_text = license_text
@@ -12,8 +13,8 @@ module LicenseFinder
     def groups; []; end
     def children; []; end
 
-    def license
-      License.find_by_text(@license_text.to_s) || default_license
+    def licenses
+      [License.find_by_text(@license_text.to_s) || default_license].to_set
     end
   end
 end

data/lib/license_finder/package_managers/gradle.rb

@@ -1,8 +1,8 @@
 require "xmlsimple"
 
 module LicenseFinder
-  class Gradle
-    def self.current_packages
+  class Gradle < PackageManager
+    def current_packages
       `#{LicenseFinder.config.gradle_command} downloadLicenses`
 
       xml = license_report.read
@@ -10,23 +10,19 @@ module LicenseFinder
       options = {
         'GroupTags' => { 'dependencies' => 'dependency' }
       }
-      XmlSimple.xml_in(xml, options).fetch('dependency', []).map do |d|
-        d["license"].reject! { |l| l["name"] == "No license found" }
-        GradlePackage.new(d)
+      XmlSimple.xml_in(xml, options).fetch('dependency', []).map do |dep|
+        dep["license"].reject! { |l| l["name"] == "No license found" }
+        GradlePackage.new(dep, logger: logger)
       end
     end
 
-    def self.active?
-      package_path.exist?
-    end
-
     private
 
-    def self.license_report
+    def license_report
       Pathname.new('build/reports/license/dependency-license.xml')
     end
 
-    def self.package_path
+    def package_path
       Pathname.new('build.gradle')
     end
   end

data/lib/license_finder/package_managers/gradle_package.rb

@@ -2,7 +2,8 @@ module LicenseFinder
   class GradlePackage < Package
     attr_reader :name, :version
 
-    def initialize(gradle_dependency)
+    def initialize(gradle_dependency, options={})
+      super options
       @gradle_dependency = gradle_dependency
       @name = @gradle_dependency["name"].split(":")[1]
       @version = @gradle_dependency["name"].split(":")[2]
@@ -28,12 +29,6 @@ module LicenseFinder
       []
     end
 
-    private
-
-    def licenses_from_files
-      []
-    end
-
     def license_names_from_spec
       @gradle_dependency["license"].map { |l| l["name"] }
     end

data/lib/license_finder/package_managers/maven.rb

@@ -1,8 +1,8 @@
 require "xmlsimple"
 
 module LicenseFinder
-  class Maven
-    def self.current_packages
+  class Maven < PackageManager
+    def current_packages
       `mvn license:download-licenses`
 
       xml = license_report.read
@@ -14,21 +14,17 @@ module LicenseFinder
       dependencies = XmlSimple.xml_in(xml, options)["dependencies"]
 
       dependencies.map do |dep|
-        MavenPackage.new(dep)
+        MavenPackage.new(dep, logger: logger)
       end
     end
 
-    def self.active?
-      package_path.exist?
-    end
-
     private
 
-    def self.license_report
+    def license_report
       Pathname.new('target/generated-resources/licenses.xml')
     end
 
-    def self.package_path
+    def package_path
       Pathname.new('pom.xml')
     end
   end

data/lib/license_finder/package_managers/maven_package.rb

@@ -1,6 +1,9 @@
 module LicenseFinder
   class MavenPackage < Package
-    def initialize(mvn_dependency)
+    attr_reader :mvn_dependency
+
+    def initialize(mvn_dependency, options={})
+      super options
       @mvn_dependency = mvn_dependency
     end
 
@@ -32,13 +35,6 @@ module LicenseFinder
       []
     end
 
-    private
-    attr_reader :mvn_dependency
-
-    def licenses_from_files
-      []
-    end
-
     def license_names_from_spec
       mvn_dependency["licenses"].map { |l| l["name"] }
     end

data/lib/license_finder/package_managers/npm.rb

@@ -1,25 +1,21 @@
 require 'json'
 
 module LicenseFinder
-  class NPM
+  class NPM < PackageManager
     DEPENDENCY_GROUPS = ["dependencies", "devDependencies", "bundleDependencies", "bundledDependencies"]
 
-    def self.current_packages
+    def current_packages
       json = npm_json
       dependencies = DEPENDENCY_GROUPS.map { |g| (json[g] || {}).values }.flatten(1).reject{ |d| d.is_a?(String) }
 
       dependencies.map do |node_module|
-        NpmPackage.new(node_module)
+        NpmPackage.new(node_module, logger: logger)
       end
     end
 
-    def self.active?
-      package_path.exist?
-    end
-
     private
 
-    def self.npm_json
+    def npm_json
       command = "npm list --json --long"
       output, success = capture(command)
       if success
@@ -35,11 +31,11 @@ module LicenseFinder
       json
     end
 
-    def self.capture(command)
+    def capture(command)
       [`#{command}`, $?.success?]
     end
 
-    def self.package_path
+    def package_path
       Pathname.new('package.json')
     end
   end

data/lib/license_finder/package_managers/npm_package.rb

@@ -1,6 +1,7 @@
 module LicenseFinder
   class NpmPackage < Package
-    def initialize(node_module)
+    def initialize(node_module, options={})
+      super options
       @node_module = node_module
     end
 

data/lib/license_finder/package_managers/pip.rb

@@ -2,40 +2,27 @@ require 'json'
 require 'httparty'
 
 module LicenseFinder
-  class Pip
-    GET_DEPENDENCIES_PY = <<-PYTHON.gsub(/\n+/, ";")
-from pip.util import get_installed_distributions
-
-dists = [(x.project_name, x.version, x.location) for x in get_installed_distributions()]
-dists = ["[\\\"{0}\\\", \\\"{1}\\\", \\\"{2}\\\"]".format(*dist) for dist in dists]
-
-print "[" + ",".join(dists) + "]"
-    PYTHON
-
-    def self.current_packages
-      output = `python -c '#{GET_DEPENDENCIES_PY}'`
-
-      JSON(output).map do |(name, version, install_dir)|
+  class Pip < PackageManager
+    def current_packages
+      output = `#{LicenseFinder::BIN_PATH.join("license_finder_pip.py")}`
+      JSON(output).map do |package|
         PipPackage.new(
-          name,
-          version,
-          File.join(install_dir, name),
-          pypi_def(name, version)
+          package["name"],
+          package["version"],
+          File.join(package["location"], package["name"]),
+          pypi_def(package["name"], package["version"]),
+          logger: logger
         )
       end
     end
 
-    def self.active?
-      requirements_path.exist?
-    end
-
     private
 
-    def self.requirements_path
+    def package_path
       Pathname.new('requirements.txt')
     end
 
-    def self.pypi_def(name, version)
+    def pypi_def(name, version)
       response = HTTParty.get("https://pypi.python.org/pypi/#{name}/#{version}/json")
       if response.code == 200
         JSON.parse(response.body).fetch("info", {})

data/lib/license_finder/package_managers/pip_package.rb

@@ -1,6 +1,7 @@
 module LicenseFinder
   class PipPackage < Package
-    def initialize(name, version, install_path, pypi_def)
+    def initialize(name, version, install_path, pypi_def, options={})
+      super options
       @name = name
       @version = version
       @install_path = install_path

data/lib/license_finder/package_saver.rb

@@ -3,7 +3,7 @@ require 'forwardable'
 module LicenseFinder
   class PackageSaver
     extend Forwardable
-    def_delegators :package, :license, :children, :groups, :summary, :description, :version, :homepage
+    def_delegators :package, :licenses, :children, :groups, :summary, :description, :version, :homepage
 
     attr_reader :dependency, :package
 
@@ -25,7 +25,7 @@ module LicenseFinder
       dependency.homepage = homepage
       dependency.bundler_group_names = groups.map(&:to_s)
       dependency.children_names = children
-      dependency.apply_better_license license
+      dependency.set_licenses licenses
 
       # Only save *changed* dependencies. This ensures re-running
       # `license_finder` won't always update the DB, and therefore won't always

data/lib/license_finder/platform.rb

@@ -15,6 +15,10 @@ module LicenseFinder
     def self.java?
       RUBY_PLATFORM =~ /java/
     end
+
+    def self.darwin?
+      RUBY_PLATFORM =~ /darwin/
+    end
   end
 end
 

data/lib/license_finder/possible_license_file.rb

@@ -15,6 +15,10 @@ module LicenseFinder
       @text ||= @file_path.send(@file_path.respond_to?(:binread) ? :binread : :read)
     end
 
+    def path
+      File.join(@install_path, file_path)
+    end
+
     def license
       License.find_by_text(text)
     end

data/lib/license_finder/possible_license_files.rb

@@ -8,7 +8,7 @@ module LicenseFinder
     end
 
     def initialize(install_path)
-      @install_path = Pathname(install_path)
+      @install_path = install_path ? Pathname(install_path) : nil
     end
 
     def find
@@ -28,6 +28,7 @@ module LicenseFinder
     end
 
     def candidate_files_and_dirs
+      return [] if install_path.nil?
       Pathname.glob(install_path.join('**', CANDIDATE_PATH_WILDCARD))
     end
 

data/lib/license_finder/reports/detailed_text_report.rb

@@ -8,7 +8,7 @@ module LicenseFinder
           csv << [
             s.name,
             s.version,
-            s.license.name,
+            s.licenses.map(&:name).join(','),
             s.summary ? s.summary.strip : "",
             s.description ? s.description.strip : ""
           ]

data/lib/license_finder/reports/formatted_report.rb

@@ -7,7 +7,7 @@ module LicenseFinder
 
     def grouped_dependencies
       find_name = lambda do |dep|
-        dep.license.name
+        dep.licenses.map(&:name).sort.join ', '
       end
 
       dependencies.group_by(&find_name).sort_by { |_, group| group.size }.reverse

data/lib/license_finder/tables/dependency.rb

@@ -1,10 +1,19 @@
+require 'json'
+
 module LicenseFinder
   class Dependency < Sequel::Model
     plugin :boolean_readers
     plugin :composition
-    composition :license,
-      composer: ->(d) { License.find_by_name(d.license_name) },
-      decomposer: ->(d) { self.license_name = license.name }
+    composition :licenses,
+      composer: ->(d) do
+        if d.license_names.nil?
+          [License.find_by_name(nil)].to_set
+        else
+          names = JSON.parse(d.license_names)
+          names.map { |n| License.find_by_name(n) }.to_set
+        end
+      end,
+      decomposer: ->(d) { self.license_names = licenses.map(&:name).to_json }
 
     one_to_one :manual_approval
     many_to_many :children, join_table: :ancestries, left_key: :parent_dependency_id, right_key: :child_dependency_id, class: self
@@ -58,26 +67,27 @@ module LicenseFinder
     end
 
     def whitelisted?
-      license.whitelisted?
+      licenses.any? &:whitelisted?
     end
 
     def approved_manually?
       !!manual_approval
     end
 
+    def set_licenses(other_licenses)
+      return if license_assigned_manually?
+      other_licenses = other_licenses.to_set
+      if licenses != other_licenses
+        self.licenses = other_licenses
+      end
+    end
+
     def set_license_manually!(license)
-      self.license = license
+      self.licenses = [license].to_set
       self.license_assigned_manually = true
       save
     end
 
-    def apply_better_license(other_license)
-      return if license_assigned_manually?
-      if license.name != other_license.name
-        self.license = other_license
-      end
-    end
-
     private
 
     def update_association_collection(association_name, names)