license_finder 0.9.5 → 0.9.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 914d2f2e411442bf2e8f37f7b17b5dd963f9c4be
-  data.tar.gz: 985aa512713ab48aaed47129747e1f7b3b1d10de
+  metadata.gz: 7d0fac94c1fcfb1e2c55c8ad51eb926d0ebf6095
+  data.tar.gz: 929357c4d7e453a934656e55868accae1c156135
 SHA512:
-  metadata.gz: c312d903761a6688929d0dc5c2b55d2e282cf2668d6f3d3d107341b9b86f75a206c7b5add0eac1c758117d89a028cd91f7ef5c8013ecce851a0f19e06f5e1eb9
-  data.tar.gz: 91f606929437fc775f297b0377a567b18b7f95109bd1a7e000706d5636c523d2381d5922116bfb3e8bdf7b412fe68cd3459b37f31b01aa81c21f66dd975a223e
+  metadata.gz: 79fcb5642c2db96be5a6c8cd51f085a655a3124b90b4b2445cfcb0329090f55ce20272d7042641587cc040197623c03bc31dc3b485f1f8b06bd43269a3759bd3
+  data.tar.gz: 86442fbe3369bb0cdc7ee538b92e4b206863a26adc2da9b0033df3f06271ffb02625be03d3fffa7a51cc60cc35a006a711d66b8e706a47feeaf79a07d7f5e3e3

data/CHANGELOG.rdoc

@@ -1,3 +1,9 @@
+=== 0.9.5.1 / 2014-01-30
+
+* Features
+
+  * Adds homepage for Bower, NPM, and PIP packages
+
 === 0.9.5 / 2014-01-30
 
 * Features
@@ -5,7 +11,7 @@
   * Add more aliases for known licenses
   * Drop support for ruby 1.9.2
   * Large refactoring to simply things, and make it easier to add new package managers
-  
+
 * Bugfixes
 
   * Make node dependency json parsing more robust

data/lib/license_finder.rb

@@ -17,15 +17,15 @@ module LicenseFinder
   autoload :Configuration,        'license_finder/configuration'
   autoload :Platform,             'license_finder/platform'
 
-  autoload :Bower,                'license_finder/bower'
-  autoload :Bundler,              'license_finder/bundler'
-  autoload :NPM,                  'license_finder/npm'
-  autoload :Pip,                  'license_finder/pip'
   autoload :Package,              'license_finder/package'
-  autoload :BowerPackage,         'license_finder/bower_package'
-  autoload :BundlerPackage,       'license_finder/bundler_package'
-  autoload :PipPackage,           'license_finder/pip_package'
-  autoload :NpmPackage,           'license_finder/npm_package'
+  autoload :Bower,                'license_finder/package_managers/bower'
+  autoload :Bundler,              'license_finder/package_managers/bundler'
+  autoload :NPM,                  'license_finder/package_managers/npm'
+  autoload :Pip,                  'license_finder/package_managers/pip'
+  autoload :BowerPackage,         'license_finder/package_managers/bower_package'
+  autoload :BundlerPackage,       'license_finder/package_managers/bundler_package'
+  autoload :PipPackage,           'license_finder/package_managers/pip_package'
+  autoload :NpmPackage,           'license_finder/package_managers/npm_package'
 
   autoload :BundlerGroup,         'license_finder/tables/bundler_group'
   autoload :Dependency,           'license_finder/tables/dependency'

data/lib/license_finder/{bower_package.rb → package_managers/bower_package.rb}

@@ -21,6 +21,10 @@ module LicenseFinder
       module_metadata.fetch("readme", nil)
     end
 
+    def homepage
+      module_metadata.fetch("homepage", nil)
+    end
+
     def children
       [] # no way to determine child deps from bower (maybe?)
     end
@@ -29,10 +33,6 @@ module LicenseFinder
       [] # no concept of dev/test groups in bower (maybe?)
     end
 
-    def homepage
-      nil # no way to extract homepage from bower (maybe?)
-    end
-
     private
 
     attr_reader :bower_module

data/lib/license_finder/{npm_package.rb → package_managers/npm_package.rb}

@@ -20,6 +20,10 @@ module LicenseFinder
       node_module["readme"]
     end
 
+    def homepage
+      node_module["homepage"]
+    end
+
     def children
       [] # no way to determine child deps from npm (maybe?)
     end
@@ -28,10 +32,6 @@ module LicenseFinder
       [] # no concept of dev/test groups in npm (maybe?)
     end
 
-    def homepage
-      nil # no way to extract homepage from npm (maybe?)
-    end
-
     private
 
     attr_reader :node_module

data/lib/license_finder/{pip_package.rb → package_managers/pip_package.rb}

@@ -17,6 +17,10 @@ module LicenseFinder
       pypi_def.fetch("description", "")
     end
 
+    def homepage
+      pypi_def["home_page"]
+    end
+
     def children
       [] # no way to determine child deps from pip (maybe?)
     end
@@ -25,10 +29,6 @@ module LicenseFinder
       [] # no concept of dev/test groups in pip (maybe?)
     end
 
-    def homepage
-      nil # no way to extract homepage from pip (maybe?)
-    end
-
     private
 
     attr_reader :install_path, :pypi_def

data/lib/license_finder/possible_license_file.rb

@@ -5,14 +5,12 @@ module LicenseFinder
       @file_path = Pathname.new(file_path)
     end
 
+    # Unused, except in tests, but might be useful if LF ever reports the
+    # locations of all the files it searched.
     def file_path
       @file_path.relative_path_from(@install_path).to_s
     end
 
-    def file_name
-      @file_path.basename.to_s
-    end
-
     def text
       @text ||= @file_path.send(@file_path.respond_to?(:binread) ? :binread : :read)
     end

data/license_finder.gemspec

@@ -3,7 +3,7 @@ require './lib/license_finder/platform'
 Gem::Specification.new do |s|
   s.required_ruby_version = '>= 1.9.3'
   s.name        = "license_finder"
-  s.version     = "0.9.5"
+  s.version     = "0.9.5.1"
   s.authors     = ["Jacob Maine", "Matthew Kane Parker", "Ian Lesperance", "David Edwards", "Paul Meskers", "Brent Wheeldon", "Trevor John", "David Tengdin", "William Ramsey"]
   s.email       = ["licensefinder@pivotalabs.com"]
   s.homepage    = "https://github.com/pivotal/LicenseFinder"

data/spec/lib/license_finder/{bower_package_spec.rb → package_managers/bower_package_spec.rb}

@@ -10,7 +10,8 @@ module LicenseFinder
           "description" => "description",
           "version" => "1.3.3.7",
           "main" => "normalize.css",
-          "readme" => "some readme stuff"
+          "readme" => "some readme stuff",
+          "homepage" => "homepage"
         }
       )
     end
@@ -21,6 +22,9 @@ module LicenseFinder
     its(:version) { should == "1.3.3.7" }
     its(:summary) { should == "description" }
     its(:description) { should == "some readme stuff" }
+    its(:homepage) { should == "homepage" }
+    its(:groups) { should == [] }
+    its(:children) { should == [] }
 
     describe '#license' do
       def stub_license_files(license_files)

data/spec/lib/license_finder/{bundler_package_spec.rb → package_managers/bundler_package_spec.rb}

@@ -22,6 +22,7 @@ module LicenseFinder
     its(:version) { should == '2.1.3' }
     its(:summary) { should == "summary" }
     its(:description) { should == "description" }
+    its(:homepage) { should == "homepage" }
     its(:groups) { should == [] }
     its(:children) { should == [] }
 
@@ -31,11 +32,17 @@ module LicenseFinder
       end
 
       it "returns the license from the gemspec if provided" do
-        gemspec.stub(:license).and_return('Gemspec License')
+        gemspec.license = 'Gemspec License'
 
         subject.license.should == "Gemspec License"
       end
 
+      it "returns the first license if the gemspec provides many" do
+        gemspec.licenses = ['First Gemspec License', 'Second Gemspec License']
+
+        subject.license.should == "First Gemspec License"
+      end
+
       it "returns a license in a file if detected" do
         stub_license_files [double(:file, license: 'Detected License')]
 

data/spec/lib/license_finder/{npm_package_spec.rb → package_managers/npm_package_spec.rb}

@@ -8,7 +8,8 @@ module LicenseFinder
         "version" => "1.3.1",
         "description" => "a description",
         "readme" => "a readme",
-        "path" => "some/node/package/path"
+        "path" => "some/node/package/path",
+        "homepage" => "a homepage"
       )
     end
 
@@ -18,6 +19,9 @@ module LicenseFinder
     its(:version) { should == "1.3.1" }
     its(:summary) { should == "a description" }
     its(:description) { should == "a readme" }
+    its(:homepage) { should == "a homepage" }
+    its(:groups) { should == [] }
+    its(:children) { should == [] }
 
     describe '#license' do
       def stub_license_files(license_files)

data/spec/lib/license_finder/{pip_package_spec.rb → package_managers/pip_package_spec.rb}

@@ -12,6 +12,9 @@ module LicenseFinder
 
     its(:name) { should == "jasmine" }
     its(:version) { should == "1.3.1" }
+    its(:homepage) { should == nil }
+    its(:groups) { should == [] }
+    its(:children) { should == [] }
 
     describe "#summary" do
       it "delegates to pypi def" do
@@ -35,6 +38,17 @@ module LicenseFinder
       end
     end
 
+    describe "#homepage" do
+      it "delegates to pypi def" do
+        subject = make_package("home_page" => "A homepage")
+        expect(subject.homepage).to eq("A homepage")
+      end
+
+      it "falls back to nothing" do
+        expect(subject.homepage).to be_nil
+      end
+    end
+
     describe '#license' do
       describe "with pypi license" do
         it "returns the license from 'license' preferentially" do

data/spec/lib/license_finder/possible_license_file_spec.rb

@@ -10,7 +10,6 @@ describe LicenseFinder::PossibleLicenseFile do
       end
 
       its(:file_path) { should == 'nested/path' }
-      its(:file_name) { should == 'path' }
       its(:text) { should == 'file text' }
     end
   end

data/spec/lib/license_finder/possible_license_files_spec.rb

@@ -15,29 +15,27 @@ module LicenseFinder
       it "includes files with names like LICENSE, License or COPYING" do
         subject = described_class.new(fixture_path('license_names'))
 
-        subject.find.map(&:file_name).should =~
+        subject.find.map(&:file_path).should =~
         %w[COPYING.txt LICENSE Mit-License README.rdoc Licence.rdoc]
       end
 
       it "includes files deep in the hierarchy" do
         subject = described_class.new(fixture_path('nested_gem'))
 
-        subject.find.map { |f| [f.file_name, f.file_path] }.should =~ [
-          %w[LICENSE vendor/LICENSE]
-        ]
+        subject.find.map(&:file_path).should =~ %w[vendor/LICENSE]
       end
 
       it "includes both files nested inside LICENSE directory and top level files" do
         subject = described_class.new(fixture_path('license_directory'))
         found_license_files = subject.find
 
-        found_license_files.map { |f| [f.file_name, f.file_path] }.should =~ [
-          %w[BSD-2-Clause.txt LICENSE/BSD-2-Clause.txt],
-          %w[GPL-2.0.txt LICENSE/GPL-2.0.txt],
-          %w[MIT.txt LICENSE/MIT.txt],
-          %w[RUBY.txt LICENSE/RUBY.txt],
-          %w[COPYING COPYING],
-          %w[LICENSE LICENSE/LICENSE]
+        found_license_files.map(&:file_path).should =~ %w[
+          LICENSE/BSD-2-Clause.txt
+          LICENSE/GPL-2.0.txt
+          LICENSE/MIT.txt
+          LICENSE/RUBY.txt
+          COPYING
+          LICENSE/LICENSE
         ]
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.5.1
 platform: ruby
 authors:
 - Jacob Maine
@@ -277,10 +277,6 @@ files:
 - lib/data/licenses/Ruby.txt
 - lib/data/licenses/SimplifiedBSD.txt
 - lib/license_finder.rb
-- lib/license_finder/bower.rb
-- lib/license_finder/bower_package.rb
-- lib/license_finder/bundler.rb
-- lib/license_finder/bundler_package.rb
 - lib/license_finder/cli.rb
 - lib/license_finder/configuration.rb
 - lib/license_finder/dependency_manager.rb
@@ -296,12 +292,16 @@ files:
 - lib/license_finder/license/ruby.rb
 - lib/license_finder/license/simplified_bsd.rb
 - lib/license_finder/license_url.rb
-- lib/license_finder/npm.rb
-- lib/license_finder/npm_package.rb
 - lib/license_finder/package.rb
+- lib/license_finder/package_managers/bower.rb
+- lib/license_finder/package_managers/bower_package.rb
+- lib/license_finder/package_managers/bundler.rb
+- lib/license_finder/package_managers/bundler_package.rb
+- lib/license_finder/package_managers/npm.rb
+- lib/license_finder/package_managers/npm_package.rb
+- lib/license_finder/package_managers/pip.rb
+- lib/license_finder/package_managers/pip_package.rb
 - lib/license_finder/package_saver.rb
-- lib/license_finder/pip.rb
-- lib/license_finder/pip_package.rb
 - lib/license_finder/platform.rb
 - lib/license_finder/possible_license_file.rb
 - lib/license_finder/possible_license_files.rb
@@ -351,10 +351,6 @@ files:
 - spec/fixtures/readme/README
 - spec/fixtures/readme/Readme.markdown
 - spec/fixtures/utf8_gem/README
-- spec/lib/license_finder/bower_package_spec.rb
-- spec/lib/license_finder/bower_spec.rb
-- spec/lib/license_finder/bundler_package_spec.rb
-- spec/lib/license_finder/bundler_spec.rb
 - spec/lib/license_finder/cli_spec.rb
 - spec/lib/license_finder/configuration_spec.rb
 - spec/lib/license_finder/dependency_manager_spec.rb
@@ -373,11 +369,15 @@ files:
 - spec/lib/license_finder/license_spec.rb
 - spec/lib/license_finder/license_url_spec.rb
 - spec/lib/license_finder/markdown_report_spec.rb
-- spec/lib/license_finder/npm_package_spec.rb
-- spec/lib/license_finder/npm_spec.rb
+- spec/lib/license_finder/package_managers/bower_package_spec.rb
+- spec/lib/license_finder/package_managers/bower_spec.rb
+- spec/lib/license_finder/package_managers/bundler_package_spec.rb
+- spec/lib/license_finder/package_managers/bundler_spec.rb
+- spec/lib/license_finder/package_managers/npm_package_spec.rb
+- spec/lib/license_finder/package_managers/npm_spec.rb
+- spec/lib/license_finder/package_managers/pip_package_spec.rb
+- spec/lib/license_finder/package_managers/pip_spec.rb
 - spec/lib/license_finder/package_saver_spec.rb
-- spec/lib/license_finder/pip_package_spec.rb
-- spec/lib/license_finder/pip_spec.rb
 - spec/lib/license_finder/possible_license_file_spec.rb
 - spec/lib/license_finder/possible_license_files_spec.rb
 - spec/lib/license_finder/reporter_spec.rb
@@ -464,10 +464,6 @@ test_files:
 - spec/fixtures/readme/README
 - spec/fixtures/readme/Readme.markdown
 - spec/fixtures/utf8_gem/README
-- spec/lib/license_finder/bower_package_spec.rb
-- spec/lib/license_finder/bower_spec.rb
-- spec/lib/license_finder/bundler_package_spec.rb
-- spec/lib/license_finder/bundler_spec.rb
 - spec/lib/license_finder/cli_spec.rb
 - spec/lib/license_finder/configuration_spec.rb
 - spec/lib/license_finder/dependency_manager_spec.rb
@@ -486,11 +482,15 @@ test_files:
 - spec/lib/license_finder/license_spec.rb
 - spec/lib/license_finder/license_url_spec.rb
 - spec/lib/license_finder/markdown_report_spec.rb
-- spec/lib/license_finder/npm_package_spec.rb
-- spec/lib/license_finder/npm_spec.rb
+- spec/lib/license_finder/package_managers/bower_package_spec.rb
+- spec/lib/license_finder/package_managers/bower_spec.rb
+- spec/lib/license_finder/package_managers/bundler_package_spec.rb
+- spec/lib/license_finder/package_managers/bundler_spec.rb
+- spec/lib/license_finder/package_managers/npm_package_spec.rb
+- spec/lib/license_finder/package_managers/npm_spec.rb
+- spec/lib/license_finder/package_managers/pip_package_spec.rb
+- spec/lib/license_finder/package_managers/pip_spec.rb
 - spec/lib/license_finder/package_saver_spec.rb
-- spec/lib/license_finder/pip_package_spec.rb
-- spec/lib/license_finder/pip_spec.rb
 - spec/lib/license_finder/possible_license_file_spec.rb
 - spec/lib/license_finder/possible_license_files_spec.rb
 - spec/lib/license_finder/reporter_spec.rb