license_finder 0.9.0 → 0.9.1

data/spec/lib/license_finder/bundle_spec.rb

@@ -5,7 +5,7 @@ module LicenseFinder
     let(:definition) do
       double('definition', {
         :dependencies => [],
-        :groups => [],
+        :groups => [:dev, :production],
         :specs_for => [
           build_gemspec('gem1', '1.2.3'),
           build_gemspec('gem2', '0.4.2')
@@ -28,7 +28,13 @@ module LicenseFinder
 
     describe '.current_gems' do
       subject do
-        Bundle.current_gems(definition)
+        Bundle.current_gems(config)
+      end
+
+      let(:config) { double(:config, ignore_groups: ['dev', 'test']) }
+
+      before do
+        Bundler::Definition.stub(:build).and_return(definition)
       end
 
       it "should have 2 dependencies" do
@@ -37,9 +43,9 @@ module LicenseFinder
 
       context "when initialized with a parent and child gem" do
         before do
-          definition.stub(:specs_for).and_return([
+          definition.stub(:specs_for).with([:production]).and_return([
             build_gemspec('gem1', '1.2.3', 'gem2'),
-            build_gemspec('gem2', '0.4.2')
+            build_gemspec('gem2', '0.4.2', 'gem3')
           ])
         end
 
@@ -48,6 +54,12 @@ module LicenseFinder
 
           gem1.children.should == ["gem2"]
         end
+
+        it "should only include the children which are project dependencies" do
+          gem2 = subject[1]
+
+          gem2.children.should == []
+        end
       end
     end
   end

data/spec/lib/license_finder/bundled_gem_saver_spec.rb

@@ -14,9 +14,22 @@ module LicenseFinder
       end
     end
 
+    describe ".save_gems" do
+      let(:bundled_gems) { [gem] }
+      let(:gem) { double(:bundled_gem) }
+
+      it "calls find_or_create_by_name on all passed in gems" do
+        described_class.should_receive(:find_or_create_by_name).with(gem).and_return(gem)
+        gem.should_receive(:save)
+        described_class.save_gems(bundled_gems)
+      end
+    end
+
     describe "#save" do
       let(:bundled_gem) { BundledGem.new(gemspec) }
-      subject { described_class.find_or_create_by_name('spec_name', bundled_gem).save }
+      subject { described_class.find_or_create_by_name(bundled_gem).save }
+
+      before { bundled_gem.children = ["foo"] }
 
       context "when the dependency is new" do
         it "persists gem data" do
@@ -29,20 +42,9 @@ module LicenseFinder
         end
 
         describe "associating children" do
-          context "when the child is in Bundler's current gems" do
-            before { LicenseFinder.stub(:current_gems).and_return([double(:gemspec, name: "foo 0.0")]) }
-
-            it "associates children" do
-              subject.children.map(&:name).should == ['foo']
-              subject.children.each { |child| child.id.should_not be_nil }
-            end
-          end
-
-          context "when the child is not in Bundler's current gems" do
-            it "does not associates children" do
-              subject.children.map(&:name).should == []
-              subject.children.each { |child| child.id.should be_nil }
-            end
+          it "associates children" do
+            subject.children.map(&:name).should == ['foo']
+            subject.children.each { |child| child.id.should_not be_nil }
           end
         end
 
@@ -76,7 +78,7 @@ module LicenseFinder
               license: license
             )
           end
-          let(:bundled_gem_saver) { described_class.find_or_create_by_name('spec_name', bundled_gem) }
+          let(:bundled_gem_saver) { described_class.find_or_create_by_name(bundled_gem) }
 
           it "does not save the dependency" do
             bundled_gem_saver.dependency.should_not_receive(:save)
@@ -107,7 +109,8 @@ module LicenseFinder
           end
 
           it "keeps a manually assigned license" do
-            old_copy.license = LicenseAlias.create(name: 'foo', manual: true)
+            old_copy.license = LicenseAlias.create(name: 'foo')
+            old_copy.license_manual = true
             old_copy.save
             subject.license.name.should == 'foo'
           end
@@ -115,7 +118,12 @@ module LicenseFinder
           it "keeps approval" do
             old_copy.approval = Approval.create(state: true)
             old_copy.save
-            subject.approval.state.should == true
+            subject.approval.state.should
+            if LicenseFinder::Platform.java?
+              subject.approval.state.should == 1
+            else
+              subject.approval.state.should == true
+            end
           end
 
           it "ensures correct children are associated" do
@@ -126,19 +134,20 @@ module LicenseFinder
           end
 
           context "with a bundler dependency" do
-            let(:bundled_gem) { BundledGem.new(gemspec, double(:bundler_dependency, groups: %w[1 2 3]))}
+            let(:bundled_gem) { BundledGem.new(gemspec, double(:bundler_dependency)) }
 
             before do
+              bundled_gem.stub(:groups) { [:group_1, :group_2, :b] }
               old_copy.add_bundler_group BundlerGroup.find_or_create(name: 'a')
               old_copy.add_bundler_group BundlerGroup.find_or_create(name: 'b')
             end
 
             it "ensures the correct bundler groups are associated" do
-              subject.bundler_groups.map(&:name).should =~ %w[1 2 3]
+              subject.bundler_groups.map(&:name).should =~ %w[group_1 group_2 b]
             end
           end
 
-          context "license changes to something other than 'other'" do
+          context "license has changed" do
             before do
               old_copy.license = LicenseAlias.create(name: 'other')
               old_copy.save
@@ -158,27 +167,17 @@ module LicenseFinder
                 subject.should_not be_approved
               end
             end
-          end
 
-          context "license changes to unknown (i.e., 'other')" do
-            before do
-              old_copy.license = LicenseAlias.create(name: 'MIT')
-              old_copy.approval = Approval.create(state: false)
-              old_copy.save
-              gemspec.license = "other"
-            end
-
-            it "should not change the license" do
-              subject.license.name.should == 'MIT'
-            end
-
-            it "should not change the approval" do
-              subject.should_not be_approved
+            context "license already exists" do
+              it "uses the existing license" do
+                new_license = LicenseAlias.create(name: 'new license')
+                subject.license.should == new_license
+              end
             end
           end
 
           context "license does not change" do
-            let(:bundled_gem_saver) { described_class.find_or_create_by_name('spec_name', bundled_gem) }
+            let(:bundled_gem_saver) { described_class.find_or_create_by_name(bundled_gem) }
 
             before do
               old_copy.license = LicenseAlias.create(name: 'MIT')
@@ -189,7 +188,11 @@ module LicenseFinder
 
             it "should not change the license or approval" do
               dependency = bundled_gem_saver.save
-              dependency.should_not be_approved
+              if LicenseFinder::Platform.java?
+                dependency.approved?.should_not == 1
+              else
+                dependency.should_not be_approved
+              end
               dependency.license.name.should == "MIT"
             end
 

data/spec/lib/license_finder/bundled_gem_spec.rb

@@ -24,7 +24,7 @@ module LicenseFinder
     its(:dependency_name) { should == 'spec_name' }
     its(:dependency_version) { should == '2.1.3' }
 
-    describe "#determine_license" do
+    describe "#license" do
       subject do
         details = BundledGem.new(gemspec)
         details.stub(:license_files).and_return([license_file])
@@ -36,19 +36,19 @@ module LicenseFinder
       it "returns the license from the gemspec if provided" do
         gemspec.stub(:license).and_return('Some License')
 
-        subject.determine_license.should == "Some License"
+        subject.license.should == "Some License"
       end
 
       it "returns the matched license if detected" do
         license_file.stub(:license).and_return('Detected License')
 
-        subject.determine_license.should == "Detected License"
+        subject.license.should == "Detected License"
       end
 
       it "returns 'other' otherwise" do
         license_file.stub(:license).and_return(nil)
 
-        subject.determine_license.should == "other"
+        subject.license.should == "other"
       end
     end
 
@@ -58,5 +58,23 @@ module LicenseFinder
         subject.license_files
       end
     end
+
+    describe "#groups" do
+      context "bundler_dependency is present" do
+        subject { described_class.new(gemspec, bundler_dependency) }
+
+        let(:bundler_dependency) { double(:dependency, groups: [1, 2, 3]) }
+
+        it "returns bundler dependency's groups" do
+          subject.groups.should == bundler_dependency.groups
+        end
+      end
+
+      context "bundler_dependency is nil" do
+        it "returns empty array" do
+          subject.groups.should == []
+        end
+      end
+    end
   end
 end

data/spec/lib/license_finder/cli_spec.rb

@@ -57,6 +57,7 @@ module LicenseFinder
         it "adds the specified license to the whitelist" do
           config.whitelist.should_receive(:push).with("test")
           config.should_receive(:save)
+          Reporter.should_receive(:write_reports)
 
           silence_stdout do
             subject.add("test")
@@ -68,6 +69,7 @@ module LicenseFinder
         it "removes the specified license from the whitelist" do
           config.should_receive(:save)
           config.whitelist.should_receive(:delete).with("test")
+          Reporter.should_receive(:write_reports)
 
           silence_stdout do
             subject.remove("test")
@@ -76,6 +78,24 @@ module LicenseFinder
       end
     end
 
+    describe ProjectName do
+      let(:config) { LicenseFinder.config }
+
+      describe "set" do
+        it "sets the project name" do
+          config.should_receive(:save)
+          config.project_name.should_not eq("new_project_name")
+          Reporter.should_receive(:write_reports)
+
+          silence_stdout do
+            subject.set("new_project_name")
+          end
+
+          config.project_name.should eq("new_project_name")
+        end
+      end
+    end
+
     describe IgnoredBundlerGroups do
       let(:config) { LicenseFinder.config }
 
@@ -93,6 +113,7 @@ module LicenseFinder
         it "adds the specified group to the ignored groups list" do
           config.ignore_groups.should_receive(:push).with("test")
           config.should_receive(:save)
+          Reporter.should_receive(:write_reports)
 
           silence_stdout do
             subject.add("test")
@@ -104,6 +125,7 @@ module LicenseFinder
         it "removes the specified group from the ignored groups list" do
           config.ignore_groups.should_receive(:delete).with("test")
           config.should_receive(:save)
+          Reporter.should_receive(:write_reports)
 
           silence_stdout do
             subject.remove("test")

data/spec/lib/license_finder/configuration_spec.rb

@@ -11,7 +11,8 @@ module LicenseFinder
         {
           "whitelist" => ["FooLicense", "BarLicense"],
           "ignore_groups" => [:test, :development],
-          "dependencies_file_dir" => "."
+          "dependencies_file_dir" => ".",
+          "project_name" => "my_app"
         }
       end
 
@@ -22,6 +23,7 @@ module LicenseFinder
           subject.whitelist.should == attributes['whitelist']
           subject.ignore_groups.should == attributes['ignore_groups']
           subject.dependencies_dir.should == attributes['dependencies_file_dir']
+          subject.project_name.should == attributes['project_name']
         end
       end
     end
@@ -39,6 +41,19 @@ module LicenseFinder
       end
     end
 
+    describe "#project_name" do
+      let(:directory_name) { "test_dir" }
+
+      before do
+        Configuration.stub(:config_hash).and_return({})
+        Dir.stub(:getwd).and_return("/path/to/#{directory_name}")
+      end
+
+      it "should default to the directory name" do
+        klass.new.project_name.should == directory_name
+      end
+    end
+
     describe "whitelisted?" do
       context "canonical name whitelisted" do
         before { config.whitelist = [License::Apache2.names[rand(License::Apache2.names.count)]]}
@@ -61,32 +76,39 @@ module LicenseFinder
 
     describe "#save" do
       let(:tmp_yml) { '.tmp.configuration_spec.yml' }
+      let(:yaml) { YAML.load(File.read(tmp_yml)) }
 
       before do
         Configuration.stub(:config_file_path).and_return(tmp_yml)
         config.whitelist = ['my_gem']
         config.ignore_groups = ['other_group', 'test']
+        config.project_name = "New Project Name"
+        config.dependencies_dir = "./deps"
       end
 
       after do
         File.delete(tmp_yml)
       end
 
-      it "writes the whitelist to the yaml file" do
-        config.save
-
-        yaml = YAML.load(File.read(tmp_yml))
+      describe "writes the configuration attributes to the yaml file" do
+        before { config.save }
 
-        yaml["whitelist"].should include("my_gem")
-      end
+        it "writes the whitelist" do
+          yaml["whitelist"].should include("my_gem")
+        end
 
-      it "writes the ignored bundler groups to the yaml file" do
-        config.save
+        it "writes the ignored bundler groups" do
+          yaml["ignore_groups"].should include("other_group")
+          yaml["ignore_groups"].should include("test")
+        end
 
-        yaml = YAML.load(File.read(tmp_yml))
+        it "writes the dependencies_dir" do
+          yaml["dependencies_file_dir"].should eq("./deps")
+        end
 
-        yaml["ignore_groups"].should include("other_group")
-        yaml["ignore_groups"].should include("test")
+        it "writes the project name" do
+          yaml["project_name"].should eq("New Project Name")
+        end
       end
 
       it "doesn't write duplicate entries" do
@@ -95,8 +117,6 @@ module LicenseFinder
 
         config.save
 
-        yaml = YAML.load(File.read(tmp_yml))
-
         yaml["whitelist"].count("my_gem").should == 1
         yaml["ignore_groups"].count("test").should == 1
       end

data/spec/lib/license_finder/dependency_manager_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'digest'
 
 module LicenseFinder
   describe DependencyManager do
@@ -11,6 +12,9 @@ module LicenseFinder
     end
 
     describe "#sync_with_bundler" do
+      let(:gem1) { double(:bundled_gem) }
+      let(:gem2) { double(:bundled_gem) }
+
       it "destroys every dependency except for the ones Bundler reports as 'current' or are marked as 'manual'" do
         cur1 = Dependency.create(name: "current dependency 1")
         cur2 = Dependency.create(name: "current dependency 2")
@@ -18,11 +22,9 @@ module LicenseFinder
         Dependency.create(name: "old dependency 1")
         Dependency.create(name: "old dependency 2")
 
-        current_gems = [
-          double(:gem1, save_as_dependency: cur1),
-          double(:gem2, save_as_dependency: cur2)
-        ]
-        LicenseFinder.stub(:current_gems) { current_gems }
+        current_gems = [gem1, gem2]
+        Bundle.stub(:current_gems).with(config) { current_gems }
+        BundledGemSaver.should_receive(:save_gems).with(current_gems).and_return([cur1, cur2])
 
         described_class.sync_with_bundler
         Dependency.all.map(&:name).should =~ [cur1, cur2, man1].map(&:name)
@@ -89,11 +91,12 @@ module LicenseFinder
     end
 
     describe ".license!" do
+      let(:dependency) { double(:dependency) }
+
       it "adds a license for the dependency" do
-        dep = described_class.create_non_bundler("old license", "current dependency", nil)
-        dep.reload.license.name.should == "old license"
-        described_class.license!("current dependency", "a license")
-        dep.reload.license.name.should == "a license"
+        DependencyManager.stub(:find_by_name).with("dependency").and_return(dependency)
+        dependency.should_receive(:set_license_manually!).with("MIT")
+        described_class.license!("dependency", "MIT")
       end
 
       it "should raise an error if it can't find the dependency" do
@@ -102,6 +105,54 @@ module LicenseFinder
       end
     end
 
+    describe ".modifying" do
+      context "when the database doesn't exist" do
+        before { File.stub(:exists?) { false } }
+
+        it "writes reports" do
+          Reporter.should_receive(:write_reports)
+          DependencyManager.modifying {}
+        end
+      end
+
+      context "when the database exists" do
+        before { File.stub(:exists?) { true } }
+
+        context "when the database has changed" do
+          before do
+            i = 0
+            Digest::SHA2.stub_chain(:file, :hexdigest) { i += 1 }
+          end
+
+          it "writes reports" do
+            Reporter.should_receive(:write_reports)
+            DependencyManager.modifying {}
+          end
+        end
+
+        context "when the database has not changed" do
+          before do
+            Digest::SHA2.stub_chain(:file, :hexdigest) { 5 }
+          end
+
+          it "does not write reports" do
+            Reporter.should_not_receive(:write_reports)
+            DependencyManager.modifying {}
+          end
+        end
+
+        context "when the reports do not exist" do
+          before do
+            Digest::SHA2.stub_chain(:file, :hexdigest) { 5 }
+            File.stub(:exists?).with(LicenseFinder.config.dependencies_html) { false }
+          end
+
+          it "writes reports" do
+            Reporter.should_receive(:write_reports)
+            DependencyManager.modifying {}
+          end
+        end
+      end
+    end
   end
 end
-