license_finder 0.7.3 → 0.8.0

data/spec/lib/license_finder/text_report_spec.rb

@@ -4,19 +4,21 @@ module LicenseFinder
   describe TextReport do
     describe '#to_s' do
       let(:dep1) do
-        Dependency.new(
+        dependency = Dependency.new(
           'name' => 'gem_a',
           'version' => '1.0',
-          'license' => "MIT"
         )
+        dependency.license = LicenseFinder::LicenseAlias.create(name: 'MIT')
+        dependency
       end
 
       let(:dep2) do
-        Dependency.new(
+        dependency = Dependency.new(
           'name' => 'gem_b',
           'version' => '1.0',
-          'license' => "MIT"
         )
+        dependency.license = LicenseFinder::LicenseAlias.create(name: 'MIT')
+        dependency
       end
 
       subject { TextReport.new([dep2, dep1]).to_s }

data/spec/lib/license_finder/yml_to_sql_spec.rb

@@ -0,0 +1,99 @@
+require "spec_helper"
+
+describe LicenseFinder::YmlToSql do
+  let(:legacy_attributes) do
+    {
+      'name' => "spec_name",
+      'version' => "2.1.3",
+      'license' => "GPLv2",
+      'license_url' => "www.license_url.org",
+      'approved' => true,
+      'manual' => true,
+      'summary' => "some summary",
+      'description' => "some description",
+      'homepage' => 'www.homepage.com',
+      'children' => ["child1_name"],
+      'parents' => ["parent1_name"],
+      'bundler_groups' => [:test],
+
+      'notes' => 'some notes',
+      'license_files' => ['/Users/pivotal/foo/lic1', '/Users/pivotal/bar/lic2'],
+    }
+  end
+  let(:config) { LicenseFinder::Configuration.new }
+
+  before do
+    LicenseFinder.stub(:config) { config }
+  end
+
+  describe ".needs_conversion?" do
+    it "is true if the yml still exists" do
+      config.stub(dependencies_dir: 'path/to')
+      File.should_receive(:exists?).with('path/to/dependencies.yml') { true }
+      described_class.needs_conversion?.should be_true
+    end
+
+    it "is false otherwise" do
+      config.stub(dependencies_dir: 'path/to')
+      File.should_receive(:exists?).with('path/to/dependencies.yml') { false }
+      described_class.needs_conversion?.should be_false
+    end
+  end
+
+  describe ".remove_yml" do
+    it "removes the yml file" do
+      config.stub(dependencies_dir: 'path/to')
+      File.should_receive(:delete).with('path/to/dependencies.yml')
+      described_class.remove_yml
+    end
+  end
+
+  describe '.convert_all' do
+    before do
+      (DB.tables - [:schema_migrations]).each { |table| DB[table].truncate }
+    end
+
+    it "persists all of the dependency's attributes" do
+      described_class.convert_all([legacy_attributes])
+
+      described_class::Sql::Dependency.count.should == 1
+      saved_dep = described_class::Sql::Dependency.first
+      saved_dep.name.should == "spec_name"
+      saved_dep.version.should == "2.1.3"
+      saved_dep.summary.should == "some summary"
+      saved_dep.description.should == "some description"
+      saved_dep.homepage.should == "www.homepage.com"
+    end
+
+    it "associates the license to the dependency" do
+      described_class.convert_all([legacy_attributes])
+
+      saved_dep = described_class::Sql::Dependency.first
+      saved_dep.license.name.should == "GPLv2"
+      saved_dep.license.url.should == "www.license_url.org"
+      saved_dep.license.manual.should == true
+    end
+
+    it "associates bundler groups" do
+      described_class.convert_all([legacy_attributes])
+
+      saved_dep = described_class::Sql::Dependency.first
+      saved_dep.bundler_groups.count.should == 1
+      saved_dep.bundler_groups.first.name.should == 'test'
+    end
+
+    it "associates children" do
+      child_attrs = {
+        'name' => 'child1_name',
+        'version' => '0.0.1',
+        'license' => 'other'
+      }
+      described_class.convert_all([legacy_attributes, child_attrs])
+
+      described_class::Sql::Dependency.count.should == 2
+      saved_dep = described_class::Sql::Dependency.first(name: 'spec_name')
+      saved_dep.children.count.should == 1
+      saved_dep.children.first.name.should == 'child1_name'
+    end
+  end
+end

data/spec/lib/license_finder_spec.rb

@@ -25,7 +25,7 @@ describe LicenseFinder do
 
       LicenseFinder.config.whitelist.should == []
       LicenseFinder.config.ignore_groups.should == []
-      LicenseFinder.config.dependencies_dir.should == '.'
+      LicenseFinder.config.dependencies_dir.should == './doc/'
     end
 
     it "should load the configuration exactly once" do
@@ -72,10 +72,10 @@ describe LicenseFinder do
 
       it 'should default the dependency files when the directory is not provided' do
         config = LicenseFinder.config
-        config.dependencies_dir.should == '.'
-        config.dependencies_yaml.should == './dependencies.yml'
-        config.dependencies_text.should == './dependencies.txt'
-        config.dependencies_html.should == './dependencies.html'
+        config.dependencies_dir.should == './doc/'
+        config.dependencies_yaml.should == './doc/dependencies.yml'
+        config.dependencies_text.should == './doc/dependencies.txt'
+        config.dependencies_html.should == './doc/dependencies.html'
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'rubygems'
 require 'bundler/setup'
-require 'pry'
 
 require 'license_finder'
 
@@ -13,3 +12,20 @@ end
 RSpec.configure do |config|
   config.mock_with :rspec
 end
+
+require 'database_cleaner'
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with(:truncation, except: [:schema_migrations])
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.8.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,10 +10,12 @@ authors:
 - Ian Lesperance
 - David Edwards
 - Paul Meskers
+- Brent Wheeldon
+- David Tengdin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-18 00:00:00.000000000 Z
+date: 2013-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -32,14 +34,14 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: sequel
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -48,7 +50,23 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -64,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: cucumber
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -80,7 +98,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: xpath
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -96,7 +114,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: capybara
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -112,7 +130,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: xpath
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -128,7 +146,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: capybara
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -143,12 +161,28 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.2.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.2.0
 description: ! "  Do you know the licenses of all your application's dependencies?
   What open source software licenses will your business accept?\n\n  LicenseFinder
   culls your Gemfile, detects the licenses of the gems in it, and gives you a report
-  that you can act on. If you already know \n  what licenses your business is comfortable
+  that you can act on. If you already know\n  what licenses your business is comfortable
   with, you can whitelist them, leaving you with an action report of only those dependencies
-  that have \n  licenses that fall outside of the whitelist.\n"
+  that have\n  licenses that fall outside of the whitelist.\n"
 email:
 - licensefinder@pivotalabs.com
 executables:
@@ -163,6 +197,15 @@ files:
 - LICENSE
 - Rakefile
 - bin/license_finder
+- db/migrate/201303290935_create_dependencies.rb
+- db/migrate/201303291155_create_licenses.rb
+- db/migrate/201303291402_create_approvals.rb
+- db/migrate/201303291456_create_ancestries.rb
+- db/migrate/201303291519_create_bundler_groups.rb
+- db/migrate/201303291720_move_manual_from_approvals_to_licenses.rb
+- db/migrate/201303291753_allow_null_license_names.rb
+- db/migrate/201304011027_allow_null_dependency_version.rb
+- db/migrate/201304020947_change_table_name_licenses_to_license_aliases.rb
 - features/approve_dependencies.feature
 - features/html_report.feature
 - features/ignore_bundle_groups.feature
@@ -170,6 +213,7 @@ files:
 - features/license_finder_rake_task.feature
 - features/rails_rake.feature
 - features/set_license.feature
+- features/step_definitions/license_finder_steps.rb
 - features/step_definitions/steps.rb
 - features/text_report.feature
 - features/whitelist.feature
@@ -189,8 +233,8 @@ files:
 - lib/license_finder/bundled_gem.rb
 - lib/license_finder/cli.rb
 - lib/license_finder/configuration.rb
-- lib/license_finder/dependency.rb
 - lib/license_finder/dependency_report.rb
+- lib/license_finder/gem_saver.rb
 - lib/license_finder/html_report.rb
 - lib/license_finder/license.rb
 - lib/license_finder/license/apache2.rb
@@ -202,18 +246,20 @@ files:
 - lib/license_finder/license/new_bsd.rb
 - lib/license_finder/license/ruby.rb
 - lib/license_finder/license/simplified_bsd.rb
+- lib/license_finder/license_files.rb
 - lib/license_finder/license_url.rb
-- lib/license_finder/persistence.rb
-- lib/license_finder/persistence/yaml.rb
-- lib/license_finder/persistence/yaml/configuration.rb
-- lib/license_finder/persistence/yaml/dependency.rb
+- lib/license_finder/platform.rb
 - lib/license_finder/possible_license_file.rb
 - lib/license_finder/railtie.rb
 - lib/license_finder/reporter.rb
-- lib/license_finder/source_syncer.rb
+- lib/license_finder/tables.rb
+- lib/license_finder/tables/approval.rb
+- lib/license_finder/tables/bundler_group.rb
+- lib/license_finder/tables/dependency.rb
+- lib/license_finder/tables/license_alias.rb
 - lib/license_finder/text_report.rb
+- lib/license_finder/yml_to_sql.rb
 - lib/tasks/license_finder.rake
-- lib/templates/dependency.html.erb
 - lib/templates/html_report.erb
 - lib/templates/text_report.erb
 - license_finder.gemspec
@@ -248,7 +294,7 @@ files:
 - spec/lib/license_finder/bundled_gem_spec.rb
 - spec/lib/license_finder/cli_spec.rb
 - spec/lib/license_finder/configuration_spec.rb
-- spec/lib/license_finder/dependency_spec.rb
+- spec/lib/license_finder/gem_saver_spec.rb
 - spec/lib/license_finder/html_report_spec.rb
 - spec/lib/license_finder/license/apache_spec.rb
 - spec/lib/license_finder/license/bsd_spec.rb
@@ -259,18 +305,18 @@ files:
 - spec/lib/license_finder/license/new_bsd_spec.rb
 - spec/lib/license_finder/license/ruby_spec.rb
 - spec/lib/license_finder/license/simplified_bsd_spec.rb
+- spec/lib/license_finder/license_files_spec.rb
 - spec/lib/license_finder/license_spec.rb
 - spec/lib/license_finder/license_url_spec.rb
-- spec/lib/license_finder/persistence/yaml/dependency_spec.rb
 - spec/lib/license_finder/possible_license_file_spec.rb
 - spec/lib/license_finder/reporter_spec.rb
-- spec/lib/license_finder/source_syncer_spec.rb
+- spec/lib/license_finder/tables/dependency_spec.rb
+- spec/lib/license_finder/tables/license_alias_spec.rb
 - spec/lib/license_finder/text_report_spec.rb
+- spec/lib/license_finder/yml_to_sql_spec.rb
 - spec/lib/license_finder_spec.rb
 - spec/spec_helper.rb
 - spec/support/license_examples.rb
-- spec/support/shared_examples/persistence/configuration.rb
-- spec/support/shared_examples/persistence/dependency.rb
 homepage: https://github.com/pivotal/LicenseFinder
 licenses:
 - MIT
@@ -286,7 +332,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3905153614201700521
+      hash: -1906227057992874758
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -295,10 +341,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3905153614201700521
+      hash: -1906227057992874758
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Audit the OSS licenses of your application's dependencies.
@@ -310,6 +356,7 @@ test_files:
 - features/license_finder_rake_task.feature
 - features/rails_rake.feature
 - features/set_license.feature
+- features/step_definitions/license_finder_steps.rb
 - features/step_definitions/steps.rb
 - features/text_report.feature
 - features/whitelist.feature
@@ -343,7 +390,7 @@ test_files:
 - spec/lib/license_finder/bundled_gem_spec.rb
 - spec/lib/license_finder/cli_spec.rb
 - spec/lib/license_finder/configuration_spec.rb
-- spec/lib/license_finder/dependency_spec.rb
+- spec/lib/license_finder/gem_saver_spec.rb
 - spec/lib/license_finder/html_report_spec.rb
 - spec/lib/license_finder/license/apache_spec.rb
 - spec/lib/license_finder/license/bsd_spec.rb
@@ -354,15 +401,15 @@ test_files:
 - spec/lib/license_finder/license/new_bsd_spec.rb
 - spec/lib/license_finder/license/ruby_spec.rb
 - spec/lib/license_finder/license/simplified_bsd_spec.rb
+- spec/lib/license_finder/license_files_spec.rb
 - spec/lib/license_finder/license_spec.rb
 - spec/lib/license_finder/license_url_spec.rb
-- spec/lib/license_finder/persistence/yaml/dependency_spec.rb
 - spec/lib/license_finder/possible_license_file_spec.rb
 - spec/lib/license_finder/reporter_spec.rb
-- spec/lib/license_finder/source_syncer_spec.rb
+- spec/lib/license_finder/tables/dependency_spec.rb
+- spec/lib/license_finder/tables/license_alias_spec.rb
 - spec/lib/license_finder/text_report_spec.rb
+- spec/lib/license_finder/yml_to_sql_spec.rb
 - spec/lib/license_finder_spec.rb
 - spec/spec_helper.rb
 - spec/support/license_examples.rb
-- spec/support/shared_examples/persistence/configuration.rb
-- spec/support/shared_examples/persistence/dependency.rb