license_finder 0.4.1 → 0.4.5

data/license_finder.gemspec

@@ -1,24 +1,19 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "license_finder/version"
-
 Gem::Specification.new do |s|
   s.name        = "license_finder"
-  s.version     = LicenseFinder::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Jacob Maine"]
-  s.email       = ["jacob.maine@gmail.com"]
-  # s.homepage    = "http://rubygems.org/gems/license_finder"
-  s.summary     = %q{License finding heaven.}
-  s.description = %q{Find and display licenses of a project's gem dependencies.}
+  s.version     = "0.4.5"
+  s.authors     = ["Jacob Maine", "Matthew Kane Parker", "Ian Lesperance", "David Edwards"]
+  s.email       = ["brent@pivotalabs.com"]
+  s.homepage    = "https://github.com/pivotal/LicenseFinder"
+  s.summary     = "Know your dependencies - and the licenses they are binding your application to."
+  s.description = "Find and display licenses of a project's gem dependencies, so that you know what your limitations are when distributing your application."
+  s.license     = "MIT"
 
-  s.rubyforge_project = "license_finder"
-  s.add_development_dependency 'rspec', '~>2.3'
-  s.add_development_dependency 'rr'
-  s.add_development_dependency 'rake'
+  s.add_development_dependency "rails", ">=3"
+  %w(rspec rr rake cucumber rails).each do |gem|
+    s.add_development_dependency gem
+  end
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
 end

data/spec/fixtures/ISC-LICENSE

@@ -0,0 +1,10 @@
+Copyright (c) 2012, Pivotal Labs
+
+Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted,
+provided that the above copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
+INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
+THIS SOFTWARE.

data/spec/fixtures/isc_licensed_gem/LICENSE

@@ -0,0 +1,10 @@
+Copyright (c) 2012, Pivotal Labs
+
+Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted,
+provided that the above copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
+INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
+THIS SOFTWARE.

data/spec/fixtures/lgpl_licensed_gem/LICENSE

@@ -0,0 +1,165 @@
+                   GNU LESSER GENERAL PUBLIC LICENSE
+                       Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+
+  This version of the GNU Lesser General Public License incorporates
+the terms and conditions of version 3 of the GNU General Public
+License, supplemented by the additional permissions listed below.
+
+  0. Additional Definitions.
+
+  As used herein, "this License" refers to version 3 of the GNU Lesser
+General Public License, and the "GNU GPL" refers to version 3 of the GNU
+General Public License.
+
+  "The Library" refers to a covered work governed by this License,
+other than an Application or a Combined Work as defined below.
+
+  An "Application" is any work that makes use of an interface provided
+by the Library, but which is not otherwise based on the Library.
+Defining a subclass of a class defined by the Library is deemed a mode
+of using an interface provided by the Library.
+
+  A "Combined Work" is a work produced by combining or linking an
+Application with the Library.  The particular version of the Library
+with which the Combined Work was made is also called the "Linked
+Version".
+
+  The "Minimal Corresponding Source" for a Combined Work means the
+Corresponding Source for the Combined Work, excluding any source code
+for portions of the Combined Work that, considered in isolation, are
+based on the Application, and not on the Linked Version.
+
+  The "Corresponding Application Code" for a Combined Work means the
+object code and/or source code for the Application, including any data
+and utility programs needed for reproducing the Combined Work from the
+Application, but excluding the System Libraries of the Combined Work.
+
+  1. Exception to Section 3 of the GNU GPL.
+
+  You may convey a covered work under sections 3 and 4 of this License
+without being bound by section 3 of the GNU GPL.
+
+  2. Conveying Modified Versions.
+
+  If you modify a copy of the Library, and, in your modifications, a
+facility refers to a function or data to be supplied by an Application
+that uses the facility (other than as an argument passed when the
+facility is invoked), then you may convey a copy of the modified
+version:
+
+   a) under this License, provided that you make a good faith effort to
+   ensure that, in the event an Application does not supply the
+   function or data, the facility still operates, and performs
+   whatever part of its purpose remains meaningful, or
+
+   b) under the GNU GPL, with none of the additional permissions of
+   this License applicable to that copy.
+
+  3. Object Code Incorporating Material from Library Header Files.
+
+  The object code form of an Application may incorporate material from
+a header file that is part of the Library.  You may convey such object
+code under terms of your choice, provided that, if the incorporated
+material is not limited to numerical parameters, data structure
+layouts and accessors, or small macros, inline functions and templates
+(ten or fewer lines in length), you do both of the following:
+
+   a) Give prominent notice with each copy of the object code that the
+   Library is used in it and that the Library and its use are
+   covered by this License.
+
+   b) Accompany the object code with a copy of the GNU GPL and this license
+   document.
+
+  4. Combined Works.
+
+  You may convey a Combined Work under terms of your choice that,
+taken together, effectively do not restrict modification of the
+portions of the Library contained in the Combined Work and reverse
+engineering for debugging such modifications, if you also do each of
+the following:
+
+   a) Give prominent notice with each copy of the Combined Work that
+   the Library is used in it and that the Library and its use are
+   covered by this License.
+
+   b) Accompany the Combined Work with a copy of the GNU GPL and this license
+   document.
+
+   c) For a Combined Work that displays copyright notices during
+   execution, include the copyright notice for the Library among
+   these notices, as well as a reference directing the user to the
+   copies of the GNU GPL and this license document.
+
+   d) Do one of the following:
+
+       0) Convey the Minimal Corresponding Source under the terms of this
+       License, and the Corresponding Application Code in a form
+       suitable for, and under terms that permit, the user to
+       recombine or relink the Application with a modified version of
+       the Linked Version to produce a modified Combined Work, in the
+       manner specified by section 6 of the GNU GPL for conveying
+       Corresponding Source.
+
+       1) Use a suitable shared library mechanism for linking with the
+       Library.  A suitable mechanism is one that (a) uses at run time
+       a copy of the Library already present on the user's computer
+       system, and (b) will operate properly with a modified version
+       of the Library that is interface-compatible with the Linked
+       Version.
+
+   e) Provide Installation Information, but only if you would otherwise
+   be required to provide such information under section 6 of the
+   GNU GPL, and only to the extent that such information is
+   necessary to install and execute a modified version of the
+   Combined Work produced by recombining or relinking the
+   Application with a modified version of the Linked Version. (If
+   you use option 4d0, the Installation Information must accompany
+   the Minimal Corresponding Source and Corresponding Application
+   Code. If you use option 4d1, you must provide the Installation
+   Information in the manner specified by section 6 of the GNU GPL
+   for conveying Corresponding Source.)
+
+  5. Combined Libraries.
+
+  You may place library facilities that are a work based on the
+Library side by side in a single library together with other library
+facilities that are not Applications and are not covered by this
+License, and convey such a combined library under terms of your
+choice, if you do both of the following:
+
+   a) Accompany the combined library with a copy of the same work based
+   on the Library, uncombined with any other library facilities,
+   conveyed under the terms of this License.
+
+   b) Give prominent notice with the combined library that part of it
+   is a work based on the Library, and explaining where to find the
+   accompanying uncombined form of the same work.
+
+  6. Revised Versions of the GNU Lesser General Public License.
+
+  The Free Software Foundation may publish revised and/or new versions
+of the GNU Lesser General Public License from time to time. Such new
+versions will be similar in spirit to the present version, but may
+differ in detail to address new problems or concerns.
+
+  Each version is given a distinguishing version number. If the
+Library as you received it specifies that a certain numbered version
+of the GNU Lesser General Public License "or any later version"
+applies to it, you have the option of following the terms and
+conditions either of that published version or of any later version
+published by the Free Software Foundation. If the Library as you
+received it does not specify a version number of the GNU Lesser
+General Public License, you may choose any version of the GNU Lesser
+General Public License ever published by the Free Software Foundation.
+
+  If the Library as you received it specifies that a proxy can decide
+whether future versions of the GNU Lesser General Public License shall
+apply, that proxy's public statement of acceptance of any version is
+permanent authorization for you to choose that version for the
+Library.

data/spec/{dependency_list_spec.rb → lib/license_finder/dependency_list_spec.rb}

@@ -2,6 +2,10 @@ require 'spec_helper'
 
 describe LicenseFinder::DependencyList do
   before do
+    config = stub(LicenseFinder).config.stub!
+    config.whitelist { [] }
+    config.ignore_groups { [] }
+
     @mock_gemspec = Class.new do
       def initialize(name = nil, version = nil, path = nil)
         @name = name
@@ -25,7 +29,6 @@ describe LicenseFinder::DependencyList do
         nil
       end
     end
-
   end
 
   describe 'from Bundler' do
@@ -79,8 +82,8 @@ describe LicenseFinder::DependencyList do
   describe 'to_yaml' do
     it "should generate yaml" do
       list = LicenseFinder::DependencyList.new([
-                                                   LicenseFinder::Dependency.new('b_gem', '0.4.2', 'MIT', false),
-                                                   LicenseFinder::Dependency.new('a_gem', '1.2.3', 'MIT', false)
+                                                   LicenseFinder::Dependency.new('name' => 'b_gem', 'version' => '0.4.2', 'license' => 'MIT', 'approved' => false),
+                                                   LicenseFinder::Dependency.new('name' => 'a_gem', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => false)
                                                ])
 
       list.to_yaml.should == "--- \n- name: \"a_gem\"\n  version: \"1.2.3\"\n  license: \"MIT\"\n  approved: false\n  license_url: \"\"\n  notes: \"\"\n  license_files:\n  readme_files:\n- name: \"b_gem\"\n  version: \"0.4.2\"\n  license: \"MIT\"\n  approved: false\n  license_url: \"\"\n  notes: \"\"\n  license_files:\n  readme_files:\n"
@@ -90,8 +93,8 @@ describe LicenseFinder::DependencyList do
   describe 'round trip' do
     it 'should recreate from to_yaml' do
       list = LicenseFinder::DependencyList.new([
-                                                   LicenseFinder::Dependency.new('gem1', '1.2.3', 'MIT', false),
-                                                   LicenseFinder::Dependency.new('gem2', '0.4.2', 'MIT', false)
+                                                   LicenseFinder::Dependency.new('name' => 'gem1', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => false),
+                                                   LicenseFinder::Dependency.new('name' => 'gem2', 'version' => '0.4.2', 'license' => 'MIT', 'approved' => false)
                                                ])
 
       new_list = LicenseFinder::DependencyList.from_yaml(list.to_yaml)
@@ -103,19 +106,19 @@ describe LicenseFinder::DependencyList do
 
   describe 'updating dependency list' do
     before(:each) do
-      @yml_same = LicenseFinder::Dependency.new('same_gem', '1.2.3', 'MIT', true, 'a', 'b')
-      @yml_updated = LicenseFinder::Dependency.new('updated_gem', '1.0.1', 'MIT', true, 'a', 'b')
-      @yml_new_license = LicenseFinder::Dependency.new('new_license_gem', '1.0.1', 'MIT', true, 'a', 'b')
-      @yml_manual_license = LicenseFinder::Dependency.new('manual_license_gem', '1.0.1', 'Ruby', true, 'a', 'b')
-      @yml_removed_gem = LicenseFinder::Dependency.new('removed_gem', '1.0.1', 'MIT', true, 'a', 'b')
-      @yml_new_whitelist = LicenseFinder::Dependency.new('new_whitelist_gem', '1.0.1', 'MIT', false, 'a', 'b')
-
-      @gemspec_same = LicenseFinder::Dependency.new('same_gem', '1.2.3', 'MIT', false)
-      @gemspec_new = LicenseFinder::Dependency.new('brand_new_gem', '0.9', 'MIT', false)
-      @gemspec_updated = LicenseFinder::Dependency.new('updated_gem', '1.1.2', 'MIT', false)
-      @gemspec_new_license = LicenseFinder::Dependency.new('new_license_gem', '2.0.1', 'Apache 2.0', false)
-      @gemspec_new_whitelist = LicenseFinder::Dependency.new('new_whitelist_gem', '1.0.1', 'MIT', true)
-      @gemspec_manual_license = LicenseFinder::Dependency.new('manual_license_gem', '1.2.1', 'other', false)
+      @yml_same = LicenseFinder::Dependency.new('name' => 'same_gem', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => true, 'license_url' => 'a', 'notes' => 'b')
+      @yml_updated = LicenseFinder::Dependency.new('name' => 'updated_gem', 'version' => '1.0.1', 'license' => 'MIT', 'approved' => true, 'license_url' => 'a', 'notes' => 'b')
+      @yml_new_license = LicenseFinder::Dependency.new('name' => 'new_license_gem', 'version' => '1.0.1', 'license' => 'MIT', 'approved' => true, 'license_url' => 'a', 'notes' => 'b')
+      @yml_manual_license = LicenseFinder::Dependency.new('name' => 'manual_license_gem', 'version' => '1.0.1', 'license' => 'Ruby', 'approved' => true, 'license_url' => 'a', 'notes' => 'b')
+      @yml_removed_gem = LicenseFinder::Dependency.new('name' => 'removed_gem', 'version' => '1.0.1', 'license' => 'MIT', 'approved' => true, 'license_url' => 'a', 'notes' => 'b')
+      @yml_new_whitelist = LicenseFinder::Dependency.new('name' => 'new_whitelist_gem', 'version' => '1.0.1', 'license' => 'MIT', 'approved' => false, 'license_url' => 'a', 'notes' => 'b')
+
+      @gemspec_same = LicenseFinder::Dependency.new('name' => 'same_gem', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => false)
+      @gemspec_new = LicenseFinder::Dependency.new('name' => 'brand_new_gem', 'version' => '0.9', 'license' => 'MIT', 'approved' => false)
+      @gemspec_updated = LicenseFinder::Dependency.new('name' => 'updated_gem', 'version' => '1.1.2', 'license' => 'MIT', 'approved' => false)
+      @gemspec_new_license = LicenseFinder::Dependency.new('name' => 'new_license_gem', 'version' => '2.0.1', 'license' => 'Apache 2.0', 'approved' => false)
+      @gemspec_new_whitelist = LicenseFinder::Dependency.new('name' => 'new_whitelist_gem', 'version' => '1.0.1', 'license' => 'MIT', 'approved' => true)
+      @gemspec_manual_license = LicenseFinder::Dependency.new('name' => 'manual_license_gem', 'version' => '1.2.1', 'license' => 'other', 'approved' => false)
 
       @list_from_yml = LicenseFinder::DependencyList.new([@yml_same, @yml_updated, @yml_new_license, @yml_removed_gem, @yml_new_whitelist, @yml_manual_license])
       @list_from_gemspec = LicenseFinder::DependencyList.new([@gemspec_same, @gemspec_new, @gemspec_updated, @gemspec_new_license, @gemspec_new_whitelist, @gemspec_manual_license])
@@ -181,8 +184,8 @@ describe LicenseFinder::DependencyList do
 
   describe "#to_s" do
     it "should return a human readable list of dependencies" do
-      gem1 = LicenseFinder::Dependency.new('b_gem', '1.2.3', 'MIT', true)
-      gem2 = LicenseFinder::Dependency.new('a_gem', '0.9', 'other', false, 'http://foo.com/LICENSE')
+      gem1 = LicenseFinder::Dependency.new('name' => 'b_gem', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => true)
+      gem2 = LicenseFinder::Dependency.new('name' => 'a_gem', 'version' => '0.9', 'license' => 'other', 'approved' => false, 'license_url' => 'http://foo.com/LICENSE')
 
       list = LicenseFinder::DependencyList.new([gem1, gem2])
 
@@ -192,9 +195,9 @@ describe LicenseFinder::DependencyList do
 
   describe '#action_items' do
     it "should return all unapproved dependencies" do
-      gem1 = LicenseFinder::Dependency.new('b_gem', '1.2.3', 'MIT', true)
-      gem2 = LicenseFinder::Dependency.new('a_gem', '0.9', 'other', false)
-      gem3 = LicenseFinder::Dependency.new('c_gem', '0.2', 'other', false)
+      gem1 = LicenseFinder::Dependency.new('name' => 'b_gem', 'version' => '1.2.3', 'license' => 'MIT', 'approved' => true)
+      gem2 = LicenseFinder::Dependency.new('name' => 'a_gem', 'version' => '0.9', 'license' => 'other', 'approved' => false)
+      gem3 = LicenseFinder::Dependency.new('name' => 'c_gem', 'version' => '0.2', 'license' => 'other', 'approved' => false)
 
       list = LicenseFinder::DependencyList.new([gem1, gem2, gem3])
 

data/spec/lib/license_finder/dependency_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe LicenseFinder::Dependency do
+  let(:attributes) do
+    {
+        'name' => "spec_name",
+        'version' => "2.1.3",
+        'license' => "GPL",
+        'approved' => false,
+        'license_url' => 'http://www.apache.org/licenses/LICENSE-2.0.html',
+        'notes' => 'some notes',
+        'license_files' => [{'path' => '/Users/pivotal/foo/lic1'}, {'path' => '/Users/pivotal/bar/lic2'}],
+        'readme_files' => [{'path' => '/Users/pivotal/foo/Readme1'}, {'path' => '/Users/pivotal/bar/Readme2'}]
+    }
+  end
+
+  before do
+    stub(LicenseFinder).config.stub!.whitelist { %w(MIT) }
+  end
+
+  describe '.new' do
+    it "should mark it as approved when the license is whitelisted" do
+      dependency = LicenseFinder::Dependency.new(attributes.merge('license' => 'MIT', 'approved' => false))
+      dependency.approved.should == true
+    end
+
+    it "should not mark it as approved when the license is not whitelisted" do
+      dependency = LicenseFinder::Dependency.new(attributes.merge('license' => 'GPL', 'approved' => false))
+      dependency.approved.should == false
+    end
+
+    it "should leave it as approved when the license is not whitelisted but it has already been marked as approved" do
+      dependency = LicenseFinder::Dependency.new(attributes.merge('license' => 'GPL', 'approved' => true))
+      dependency.approved.should == true
+    end
+  end
+
+  describe '.from_hash' do
+    subject { LicenseFinder::Dependency.from_hash(attributes) }
+
+    its(:name) { should == 'spec_name' }
+    its(:version) { should == '2.1.3' }
+    its(:license) { should == 'GPL' }
+    its(:approved) { should == false }
+    its(:license_url) { should == "http://www.apache.org/licenses/LICENSE-2.0.html" }
+    its(:notes) { should == "some notes" }
+    its(:license_files) { should == ["/Users/pivotal/foo/lic1", "/Users/pivotal/bar/lic2"] }
+    its(:readme_files) { should == ["/Users/pivotal/foo/Readme1", "/Users/pivotal/bar/Readme2"] }
+    its(:to_yaml_entry) { should == "- name: \"spec_name\"\n  version: \"2.1.3\"\n  license: \"GPL\"\n  approved: false\n  license_url: \"http://www.apache.org/licenses/LICENSE-2.0.html\"\n  notes: \"some notes\"\n  license_files:\n  - path: \"/Users/pivotal/foo/lic1\"\n  - path: \"/Users/pivotal/bar/lic2\"\n  readme_files:\n  - path: \"/Users/pivotal/foo/Readme1\"\n  - path: \"/Users/pivotal/bar/Readme2\"\n" }
+  end
+end
+
+

data/spec/lib/license_finder/finder_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe LicenseFinder::Finder do
+  before do
+    config = stub(LicenseFinder).config.stub!
+    config.dependencies_yaml { './dependencies.yml' }
+    config.dependencies_text { './dependencies.txt' }
+  end
+
+  it "should generate a yml file and txt file" do
+    stub(File).exists?('./dependencies.yml') {false}
+
+    yml_output = StringIO.new
+    txt_output = StringIO.new
+    stub(File).open('./dependencies.yml', 'w+').yields(yml_output)
+    stub(File).open('./dependencies.txt', 'w+').yields(txt_output)
+    stub(LicenseFinder::DependencyList).from_bundler.stub!.to_yaml {"output"}
+    LicenseFinder::Finder.new.write_files
+    yml_output.string.should == "output\n"
+  end
+
+  it 'should update an existing yml file' do
+    stub(File).exists?('./dependencies.yml') {true}
+
+    yml_output = StringIO.new
+    txt_output = StringIO.new
+    stub(File).open('./dependencies.yml').stub!.readlines {['existing yml']}
+    stub(File).open('./dependencies.yml', 'w+').yields(yml_output)
+    stub(File).open('./dependencies.txt', 'w+').yields(txt_output)
+
+    stub(LicenseFinder::DependencyList).from_yaml.stub!.merge.stub!.to_yaml {"output"}
+    stub(LicenseFinder::DependencyList).from_bundler
+    LicenseFinder::Finder.new.write_files
+    yml_output.string.should == "output\n"
+  end
+end

data/spec/{gem_spec_details_spec.rb → lib/license_finder/gem_spec_details_spec.rb}

@@ -17,7 +17,7 @@ describe LicenseFinder::GemSpecDetails do
 
       def full_gem_path
         if @path
-          gem_install_path = File.join(File.dirname(__FILE__), '/../', @path)
+          gem_install_path = File.join(File.dirname(__FILE__), '..', '..', '..', @path)
           raise Errno::ENOENT, @path unless File.exists?(gem_install_path)
           gem_install_path
         else
@@ -111,9 +111,13 @@ describe LicenseFinder::GemSpecDetails do
   end
 
   describe 'to dependency' do
+    before do
+      stub(LicenseFinder).config.stub!.whitelist { ['MIT', 'Apache 2.0', 'LGPL', 'GPLv2'] }
+    end
+
     describe 'with MIT License' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem'), ['MIT']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -126,7 +130,7 @@ describe LicenseFinder::GemSpecDetails do
 
     describe 'with MIT License in README' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem_in_README'), ['MIT']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem_in_README')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -139,7 +143,7 @@ describe LicenseFinder::GemSpecDetails do
 
     describe 'with MIT License in README' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem_via_url'), ['MIT']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_gem_via_url')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -150,10 +154,9 @@ describe LicenseFinder::GemSpecDetails do
       its(:notes) { should == '' }
     end
 
-
     describe 'with MIT License with hashes' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_with_hashes'), ['MIT']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/mit_licensed_with_hashes')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -166,7 +169,7 @@ describe LicenseFinder::GemSpecDetails do
 
     describe 'with Apache License' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/apache_licensed_gem'), ['Apache 2.0']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/apache_licensed_gem')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -179,7 +182,7 @@ describe LicenseFinder::GemSpecDetails do
 
     describe 'with GPLv2 License' do
       subject do
-        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/gplv2_licensed_gem'), ['GPLv2']).dependency
+        LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/gplv2_licensed_gem')).dependency
       end
 
       its(:name) { should == 'spec_name' }
@@ -190,6 +193,20 @@ describe LicenseFinder::GemSpecDetails do
       its(:notes) { should == '' }
     end
 
+    describe 'with LGPL License' do
+      it "should detect the license as LGPL" do
+        dependency = LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/lgpl_licensed_gem')).dependency
+        dependency.license.should == "LGPL"
+      end
+    end
+
+    describe 'with ISC License' do
+      it "should detect the license as ISC" do
+        dependency = LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/isc_licensed_gem')).dependency
+        dependency.license.should == "ISC"
+      end
+    end
+
     describe 'with unknown license' do
       subject { LicenseFinder::GemSpecDetails.new(@mock_gemspec.new('spec/fixtures/other_licensed_gem')).dependency }