license-acceptance 1.0.13 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fef5c00ef5400506f147e81de6189cac6b2b62a3072c3b5ce947e1ea1cf45d9b
-  data.tar.gz: 05a004b7385c49d4b32b45df716e720ca406b011e15a8f270e9f27e79f13a740
+  metadata.gz: d82f01f1176a863816de18e547817c501d796873019601fc84a6c01a2e97c713
+  data.tar.gz: eab594e87a7613d6126e124757f63f2acc35fcbf24485a50d84e96f2609c6f51
 SHA512:
-  metadata.gz: 3133cff2199bf4131a40065512443e648dec1f406c0198f094cfcebcd0876ef1c86801d5b103caf55d6036cc2a8e7acdac089999c81aedfc9e758e7a2db449ce
-  data.tar.gz: 8e27b606ef2f4a55b3b67e474cf14f247ec186520e372657982488eadd8e868a45c9c2800c790052b8343fec90a6a44b9edba62a70e88ad79d0b6009ab150d01
+  metadata.gz: c9ed6dd65f3fb274f110157fab725a9b2cc0b341aff313f38a4a30809fd19aaef0dd52d9eabeb95a8f1738c45fff0f3efdf39a9d681fb4b9ed3118b0eeb0090e
+  data.tar.gz: 3fe1ba49289e95c77ffc863deea1221bd418cb5a111262904349d4c92e3dc2a5a760e5c562175d0a167916c3f028bcf8d0a346e038e8b935a69aadc6d147f3f6

data/Gemfile

@@ -1,6 +1,28 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in license-acceptance.gemspec
 gemspec
+
+group :development do
+  gem "chefstyle", "1.3.2"
+  gem "climate_control", "~> 0.2"
+  gem "mixlib-cli", "~> 2.1"
+  gem "rake", ">= 10.1.0"
+  gem "rspec", "~> 3.0"
+  gem "thor", ">= 0.20", "< 2.0" # validate 2.0 when it ships
+end
+
+group :docs do
+  gem "yard"
+  gem "redcarpet"
+  gem "github-markup"
+end
+
+group :debug do
+  gem "pry"
+  gem "pry-byebug"
+  gem "pry-stack_explorer", "~> 0.4.0" # pin until we drop ruby < 2.6
+  gem "rb-readline"
+end

data/lib/license_acceptance/acceptor.rb

@@ -1,4 +1,4 @@
-require "forwardable"
+require "forwardable" unless defined?(Forwardable)
 require "license_acceptance/config"
 require "license_acceptance/logger"
 require "license_acceptance/product_reader"
@@ -11,9 +11,9 @@ require "license_acceptance/strategy/provided_value"
 
 module LicenseAcceptance
 
-  ACCEPT = "accept"
-  ACCEPT_SILENT = "accept-silent"
-  ACCEPT_NO_PERSIST = "accept-no-persist"
+  ACCEPT = "accept".freeze
+  ACCEPT_SILENT = "accept-silent".freeze
+  ACCEPT_NO_PERSIST = "accept-no-persist".freeze
 
   class Acceptor
     extend Forwardable
@@ -21,7 +21,7 @@ module LicenseAcceptance
 
     attr_reader :config, :product_reader, :env_strategy, :file_strategy, :arg_strategy, :prompt_strategy, :provided_strategy
 
-    def initialize(opts={})
+    def initialize(opts = {})
       @config = Config.new(opts)
       Logger.initialize(config.logger)
       @product_reader = ProductReader.new
@@ -75,37 +75,48 @@ module LicenseAcceptance
         end
         @acceptance_value = accepted_silent? ? ACCEPT_SILENT : ACCEPT
         return true
-      elsif config.output.isatty && prompt_strategy.request(missing_licenses) do
-          # We have to infer the acceptance value if they use the prompt to accept
-          if config.persist
-            @acceptance_value = ACCEPT
-            file_strategy.persist(product_relationship, missing_licenses)
-          else
-            @acceptance_value = ACCEPT_NO_PERSIST
-            []
-          end
-        end
-        return true
-      else
+      end
+
+      if acceptance_value_provided?
+        value = provided_strategy.value || env_strategy.value || arg_strategy.value
+        output.puts("Unrecognized license acceptance value '#{value}', expected one of: '#{ACCEPT}', '#{ACCEPT_SILENT}', '#{ACCEPT_NO_PERSIST}'")
         raise LicenseNotAcceptedError.new(product_relationship.parent, missing_licenses)
       end
+
+      return true if output.isatty && accepted_license_prompt?(product_relationship, missing_licenses)
+
+      raise LicenseNotAcceptedError.new(product_relationship.parent, missing_licenses)
     end
 
-    def self.check_and_persist!(product_id, version, opts={})
+    def self.check_and_persist!(product_id, version, opts = {})
       new(opts).check_and_persist!(product_id, version)
     end
 
-    def self.check_and_persist(product_id, version, opts={})
+    def self.check_and_persist(product_id, version, opts = {})
       new(opts).check_and_persist(product_id, version)
     end
 
+    def accepted_license_prompt?(product_relationship, missing_licenses)
+      prompt_strategy.request(missing_licenses) do
+        # We have to infer the acceptance value if they use the prompt to accept
+        if config.persist
+          @acceptance_value = ACCEPT
+          file_strategy.persist(product_relationship, missing_licenses)
+        else
+          @acceptance_value = ACCEPT_NO_PERSIST
+          []
+        end
+      end
+    end
+
     # Check whether the specified product requires license acceptance for the given version.
     def license_required?(mixlib_name, version)
       product = product_reader.lookup_by_mixlib(mixlib_name)
       return false if product.nil?
       # If they don't pass a version we assume they want latest
       # All versions in all channels require license acceptance
-      return true if ["latest", "unstable", "current", "stable"].include?(version.to_s) || version.nil?
+      return true if %w{latest unstable current stable}.include?(version.to_s) || version.nil?
+
       Gem::Version.new(version) >= Gem::Version.new(product.license_required_version)
     end
 
@@ -114,6 +125,7 @@ module LicenseAcceptance
     def id_from_mixlib(mixlib_name)
       product = product_reader.lookup_by_mixlib(mixlib_name)
       return nil if product.nil?
+
       product.id
     end
 
@@ -138,23 +150,27 @@ module LicenseAcceptance
       provided_strategy.silent? || env_strategy.silent? || arg_strategy.silent?
     end
 
+    def acceptance_value_provided?
+      provided_strategy.value? || env_strategy.value? || arg_strategy.value?
+    end
+
     # In the case where users accept with a command line argument or environment variable
     # we still want to output the fact that the filesystem was changed.
     def output_num_persisted(count)
-      s = count > 1 ? "s": ""
+      s = count > 1 ? "s" : ""
       output.puts <<~EOM
-      #{Strategy::Prompt::BORDER}
-      #{Strategy::Prompt::CHECK} #{count} product license#{s} accepted.
-      #{Strategy::Prompt::BORDER}
+        #{Strategy::Prompt::BORDER}
+        #{Strategy::Prompt::CHECK} #{count} product license#{s} accepted.
+        #{Strategy::Prompt::BORDER}
       EOM
     end
 
     def output_persist_failed(errs)
       output.puts <<~EOM
-      #{Strategy::Prompt::BORDER}
-      #{Strategy::Prompt::CHECK} Product license accepted.
-      Could not persist acceptance:\n\t* #{errs.map(&:message).join("\n\t* ")}
-      #{Strategy::Prompt::BORDER}
+        #{Strategy::Prompt::BORDER}
+        #{Strategy::Prompt::CHECK} Product license accepted.
+        Could not persist acceptance:\n\t* #{errs.map(&:message).join("\n\t* ")}
+        #{Strategy::Prompt::BORDER}
       EOM
     end
 

data/lib/license_acceptance/cli_flags/mixlib_cli.rb

@@ -1,6 +1,6 @@
 begin
-  require 'mixlib/cli'
-rescue => exception
+  require "mixlib/cli" unless defined?(Mixlib::CLI)
+rescue
   raise "Must have mixlib-cli gem installed to use this mixin"
 end
 

data/lib/license_acceptance/cli_flags/thor.rb

@@ -1,6 +1,6 @@
 begin
-  require 'thor'
-rescue => exception
+  require "thor" unless defined?(Thor)
+rescue
   raise "Must have thor gem installed to use this mixin"
 end
 
@@ -12,7 +12,7 @@ module LicenseAcceptance
       def self.included(klass)
         klass.class_option :chef_license,
           type: :string,
-          desc: 'Accept the license for this product and any contained products: accept, accept-no-persist, accept-silent'
+          desc: "Accept the license for this product and any contained products: accept, accept-no-persist, accept-silent"
       end
 
     end

data/lib/license_acceptance/config.rb

@@ -1,10 +1,10 @@
-require 'logger'
+require "logger"
 
 module LicenseAcceptance
   class Config
     attr_accessor :output, :logger, :license_locations, :persist_location, :persist
 
-    def initialize(opts={})
+    def initialize(opts = {})
       @output = opts.fetch(:output, $stdout)
       @logger = opts.fetch(:logger, ::Logger.new(IO::NULL))
       @license_locations = opts.fetch(:license_locations, default_license_locations)
@@ -21,7 +21,7 @@ module LicenseAcceptance
 
     def default_license_locations
       if windows?
-        root = ENV.fetch("SYSTEMDRIVE","C:")
+        root = ENV.fetch("SYSTEMDRIVE", "C:")
         l = [ File.join(root, "chef/accepted_licenses/") ]
         unless is_root?
           # Look through a list of possible user locations and pick the first one that exists
@@ -32,6 +32,7 @@ module LicenseAcceptance
           possible_dirs << ENV["HOMESHARE"] + ENV["HOMEPATH"] if ENV["HOMESHARE"] && ENV["HOMEPATH"]
           possible_dirs << ENV["USERPROFILE"] if ENV["USERPROFILE"]
           raise NoValidEnvironmentVar if possible_dirs.empty?
+
           possible_dirs.each do |possible_dir|
             if Dir.exist?(possible_dir)
               full_possible_dir = File.join(possible_dir, ".chef/accepted_licenses/")
@@ -42,7 +43,7 @@ module LicenseAcceptance
         end
       else
         l = [ "/etc/chef/accepted_licenses/" ]
-        l << File.join(ENV['HOME'], ".chef/accepted_licenses/") unless is_root?
+        l << File.join(ENV["HOME"], ".chef/accepted_licenses/") unless is_root?
       end
       l
     end

data/lib/license_acceptance/product.rb

@@ -14,14 +14,16 @@ module LicenseAcceptance
 
     def ==(other)
       return false if other.class != Product
+
       if other.id == id &&
-         other.pretty_name == pretty_name &&
-         other.filename == filename &&
-         other.mixlib_name == mixlib_name
-         other.license_required_version == license_required_version
-         return true
+          other.pretty_name == pretty_name &&
+          other.filename == filename &&
+          other.mixlib_name == mixlib_name &&
+          other.license_required_version == license_required_version
+        return true
       end
-      return false
+
+      false
     end
 
   end

data/lib/license_acceptance/product_reader.rb

@@ -1,4 +1,4 @@
-require "tomlrb"
+autoload :Tomlrb, "tomlrb"
 require "license_acceptance/logger"
 require "license_acceptance/product"
 require "license_acceptance/product_relationship"
@@ -18,7 +18,7 @@ module LicenseAcceptance
       toml = Tomlrb.load_file(location, symbolize_keys: false)
       raise InvalidProductInfo.new(location) if toml.empty? || toml["products"].nil? || toml["relationships"].nil?
 
-      for product in toml["products"]
+      toml["products"].each do |product|
         products[product["id"]] = Product.new(
           product["id"], product["pretty_name"],
           product["filename"], product["mixlib_name"],
@@ -26,7 +26,7 @@ module LicenseAcceptance
         )
       end
 
-      for parent_id, children in toml["relationships"]
+      toml["relationships"].each do |parent_id, children|
         parent = products[parent_id]
         raise UnknownParent.new(parent_id) if parent.nil?
         # Its fine to not have a relationship entry, but not fine to have
@@ -34,9 +34,11 @@ module LicenseAcceptance
         if children.nil? || children.empty? || !children.is_a?(Array)
           raise NoChildRelationships.new(parent)
         end
+
         children.map! do |child_id|
           child = products[child_id]
           raise UnknownChild.new(child_id) if child.nil?
+
           child
         end
         relationships[parent] = children
@@ -52,6 +54,7 @@ module LicenseAcceptance
       if ENV["CHEF_LICENSE_PRODUCT_INFO"]
         return ENV["CHEF_LICENSE_PRODUCT_INFO"]
       end
+
       File.absolute_path(File.join(__FILE__, "../../../config/product_info.toml"))
     end
 
@@ -60,9 +63,10 @@ module LicenseAcceptance
         raise UnknownProduct.new(parent_id)
       end
       children = relationships.fetch(parent_product, [])
-      if !parent_version.is_a? String
+      unless parent_version.is_a? String
         raise ProductVersionTypeError.new(parent_version)
       end
+
       ProductRelationship.new(parent_product, children, parent_version)
     end
 

data/lib/license_acceptance/strategy/argument.rb

@@ -6,6 +6,8 @@ module LicenseAcceptance
     # Look for acceptance values in the ARGV
     class Argument < Base
 
+      FLAG = "--chef-license".freeze
+
       attr_reader :argv
 
       def initialize(argv)
@@ -13,31 +15,30 @@ module LicenseAcceptance
       end
 
       def accepted?
-        look_for_value(ACCEPT)
+        String(value).downcase == ACCEPT
       end
 
       def silent?
-        look_for_value(ACCEPT_SILENT)
+        String(value).downcase == ACCEPT_SILENT
       end
 
       def no_persist?
-        look_for_value(ACCEPT_NO_PERSIST)
+        String(value).downcase == ACCEPT_NO_PERSIST
       end
 
-      private
+      def value?
+        argv.any? { |s| s == FLAG || s.start_with?("#{FLAG}=") }
+      end
 
-      def look_for_value(sought)
-        if argv.include?("--chef-license=#{sought}")
-          return true
-        end
-        i = argv.index("--chef-license")
-        unless i.nil?
-          val = argv[i+1]
-          if val != nil && val.downcase == sought
-            return true
-          end
+      def value
+        match = argv.detect { |s| s.start_with?("#{FLAG}=") }
+        return match.split("=").last if match
+
+        argv.each_cons(2) do |arg, value|
+          return value if arg == FLAG
         end
-        return false
+
+        nil
       end
     end
   end

data/lib/license_acceptance/strategy/environment.rb

@@ -6,6 +6,8 @@ module LicenseAcceptance
     # Look for acceptance values in the environment
     class Environment < Base
 
+      ENV_KEY = "CHEF_LICENSE".freeze
+
       attr_reader :env
 
       def initialize(env)
@@ -13,24 +15,23 @@ module LicenseAcceptance
       end
 
       def accepted?
-        look_for_value(ACCEPT)
+        String(value).downcase == ACCEPT
       end
 
       def silent?
-        look_for_value(ACCEPT_SILENT)
+        String(value).downcase == ACCEPT_SILENT
       end
 
       def no_persist?
-        look_for_value(ACCEPT_NO_PERSIST)
+        String(value).downcase == ACCEPT_NO_PERSIST
       end
 
-      private
+      def value?
+        env.key?(ENV_KEY)
+      end
 
-      def look_for_value(sought)
-        if env['CHEF_LICENSE'] && env['CHEF_LICENSE'].downcase == sought
-          return true
-        end
-        return false
+      def value
+        env[ENV_KEY]
       end
 
     end

data/lib/license_acceptance/strategy/file.rb

@@ -1,7 +1,7 @@
-require 'date'
-require 'yaml'
-require 'fileutils'
-require 'etc'
+require "date"
+autoload :YAML, "yaml"
+require "fileutils" unless defined?(FileUtils)
+require "etc" unless defined?(Etc)
 require "license_acceptance/logger"
 require "license_acceptance/strategy/base"
 
@@ -28,11 +28,9 @@ module LicenseAcceptance
         logger.debug("Searching for the following licenses: #{missing_licenses.map(&:id)}")
 
         searching.each do |product|
-          found = false
           config.license_locations.each do |loc|
             f = ::File.join(loc, product.filename)
             if ::File.exist?(f)
-              found = true
               logger.debug("Found license #{product.filename} at #{f}")
               missing_licenses.delete(product)
               break
@@ -49,7 +47,7 @@ module LicenseAcceptance
         parent_version = product_relationship.parent_version
         root_dir = config.persist_location
 
-        if !Dir.exist?(root_dir)
+        unless Dir.exist?(root_dir)
           begin
             FileUtils.mkdir_p(root_dir)
           rescue StandardError => e
@@ -70,7 +68,7 @@ module LicenseAcceptance
             errs << err unless err.nil?
           end
         end
-        return errs
+        errs
       end
 
       private
@@ -91,11 +89,11 @@ module LicenseAcceptance
           contents = Hash[contents.map { |k, v| [k.to_s, v] }]
           license_file << YAML.dump(contents)
         end
-        return nil
+        nil
       rescue StandardError => e
         msg = "Could not persist license to #{path}"
         logger.info "#{msg}\n\t#{e.message}\n\t#{e.backtrace.join("\n\t")}"
-        return e
+        e
       end
 
     end