libxml-ruby 4.1.2 → 6.0.0

data/test/test_document_write.rb

@@ -1,146 +1,143 @@
-# encoding: UTF-8
-
-require_relative './test_helper'
-require 'tmpdir'
-
-class TestDocumentWrite < Minitest::Test
-  def setup
-    @file_name = "model/bands.utf-8.xml"
-
-    # Strip spaces to make testing easier
-    LibXML::XML.default_keep_blanks = false
-    file = File.join(File.dirname(__FILE__), @file_name)
-    @doc = LibXML::XML::Document.file(file)
-  end
-
-  def teardown
-    LibXML::XML.default_keep_blanks = true
-    @doc = nil
-  end
-
-  # ---  to_s tests  ---
-  def test_to_s_default
-    # Default to_s has indentation
-    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
-                 @doc.to_s)
-  end
-
-  def test_to_s_no_global_indentation
-    # No indentation due to global setting
-    LibXML::XML.indent_tree_output = false
-    value = @doc.to_s
-
-    assert_equal(Encoding::UTF_8, value.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n<m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n<iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
-                 value)
-  ensure
-    LibXML::XML.indent_tree_output = true
-  end
-
-  def test_to_s_no_indentation
-    # No indentation due to local setting
-    value = @doc.to_s(:indent => false)
-    assert_equal(Encoding::UTF_8, value.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\"><m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n",
-                 value)
-  end
-
-  def test_to_s_encoding
-    # Test encodings
-
-    # UTF8:
-    # ö - c3 b6 in hex, \303\266 in octal
-    # ü - c3 bc in hex, \303\274 in octal
-    value = @doc.to_s(:encoding => LibXML::XML::Encoding::UTF_8)
-    assert_equal(Encoding::UTF_8, value.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
-                 value)
-
-    # ISO_8859_1:
-    # ö - f6 in hex, \366 in octal
-    # ü - fc in hex, \374 in octal
-    value = @doc.to_s(:encoding => LibXML::XML::Encoding::ISO_8859_1)
-    assert_equal(Encoding::ISO8859_1, value.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\">\n  <m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n".force_encoding(Encoding::ISO8859_1),
-                 @doc.to_s(:encoding => LibXML::XML::Encoding::ISO_8859_1))
-
-    # Invalid encoding
-    error = assert_raises(ArgumentError) do
-      @doc.to_s(:encoding => -9999)
-    end
-    assert_equal('Unknown encoding value: -9999', error.to_s)
-  end
-
-  # --- save tests -----
-  def test_save_utf8
-    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_utf8.xml")
-
-    bytes = @doc.save(temp_filename)
-    assert_equal(305, bytes)
-
-    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::UTF_8)
-    assert_equal(Encoding::UTF_8, contents.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
-                  contents)
-  ensure
-    File.delete(temp_filename)
-  end
-
-  def test_save_utf8_no_indents
-    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_utf8_no_indents.xml")
-
-    bytes = @doc.save(temp_filename, :indent => false)
-    assert_equal(298, bytes)
-
-    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::UTF_8)
-    assert_equal("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<bands genre=\"metal\"><m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n",
-               contents)
-  ensure
-    File.delete(temp_filename)
-  end
-
-  def test_save_iso_8859_1
-    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_iso_8859_1.xml")
-    bytes = @doc.save(temp_filename, :encoding => LibXML::XML::Encoding::ISO_8859_1)
-    assert_equal(304, bytes)
-
-    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::ISO8859_1)
-    assert_equal(Encoding::ISO8859_1, contents.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\">\n  <m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n".force_encoding(Encoding::ISO8859_1),
-               contents)
-  ensure
-    File.delete(temp_filename)
-  end
-
-  def test_save_iso_8859_1_no_indent
-    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_iso_8859_1_no_indent.xml")
-    bytes = @doc.save(temp_filename, :indent => false, :encoding => LibXML::XML::Encoding::ISO_8859_1)
-    assert_equal(297, bytes)
-
-    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::ISO8859_1)
-    assert_equal(Encoding::ISO8859_1, contents.encoding)
-    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\"><m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n".force_encoding(Encoding::ISO8859_1),
-                 contents)
-  ensure
-    File.delete(temp_filename)
-  end
-
-  def test_thread_set_root
-    # Previously a segmentation fault occurred when running libxml in
-    # background threads.
-    thread = Thread.new do
-      100000.times do |i|
-        document = LibXML::XML::Document.new
-        node = LibXML::XML::Node.new('test')
-        document.root = node
-      end
-    end
-    thread.join
-    assert(true)
-  end
-
-  # --- Debug ---
-  def test_debug
-    assert(@doc.debug)
-  end
+# encoding: UTF-8
+
+require_relative './test_helper'
+require 'tmpdir'
+
+class TestDocumentWrite < Minitest::Test
+  def setup
+    @file_name = "model/bands.utf-8.xml"
+
+    file = File.join(File.dirname(__FILE__), @file_name)
+    @doc = LibXML::XML::Document.file(file, options: LibXML::XML::Parser::Options::NOBLANKS)
+  end
+
+  def teardown
+    @doc = nil
+  end
+
+  # ---  to_s tests  ---
+  def test_to_s_default
+    # Default to_s has indentation
+    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
+                 @doc.to_s)
+  end
+
+  def test_to_s_no_global_indentation
+    # No indentation due to global setting
+    LibXML::XML.indent_tree_output = false
+    value = @doc.to_s
+
+    assert_equal(Encoding::UTF_8, value.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n<m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n<iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
+                 value)
+  ensure
+    LibXML::XML.indent_tree_output = true
+  end
+
+  def test_to_s_no_indentation
+    # No indentation due to local setting
+    value = @doc.to_s(:indent => false)
+    assert_equal(Encoding::UTF_8, value.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\"><m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n",
+                 value)
+  end
+
+  def test_to_s_encoding
+    # Test encodings
+
+    # UTF8:
+    # ö - c3 b6 in hex, \303\266 in octal
+    # ü - c3 bc in hex, \303\274 in octal
+    value = @doc.to_s(:encoding => LibXML::XML::Encoding::UTF_8)
+    assert_equal(Encoding::UTF_8, value.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
+                 value)
+
+    # ISO_8859_1:
+    # ö - f6 in hex, \366 in octal
+    # ü - fc in hex, \374 in octal
+    value = @doc.to_s(:encoding => LibXML::XML::Encoding::ISO_8859_1)
+    assert_equal(Encoding::ISO8859_1, value.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\">\n  <m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n".force_encoding(Encoding::ISO8859_1),
+                 @doc.to_s(:encoding => LibXML::XML::Encoding::ISO_8859_1))
+
+    # Invalid encoding
+    error = assert_raises(ArgumentError) do
+      @doc.to_s(:encoding => -9999)
+    end
+    assert_equal('Unknown encoding value: -9999', error.to_s)
+  end
+
+  # --- save tests -----
+  def test_save_utf8
+    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_utf8.xml")
+
+    bytes = @doc.save(temp_filename)
+    assert_equal(305, bytes)
+
+    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::UTF_8)
+    assert_equal(Encoding::UTF_8, contents.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<bands genre=\"metal\">\n  <m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n",
+                  contents)
+  ensure
+    File.delete(temp_filename)
+  end
+
+  def test_save_utf8_no_indents
+    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_utf8_no_indents.xml")
+
+    bytes = @doc.save(temp_filename, :indent => false)
+    assert_equal(298, bytes)
+
+    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::UTF_8)
+    assert_equal("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<bands genre=\"metal\"><m\u00F6tley_cr\u00FCe country=\"us\">M\u00F6tley Cr\u00FCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\u00F6tley_cr\u00FCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n",
+               contents)
+  ensure
+    File.delete(temp_filename)
+  end
+
+  def test_save_iso_8859_1
+    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_iso_8859_1.xml")
+    bytes = @doc.save(temp_filename, :encoding => LibXML::XML::Encoding::ISO_8859_1)
+    assert_equal(304, bytes)
+
+    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::ISO8859_1)
+    assert_equal(Encoding::ISO8859_1, contents.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\">\n  <m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe>\n  <iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden>\n</bands>\n".force_encoding(Encoding::ISO8859_1),
+               contents)
+  ensure
+    File.delete(temp_filename)
+  end
+
+  def test_save_iso_8859_1_no_indent
+    temp_filename = File.join(Dir.tmpdir, "tc_document_write_test_save_iso_8859_1_no_indent.xml")
+    bytes = @doc.save(temp_filename, :indent => false, :encoding => LibXML::XML::Encoding::ISO_8859_1)
+    assert_equal(297, bytes)
+
+    contents = File.read(temp_filename, nil, nil, :encoding => Encoding::ISO8859_1)
+    assert_equal(Encoding::ISO8859_1, contents.encoding)
+    assert_equal("<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n<bands genre=\"metal\"><m\xF6tley_cr\xFCe country=\"us\">M\xF6tley Cr\xFCe is an American heavy metal band formed in Los Angeles, California in 1981.</m\xF6tley_cr\xFCe><iron_maiden country=\"uk\">Iron Maiden is a British heavy metal band formed in 1975.</iron_maiden></bands>\n".force_encoding(Encoding::ISO8859_1),
+                 contents)
+  ensure
+    File.delete(temp_filename)
+  end
+
+  def test_thread_set_root
+    # Previously a segmentation fault occurred when running libxml in
+    # background threads.
+    thread = Thread.new do
+      100000.times do |i|
+        document = LibXML::XML::Document.new
+        node = LibXML::XML::Node.new('test')
+        document.root = node
+      end
+    end
+    thread.join
+    assert(true)
+  end
+
+  # --- Debug ---
+  def test_debug
+    assert(@doc.debug)
+  end
 end

data/test/test_dtd.rb

@@ -1,129 +1,134 @@
-# encoding: UTF-8
-
-require_relative './test_helper'
-
-
-class TestDtd < Minitest::Test
-  def setup
-    xp = LibXML::XML::Parser.string(<<-EOS)
-      <root>
-        <head a="ee" id="1">Colorado</head>
-        <descr>Lots of nice mountains</descr>
-      </root>
-    EOS
-    @doc = xp.parse
-  end
-
-  def teardown
-    @doc = nil
-  end
-  
-  def dtd
-    LibXML::XML::Dtd.new(<<-EOS)
-      <!ELEMENT root (head, descr)>
-      <!ELEMENT head (#PCDATA)>
-      <!ATTLIST head
-        id NMTOKEN #REQUIRED
-        a CDATA #IMPLIED
-      >
-      <!ELEMENT descr (#PCDATA)>
-    EOS
-  end
-  
-  def test_internal_subset
-    xhtml_dtd = LibXML::XML::Dtd.new "-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", nil, nil, true
-		assert xhtml_dtd.name.nil?
-		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
-
-    xhtml_dtd = LibXML::XML::Dtd.new "-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", "xhtml1", nil, true
-		assert_equal "xhtml1", xhtml_dtd.name
-		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
-  end
-
-  def test_external_subset
-    xhtml_dtd = LibXML::XML::Dtd.new "-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", nil
-		assert xhtml_dtd.name.nil?
-		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
-
-    xhtml_dtd = LibXML::XML::Dtd.new "-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", "xhtml1"
-		assert_equal "xhtml1", xhtml_dtd.name
-		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
-		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
-  end
-
-  def test_valid
-    assert(@doc.validate(dtd))
-  end
-
-  def test_node_type
-    assert_equal(LibXML::XML::Node::DTD_NODE, dtd.node_type)
-  end
-
-  def test_invalid
-    new_node = LibXML::XML::Node.new('invalid', 'this will mess up validation')
-    @doc.root << new_node
-
-    error = assert_raises(LibXML::XML::Error) do
-      @doc.validate(dtd)
-    end
-
-    # Check the error worked
-    refute_nil(error)
-    assert_kind_of(LibXML::XML::Error, error)
-    assert_equal("Error: No declaration for element invalid.", error.message)
-    assert_equal(LibXML::XML::Error::VALID, error.domain)
-    assert_equal(LibXML::XML::Error::DTD_UNKNOWN_ELEM, error.code)
-    assert_equal(LibXML::XML::Error::ERROR, error.level)
-    assert_nil(error.file)
-    assert_nil(error.line)
-    assert_equal('invalid', error.str1)
-    # Different answers across operating systems
-    # assert_nil(error.str2)
-    assert_nil(error.str3)
-    assert_equal(0, error.int1)
-    assert_equal(0, error.int2)
-    refute_nil(error.node)
-    assert_equal('invalid', error.node.name)
-  end
-
-  def test_external_dtd
-    xml = <<-EOS
-      <!DOCTYPE test PUBLIC "-//TEST" "test.dtd" []>
-      <test>
-        <title>T1</title>
-      </test>
-    EOS
-
-    errors = Array.new
-    LibXML::XML::Error.set_handler do |error|
-      errors << error
-    end
-
-    LibXML::XML.default_load_external_dtd = false
-    LibXML::XML::Parser.string(xml).parse
-    assert_equal(0, errors.length)
-
-    errors.clear
-    LibXML::XML.default_load_external_dtd = true
-    LibXML::XML::Parser.string(xml).parse
-    assert_equal(1, errors.length)
-    assert_equal("Warning: failed to load external entity \"test.dtd\" at :1.",
-                 errors[0].to_s)
-
-    errors = Array.new
-    LibXML::XML::Parser.string(xml, :options => LibXML::XML::Parser::Options::DTDLOAD).parse
-    assert_equal(1, errors.length)
-    assert_equal("Warning: failed to load external entity \"test.dtd\" at :1.",
-                 errors[0].to_s)
-  ensure
-    LibXML::XML.default_load_external_dtd = false
-    LibXML::XML::Error.reset_handler
-  end
-end
+# encoding: UTF-8
+
+require_relative './test_helper'
+
+
+class TestDtd < Minitest::Test
+  def setup
+    xp = LibXML::XML::Parser.string(<<-EOS)
+      <root>
+        <head a="ee" id="1">Colorado</head>
+        <descr>Lots of nice mountains</descr>
+      </root>
+    EOS
+    @doc = xp.parse
+  end
+
+  def teardown
+    @doc = nil
+  end
+  
+  def dtd
+    LibXML::XML::Dtd.new(<<-EOS)
+      <!ELEMENT root (head, descr)>
+      <!ELEMENT head (#PCDATA)>
+      <!ATTLIST head
+        id NMTOKEN #REQUIRED
+        a CDATA #IMPLIED
+      >
+      <!ELEMENT descr (#PCDATA)>
+    EOS
+  end
+  
+  def test_internal_subset
+    xhtml_dtd = LibXML::XML::Dtd.new("-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", nil, nil, true)
+		assert xhtml_dtd.name.nil?
+		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
+
+    xhtml_dtd = LibXML::XML::Dtd.new("-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", "xhtml1", nil, true)
+		assert_equal "xhtml1", xhtml_dtd.name
+		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
+  end
+
+  def test_internal_subset_nil_ids
+    doc = LibXML::XML::Document.new
+    doc.root = LibXML::XML::Node.new('test')
+    dtd = LibXML::XML::Dtd.new(nil, nil, 'test', doc, true)
+    assert_equal('test', dtd.name)
+    assert_nil(dtd.external_id)
+    assert_nil(dtd.uri)
+    assert_equal("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<!DOCTYPE test>\n<test/>\n", doc.to_s)
+  end
+
+  def test_external_subset
+    xhtml_dtd = LibXML::XML::Dtd.new("-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", nil)
+		assert xhtml_dtd.name.nil?
+		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
+
+    xhtml_dtd = LibXML::XML::Dtd.new("-//W3C//DTD XHTML 1.0 Transitional//EN", "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", "xhtml1")
+		assert_equal "xhtml1", xhtml_dtd.name
+		assert_equal "-//W3C//DTD XHTML 1.0 Transitional//EN", xhtml_dtd.external_id
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.uri
+		assert_equal "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd", xhtml_dtd.system_id
+  end
+
+  def test_valid
+    assert(@doc.validate(dtd))
+  end
+
+  def test_node_type
+    assert_equal(LibXML::XML::Node::DTD_NODE, dtd.node_type)
+  end
+
+  def test_invalid
+    new_node = LibXML::XML::Node.new('invalid', 'this will mess up validation')
+    @doc.root << new_node
+
+    error = assert_raises(LibXML::XML::Error) do
+      @doc.validate(dtd)
+    end
+
+    # Check the error worked
+    refute_nil(error)
+    assert_kind_of(LibXML::XML::Error, error)
+    assert_equal("Error: No declaration for element invalid.", error.message)
+    assert_equal(LibXML::XML::Error::VALID, error.domain)
+    assert_equal(LibXML::XML::Error::DTD_UNKNOWN_ELEM, error.code)
+    assert_equal(LibXML::XML::Error::ERROR, error.level)
+    assert_nil(error.file)
+    assert_nil(error.line)
+    assert_equal('invalid', error.str1)
+    # Different answers across operating systems
+    # assert_nil(error.str2)
+    assert_nil(error.str3)
+    assert_equal(0, error.int1)
+    assert_equal(0, error.int2)
+    refute_nil(error.node)
+    assert_equal('invalid', error.node.name)
+  end
+
+  def test_external_dtd
+    xml = <<-EOS
+      <!DOCTYPE test PUBLIC "-//TEST" "test.dtd" []>
+      <test>
+        <title>T1</title>
+      </test>
+    EOS
+
+    errors = Array.new
+    LibXML::XML::Error.set_handler do |error|
+      errors << error
+    end
+
+    LibXML::XML::Parser.string(xml).parse
+    assert_equal(0, errors.length)
+
+    errors.clear
+    LibXML::XML::Parser.string(xml, options: LibXML::XML::Parser::Options::DTDLOAD).parse
+    assert_equal(1, errors.length)
+    assert_match(/Warning: failed to load.*test\.dtd/, errors[0].to_s)
+
+    errors = Array.new
+    LibXML::XML::Parser.string(xml, :options => LibXML::XML::Parser::Options::DTDLOAD).parse
+    assert_equal(1, errors.length)
+    assert_match(/Warning: failed to load.*test\.dtd/, errors[0].to_s)
+  ensure
+    LibXML::XML::Error.reset_handler
+  end
+end