libv8 7.8.279.23.0beta1 → 8.4.255.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6356a85c0e08d10212afe97f09fa0c60960e6733861a3b77048925ee8fc8cc8c
-  data.tar.gz: '0199d7986e1ec191749a9a948574261cf361ce6f931ebdd4899e69ca94d2b9ae'
+  metadata.gz: 7af261fb4637a57b9214feb4e54d8d3783fc01b632f0a6b8ca51318686712847
+  data.tar.gz: ae224d84d9fd3511c7b77e795c7788a221c40b6627c5e57dc69ebf3a26afd62c
 SHA512:
-  metadata.gz: a2ac8132ffdec219eade0c245ec13f109ca0890a5e0061f16490667399fd6e70bb481f75100d58ea2820b803cb3baa82f5c694e0156e44d7bcb523bceaa128d2
-  data.tar.gz: 16e14e1a8f9e25b57735c30db1e940f3de4da1a16c2ba9b5937046f837f4735005d0f24d7fb49c49b4b15eed1b491fc7133dc444f54d1b9565180c8146fca6d2
+  metadata.gz: 30ee91bab7e421ff8ed4edba85cdef92a10db2e9acc7b550694e5a5fb789dbc520a7a3b81bbca49204282f2ed6840318ed4fc3b606df07d1cdb3a93b2d401ea9
+  data.tar.gz: 0d86bc2ca4b4ffe26dba261cfea44a2b8cb4808f93e6a6fd561ee7ddc556b84330471a8b67dcc5b7cddc6fa18527df1d747688b9e75cfdeefd52e62a7f5ce205

data/.gitignore

@@ -15,4 +15,5 @@ lib/libv8/VERSION
 /release/**/.scaleway
 /vendor/.gclient
 /vendor/.gclient_entries
+/vendor/.cipd
 /vendor/v8/

data/.travis.yml

@@ -2,20 +2,13 @@ dist: xenial
 compiler: clang
 language: ruby
 rvm:
+  - 2.7
+  - 2.6
   - 2.5
-  - 2.4
-  - rubinius-3
 matrix:
   include:
-    - rvm: 2.5.1
-      os: osx
-      osx_image: xcode9.4.1
-    - rvm: 2.5.1
-      os: osx
-      osx_image: xcode9.2
-  allow_failures:
-    - rvm: rubinius-3
-  fast_finish: true
+    - os: osx
+      osx_image: xcode11.6
 addons:
   apt:
     packages:
@@ -31,18 +24,22 @@ before_install:
 script:
   - git submodule update --init
   - bundle exec rake spec binary --trace
+before_deploy:
+  - bundle exec rake osx_varients --trace
 deploy:
   provider: releases
-  file: $(git ls-files -o pkg | head -1)
+  file_glob: true
+  file: pkg/*.gem
   api_key:
-    secure: OMCBceg89uRnU+FIPAPbeOK2pISvV4Cz62r9iTRIGXQCOOXX8M40i77/3DmtkMtc9FEuNyAu1+CH886PL2WtZZPK4CmEU3HuqXz1a5VsCI+zcAZL1tevKvblXOVQ3MG+B/SZRC3rEzGwjk4027WtzCCGoGCLUu4TFJP05+/8XN4=
+    secure: "ONqUP7Unb84uQJhPCacyNdQL2JznZHIpXjXvW3Zcmvz9Hifp0Q94Kk/k7Q7jDgVZjHvqs9iI2WaXOut55Tumb9yZcMtn4ZbMCh/93MPPBYnvFGJd4qDQdiVylm+WLrg+phK/nG1259T/dX+nZKYbvKjQxQSHYaP7q6+MVvLPPcY="
   skip_cleanup: true
   on:
     tags: true
-    # condition: $TRAVIS_OS_NAME = osx
+    rvm: '2.7'
 cache:
   bundler: true
 notifications:
   recipients:
     - cowboyd@thefrontside.net
     - bordjukov@gmail.com
+    - nightpool@cybre.space

data/CHANGELOG.md

@@ -1,6 +1,12 @@
-### Unreleased
+### v8.4.255.0 - 2020-07-15
 
+* Update upstream v8 version to 8.4.255.0
+
+### v7.3.495.0 - 2020-04-14
+
+* Update upstream v8 version to 7.3.495.0
 * Enable I18n support in V8
+* Drop support for Ruby 2.4 (EOL)
 
 ### v7.3.492.27.0, v7.3.492.27.1 - 2019-04-24
 

data/README.md

@@ -1,7 +1,7 @@
 # libv8
 [![Gem Version](https://badge.fury.io/rb/libv8.svg)](https://badge.fury.io/rb/libv8)
 [![Number of downloads](https://ruby-gem-downloads-badge.herokuapp.com/libv8?type=total)](https://rubygems.org/gems/libv8)
-[![Build Status](https://travis-ci.org/cowboyd/libv8.svg?branch=master)](https://travis-ci.org/cowboyd/libv8)
+[![Build Status](https://travis-ci.org/rubyjs/libv8.svg?branch=master)](https://travis-ci.org/rubyjs/libv8)
 [![Join the chat at https://gitter.im/cowboyd/therubyracer](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cowboyd/therubyracer?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Code Triagers Badge](https://www.codetriage.com/cowboyd/libv8/badges/users.svg)](https://www.codetriage.com/cowboyd/libv8)
 
@@ -23,10 +23,9 @@ opens the door for supporting Windows.
 That depends on your platform. Right now, we support the following
 platforms.
 
+* x86_64-darwin-19
+* x86_64-darwin-18
 * x86_64-darwin-17
-* x86_64-darwin-16
-* x86_64-darwin-15
-* x86_64-darwin-14
 * x86_64-linux
 * x86-linux
 
@@ -77,11 +76,11 @@ source-based distribution
 
 Building the V8 library from source imposes the following requirements:
 
-* An x86/x86_64 CPU. See [#261](https://github.com/cowboyd/libv8/issues/261) for ARM state.
+* An x86/x86_64 CPU. See [#261](https://github.com/rubyjs/libv8/issues/261) for ARM state.
 * Linux with glibc or macOS. See
-  [#259](https://github.com/cowboyd/libv8/issues/259),
-  [#253](https://github.com/cowboyd/libv8/issues/253) and
-  [#217](https://github.com/cowboyd/libv8/issues/217) for state of other
+  [#259](https://github.com/rubyjs/libv8/issues/259),
+  [#253](https://github.com/rubyjs/libv8/issues/253) and
+  [#217](https://github.com/rubyjs/libv8/issues/217) for state of other
   platforms.
 * Python 2
 * pkg-config
@@ -94,7 +93,7 @@ so by specifying the git repo as a gem source. Just make sure you add
 the following to your `Gemfile`:
 
 ```Ruby
-gem "libv8", github: "cowboyd/libv8", submodules: true
+gem "libv8", github: "rubyjs/libv8", submodules: true
 ```
 
 You can find more info on using a git repo as a gem source in
@@ -107,7 +106,7 @@ platform, we'll pull it right in!
 
 To get the source, these commands will get you started:
 
-    git clone --recursive git://github.com/cowboyd/libv8.git
+    git clone --recursive git://github.com/rubyjs/libv8.git
     cd libv8
     bundle install
     bundle exec rake compile
@@ -115,7 +114,7 @@ To get the source, these commands will get you started:
 ### About
 
 This project spun off of
-[therubyracer](http://github.com/cowboyd/therubyracer) which depends
+[therubyracer](http://github.com/rubyjs/therubyracer) which depends
 on having a specific version of V8 to compile and run against.
 However, actually delivering that version reliably to all the
 different platforms proved to be a challenge to say the least.

data/Rakefile

@@ -1,6 +1,7 @@
 require 'bundler/setup'
 require 'rspec/core/rake_task'
 require 'tmpdir'
+require 'rubygems/package'
 
 Bundler::GemHelper.install_tasks
 RSpec::Core::RakeTask.new :spec
@@ -20,9 +21,20 @@ DISTRIBUTIONS = [
 module Helpers
   module_function
   def binary_gemspec(platform = Gem::Platform.local)
-    gemspec = eval(File.read 'libv8.gemspec')
-    gemspec.platform = platform
-    gemspec
+    eval(File.read 'libv8.gemspec').tap do |gemspec|
+      gemspec.platform = platform
+      gemspec.extensions.clear
+
+      # We don't need most things for the binary
+      gemspec.files = []
+      gemspec.files += ['lib/libv8.rb', 'lib/libv8/version.rb']
+      gemspec.files += ['ext/libv8/location.rb', 'ext/libv8/paths.rb']
+      gemspec.files += ['ext/libv8/.location.yml']
+
+      # V8
+      gemspec.files += Dir['vendor/v8/include/**/*.h']
+      gemspec.files += Dir['vendor/v8/out.gn/**/*.a']
+    end
   end
 
   def binary_gem_name(platform = Gem::Platform.local)
@@ -38,28 +50,11 @@ end
 desc "build a binary gem #{Helpers.binary_gem_name}"
 task :binary => :compile do
   gemspec = Helpers.binary_gemspec
-  gemspec.extensions.clear
-
-  # We don't need most things for the binary
-  gemspec.files = []
-  gemspec.files += ['lib/libv8.rb', 'lib/libv8/version.rb']
-  gemspec.files += ['ext/libv8/location.rb', 'ext/libv8/paths.rb']
-  gemspec.files += ['ext/libv8/.location.yml']
-
-  # V8
-  gemspec.files += Dir['vendor/v8/include/**/*.h']
-  gemspec.files += Dir['vendor/v8/out.gn/**/*.a']
 
   FileUtils.chmod 0644, gemspec.files
   FileUtils.mkdir_p 'pkg'
 
-  package = if Gem::VERSION < '2.0.0'
-    Gem::Builder.new(gemspec).build
-  else
-    require 'rubygems/package'
-    Gem::Package.build gemspec
-  end
-
+  package = Gem::Package.build gemspec
   FileUtils.mv package, 'pkg'
 end
 
@@ -110,22 +105,21 @@ end
 task :default => [:compile, :spec]
 task :build => [:clean]
 
-task :repack, [:gemfile, :new_arch] do |t, args|
-  dir = Dir::mktmpdir
-
-  begin
-    sh "gem unpack #{args[:gemfile]} --target=#{dir}"
-    sh "gem spec #{args[:gemfile]} --ruby > #{dir}/repack.gemspec"
-    Dir.chdir(dir) do
-      sh "sed -iorig 's/^  s.platform = .*$/  s.platform = \"#{args[:new_arch]}\".freeze/' repack.gemspec"
-      Dir.chdir(Dir.glob("libv8-*/").first) do
-        sh 'mv ../repack.gemspec ./'
-        sh 'gem build repack.gemspec'
+desc 'Generate OSX platform builds. Although any v8 OSX compile will run on any Mac OS version down to 10.10, RubyGems requires us to submit all of the different platforms seperately. Requires `compile` to already have been run, but is seperate for Travis reasons.'
+task :osx_varients do
+  gemspec = Helpers.binary_gemspec
+  next unless Gem::Platform.local.os == 'darwin'
+
+  [15, 16, 17, 18, 19].each do |version|
+    %w(x86_64 universal).each do |cpu|
+
+      gemspec.platform = Gem::Platform.local.tap do |platform|
+        platform.cpu = cpu
+        platform.version = version
       end
-    end
 
-    sh "mv #{dir}/*/*.gem ./pkg/"
-  ensure
-    FileUtils.remove_entry_secure dir
+      package = Gem::Package.build gemspec
+      FileUtils.mv package, 'pkg'
+    end
   end
 end

data/ext/libv8/builder.rb

@@ -23,7 +23,8 @@ module Libv8
          v8_use_external_startup_data=false
          target_cpu="#{libv8_arch}"
          v8_target_cpu="#{libv8_arch}"
-         treat_warnings_as_errors=false).join(' ')
+         treat_warnings_as_errors=false
+         icu_use_data_file=false).join(' ')
     end
 
     def generate_gn_args

data/ext/libv8/location.rb

@@ -13,7 +13,7 @@ module Libv8
 
     def self.load!
       File.open(Pathname(__FILE__).dirname.join('.location.yml')) do |f|
-        YAML.load f
+        YAML.respond_to?(:unsafe_load) ? YAML.unsafe_load(f) : YAML.load(f) # rubocop:disable Security/YAMLLoad
       end
     end
 

data/lib/libv8/version.rb

@@ -1,3 +1,3 @@
 module Libv8
-  VERSION = "7.8.279.23.0beta1"
+  VERSION = "8.4.255.0.1"
 end

data/libv8.gemspec

@@ -7,13 +7,11 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Charles Lowell"]
   s.email       = ["cowboyd@thefrontside.net"]
-  s.homepage    = "http://github.com/cowboyd/libv8"
+  s.homepage    = "http://github.com/rubyjs/libv8"
   s.summary     = %q{Distribution of the V8 JavaScript engine}
   s.description = %q{Distributes the V8 JavaScript engine in binary and source forms in order to support fast builds of The Ruby Racer}
   s.license     = "MIT"
 
-  s.rubyforge_project = "libv8"
-
   s.files  = `git ls-files`.split("\n").reject {|f| f =~ /^release\//}
 
   submodules = `git submodule --quiet foreach 'echo $path'`.split("\n").map(&:chomp)

data/vendor/depot_tools/.gitattributes

@@ -10,6 +10,7 @@
 /*.sh  recipes
 
 # vpython specs
+/.vpython*      recipes
 /gsutil.vpython recipes
 
 # Extensionless tools we want and support scripts.
@@ -37,7 +38,6 @@
 # TODO: There are some really junky dependencies in here that we should probably
 # move to vpython/cipd.
 /third_party/**                     recipes
-/third_party/pymox/**              -recipes
 
 /win_toolchain/** recipes
 

data/vendor/depot_tools/.gitignore

@@ -13,10 +13,10 @@
 /git-bash
 /git.bat
 /gitk.bat
-/pylint.bat
 /.pylint.d/
 /python
 /python.bat
+/python3.bat
 /ssh.bat
 /ssh-keygen.bat
 /svn
@@ -32,8 +32,10 @@
 /.subversion
 
 # Ignore locations where third-party tools are placed during bootstrapping.
+/bootstrap*_bin
 /python*_bin
 /python_bin_reldir.txt
+/python3_bin_reldir.txt
 /win_tools*_bin
 /git_bin
 /git-*_bin

data/vendor/depot_tools/.style.yapf

@@ -1,2 +1,4 @@
 [style]
-based_on_style = chromium
+based_on_style = pep8
+indent_width = 2
+column_limit = 80

data/vendor/depot_tools/.vpython

@@ -0,0 +1,55 @@
+python_version: "2.7"
+
+# Used by:
+#   auth.py
+#   gerrit_util.py
+#   git_cl.py
+#   my_activity.py
+#   TODO(crbug.com/1002153): Add ninjalog_uploader.py
+wheel: <
+  name: "infra/python/wheels/httplib2-py2_py3"
+  version: "version:0.10.3"
+>
+
+# Used by:
+#   my_activity.py
+wheel: <
+  name: "infra/python/wheels/python-dateutil-py2_py3"
+  version: "version:2.7.3"
+>
+wheel: <
+  name: "infra/python/wheels/six-py2_py3"
+  version: "version:1.10.0"
+>
+
+# Used by:
+#   tests/auth_test.py
+#   tests/detect_host_arch_test.py
+#   tests/gclient_scm_test.py
+#   tests/gclient_test.py
+#   tests/gclient_utils_test.py
+#   tests/gerrit_util_test.py
+#   tests/git_cl_test.py
+#   tests/git_drover_test.py
+#   tests/git_footers_test.py
+#   tests/metrics_test.py
+#   tests/presubmit_unittest.py
+#   tests/scm_unittest.py
+#   tests/subprocess2_test.py
+#   tests/watchlists_unittest.py
+wheel: <
+  name: "infra/python/wheels/mock-py2_py3"
+  version: "version:2.0.0"
+>
+wheel <
+  name: "infra/python/wheels/funcsigs-py2_py3"
+  version: "version:1.0.2"
+>
+wheel: <
+  name: "infra/python/wheels/pbr-py2_py3"
+  version: "version:3.0.0"
+>
+wheel: <
+  name: "infra/python/wheels/six-py2_py3"
+  version: "version:1.10.0"
+>

data/vendor/depot_tools/.vpython3

@@ -0,0 +1,23 @@
+python_version: "3.8"
+
+# Used by:
+#   auth.py
+#   gerrit_util.py
+#   git_cl.py
+#   my_activity.py
+#   TODO(crbug.com/1002153): Add ninjalog_uploader.py
+wheel: <
+  name: "infra/python/wheels/httplib2-py3"
+  version: "version:0.13.1"
+>
+
+# Used by:
+#   my_activity.py
+wheel: <
+  name: "infra/python/wheels/python-dateutil-py2_py3"
+  version: "version:2.7.3"
+>
+wheel: <
+  name: "infra/python/wheels/six-py2_py3"
+  version: "version:1.10.0"
+>

data/vendor/depot_tools/CROS_OWNERS

@@ -1,5 +1,7 @@
 # Chrome OS developers looking over Chrome OS related files.
-lamont@chromium.org
+cjmcdonald@chromium.org
+lamontjones@chromium.org
+mmortensen@google.com
 nednguyen@chromium.org
 saklein@chromium.org
 vapier@chromium.org

data/vendor/depot_tools/GOMA_OWNERS

@@ -0,0 +1,9 @@
+sque@chromium.org
+sque@google.com
+tikuta@chromium.org
+tikuta@google.com
+ukai@chromium.org
+ukai@google.com
+yekuang@google.com
+yyanagisawa@chromium.org
+yyanagisawa@google.com

data/vendor/depot_tools/LUCI_OWNERS

@@ -0,0 +1,5 @@
+iannucci@chromium.org
+nodir@chromium.org
+tandrii@chromium.org
+tandrii@google.com
+vadimsh@chromium.org

data/vendor/depot_tools/OWNERS

@@ -1,24 +1,39 @@
 set noparent
 
-agable@chromium.org
+apolito@google.com
 dpranke@chromium.org
+dpranke@google.com
 ehmaldonado@chromium.org
-hinoka@chromium.org
-iannucci@chromium.org
+ehmaldonado@google.com
 jochen@chromium.org
-maruel@chromium.org
-nodir@chromium.org
-tandrii@chromium.org
+sokcevic@google.com
 
 per-file ninja*=thakis@chromium.org
 per-file ninja*=scottmg@chromium.org
 
 per-file autoninja*=brucedawson@chromium.org
+per-file post_build_ninja_summary.py=brucedawson@chromium.org
 
 per-file ninjalog*=tikuta@chromium.org
 
+per-file pylint*=vapier@chromium.org
+
 per-file cbuildbot=file://CROS_OWNERS
 per-file chrome_set_ver=file://CROS_OWNERS
 per-file cros=file://CROS_OWNERS
 per-file cros_sdk=file://CROS_OWNERS
 per-file repo=file://CROS_OWNERS
+per-file CROS_OWNERS=file://CROS_OWNERS
+
+# for the Goma client update
+per-file cipd_manifest*=file://GOMA_OWNERS
+
+# LUCI related tooling
+per-file bb*=file://LUCI_OWNERS
+per-file cipd*=file://LUCI_OWNERS
+per-file cit*=file://LUCI_OWNERS
+per-file led*=file://LUCI_OWNERS
+per-file luci*=file://LUCI_OWNERS
+per-file vpython*=file://LUCI_OWNERS
+
+# COMPONENT: Infra>SDK

data/vendor/depot_tools/PRESUBMIT.py

@@ -10,6 +10,7 @@ details on the presubmit API built into depot_tools.
 
 import fnmatch
 import os
+import sys
 
 
 # CIPD ensure manifest for checking CIPD client itself.
@@ -24,25 +25,29 @@ $VerifiedPlatform linux-mips64 linux-mips64le linux-mipsle
 %s %s
 '''
 
+# Timeout for a test to be executed.
+TEST_TIMEOUT_S = 330  # 5m 30s
+
+
 
 def DepotToolsPylint(input_api, output_api):
   """Gather all the pylint logic into one place to make it self-contained."""
-  white_list = [
+  files_to_check = [
     r'^[^/]*\.py$',
     r'^testing_support/[^/]*\.py$',
     r'^tests/[^/]*\.py$',
     r'^recipe_modules/.*\.py$',  # Allow recursive search in recipe modules.
   ]
-  black_list = list(input_api.DEFAULT_BLACK_LIST)
+  files_to_skip = list(input_api.DEFAULT_FILES_TO_SKIP)
   if os.path.exists('.gitignore'):
     with open('.gitignore') as fh:
       lines = [l.strip() for l in fh.readlines()]
-      black_list.extend([fnmatch.translate(l) for l in lines if
+      files_to_skip.extend([fnmatch.translate(l) for l in lines if
                          l and not l.startswith('#')])
   if os.path.exists('.git/info/exclude'):
     with open('.git/info/exclude') as fh:
       lines = [l.strip() for l in fh.readlines()]
-      black_list.extend([fnmatch.translate(l) for l in lines if
+      files_to_skip.extend([fnmatch.translate(l) for l in lines if
                          l and not l.startswith('#')])
   disabled_warnings = [
     'R0401',  # Cyclic import
@@ -51,22 +56,33 @@ def DepotToolsPylint(input_api, output_api):
   return input_api.canned_checks.GetPylint(
       input_api,
       output_api,
-      white_list=white_list,
-      black_list=black_list,
+      files_to_check=files_to_check,
+      files_to_skip=files_to_skip,
       disabled_warnings=disabled_warnings)
 
 
-def CommonChecks(input_api, output_api, tests_to_black_list):
+def CommonChecks(input_api, output_api, tests_to_skip_list, run_on_python3):
+  input_api.SetTimeout(TEST_TIMEOUT_S)
+
   results = []
   results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
   results.extend(input_api.canned_checks.CheckOwnersFormat(
       input_api, output_api))
+  results.extend(input_api.canned_checks.CheckJsonParses(
+      input_api, output_api))
 
   # Run only selected tests on Windows.
-  tests_to_white_list = [r'.*test\.py$']
+  test_to_run_list = [r'.*test\.py$']
   if input_api.platform.startswith(('cygwin', 'win32')):
     print('Warning: skipping most unit tests on Windows')
-    tests_to_white_list = [r'.*cipd_bootstrap_test\.py$']
+    tests_to_skip_list = [
+        r'.*auth_test\.py$',
+        r'.*git_common_test\.py$',
+        r'.*git_hyper_blame_test\.py$',
+        r'.*git_map_test\.py$',
+        r'.*ninjalog_uploader_test\.py$',
+        r'.*recipes_test\.py$',
+    ]
 
   # TODO(maruel): Make sure at least one file is modified first.
   # TODO(maruel): If only tests are modified, only run them.
@@ -75,8 +91,9 @@ def CommonChecks(input_api, output_api, tests_to_black_list):
       input_api,
       output_api,
       'tests',
-      whitelist=tests_to_white_list,
-      blacklist=tests_to_black_list))
+      allowlist=test_to_run_list,
+      blocklist=tests_to_skip_list,
+      run_on_python3=run_on_python3))
 
   # Validate CIPD manifests.
   root = input_api.os_path.normpath(
@@ -84,8 +101,8 @@ def CommonChecks(input_api, output_api, tests_to_black_list):
   rel_file = lambda rel: input_api.os_path.join(root, rel)
   cipd_manifests = set(rel_file(input_api.os_path.join(*x)) for x in (
     ('cipd_manifest.txt',),
-    ('bootstrap', 'win', 'manifest.txt'),
-    ('bootstrap', 'win', 'manifest_bleeding_edge.txt'),
+    ('bootstrap', 'manifest.txt'),
+    ('bootstrap', 'manifest_bleeding_edge.txt'),
 
     # Also generate a file for the cipd client itself.
     ('cipd_client_version',),
@@ -114,19 +131,19 @@ def CommonChecks(input_api, output_api, tests_to_black_list):
 
 def CheckChangeOnUpload(input_api, output_api):
   # Do not run integration tests on upload since they are way too slow.
-  tests_to_black_list = [
+  tests_to_skip_list = [
       r'^checkout_test\.py$',
       r'^cipd_bootstrap_test\.py$',
       r'^gclient_smoketest\.py$',
-      r'^scm_unittest\.py$',
-      r'^subprocess2_test\.py$',
   ]
-  return CommonChecks(input_api, output_api, tests_to_black_list)
+  # TODO(ehmaldonado): Run Python 3 tests on upload once Python 3 is
+  # bootstrapped on Linux and Mac.
+  return CommonChecks(input_api, output_api, tests_to_skip_list, False)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   output = []
-  output.extend(CommonChecks(input_api, output_api, []))
+  output.extend(CommonChecks(input_api, output_api, [], True))
   output.extend(input_api.canned_checks.CheckDoNotSubmit(
       input_api,
       output_api))

data/vendor/depot_tools/README.git-cl.md

@@ -6,20 +6,6 @@ git but unfamiliar with the code review process supported by Rietveld and
 Gerrit.
 
 
-## Rietveld concepts and terms
-
-A Rietveld review is for discussion of a single change or patch. You upload a
-proposed change, the reviewer comments on your change, and then you can upload a
-revised version of your change. Rietveld stores the history of uploaded patches
-as well as the comments, and can compute diffs in between these patches. The
-history of a patch is very much like a small branch in git, but since Rietveld
-is VCS-agnostic, the concepts don't map perfectly. The identifier for a single
-review thread including patches and comments in Rietveld is called an **issue**.
-
-Rietveld provides a basic uploader that understands git. This program is used by
-git-cl, and is included in the git-cl repo as upload.py.
-
-
 ## Basic interaction with git
 
 The fundamental problem you encounter when you try to mix git and code review is

data/vendor/depot_tools/README.md

@@ -1,6 +1,6 @@
 # depot_tools
 
-Tools for working with Chromium development. It requires python 2.7.
+Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
 
 
 ## Tools

data/vendor/depot_tools/WATCHLISTS

@@ -1,4 +1,4 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright (c) 2019 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -19,7 +19,7 @@
   'WATCHLISTS': {
     'this_file': [],
     'depot_tools': [
-      'iannucci+depot_tools@chromium.org',
+      'chops-source-team+depot_tools@google.com',
     ],
   },