libv8 7.3.492.27.1 → 8.4.255.0

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/__init__.py

@@ -1,4 +0,0 @@
-DEPS = [
-  'recipe_engine/path',
-  'recipe_engine/properties',
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/api.py

@@ -1,29 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from recipe_engine import recipe_api
-
-
-class InfraPathsApi(recipe_api.RecipeApi):
-  """infra_paths module is glue for design mistakes. It will be removed."""
-
-  def initialize(self):
-    path_config = self.m.properties.get('path_config')
-    if path_config:
-      # TODO(phajdan.jr): remove dupes from the engine and delete infra_ prefix.
-      self.m.path.set_config('infra_' + path_config)
-
-  @property
-  def default_git_cache_dir(self):
-    """Returns the location of the default git cache directory.
-
-    This property should be used instead of using path['git_cache'] directly.
-
-    It returns git_cache path if it is defined (Buildbot world), otherwise
-    uses the more generic [CACHE]/git path (LUCI world).
-    """
-    try:
-      return self.m.path['git_cache']
-    except KeyError:
-      return self.m.path['cache'].join('git')

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/basic.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'cache': ('/', 'b', 'c'), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('cache', 'git')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_buildbot_linux.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'build.dead'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_buildbot_mac.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'build.dead'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_buildbot_win.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('C:\\\\', 'b', 'FakeTestingCWD'), 'cleanup': ('C:\\\\', 'b', 'build.dead'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('C:\\\\',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_generic_linux.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_generic_mac.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_generic_win.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('C:\\\\', 'b', 'c', 'builder'), 'cache': ('C:\\\\', 'b', 'c'), 'goma_cache': ('C:\\\\', 'b', 'c', 'goma'), 'start_dir': ('C:\\\\', 'b', 'FakeTestingCWD'), 'cleanup': ('C:\\\\', 'b', 'cleanup'), 'git_cache': ('C:\\\\', 'b', 'c', 'git'), 'tmp_base': ('C:\\\\',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_linux.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_mac.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_win.json

@@ -1,15 +0,0 @@
-[
-  {
-    "cmd": [],
-    "name": "show paths",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('C:\\\\', 'b', 'c', 'b'), 'cache': ('C:\\\\', 'b', 'c'), 'goma_cache': ('C:\\\\', 'b', 'c', 'goma_cache'), 'start_dir': ('C:\\\\', 'b', 'FakeTestingCWD'), 'cleanup': ('C:\\\\', 'b', 'cleanup'), 'git_cache': ('C:\\\\', 'b', 'c', 'git_cache'), 'root': ('C:\\\\', 'b', 'FakeTestingCWD'), 'tmp_base': ('C:\\\\',)}@@@",
-      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
-      "@@@STEP_LOG_END@result@@@"
-    ]
-  },
-  {
-    "jsonResult": null,
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.py

@@ -1,33 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import json
-
-DEPS = [
-  'infra_paths',
-  'recipe_engine/path',
-  'recipe_engine/platform',
-  'recipe_engine/properties',
-  'recipe_engine/step',
-]
-
-
-def RunSteps(api):
-  api.step('show paths', [])
-  api.step.active_result.presentation.logs['result'] = [
-    'base_paths: %r' % (api.path.c.base_paths,),
-    'default_git_cache_dir: %r' % (api.infra_paths.default_git_cache_dir,),
-  ]
-
-
-def GenTests(api):
-  yield api.test('basic')
-
-  for platform in ('linux', 'mac', 'win'):
-    for path_config in ('buildbot', 'kitchen', 'generic'):
-      yield (
-          api.test('paths_%s_%s' % (path_config, platform)) +
-          api.platform.name(platform) +
-          api.properties(path_config=path_config)
-      )

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/path_config.py

@@ -1,66 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from RECIPE_MODULES.recipe_engine.path import CONFIG_CTX
-
-
-@CONFIG_CTX()
-def infra_common(c):
-  c.dynamic_paths['checkout'] = None
-
-
-@CONFIG_CTX(includes=['infra_common'])
-def infra_buildbot(c):
-  """Used on BuildBot by "annotated_run"."""
-  c.base_paths['root'] = c.START_DIR[:-4]
-  c.base_paths['cache'] = c.base_paths['root'] + (
-      'build', 'slave', 'cache')
-  c.base_paths['git_cache'] = c.base_paths['root'] + (
-      'build', 'slave', 'cache_dir')
-  c.base_paths['cleanup'] = c.START_DIR[:-1] + ('build.dead',)
-  c.base_paths['goma_cache'] = c.base_paths['root'] + (
-      'build', 'slave', 'goma_cache')
-  for token in ('build_internal', 'build', 'depot_tools'):
-    c.base_paths[token] = c.base_paths['root'] + (token,)
-
-
-@CONFIG_CTX(includes=['infra_common'])
-def infra_kitchen(c):
-  """Used on BuildBot by "remote_run" when NOT running Kitchen."""
-  c.base_paths['root'] = c.START_DIR
-  # TODO(phajdan.jr): have one cache dir, let clients append suffixes.
-
-  b_dir = c.START_DIR
-  while b_dir and b_dir[-1] != 'b':
-    b_dir = b_dir[:-1]
-
-  if c.PLATFORM in ('linux', 'mac'):
-    c.base_paths['cache'] = ('/', 'b', 'c')
-    c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
-    for path in ('git_cache', 'goma_cache'):
-      c.base_paths[path] = c.base_paths['cache'] + (path,)
-  elif b_dir:
-    c.base_paths['cache'] = b_dir + ('c',)
-    c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
-    for path in ('git_cache', 'goma_cache'):
-      c.base_paths[path] = c.base_paths['cache'] + (path,)
-  else:  # pragma: no cover
-    c.base_paths['cache'] = c.base_paths['root'] + ('c',)
-    c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
-    c.base_paths['git_cache'] = c.base_paths['root'] + ('cache_dir',)
-    for path in ('goma_cache',):
-      c.base_paths[path] = c.base_paths['cache'] + (path,)
-
-
-@CONFIG_CTX()
-def infra_generic(c):
-  """Used by Kitchen runs on both SwarmBucket and "remote_run"+Kitchen.
-
-  The default path values (ones not set explicitly here) are either installed by
-  Kitchen directly, or are recipe engine defaults. Note that in "kitchen",
-  the "start_dir" is ephemeral.
-  """
-  c.base_paths['builder_cache'] = c.base_paths['cache'] + ('builder',)
-  c.base_paths['git_cache'] = c.base_paths['cache'] + ('git',)
-  c.base_paths['goma_cache'] = c.base_paths['cache'] + ('goma',)

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.expected/set_failure_hash_with_no_steps.json

@@ -1,11 +0,0 @@
-[
-  {
-    "failure": {
-      "failure": {
-        "step": ""
-      },
-      "humanReason": "boom!"
-    },
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.expected/with_git_patch.json

@@ -1,45 +0,0 @@
-[
-  {
-    "cmd": [
-      "git",
-      "-c",
-      "core.quotePath=false",
-      "diff",
-      "--cached",
-      "--name-only"
-    ],
-    "cwd": "[START_DIR]/v8",
-    "infra_step": true,
-    "name": "git diff to analyze patch",
-    "stdout": "/path/to/tmp/",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@files@v8/foo.cc@@@",
-      "@@@STEP_LOG_END@files@@@",
-      "@@@SET_BUILD_PROPERTY@do_not_retry@true@@@",
-      "@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",
-      "@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"
-    ]
-  },
-  {
-    "cmd": [
-      "python",
-      "-u",
-      "import sys; sys.exit(1)"
-    ],
-    "name": "fail",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@foo@@@",
-      "@@@STEP_FAILURE@@@",
-      "@@@SET_BUILD_PROPERTY@failure_hash@\"c2311ad770732eade3d2f48247abd147e40a70e7\"@@@"
-    ]
-  },
-  {
-    "failure": {
-      "failure": {
-        "step": "fail"
-      },
-      "humanReason": "Step('fail') failed with return_code 1"
-    },
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.expected/with_git_patch_luci.json

@@ -1,45 +0,0 @@
-[
-  {
-    "cmd": [
-      "git",
-      "-c",
-      "core.quotePath=false",
-      "diff",
-      "--cached",
-      "--name-only"
-    ],
-    "cwd": "[START_DIR]/v8",
-    "infra_step": true,
-    "name": "git diff to analyze patch",
-    "stdout": "/path/to/tmp/",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@files@v8/foo.cc@@@",
-      "@@@STEP_LOG_END@files@@@",
-      "@@@SET_BUILD_PROPERTY@do_not_retry@true@@@",
-      "@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",
-      "@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"
-    ]
-  },
-  {
-    "cmd": [
-      "python",
-      "-u",
-      "import sys; sys.exit(1)"
-    ],
-    "name": "fail",
-    "~followup_annotations": [
-      "@@@STEP_TEXT@foo@@@",
-      "@@@STEP_FAILURE@@@",
-      "@@@SET_BUILD_PROPERTY@failure_hash@\"c2311ad770732eade3d2f48247abd147e40a70e7\"@@@"
-    ]
-  },
-  {
-    "failure": {
-      "failure": {
-        "step": "fail"
-      },
-      "humanReason": "Step('fail') failed with return_code 1"
-    },
-    "name": "$result"
-  }
-]

data/vendor/depot_tools/rietveld.py

@@ -1,779 +0,0 @@
-# coding: utf-8
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-"""Defines class Rietveld to easily access a rietveld instance.
-
-Security implications:
-
-The following hypothesis are made:
-- Rietveld enforces:
-  - Nobody else than issue owner can upload a patch set
-  - Verifies the issue owner credentials when creating new issues
-  - A issue owner can't change once the issue is created
-  - A patch set cannot be modified
-"""
-
-import copy
-import errno
-import json
-import logging
-import re
-import socket
-import ssl
-import StringIO
-import sys
-import time
-import urllib
-import urllib2
-import urlparse
-
-import patch
-
-from third_party import upload
-import third_party.oauth2client.client as oa2client
-from third_party import httplib2
-
-# Appengine replies with 302 when authentication fails (sigh.)
-oa2client.REFRESH_STATUS_CODES.append(302)
-upload.LOGGER.setLevel(logging.WARNING)  # pylint: disable=E1103
-
-
-class Rietveld(object):
-  """Accesses rietveld."""
-  def __init__(
-      self, url, auth_config, email=None, extra_headers=None, maxtries=None):
-    self.url = url.rstrip('/')
-    self.rpc_server = upload.GetRpcServer(self.url, auth_config, email)
-
-    self._xsrf_token = None
-    self._xsrf_token_time = None
-
-    self._maxtries = maxtries or 40
-
-  def xsrf_token(self):
-    if (not self._xsrf_token_time or
-        (time.time() - self._xsrf_token_time) > 30*60):
-      self._xsrf_token_time = time.time()
-      self._xsrf_token = self.get(
-          '/xsrf_token',
-          extra_headers={'X-Requesting-XSRF-Token': '1'})
-    return self._xsrf_token
-
-  def get_pending_issues(self):
-    """Returns an array of dict of all the pending issues on the server."""
-    # TODO: Convert this to use Rietveld::search(), defined below.
-    return json.loads(
-        self.get('/search?format=json&commit=2&closed=3&'
-                 'keys_only=True&limit=1000&order=__key__'))['results']
-
-  def close_issue(self, issue):
-    """Closes the Rietveld issue for this changelist."""
-    logging.info('closing issue %d' % issue)
-    self.post("/%d/close" % issue, [('xsrf_token', self.xsrf_token())])
-
-  def get_description(self, issue, force=False):
-    """Returns the issue's description.
-
-    Converts any CRLF into LF and strip extraneous whitespace.
-    """
-    return '\n'.join(self.get('/%d/description' % issue).strip().splitlines())
-
-  def get_issue_properties(self, issue, messages):
-    """Returns all the issue's metadata as a dictionary."""
-    url = '/api/%d' % issue
-    if messages:
-      url += '?messages=true'
-    data = json.loads(self.get(url, retry_on_404=True))
-    data['description'] = '\n'.join(data['description'].strip().splitlines())
-    return data
-
-  def get_depends_on_patchset(self, issue, patchset):
-    """Returns the patchset this patchset depends on if it exists."""
-    url = '/%d/patchset/%d/get_depends_on_patchset' % (issue, patchset)
-    resp = None
-    try:
-      resp = json.loads(self.get(url))
-    except (urllib2.HTTPError, ValueError):
-      # The get_depends_on_patchset endpoint does not exist on this Rietveld
-      # instance yet. Ignore the error and proceed.
-      # TODO(rmistry): Make this an error when all Rietveld instances have
-      # this endpoint.
-      pass
-    return resp
-
-  def get_patchset_properties(self, issue, patchset):
-    """Returns the patchset properties."""
-    url = '/api/%d/%d' % (issue, patchset)
-    return json.loads(self.get(url))
-
-  def get_file_content(self, issue, patchset, item):
-    """Returns the content of a new file.
-
-    Throws HTTP 302 exception if the file doesn't exist or is not a binary file.
-    """
-    # content = 0 is the old file, 1 is the new file.
-    content = 1
-    url = '/%d/binary/%d/%d/%d' % (issue, patchset, item, content)
-    return self.get(url)
-
-  def get_file_diff(self, issue, patchset, item):
-    """Returns the diff of the file.
-
-    Returns a useless diff for binary files.
-    """
-    url = '/download/issue%d_%d_%d.diff' % (issue, patchset, item)
-    return self.get(url)
-
-  def get_patch(self, issue, patchset):
-    """Returns a PatchSet object containing the details to apply this patch."""
-    props = self.get_patchset_properties(issue, patchset) or {}
-    out = []
-    for filename, state in props.get('files', {}).iteritems():
-      logging.debug('%s' % filename)
-      # If not status, just assume it's a 'M'. Rietveld often gets it wrong and
-      # just has status: null. Oh well.
-      status = state.get('status') or 'M'
-      if status[0] not in ('A', 'D', 'M', 'R'):
-        raise patch.UnsupportedPatchFormat(
-            filename, 'Change with status \'%s\' is not supported.' % status)
-
-      svn_props = self.parse_svn_properties(
-          state.get('property_changes', ''), filename)
-
-      if state.get('is_binary'):
-        if status[0] == 'D':
-          if status[0] != status.strip():
-            raise patch.UnsupportedPatchFormat(
-                filename, 'Deleted file shouldn\'t have property change.')
-          out.append(patch.FilePatchDelete(filename, state['is_binary']))
-        else:
-          content = self.get_file_content(issue, patchset, state['id'])
-          if not content or content == 'None':
-            # As a precaution due to a bug in upload.py for git checkout, refuse
-            # empty files. If it's empty, it's not a binary file.
-            raise patch.UnsupportedPatchFormat(
-                filename,
-                'Binary file is empty. Maybe the file wasn\'t uploaded in the '
-                'first place?')
-          out.append(patch.FilePatchBinary(
-              filename,
-              content,
-              svn_props,
-              is_new=(status[0] == 'A')))
-        continue
-
-      try:
-        diff = self.get_file_diff(issue, patchset, state['id'])
-      except urllib2.HTTPError, e:
-        if e.code == 404:
-          raise patch.UnsupportedPatchFormat(
-              filename, 'File doesn\'t have a diff.')
-        raise
-
-      # FilePatchDiff() will detect file deletion automatically.
-      p = patch.FilePatchDiff(filename, diff, svn_props)
-      out.append(p)
-      if status[0] == 'A':
-        # It won't be set for empty file.
-        p.is_new = True
-      if (len(status) > 1 and
-          status[1] == '+' and
-          not (p.source_filename or p.svn_properties)):
-        raise patch.UnsupportedPatchFormat(
-            filename, 'Failed to process the svn properties')
-
-    return patch.PatchSet(out)
-
-  @staticmethod
-  def parse_svn_properties(rietveld_svn_props, filename):
-    """Returns a list of tuple [('property', 'newvalue')].
-
-    rietveld_svn_props is the exact format from 'svn diff'.
-    """
-    rietveld_svn_props = rietveld_svn_props.splitlines()
-    svn_props = []
-    if not rietveld_svn_props:
-      return svn_props
-    # 1. Ignore svn:mergeinfo.
-    # 2. Accept svn:eol-style and svn:executable.
-    # 3. Refuse any other.
-    # \n
-    # Added: svn:ignore\n
-    #    + LF\n
-
-    spacer = rietveld_svn_props.pop(0)
-    if spacer or not rietveld_svn_props:
-      # svn diff always put a spacer between the unified diff and property
-      # diff
-      raise patch.UnsupportedPatchFormat(
-          filename, 'Failed to parse svn properties.')
-
-    while rietveld_svn_props:
-      # Something like 'Added: svn:eol-style'. Note the action is localized.
-      # *sigh*.
-      action = rietveld_svn_props.pop(0)
-      match = re.match(r'^(\w+): (.+)$', action)
-      if not match or not rietveld_svn_props:
-        raise patch.UnsupportedPatchFormat(
-            filename,
-            'Failed to parse svn properties: %s, %s' % (action, svn_props))
-
-      if match.group(2) == 'svn:mergeinfo':
-        # Silently ignore the content.
-        rietveld_svn_props.pop(0)
-        continue
-
-      if match.group(1) not in ('Added', 'Modified'):
-        # Will fail for our French friends.
-        raise patch.UnsupportedPatchFormat(
-            filename, 'Unsupported svn property operation.')
-
-      if match.group(2) in ('svn:eol-style', 'svn:executable', 'svn:mime-type'):
-        # '   + foo' where foo is the new value. That's fragile.
-        content = rietveld_svn_props.pop(0)
-        match2 = re.match(r'^   \+ (.*)$', content)
-        if not match2:
-          raise patch.UnsupportedPatchFormat(
-              filename, 'Unsupported svn property format.')
-        svn_props.append((match.group(2), match2.group(1)))
-    return svn_props
-
-  def update_description(self, issue, description):
-    """Sets the description for an issue on Rietveld."""
-    logging.info('new description for issue %d' % issue)
-    self.post('/%d/description' % issue, [
-        ('description', description),
-        ('xsrf_token', self.xsrf_token())])
-
-  def add_comment(self, issue, message, add_as_reviewer=False):
-    max_message = 10000
-    tail = '…\n(message too large)'
-    if len(message) > max_message:
-      message = message[:max_message-len(tail)] + tail
-    logging.info('issue %d; comment: %s' % (issue, message.strip()[:300]))
-    return self.post('/%d/publish' % issue, [
-        ('xsrf_token', self.xsrf_token()),
-        ('message', message),
-        ('message_only', 'True'),
-        ('add_as_reviewer', str(bool(add_as_reviewer))),
-        ('send_mail', 'True'),
-        ('no_redirect', 'True')])
-
-  def add_inline_comment(
-      self, issue, text, side, snapshot, patchset, patchid, lineno):
-    logging.info('add inline comment for issue %d' % issue)
-    return self.post('/inline_draft', [
-        ('issue', str(issue)),
-        ('text', text),
-        ('side', side),
-        ('snapshot', snapshot),
-        ('patchset', str(patchset)),
-        ('patch', str(patchid)),
-         ('lineno', str(lineno))])
-
-  def set_flag(self, issue, patchset, flag, value):
-    return self.post('/%d/edit_flags' % issue, [
-        ('last_patchset', str(patchset)),
-        ('xsrf_token', self.xsrf_token()),
-        (flag, str(value))])
-
-  def set_flags(self, issue, patchset, flags):
-    return self.post('/%d/edit_flags' % issue, [
-        ('last_patchset', str(patchset)),
-        ('xsrf_token', self.xsrf_token()),
-        ] + [(flag, str(value)) for flag, value in flags.iteritems()])
-
-  def search(
-      self,
-      owner=None, reviewer=None,
-      base=None,
-      closed=None, private=None, commit=None,
-      created_before=None, created_after=None,
-      modified_before=None, modified_after=None,
-      per_request=None, keys_only=False,
-      with_messages=False):
-    """Yields search results."""
-    # These are expected to be strings.
-    string_keys = {
-        'owner': owner,
-        'reviewer': reviewer,
-        'base': base,
-        'created_before': created_before,
-        'created_after': created_after,
-        'modified_before': modified_before,
-        'modified_after': modified_after,
-    }
-    # These are either None, False or True.
-    three_state_keys = {
-      'closed': closed,
-      'private': private,
-      'commit': commit,
-    }
-    # The integer values were determined by checking HTML source of Rietveld on
-    # https://codereview.chromium.org/search. See also http://crbug.com/712060.
-    three_state_value_map = {
-        None: 1,   # Unknown.
-        True: 2,   # Yes.
-        False: 3,  # No.
-    }
-
-    url = '/search?format=json'
-    # Sort the keys mainly to ease testing.
-    for key in sorted(string_keys):
-      value = string_keys[key]
-      if value:
-        url += '&%s=%s' % (key, urllib2.quote(value))
-    for key in sorted(three_state_keys):
-      value = three_state_keys[key]
-      if value is not None:
-        url += '&%s=%d' % (key, three_state_value_map[value])
-
-    if keys_only:
-      url += '&keys_only=True'
-    if with_messages:
-      url += '&with_messages=True'
-    if per_request:
-      url += '&limit=%d' % per_request
-
-    cursor = ''
-    while True:
-      output = self.get(url + cursor)
-      if output.startswith('<'):
-        # It's an error message. Return as no result.
-        break
-      data = json.loads(output) or {}
-      if not data.get('results'):
-        break
-      for i in data['results']:
-        yield i
-      cursor = '&cursor=%s' % data['cursor']
-
-  def trigger_try_jobs(
-      self, issue, patchset, reason, clobber, revision, builders_and_tests,
-      master=None, category='cq'):
-    """Requests new try jobs.
-
-    |builders_and_tests| is a map of builders: [tests] to run.
-    |master| is the name of the try master the builders belong to.
-    |category| is used to distinguish regular jobs and experimental jobs.
-
-    Returns the keys of the new TryJobResult entites.
-    """
-    params = [
-      ('reason', reason),
-      ('clobber', 'True' if clobber else 'False'),
-      ('builders', json.dumps(builders_and_tests)),
-      ('xsrf_token', self.xsrf_token()),
-      ('category', category),
-    ]
-    if revision:
-      params.append(('revision', revision))
-    if master:
-      # Temporarily allow empty master names for old configurations. The try
-      # job will not be associated with a master name on rietveld. This is
-      # going to be deprecated.
-      params.append(('master', master))
-    return self.post('/%d/try/%d' % (issue, patchset), params)
-
-  def trigger_distributed_try_jobs(
-      self, issue, patchset, reason, clobber, revision, masters,
-      category='cq'):
-    """Requests new try jobs.
-
-    |masters| is a map of masters: map of builders: [tests] to run.
-    |category| is used to distinguish regular jobs and experimental jobs.
-    """
-    for (master, builders_and_tests) in masters.iteritems():
-      self.trigger_try_jobs(
-          issue, patchset, reason, clobber, revision, builders_and_tests,
-          master, category)
-
-  def get_pending_try_jobs(self, cursor=None, limit=100):
-    """Retrieves the try job requests in pending state.
-
-    Returns a tuple of the list of try jobs and the cursor for the next request.
-    """
-    url = '/get_pending_try_patchsets?limit=%d' % limit
-    extra = ('&cursor=' + cursor) if cursor else ''
-    data = json.loads(self.get(url + extra))
-    return data['jobs'], data['cursor']
-
-  def get(self, request_path, **kwargs):
-    kwargs.setdefault('payload', None)
-    return self._send(request_path, **kwargs)
-
-  def post(self, request_path, data, **kwargs):
-    ctype, body = upload.EncodeMultipartFormData(data, [])
-    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
-
-  def _send(self, request_path, retry_on_404=False, **kwargs):
-    """Sends a POST/GET to Rietveld.  Returns the response body."""
-    # rpc_server.Send() assumes timeout=None by default; make sure it's set
-    # to something reasonable.
-    kwargs.setdefault('timeout', 15)
-    logging.debug('POSTing to %s, args %s.', request_path, kwargs)
-    try:
-      # Sadly, upload.py calls ErrorExit() which does a sys.exit(1) on HTTP
-      # 500 in AbstractRpcServer.Send().
-      old_error_exit = upload.ErrorExit
-      def trap_http_500(msg):
-        """Converts an incorrect ErrorExit() call into a HTTPError exception."""
-        m = re.search(r'(50\d) Server Error', msg)
-        if m:
-          # Fake an HTTPError exception. Cheezy. :(
-          raise urllib2.HTTPError(
-              request_path, int(m.group(1)), msg, None, StringIO.StringIO())
-        old_error_exit(msg)
-      upload.ErrorExit = trap_http_500
-
-      for retry in xrange(self._maxtries):
-        try:
-          logging.debug('%s' % request_path)
-          return self.rpc_server.Send(request_path, **kwargs)
-        except urllib2.HTTPError, e:
-          if retry >= (self._maxtries - 1):
-            raise
-          flake_codes = {500, 502, 503}
-          if retry_on_404:
-            flake_codes.add(404)
-          if e.code not in flake_codes:
-            raise
-        except urllib2.URLError, e:
-          if retry >= (self._maxtries - 1):
-            raise
-
-          def is_transient():
-            # The idea here is to retry if the error isn't permanent.
-            # Unfortunately, there are so many different possible errors,
-            # that we end up enumerating those that are known to us to be
-            # transient.
-            # The reason can be a string or another exception, e.g.,
-            # socket.error or whatever else.
-            reason_as_str = str(e.reason)
-            for retry_anyway in (
-                'Name or service not known',
-                'EOF occurred in violation of protocol',
-                'timed out',
-                # See http://crbug.com/601260.
-                '[Errno 10060] A connection attempt failed',
-                '[Errno 104] Connection reset by peer',
-            ):
-              if retry_anyway in reason_as_str:
-                return True
-            return False  # Assume permanent otherwise.
-          if not is_transient():
-            logging.error('Caught urllib2.URLError %s which wasn\'t deemed '
-                          'transient', e.reason)
-            raise
-        except socket.error, e:
-          if retry >= (self._maxtries - 1):
-            raise
-          if not 'timed out' in str(e):
-            raise
-        # If reaching this line, loop again. Uses a small backoff.
-        time.sleep(min(10, 1+retry*2))
-    except urllib2.HTTPError as e:
-      print 'Request to %s failed: %s' % (e.geturl(), e.read())
-      raise
-    finally:
-      upload.ErrorExit = old_error_exit
-
-  # DEPRECATED.
-  Send = get
-
-
-class OAuthRpcServer(object):
-  def __init__(self,
-               host,
-               client_email,
-               client_private_key,
-               private_key_password='notasecret',
-               user_agent=None,
-               timeout=None,
-               extra_headers=None):
-    """Wrapper around httplib2.Http() that handles authentication.
-
-    client_email: email associated with the service account
-    client_private_key: encrypted private key, as a string
-    private_key_password: password used to decrypt the private key
-    """
-
-    # Enforce https
-    host_parts = urlparse.urlparse(host)
-
-    if host_parts.scheme == 'https':  # fine
-      self.host = host
-    elif host_parts.scheme == 'http':
-      upload.logging.warning('Changing protocol to https')
-      self.host = 'https' + host[4:]
-    else:
-      msg = 'Invalid url provided: %s' % host
-      upload.logging.error(msg)
-      raise ValueError(msg)
-
-    self.host = self.host.rstrip('/')
-
-    self.extra_headers = extra_headers or {}
-
-    if not oa2client.HAS_OPENSSL:
-      logging.error("No support for OpenSSL has been found, "
-                    "OAuth2 support requires it.")
-      logging.error("Installing pyopenssl will probably solve this issue.")
-      raise RuntimeError('No OpenSSL support')
-    self.creds = oa2client.SignedJwtAssertionCredentials(
-      client_email,
-      client_private_key,
-      'https://www.googleapis.com/auth/userinfo.email',
-      private_key_password=private_key_password,
-      user_agent=user_agent)
-
-    self._http = self.creds.authorize(httplib2.Http(timeout=timeout))
-
-  def Send(self,
-           request_path,
-           payload=None,
-           content_type='application/octet-stream',
-           timeout=None,
-           extra_headers=None,
-           **kwargs):
-    """Send a POST or GET request to the server.
-
-    Args:
-      request_path: path on the server to hit. This is concatenated with the
-        value of 'host' provided to the constructor.
-      payload: request is a POST if not None, GET otherwise
-      timeout: in seconds
-      extra_headers: (dict)
-
-    Returns: the HTTP response body as a string
-
-    Raises:
-      urllib2.HTTPError
-    """
-    # This method signature should match upload.py:AbstractRpcServer.Send()
-    method = 'GET'
-
-    headers = self.extra_headers.copy()
-    headers.update(extra_headers or {})
-
-    if payload is not None:
-      method = 'POST'
-      headers['Content-Type'] = content_type
-
-    prev_timeout = self._http.timeout
-    try:
-      if timeout:
-        self._http.timeout = timeout
-      url = self.host + request_path
-      if kwargs:
-        url += "?" + urllib.urlencode(kwargs)
-
-      # This weird loop is there to detect when the OAuth2 token has expired.
-      # This is specific to appengine *and* rietveld. It relies on the
-      # assumption that a 302 is triggered only by an expired OAuth2 token. This
-      # prevents any usage of redirections in pages accessed this way.
-
-      # This variable is used to make sure the following loop runs only twice.
-      redirect_caught = False
-      while True:
-        try:
-          ret = self._http.request(url,
-                                   method=method,
-                                   body=payload,
-                                   headers=headers,
-                                   redirections=0)
-        except httplib2.RedirectLimit:
-          if redirect_caught or method != 'GET':
-            logging.error('Redirection detected after logging in. Giving up.')
-            raise
-          redirect_caught = True
-          logging.debug('Redirection detected. Trying to log in again...')
-          self.creds.access_token = None
-          continue
-        break
-
-      if ret[0].status >= 300:
-        raise urllib2.HTTPError(
-            request_path, int(ret[0]['status']), ret[1], None,
-            StringIO.StringIO())
-
-      return ret[1]
-
-    finally:
-      self._http.timeout = prev_timeout
-
-
-class JwtOAuth2Rietveld(Rietveld):
-  """Access to Rietveld using OAuth authentication.
-
-  This class is supposed to be used only by bots, since this kind of
-  access is restricted to service accounts.
-  """
-  # The parent__init__ is not called on purpose.
-  # pylint: disable=super-init-not-called
-  def __init__(self,
-               url,
-               client_email,
-               client_private_key_file,
-               private_key_password=None,
-               extra_headers=None,
-               maxtries=None):
-
-    if private_key_password is None:  # '' means 'empty password'
-      private_key_password = 'notasecret'
-
-    self.url = url.rstrip('/')
-    bot_url = self.url
-    if self.url.endswith('googleplex.com'):
-      bot_url = self.url + '/bots'
-
-    with open(client_private_key_file, 'rb') as f:
-      client_private_key = f.read()
-    logging.info('Using OAuth login: %s' % client_email)
-    self.rpc_server = OAuthRpcServer(bot_url,
-                                     client_email,
-                                     client_private_key,
-                                     private_key_password=private_key_password,
-                                     extra_headers=extra_headers or {})
-    self._xsrf_token = None
-    self._xsrf_token_time = None
-
-    self._maxtries = maxtries or 40
-
-
-class CachingRietveld(Rietveld):
-  """Caches the common queries.
-
-  Not to be used in long-standing processes, like the commit queue.
-  """
-  def __init__(self, *args, **kwargs):
-    super(CachingRietveld, self).__init__(*args, **kwargs)
-    self._cache = {}
-
-  def _lookup(self, function_name, args, update):
-    """Caches the return values corresponding to the arguments.
-
-    It is important that the arguments are standardized, like None vs False.
-    """
-    function_cache = self._cache.setdefault(function_name, {})
-    if args not in function_cache:
-      function_cache[args] = update(*args)
-    return copy.deepcopy(function_cache[args])
-
-  def get_description(self, issue, force=False):
-    if force:
-      return super(CachingRietveld, self).get_description(issue, force=force)
-    else:
-      return self._lookup(
-          'get_description',
-          (issue,),
-          super(CachingRietveld, self).get_description)
-
-  def get_issue_properties(self, issue, messages):
-    """Returns the issue properties.
-
-    Because in practice the presubmit checks often ask without messages first
-    and then with messages, always ask with messages and strip off if not asked
-    for the messages.
-    """
-    # It's a tad slower to request with the message but it's better than
-    # requesting the properties twice.
-    data = self._lookup(
-        'get_issue_properties',
-        (issue, True),
-        super(CachingRietveld, self).get_issue_properties)
-    if not messages:
-      # Assumes self._lookup uses deepcopy.
-      del data['messages']
-    return data
-
-  def get_patchset_properties(self, issue, patchset):
-    return self._lookup(
-        'get_patchset_properties',
-        (issue, patchset),
-        super(CachingRietveld, self).get_patchset_properties)
-
-
-class ReadOnlyRietveld(object):
-  """
-  Only provides read operations, and simulates writes locally.
-
-  Intentionally do not inherit from Rietveld to avoid any write-issuing
-  logic to be invoked accidentally.
-  """
-
-  # Dictionary of local changes, indexed by issue number as int.
-  _local_changes = {}
-
-  def __init__(self, *args, **kwargs):
-    # We still need an actual Rietveld instance to issue reads, just keep
-    # it hidden.
-    self._rietveld = Rietveld(*args, **kwargs)
-
-  @classmethod
-  def _get_local_changes(cls, issue):
-    """Returns dictionary of local changes for |issue|, if any."""
-    return cls._local_changes.get(issue, {})
-
-  @property
-  def url(self):
-    return self._rietveld.url
-
-  def get_pending_issues(self):
-    pending_issues = self._rietveld.get_pending_issues()
-
-    # Filter out issues we've closed or unchecked the commit checkbox.
-    return [issue for issue in pending_issues
-            if not self._get_local_changes(issue).get('closed', False) and
-            self._get_local_changes(issue).get('commit', True)]
-
-  def close_issue(self, issue):  # pylint:disable=no-self-use
-    logging.info('ReadOnlyRietveld: closing issue %d' % issue)
-    ReadOnlyRietveld._local_changes.setdefault(issue, {})['closed'] = True
-
-  def get_issue_properties(self, issue, messages):
-    data = self._rietveld.get_issue_properties(issue, messages)
-    data.update(self._get_local_changes(issue))
-    return data
-
-  def get_patchset_properties(self, issue, patchset):
-    return self._rietveld.get_patchset_properties(issue, patchset)
-
-  def get_depends_on_patchset(self, issue, patchset):
-    return self._rietveld.get_depends_on_patchset(issue, patchset)
-
-  def get_patch(self, issue, patchset):
-    return self._rietveld.get_patch(issue, patchset)
-
-  def update_description(self, issue, description):  # pylint:disable=no-self-use
-    logging.info('ReadOnlyRietveld: new description for issue %d: %s' %
-        (issue, description))
-
-  def add_comment(self,  # pylint:disable=no-self-use
-                  issue,
-                  message,
-                  add_as_reviewer=False):
-    logging.info('ReadOnlyRietveld: posting comment "%s" to issue %d' %
-        (message, issue))
-
-  def set_flag(self, issue, patchset, flag, value):  # pylint:disable=no-self-use
-    logging.info('ReadOnlyRietveld: setting flag "%s" to "%s" for issue %d' %
-        (flag, value, issue))
-    ReadOnlyRietveld._local_changes.setdefault(issue, {})[flag] = value
-
-  def set_flags(self, issue, patchset, flags):
-    for flag, value in flags.iteritems():
-      self.set_flag(issue, patchset, flag, value)
-
-  def trigger_try_jobs(  # pylint:disable=no-self-use
-      self, issue, patchset, reason, clobber, revision, builders_and_tests,
-      master=None, category='cq'):
-    logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
-        (builders_and_tests, issue))
-
-  def trigger_distributed_try_jobs(  # pylint:disable=no-self-use
-      self, issue, patchset, reason, clobber, revision, masters,
-      category='cq'):
-    logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
-        (masters, issue))