libv8 7.3.492.27.0 → 8.4.255.0

data/vendor/depot_tools/recipes/recipe_modules/OWNERS

@@ -1 +1 @@
-recipe-roller@chromium.org
+recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com

data/vendor/depot_tools/recipes/recipe_modules/bot_update/__init__.py

@@ -1,20 +1,21 @@
 DEPS = [
-  'depot_tools',
-  'gclient',
-  'gerrit',
-  'gitiles',
-  'recipe_engine/buildbucket',
-  'recipe_engine/context',
-  'recipe_engine/json',
-  'recipe_engine/path',
-  'recipe_engine/platform',
-  'recipe_engine/properties',
-  'recipe_engine/python',
-  'recipe_engine/raw_io',
-  'recipe_engine/runtime',
-  'recipe_engine/source_manifest',
-  'recipe_engine/step',
-  'tryserver',
+    'depot_tools',
+    'gclient',
+    'gerrit',
+    'gitiles',
+    'recipe_engine/buildbucket',
+    'recipe_engine/context',
+    'recipe_engine/commit_position',
+    'recipe_engine/cq',
+    'recipe_engine/json',
+    'recipe_engine/path',
+    'recipe_engine/platform',
+    'recipe_engine/properties',
+    'recipe_engine/python',
+    'recipe_engine/raw_io',
+    'recipe_engine/runtime',
+    'recipe_engine/step',
+    'tryserver',
 ]
 
 from recipe_engine.recipe_api import Property

data/vendor/depot_tools/recipes/recipe_modules/bot_update/api.py

@@ -30,12 +30,20 @@ class BotUpdateApi(recipe_api.RecipeApi):
     bot_update_path = self.resource('bot_update.py')
     kwargs.setdefault('infra_step', True)
 
-    with self.m.depot_tools.on_path():
-      return self.m.python(name, bot_update_path, cmd, **kwargs)
+    # If a Git HTTP request is constantly below GIT_HTTP_LOW_SPEED_LIMIT
+    # bytes/second for GIT_HTTP_LOW_SPEED_TIME seconds then such request will be
+    # aborted. Otherwise, it would wait for global timeout to be reached.
+    env = {
+        'GIT_HTTP_LOW_SPEED_LIMIT': '102400',  # in bytes
+        'GIT_HTTP_LOW_SPEED_TIME': 300,  # in seconds
+    }
+    with self.m.context(env=env):
+      with self.m.depot_tools.on_path():
+        return self.m.python(name, bot_update_path, cmd, **kwargs)
 
   @property
   def last_returned_properties(self):
-      return self._last_returned_properties
+    return self._last_returned_properties
 
   def _get_commit_repo_path(self, commit, gclient_config):
     """Returns local path to the repo that the commit is associated with.
@@ -65,28 +73,43 @@ class BotUpdateApi(recipe_api.RecipeApi):
 
     return repo_path
 
-  def ensure_checkout(self, gclient_config=None, suffix=None,
-                      patch=True, update_presentation=True,
+  def ensure_checkout(self,
+                      gclient_config=None,
+                      suffix=None,
+                      patch=True,
+                      update_presentation=True,
                       patch_root=None,
-                      with_branch_heads=False, with_tags=False, refs=None,
-                      patch_oauth2=None, oauth2_json=None,
-                      use_site_config_creds=None, clobber=False,
-                      root_solution_revision=None, rietveld=None, issue=None,
-                      patchset=None, gerrit_no_reset=False,
+                      with_branch_heads=False,
+                      with_tags=False,
+                      no_fetch_tags=False,
+                      refs=None,
+                      patch_oauth2=None,
+                      oauth2_json=None,
+                      use_site_config_creds=None,
+                      clobber=False,
+                      root_solution_revision=None,
+                      rietveld=None,
+                      issue=None,
+                      patchset=None,
+                      gerrit_no_reset=False,
                       gerrit_no_rebase_patch_ref=False,
-                      disable_syntax_validation=False, manifest_name=None,
-                      patch_refs=None, ignore_input_commit=False,
+                      disable_syntax_validation=False,
+                      patch_refs=None,
+                      ignore_input_commit=False,
                       set_output_commit=False,
+                      step_test_data=None,
                       **kwargs):
     """
     Args:
       gclient_config: The gclient configuration to use when running bot_update.
         If omitted, the current gclient configuration is used.
+      no_fetch_tags: When true, the root git repo being checked out will not
+        fetch any tags referenced from the references being fetched. When a repo
+        has many references, it can become a performance bottleneck, so avoid
+        tags if the checkout will not need them present.
       disable_syntax_validation: (legacy) Disables syntax validation for DEPS.
         Needed as migration paths for recipes dealing with older revisions,
         such as bisect.
-      manifest_name: The name of the manifest to upload to LogDog.  This must
-        be unique for the whole build.
       ignore_input_commit: if True, ignore api.buildbucket.gitiles_commit.
         Exists for historical reasons. Please do not use.
       set_output_commit: if True, mark the checked out commit as the
@@ -96,6 +119,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
         api.buildbucket.gitiles_commit or the first configured solution.
         When sorting builds by commit position, this commit will be used.
         Requires falsy ignore_input_commit.
+      step_test_data: a null function that returns test bot_update.py output.
+        Use test_api.output_json to generate test data.
     """
     assert use_site_config_creds is None, "use_site_config_creds is deprecated"
     assert rietveld is None, "rietveld is deprecated"
@@ -117,7 +142,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
     patch_root = patch_root or self.m.gclient.get_gerrit_patch_root(
         gclient_config=cfg)
 
-    # Allow patch_project's revision if necessary.
+    # Allow patched project's revision if necessary.
     # This is important for projects which are checked out as DEPS of the
     # gclient solution.
     self.m.gclient.set_patch_repo_revision(cfg)
@@ -141,8 +166,12 @@ class BotUpdateApi(recipe_api.RecipeApi):
     if patch:
       repo_url = self.m.tryserver.gerrit_change_repo_url
       fetch_ref = self.m.tryserver.gerrit_change_fetch_ref
+      target_ref = self.m.tryserver.gerrit_change_target_ref
       if repo_url and fetch_ref:
-        flags.append(['--patch_ref', '%s@%s' % (repo_url, fetch_ref)])
+        flags.append([
+            '--patch_ref',
+            '%s@%s:%s' % (repo_url, target_ref, fetch_ref),
+        ])
       if patch_refs:
         flags.extend(
             ['--patch_ref', patch_ref]
@@ -156,19 +185,22 @@ class BotUpdateApi(recipe_api.RecipeApi):
 
     # HACK: ensure_checkout API must be redesigned so that we don't pass such
     # parameters. Existing semantics is too opiniated.
-    main_repo_path = None
-    input_commit = self.m.buildbucket.gitiles_commit
-    input_commit_rev = input_commit.id or input_commit.ref
-    if not ignore_input_commit:
-      main_repo_path = self._get_commit_repo_path(input_commit, cfg)
+    in_commit = self.m.buildbucket.gitiles_commit
+    in_commit_rev = in_commit.id or in_commit.ref
+    if not ignore_input_commit and in_commit_rev:
       # Note: this is not entirely correct. build.input.gitiles_commit
       # definition says "The Gitiles commit to run against.".
       # However, here we ignore it if the config specified a revision.
       # This is necessary because existing builders rely on this behavior,
       # e.g. they want to force refs/heads/master at the config level.
-      if input_commit_rev:
-        revisions[main_repo_path] = (
-            revisions.get(main_repo_path) or input_commit_rev)
+      in_commit_repo_path = self._get_commit_repo_path(in_commit, cfg)
+      revisions[in_commit_repo_path] = (
+          revisions.get(in_commit_repo_path) or in_commit_rev)
+      parsed_solution_urls = set(
+          self.m.gitiles.parse_repo_url(s.url) for s in cfg.solutions)
+      if (in_commit.id and in_commit.ref
+          and (in_commit.host, in_commit.project) in parsed_solution_urls):
+        refs = [in_commit.ref] + refs
 
     # Guarantee that first solution has a revision.
     # TODO(machenbach): We should explicitly pass HEAD for ALL solutions
@@ -180,7 +212,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
       # Only update with non-empty values. Some recipe might otherwise
       # overwrite the HEAD default with an empty string.
       revisions.update(
-          (k, v) for k, v in cfg.revisions.iteritems() if v)
+          (k, v) for k, v in cfg.revisions.items() if v)
     if cfg.solutions and root_solution_revision:
       revisions[first_sol] = root_solution_revision
     # Allow for overrides required to bisect into rolls.
@@ -196,8 +228,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
       if fixed_revision:
         fixed_revisions[name] = fixed_revision
         if fixed_revision.upper() == 'HEAD':
-          # Sync to correct destination branch if HEAD was specified.
-          fixed_revision = self._destination_branch(cfg, name)
+          # Sync to correct destination ref if HEAD was specified.
+          fixed_revision = self._destination_ref(cfg, name)
         # If we're syncing to a ref, we want to make sure it exists before
         # trying to check it out.
         if (fixed_revision.startswith('refs/') and
@@ -235,6 +267,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
       cmd.append('--with_tags')
     if gerrit_no_reset:
       cmd.append('--gerrit_no_reset')
+    if no_fetch_tags:
+      cmd.append('--no_fetch_tags')
     if gerrit_no_rebase_patch_ref:
       cmd.append('--gerrit_no_rebase_patch_ref')
     if disable_syntax_validation or cfg.disable_syntax_validation:
@@ -242,9 +276,9 @@ class BotUpdateApi(recipe_api.RecipeApi):
 
     # Inject Json output for testing.
     first_sln = cfg.solutions[0].name
-    step_test_data = lambda: self.test_api.output_json(
+    step_test_data = step_test_data or (lambda: self.test_api.output_json(
         patch_root, first_sln, reverse_rev_map, self._fail_patch,
-        fixed_revisions=fixed_revisions)
+        fixed_revisions=fixed_revisions))
 
     name = 'bot_update'
     if not patch:
@@ -272,7 +306,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
         if update_presentation:
           # Set properties such as got_revision.
           for prop_name, prop_value in (
-              self.last_returned_properties.iteritems()):
+              self.last_returned_properties.items()):
             step_result.presentation.properties[prop_name] = prop_value
 
         # Add helpful step description in the step UI.
@@ -280,41 +314,48 @@ class BotUpdateApi(recipe_api.RecipeApi):
           step_text = result['step_text']
           step_result.presentation.step_text = step_text
 
-        # Export the step results as a Source Manifest to LogDog.
-        source_manifest = result.get('source_manifest', {})
-        if manifest_name:
-          if not patch:
-            # The param "patched" is purely cosmetic to mean "if false, this
-            # bot_update run exists purely to unpatch an existing patch".
-            manifest_name += '_unpatched'
-          self.m.source_manifest.set_json_manifest(
-              manifest_name, source_manifest)
-
         # Set output commit of the build.
-        git_checkout = (
-            source_manifest
-            .get('directories', {})
-            .get(main_repo_path, {})
-            .get('git_checkout', {}))
-        if set_output_commit and git_checkout:
-          output_commit = common_pb2.GitilesCommit(
-              ref=revisions.get(main_repo_path) or '',
-              id=git_checkout['revision'],
+        if set_output_commit:
+          # As of April 2019, got_revision describes the output commit,
+          # the same commit that Build.output.gitiles_commit describes.
+          # In particular, users tend to set got_revision to make Milo display
+          # it. Derive output commit from got_revision.
+          out_commit = common_pb2.GitilesCommit(
+              id=self._last_returned_properties['got_revision'],
+          )
+
+          out_solution = reverse_rev_map['got_revision']
+          out_manifest = result['manifest'][out_solution]
+          assert out_manifest['revision'] == out_commit.id, (
+              out_manifest, out_commit.id)
+
+          out_commit.host, out_commit.project = (
+              self.m.gitiles.parse_repo_url(out_manifest['repository'])
           )
-          if not output_commit.ref.startswith('refs/'):
-            # Require that what was checked out is what was requested on
-            # input commit.
-            # If this assertion fails, this setup is unusual/unsupported.
-            # The caller should not pass set_output_commit=True and should call
-            # api.buildbucket.set_output_gitiles_commit themselves.
-            assert (
-                input_commit.ref and
-                # Revision was not overridden.
-                revisions[main_repo_path] == input_commit_rev)
-            output_commit.ref = input_commit.ref
-          output_commit.host, output_commit.project = (
-              self.m.gitiles.parse_repo_url(git_checkout['repo_url']))
-          self.m.buildbucket.set_output_gitiles_commit(output_commit)
+
+          # Determine the output ref.
+          got_revision_cp = self._last_returned_properties.get('got_revision_cp')
+          in_rev = revisions.get(out_solution)
+          if got_revision_cp:
+            # If commit position string is available, read the ref from there.
+            out_commit.ref, out_commit.position = (
+                self.m.commit_position.parse(got_revision_cp))
+          elif in_rev.startswith('refs/'):
+            # If we were asked to check out a specific ref, use it as output
+            # ref.
+            out_commit.ref = in_rev
+          elif in_rev == 'HEAD':
+            # bot_update.py interprets HEAD as refs/heads/master
+            out_commit.ref = 'refs/heads/master'
+          elif out_commit.id == in_commit.id and in_commit.ref:
+            # Derive output ref from the input ref.
+            out_commit.ref = in_commit.ref
+          else: # pragma: no cover
+            assert False, (
+                'Unsupposed case. '
+                'Call buildbucket.set_output_gitiles_commit directly.'
+            )
+          self.m.buildbucket.set_output_gitiles_commit(out_commit)
 
         # Set the "checkout" path for the main solution.
         # This is used by the Chromium module to figure out where to look for
@@ -333,6 +374,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
             else:
               # This is actual patch failure.
               self.m.tryserver.set_patch_failure_tryjob_result()
+              self.m.cq.set_do_not_retry_build()
               self.m.python.failing_step(
                   'Patch failure', 'See attached log. Try rebasing?')
           except self.m.step.StepFailure as e:
@@ -352,13 +394,13 @@ class BotUpdateApi(recipe_api.RecipeApi):
 
     return step_result
 
-  def _destination_branch(self, cfg, path):
-    """Returns the destination branch of a CL for the matching project
-    if available or HEAD otherwise.
+  def _destination_ref(self, cfg, path):
+    """Returns the ref branch of a CL for the matching project if available or
+    HEAD otherwise.
 
     If there's no Gerrit CL associated with the run, returns 'HEAD'.
-    Otherwise this queries Gerrit for the correct destination branch, which
-    might differ from master.
+    Otherwise this queries Gerrit for the correct destination ref, which
+    might differ from refs/heads/master.
 
     Args:
       cfg: The used gclient config.
@@ -366,11 +408,13 @@ class BotUpdateApi(recipe_api.RecipeApi):
           'src/v8'. The query will only be made for the project that matches
           the CL's project.
     Returns:
-        A destination branch as understood by bot_update.py if available
-        and if different from master, returns 'HEAD' otherwise.
+        A destination ref as understood by bot_update.py if available
+        and if different from refs/heads/master, returns 'HEAD' otherwise.
     """
     # Ignore project paths other than the one belonging to the current CL.
     patch_path = self.m.gclient.get_gerrit_patch_root(gclient_config=cfg)
+    if patch_path:
+      patch_path = patch_path.replace(self.m.path.sep, '/')
     if not patch_path or path != patch_path:
       return 'HEAD'
 
@@ -378,13 +422,17 @@ class BotUpdateApi(recipe_api.RecipeApi):
     if target_ref == 'refs/heads/master':
       return 'HEAD'
 
-    # TODO: Remove. Return ref, not branch.
-    ret = target_ref
-    prefix = 'refs/heads/'
-    if ret.startswith(prefix):
-      ret = ret[len(prefix):]
+    return target_ref
+
+  def resolve_fixed_revision(self, bot_update_json, name):
+    """Set a fixed revision for a single dependency using project revision
+    properties.
+    """
 
-    return ret
+    rev_properties = self.get_project_revision_properties(name)
+    self.m.gclient.c.revisions = {
+      name: bot_update_json['properties'][rev_properties[0]]
+    }
 
   def _resolve_fixed_revisions(self, bot_update_json):
     """Set all fixed revisions from the first sync to their respective
@@ -445,7 +493,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
     rev_reverse_map = self.m.gclient.got_revision_reverse_mapping(cfg)
     return sorted(
         prop
-        for prop, project in rev_reverse_map.iteritems()
+        for prop, project in rev_reverse_map.items()
         if project == project_name
     )
 
@@ -464,4 +512,5 @@ class BotUpdateApi(recipe_api.RecipeApi):
         bot_update_json['properties'][rev_property])
     self._resolve_fixed_revisions(bot_update_json)
 
-    self.ensure_checkout(patch=False, update_presentation=False)
+    self.ensure_checkout(
+        patch=False, no_fetch_tags=True, update_presentation=False)

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/basic.json

@@ -5,20 +5,29 @@
       "-u",
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
       "--spec-path",
-      "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
+      "cache_dir = '[CACHE]/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
       "--revision_mapping_file",
       "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
       "--git-cache-dir",
-      "[GIT_CACHE]",
+      "[CACHE]/git",
       "--cleanup-dir",
       "[CLEANUP]/bot_update",
       "--output_json",
       "/path/to/tmp/json",
       "--revision",
       "src@2d72510e447ab60a9728aeea2362d8be2cbd7789",
+      "--refs",
+      "refs/heads/master",
       "--disable-syntax-validation"
     ],
-    "env_prefixes": {
+    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT": "102400",
+      "GIT_HTTP_LOW_SPEED_TIME": "300"
+    },
+    "env_suffixes": {
+      "DEPOT_TOOLS_UPDATE": [
+        "0"
+      ],
       "PATH": [
         "RECIPE_REPO[depot_tools]"
       ]
@@ -96,7 +105,13 @@
     ]
   },
   {
-    "jsonResult": null,
+    "cmd": [],
+    "name": "set_output_gitiles_commit",
+    "~followup_annotations": [
+      "@@@SET_BUILD_PROPERTY@$recipe_engine/buildbucket/output_gitiles_commit@{\"host\": \"fake.org\", \"id\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", \"position\": 170242, \"project\": \"src\", \"ref\": \"refs/heads/master\"}@@@"
+    ]
+  },
+  {
     "name": "$result"
   }
 ]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/basic_luci.json

@@ -5,20 +5,29 @@
       "-u",
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
       "--spec-path",
-      "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
+      "cache_dir = '[CACHE]/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
       "--revision_mapping_file",
       "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
       "--git-cache-dir",
-      "[GIT_CACHE]",
+      "[CACHE]/git",
       "--cleanup-dir",
       "[CLEANUP]/bot_update",
       "--output_json",
       "/path/to/tmp/json",
       "--revision",
       "src@2d72510e447ab60a9728aeea2362d8be2cbd7789",
+      "--refs",
+      "refs/heads/master",
       "--disable-syntax-validation"
     ],
+    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT": "102400",
+      "GIT_HTTP_LOW_SPEED_TIME": "300"
+    },
     "env_suffixes": {
+      "DEPOT_TOOLS_UPDATE": [
+        "0"
+      ],
       "PATH": [
         "RECIPE_REPO[depot_tools]"
       ]
@@ -96,7 +105,13 @@
     ]
   },
   {
-    "jsonResult": null,
+    "cmd": [],
+    "name": "set_output_gitiles_commit",
+    "~followup_annotations": [
+      "@@@SET_BUILD_PROPERTY@$recipe_engine/buildbucket/output_gitiles_commit@{\"host\": \"fake.org\", \"id\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", \"position\": 170242, \"project\": \"src\", \"ref\": \"refs/heads/master\"}@@@"
+    ]
+  },
+  {
     "name": "$result"
   }
 ]