libv8 6.7.288.46.1 → 7.3.492.27.0beta1

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json

@@ -1,4 +1,43 @@
 [
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "RECIPE_REPO[depot_tools]/gerrit_client.py",
+      "changes",
+      "--host",
+      "https://chromium-review.googlesource.com",
+      "--json_file",
+      "/path/to/tmp/json",
+      "--limit",
+      "1",
+      "-p",
+      "change=123456",
+      "-o",
+      "ALL_REVISIONS",
+      "-o",
+      "DOWNLOAD_COMMANDS"
+    ],
+    "env": {
+      "PATH": "<PATH>:RECIPE_REPO[depot_tools]"
+    },
+    "infra_step": true,
+    "name": "gerrit fetch current CL info",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output@[@@@",
+      "@@@STEP_LOG_LINE@json.output@  {@@@",
+      "@@@STEP_LOG_LINE@json.output@    \"branch\": \"master\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"revisions\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@      \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@        \"_number\": \"7\", @@@",
+      "@@@STEP_LOG_LINE@json.output@        \"ref\": \"refs/changes/56/123456/7\"@@@",
+      "@@@STEP_LOG_LINE@json.output@      }@@@",
+      "@@@STEP_LOG_LINE@json.output@    }@@@",
+      "@@@STEP_LOG_LINE@json.output@  }@@@",
+      "@@@STEP_LOG_LINE@json.output@]@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
+  },
   {
     "cmd": [
       "python",
@@ -16,6 +55,8 @@
       "[CLEANUP]/bot_update",
       "--output_json",
       "/path/to/tmp/json",
+      "--patch_ref",
+      "https://chromium.googlesource.com/v8/v8@refs/changes/56/123456/7",
       "--revision",
       "src@HEAD",
       "--revision",
@@ -24,7 +65,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -124,7 +165,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -193,8 +234,7 @@
     ]
   },
   {
-    "name": "$result",
-    "recipe_result": null,
-    "status_code": 0
+    "jsonResult": null,
+    "name": "$result"
   }
 ]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json

@@ -3,7 +3,7 @@
     "cmd": [
       "python",
       "-u",
-      "RECIPE_PACKAGE_REPO[depot_tools]/gerrit_client.py",
+      "RECIPE_REPO[depot_tools]/gerrit_client.py",
       "changes",
       "--host",
       "https://chromium-review.googlesource.com",
@@ -12,32 +12,27 @@
       "--limit",
       "1",
       "-p",
-      "change=456789"
+      "change=123456",
+      "-o",
+      "ALL_REVISIONS",
+      "-o",
+      "DOWNLOAD_COMMANDS"
     ],
     "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+      "PATH": "<PATH>:RECIPE_REPO[depot_tools]"
     },
     "infra_step": true,
-    "name": "gerrit get_patch_destination_branch",
+    "name": "gerrit fetch current CL info",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@json.output@[@@@",
       "@@@STEP_LOG_LINE@json.output@  {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"_number\": \"91827\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"branch\": \"master\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"change_id\": \"Ideadbeef\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"has_review_started\": false, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"project\": \"chromium/src\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"revisions\": {@@@",
       "@@@STEP_LOG_LINE@json.output@      \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"_number\": \"1\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"commit\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"message\": \"Change commit message\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
+      "@@@STEP_LOG_LINE@json.output@        \"_number\": \"7\", @@@",
+      "@@@STEP_LOG_LINE@json.output@        \"ref\": \"refs/changes/56/123456/7\"@@@",
       "@@@STEP_LOG_LINE@json.output@      }@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"status\": \"NEW\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"subject\": \"Change title\"@@@",
+      "@@@STEP_LOG_LINE@json.output@    }@@@",
       "@@@STEP_LOG_LINE@json.output@  }@@@",
       "@@@STEP_LOG_LINE@json.output@]@@@",
       "@@@STEP_LOG_END@json.output@@@"
@@ -58,12 +53,10 @@
       "[GIT_CACHE]",
       "--cleanup-dir",
       "[CLEANUP]/bot_update",
-      "--gerrit_repo",
-      "https://chromium.googlesource.com/chromium/src",
-      "--gerrit_ref",
-      "refs/changes/89/456789/12",
       "--output_json",
       "/path/to/tmp/json",
+      "--patch_ref",
+      "https://chromium.googlesource.com/v8/v8@refs/changes/56/123456/7",
       "--revision",
       "src@HEAD",
       "--revision",
@@ -72,7 +65,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -172,7 +165,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -241,8 +234,7 @@
     ]
   },
   {
-    "name": "$result",
-    "recipe_result": null,
-    "status_code": 0
+    "jsonResult": null,
+    "name": "$result"
   }
 ]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/unrecognized_commit_repo.json

@@ -0,0 +1,13 @@
+[
+  {
+    "failure": {
+      "exception": {
+        "traceback": [
+          "<omitted by recipe engine>"
+        ]
+      },
+      "humanReason": "invalid (host, project) pair in buildbucket.build.input.gitiles_commit: (u'unrecognized', u'repo') does not match any of configured gclient solutions and not present in gclient_config.repo_path_map"
+    },
+    "name": "$result"
+  }
+]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/with_manifest_name.json

@@ -6,8 +6,6 @@
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
       "--spec-path",
       "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
-      "--patch_root",
-      "src",
       "--revision_mapping_file",
       "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
       "--git-cache-dir",
@@ -17,178 +15,41 @@
       "--output_json",
       "/path/to/tmp/json",
       "--revision",
-      "src@HEAD",
+      "src@2d72510e447ab60a9728aeea2362d8be2cbd7789",
       "--disable-syntax-validation"
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
-    "name": "bot_update",
+    "name": "bot_update (without patch)",
     "~followup_annotations": [
-      "@@@STEP_TEXT@Some step text@@@",
       "@@@STEP_LOG_LINE@json.output@{@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"did_run\": true, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"fixed_revisions\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src\": \"HEAD\"@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"manifest\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src/third_party/angle\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src/third_party/angle.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src/v8\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src/v8.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"patch_failure\": false, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"patch_root\": \"src\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"properties\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_angle_revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_angle_revision_cp\": \"refs/heads/master@{#297276}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_cr_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_cr_revision_cp\": \"refs/heads/master@{#170242}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_revision_cp\": \"refs/heads/master@{#170242}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_v8_revision_cp\": \"refs/heads/master@{#43426}\"@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"root\": \"src\", @@@",
       "@@@STEP_LOG_LINE@json.output@  \"source_manifest\": {@@@",
       "@@@STEP_LOG_LINE@json.output@    \"directories\": {@@@",
       "@@@STEP_LOG_LINE@json.output@      \"src\": {@@@",
       "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
-      "@@@STEP_LOG_LINE@json.output@      }, @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"src/third_party/angle\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src/third_party/angle.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
-      "@@@STEP_LOG_LINE@json.output@      }, @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"src/v8\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src/v8.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
+      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://chromium.googlesource.com/chromium/src.git\", @@@",
+      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"ea17a292ecfb3dcdaa8dd226e67d6504fc13c15a\"@@@",
       "@@@STEP_LOG_LINE@json.output@        }@@@",
       "@@@STEP_LOG_LINE@json.output@      }@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"version\": 0@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"step_text\": \"Some step text\"@@@",
+      "@@@STEP_LOG_LINE@json.output@    }@@@",
+      "@@@STEP_LOG_LINE@json.output@  }@@@",
       "@@@STEP_LOG_LINE@json.output@}@@@",
-      "@@@STEP_LOG_END@json.output@@@",
-      "@@@SET_BUILD_PROPERTY@got_angle_revision@\"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_angle_revision_cp@\"refs/heads/master@{#297276}\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_cr_revision@\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_cr_revision_cp@\"refs/heads/master@{#170242}\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_revision@\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_revision_cp@\"refs/heads/master@{#170242}\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_v8_revision@\"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
-      "@@@SET_BUILD_PROPERTY@got_v8_revision_cp@\"refs/heads/master@{#43426}\"@@@"
+      "@@@STEP_LOG_END@json.output@@@"
     ]
   },
   {
-    "cmd": [
-      "python",
-      "-u",
-      "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
-      "--spec-path",
-      "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
-      "--patch_root",
-      "src",
-      "--revision_mapping_file",
-      "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
-      "--git-cache-dir",
-      "[GIT_CACHE]",
-      "--cleanup-dir",
-      "[CLEANUP]/bot_update",
-      "--output_json",
-      "/path/to/tmp/json",
-      "--revision",
-      "src@f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9"
-    ],
-    "env_prefixes": {
-      "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
-      ]
-    },
-    "infra_step": true,
-    "name": "bot_update (without patch)",
+    "cmd": [],
+    "name": "set_output_gitiles_commit",
     "~followup_annotations": [
-      "@@@STEP_TEXT@Some step text@@@",
-      "@@@STEP_LOG_LINE@json.output@{@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"did_run\": true, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"fixed_revisions\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"manifest\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src/third_party/angle\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src/third_party/angle.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"src/v8\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"repository\": \"https://fake.org/src/v8.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"patch_failure\": false, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"patch_root\": \"src\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"properties\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_angle_revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_angle_revision_cp\": \"refs/heads/master@{#297276}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_cr_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_cr_revision_cp\": \"refs/heads/master@{#170242}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_revision_cp\": \"refs/heads/master@{#170242}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"got_v8_revision_cp\": \"refs/heads/master@{#43426}\"@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"root\": \"src\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"source_manifest\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@    \"directories\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"src\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
-      "@@@STEP_LOG_LINE@json.output@      }, @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"src/third_party/angle\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src/third_party/angle.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
-      "@@@STEP_LOG_LINE@json.output@      }, @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"src/v8\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"git_checkout\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@          \"repo_url\": \"https://fake.org/src/v8.git\", @@@",
-      "@@@STEP_LOG_LINE@json.output@          \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
-      "@@@STEP_LOG_LINE@json.output@        }@@@",
-      "@@@STEP_LOG_LINE@json.output@      }@@@",
-      "@@@STEP_LOG_LINE@json.output@    }, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"version\": 0@@@",
-      "@@@STEP_LOG_LINE@json.output@  }, @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"step_text\": \"Some step text\"@@@",
-      "@@@STEP_LOG_LINE@json.output@}@@@",
-      "@@@STEP_LOG_END@json.output@@@"
+      "@@@SET_BUILD_PROPERTY@$recipe_engine/buildbucket/output_gitiles_commit@{\"host\": \"chromium.googlesource.com\", \"id\": \"ea17a292ecfb3dcdaa8dd226e67d6504fc13c15a\", \"project\": \"chromium/src\", \"ref\": \"refs/heads/master\"}@@@"
     ]
   },
   {
-    "name": "$result",
-    "recipe_result": null,
-    "status_code": 0
+    "jsonResult": null,
+    "name": "$result"
   }
 ]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json

@@ -6,8 +6,6 @@
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
       "--spec-path",
       "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
-      "--patch_root",
-      "src",
       "--revision_mapping_file",
       "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
       "--git-cache-dir",
@@ -23,7 +21,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -105,8 +103,6 @@
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
       "--spec-path",
       "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
-      "--patch_root",
-      "src",
       "--revision_mapping_file",
       "{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
       "--git-cache-dir",
@@ -120,7 +116,7 @@
     ],
     "env_prefixes": {
       "PATH": [
-        "RECIPE_PACKAGE_REPO[depot_tools]"
+        "RECIPE_REPO[depot_tools]"
       ]
     },
     "infra_step": true,
@@ -188,8 +184,7 @@
     ]
   },
   {
-    "name": "$result",
-    "recipe_result": null,
-    "status_code": 0
+    "jsonResult": null,
+    "name": "$result"
   }
 ]

data/vendor/depot_tools/recipes/recipe_modules/bot_update/examples/full.py

@@ -6,6 +6,8 @@ DEPS = [
   'bot_update',
   'gclient',
   'gerrit',
+  'tryserver',
+  'recipe_engine/buildbucket',
   'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/platform',
@@ -13,14 +15,17 @@ DEPS = [
   'recipe_engine/runtime',
 ]
 
+from PB.go.chromium.org.luci.buildbucket.proto.build import Build
+
 def RunSteps(api):
   api.gclient.use_mirror = True
+  commit = api.buildbucket.build.input.gitiles_commit
 
   src_cfg = api.gclient.make_config(CACHE_DIR='[GIT_CACHE]')
   soln = src_cfg.solutions.add()
   soln.name = 'src'
   soln.url = 'https://chromium.googlesource.com/chromium/src.git'
-  soln.revision = api.properties.get('revision')
+  soln.revision = commit.id or commit.ref or None
   api.gclient.c = src_cfg
   api.gclient.c.revisions.update(api.properties.get('revisions', {}))
   if api.properties.get('deprecated_got_revision_mapping'):
@@ -31,16 +36,15 @@ def RunSteps(api):
     api.gclient.c.got_revision_reverse_mapping['got_v8_revision'] = 'src/v8'
     api.gclient.c.got_revision_reverse_mapping['got_angle_revision'] = (
         'src/third_party/angle')
-  api.gclient.c.patch_projects['v8'] = ('src/v8', 'HEAD')
-  api.gclient.c.patch_projects['v8/v8'] = ('src/v8', 'HEAD')
-  api.gclient.c.patch_projects['angle/angle'] = ('src/third_party/angle',
-                                                 'HEAD')
-  api.gclient.c.repo_path_map['https://webrtc.googlesource.com/src'] = (
-      'src/third_party/webrtc', 'HEAD')
+  api.gclient.c.repo_path_map.update({
+      'https://chromium.googlesource.com/angle/angle': (
+          'src/third_party/angle', 'HEAD'),
+      'https://chromium.googlesource.com/v8/v8': ('src/v8', 'HEAD'),
+      'https://webrtc.googlesource.com/src': ('src/third_party/webrtc', 'HEAD'),
+  })
 
   patch = api.properties.get('patch', True)
   clobber = True if api.properties.get('clobber') else False
-  no_shallow = True if api.properties.get('no_shallow', 1) else False
   with_branch_heads = api.properties.get('with_branch_heads', False)
   with_tags = api.properties.get('with_tags', False)
   refs = api.properties.get('refs', [])
@@ -50,203 +54,182 @@ def RunSteps(api):
   gerrit_no_rebase_patch_ref = bool(
       api.properties.get('gerrit_no_rebase_patch_ref'))
   manifest_name = api.properties.get('manifest_name')
+  patch_refs = api.properties.get('patch_refs')
+  set_output_commit = api.properties.get('set_output_commit', False)
 
-  if api.properties.get('test_apply_gerrit_ref'):
-    prop2arg = {
-        'gerrit_custom_repo': 'gerrit_repo',
-        'gerrit_custom_ref': 'gerrit_ref',
-        'gerrit_custom_step_name': 'step_name',
-    }
-    kwargs = {
-        prop2arg[p]: api.properties.get(p)
-        for p in prop2arg if api.properties.get(p)
-    }
-    api.bot_update.apply_gerrit_ref(
-        root='/tmp/test/root',
-        gerrit_no_reset=gerrit_no_reset,
-        gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref,
-        **kwargs
+  bot_update_step = api.bot_update.ensure_checkout(
+      patch=patch,
+      with_branch_heads=with_branch_heads,
+      with_tags=with_tags,
+      refs=refs,
+      clobber=clobber,
+      root_solution_revision=root_solution_revision,
+      suffix=suffix,
+      gerrit_no_reset=gerrit_no_reset,
+      gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref,
+      disable_syntax_validation=True,
+      manifest_name=manifest_name,
+      patch_refs=patch_refs,
+      set_output_commit=set_output_commit,
     )
-  else:
-    bot_update_step = api.bot_update.ensure_checkout(
-        no_shallow=no_shallow,
-        patch=patch,
-        with_branch_heads=with_branch_heads,
-        with_tags=with_tags,
-        refs=refs,
-        clobber=clobber,
-        root_solution_revision=root_solution_revision,
-        suffix=suffix,
-        gerrit_no_reset=gerrit_no_reset,
-        gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref,
-        disable_syntax_validation=True,
-        manifest_name=manifest_name)
-    if patch:
-      api.bot_update.deapply_patch(bot_update_step)
+  if patch:
+    api.bot_update.deapply_patch(bot_update_step)
 
 
 def GenTests(api):
-  yield api.test('basic') + api.properties(
-      patch=False,
-      revision='abc'
-  )
-  yield api.test('basic_luci') + api.properties(
-      patch=False,
-      revision='abc'
-  ) + api.runtime(is_experimental=False, is_luci=True)
-  yield api.test('with_manifest_name_no_patch') + api.properties(
-      manifest_name='checkout',
-      patch=False
-  )
-  yield api.test('with_manifest_name') + api.properties(
-      manifest_name='checkout'
-  )
-  yield api.test('buildbot') + api.properties(
-      path_config='buildbot',
-      patch=False,
-      revision='abc'
-  )
-  yield api.test('basic_with_branch_heads') + api.properties(
-      with_branch_heads=True,
-      suffix='with branch heads'
-  )
-  yield api.test('with_tags') + api.properties(with_tags=True)
-  yield api.test('tryjob') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-  )
-  yield api.test('tryjob_empty_revision') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-      revisions={'src': ''},
-  )
-  yield api.test('deprecated_got_revision_mapping') + api.properties(
-      deprecated_got_revision_mapping=True,
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-  )
-  yield api.test('trychange') + api.properties(
-      refs=['+refs/change/1/2/333'],
-  )
-  yield api.test('tryjob_fail') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-  ) + api.step_data('bot_update', api.json.invalid(None), retcode=1)
-  yield api.test('tryjob_fail_patch') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-      fail_patch='apply',
-  ) + api.step_data('bot_update', retcode=88)
-  yield api.test('tryjob_fail_patch_download') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-      fail_patch='download'
-  ) + api.step_data('bot_update', retcode=87)
-  yield api.test('shallow') + api.properties(
-      no_shallow=0
-  )
-  yield api.test('clobber') + api.properties(
-      clobber=1
-  )
-  yield api.test('reset_root_solution_revision') + api.properties(
-      root_solution_revision='revision',
-  )
-  yield api.test('gerrit_no_reset') + api.properties(
-      gerrit_no_reset=1
-  )
-  yield api.test('gerrit_no_rebase_patch_ref') + api.properties(
-      gerrit_no_rebase_patch_ref=True
-  )
-  yield api.test('apply_gerrit_ref') + api.properties(
-      repository='chromium',
-      gerrit_no_rebase_patch_ref=True,
-      gerrit_no_reset=1,
-      test_apply_gerrit_ref=True,
-  )
-  yield api.test('apply_gerrit_ref_custom') + api.properties(
-      repository='chromium',
-      gerrit_no_rebase_patch_ref=True,
-      gerrit_no_reset=1,
-      gerrit_custom_repo='https://custom/repo',
-      gerrit_custom_ref='refs/changes/custom/1234567/1',
-      gerrit_custom_step_name='Custom apply gerrit step',
-      test_apply_gerrit_ref=True,
-  )
-  yield api.test('tryjob_v8') + api.properties(
-      issue=12345,
-      patchset=654321,
-      rietveld='https://rietveld.example.com/',
-      patch_project='v8',
-      revisions={'src/v8': 'abc'}
-  )
-  yield api.test('tryjob_v8_head_by_default') + api.properties.tryserver(
-      patch_project='v8',
-  )
-  yield api.test('tryjob_gerrit_angle') + api.properties.tryserver(
-      gerrit_project='angle/angle',
-      patch_issue=338811,
-      patch_set=3,
-  )
-  yield api.test('no_apply_patch_on_gclient') + api.properties.tryserver(
-      gerrit_project='angle/angle',
-      patch_issue=338811,
-      patch_set=3,
-  ) + api.bot_update.properties(
-      apply_patch_on_gclient=False,
-  )
-  yield api.test('tryjob_gerrit_v8') + api.properties.tryserver(
-      gerrit_project='v8/v8',
-      patch_issue=338811,
-      patch_set=3,
-  )
-  yield api.test('tryjob_gerrit_v8_feature_branch') + api.properties.tryserver(
-      gerrit_project='v8/v8',
-      patch_issue=338811,
-      patch_set=3,
-  ) + api.step_data(
-      'gerrit get_patch_destination_branch',
-      api.gerrit.get_one_change_response_data(branch='experimental/feature'),
-  )
-  yield api.test('tryjob_gerrit_feature_branch') + api.properties.tryserver(
-      buildername='feature_rel',
-      gerrit_project='chromium/src',
-      patch_issue=338811,
-      patch_set=3,
-  ) + api.step_data(
-      'gerrit get_patch_destination_branch',
-      api.gerrit.get_one_change_response_data(branch='experimental/feature'),
-  )
-  yield api.test('tryjob_gerrit_branch_heads') + api.properties.tryserver(
-      gerrit_project='chromium/src',
-      patch_issue=338811,
-      patch_set=3,
-  ) + api.step_data(
-      'gerrit get_patch_destination_branch',
-      api.gerrit.get_one_change_response_data(branch='refs/branch-heads/67'),
-  )
-  yield api.test('tryjob_gerrit_angle_deprecated') + api.properties.tryserver(
-      patch_project='angle/angle',
-      gerrit='https://chromium-review.googlesource.com',
-      patch_storage='gerrit',
-      repository='https://chromium.googlesource.com/angle/angle',
-      rietveld=None,
-      **{
-        'event.change.id': 'angle%2Fangle~master~Ideadbeaf',
-        'event.change.number': 338811,
-        'event.change.url':
-          'https://chromium-review.googlesource.com/#/c/338811',
-        'event.patchSet.ref': 'refs/changes/11/338811/3',
-      }
-  )
-  yield api.test('tryjob_gerrit_webrtc') + api.properties.tryserver(
-      gerrit_project='src',
-      git_url='https://webrtc.googlesource.com/src',
-      patch_issue=338811,
-      patch_set=3,
+
+  def try_build(**kwargs):
+    kwargs.setdefault(
+        'git_repo', 'https://chromium.googlesource.com/chromium/src')
+    return api.buildbucket.try_build('chromium', 'linux', **kwargs)
+
+  def ci_build(**kwargs):
+    kwargs.setdefault(
+        'git_repo', 'https://chromium.googlesource.com/chromium/src')
+    return (
+        api.buildbucket.ci_build('chromium', 'linux', **kwargs) +
+        api.properties(patch=False)
+    )
+
+
+  yield (
+      api.test('basic') +
+      ci_build()
+  )
+  yield (
+      api.test('input_commit_with_id_without_repo') +
+      api.buildbucket.build(Build(
+          input={
+              'gitiles_commit': {
+                  'id': 'a' * 40,
+              },
+          },
+      ))
+  )
+  yield (
+      api.test('unrecognized_commit_repo') +
+      ci_build(git_repo='https://unrecognized/repo')
+  )
+  yield (
+      api.test('basic_luci') +
+      ci_build() +
+      api.runtime(is_experimental=False, is_luci=True)
+  )
+  yield (
+      api.test('with_manifest_name') +
+      ci_build() +
+      api.properties(manifest_name='checkout', set_output_commit=True) +
+      api.step_data('bot_update (without patch)', api.json.output({
+        'source_manifest': {
+          'directories': {
+            'src': {
+              'git_checkout': {
+                'repo_url': (
+                    'https://chromium.googlesource.com/chromium/src.git'),
+                'revision': 'ea17a292ecfb3dcdaa8dd226e67d6504fc13c15a'
+              },
+            },
+          },
+        },
+      }))
+  )
+  yield (
+      api.test('basic_with_branch_heads') +
+      ci_build() +
+      api.properties(
+          with_branch_heads=True,
+          suffix='with branch heads'
+      )
+  )
+  yield (
+      api.test('with_tags') +
+      api.properties(with_tags=True)
+  )
+  yield (
+      api.test('deprecated_got_revision_mapping') +
+      try_build() +
+      api.properties(deprecated_got_revision_mapping=True)
+  )
+  yield (
+      api.test('refs') +
+      api.properties(refs=['+refs/change/1/2/333'])
+  )
+  yield (
+      api.test('tryjob_fail') +
+      try_build() +
+      api.step_data('bot_update', api.json.invalid(None), retcode=1)
+  )
+  yield (
+      api.test('tryjob_fail_patch') +
+      try_build() +
+      api.properties(fail_patch='apply') +
+      api.step_data('bot_update', retcode=88)
+  )
+  yield (
+      api.test('tryjob_fail_patch_download') +
+      try_build() +
+      api.properties(fail_patch='download') +
+      api.step_data('bot_update', retcode=87)
+  )
+  yield (
+      api.test('clobber') +
+      api.properties(clobber=1)
+  )
+  yield (
+      api.test('reset_root_solution_revision') +
+      api.properties(root_solution_revision='revision')
+  )
+  yield (
+      api.test('gerrit_no_reset') +
+      api.properties(gerrit_no_reset=1)
+  )
+  yield (
+      api.test('gerrit_no_rebase_patch_ref') +
+      api.properties(gerrit_no_rebase_patch_ref=True)
+  )
+  yield (
+      api.test('tryjob_v8') +
+      try_build(git_repo='https://chromium.googlesource.com/v8/v8') +
+       api.properties(revisions={'src/v8': 'abc'})
+  )
+  yield (
+      api.test('tryjob_v8_head_by_default') +
+      try_build(git_repo='https://chromium.googlesource.com/v8/v8')
+  )
+  yield (
+      api.test('tryjob_gerrit_angle') +
+      try_build(git_repo='https://chromium.googlesource.com/angle/angle')
+  )
+  yield (
+      api.test('no_apply_patch_on_gclient') +
+      try_build(git_repo='https://chromium.googlesource.com/angle/angle')
+  )
+  yield (
+      api.test('tryjob_gerrit_v8_feature_branch') +
+      try_build(git_repo='https://chromium.googlesource.com/v8/v8') +
+      api.tryserver.gerrit_change_target_ref('refs/heads/experimental/feature')
+  )
+  yield (
+      api.test('tryjob_gerrit_feature_branch') +
+      try_build() +
+      api.tryserver.gerrit_change_target_ref('refs/heads/experimental/feature')
+  )
+  yield (
+      api.test('tryjob_gerrit_branch_heads') +
+      try_build() +
+      api.tryserver.gerrit_change_target_ref('refs/branch-heads/67')
+  )
+  yield (
+      api.test('tryjob_gerrit_webrtc') +
+      try_build(git_repo='https://webrtc.googlesource.com/src')
+  )
+  yield (
+      api.test('multiple_patch_refs') +
+      api.properties(
+          patch_refs=[
+              ('https://chromium.googlesource.com/chromium/src@'
+               'refs/changes/12/34/5'),
+              'https://chromium.googlesource.com/v8/v8@refs/changes/124/45/6',
+          ],
+      )
   )