libv8 5.7.492.65.1 → 5.9.211.38.0beta0

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_linux.json

@@ -0,0 +1,16 @@
+[
+  {
+    "cmd": [],
+    "name": "show paths",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
+      "@@@STEP_LOG_END@result@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "recipe_result": null,
+    "status_code": 0
+  }
+]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_mac.json

@@ -0,0 +1,16 @@
+[
+  {
+    "cmd": [],
+    "name": "show paths",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cleanup': ('/', 'b', 'cleanup'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
+      "@@@STEP_LOG_END@result@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "recipe_result": null,
+    "status_code": 0
+  }
+]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/examples/full.expected/paths_kitchen_win.json

@@ -0,0 +1,16 @@
+[
+  {
+    "cmd": [],
+    "name": "show paths",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('C:\\\\', 'b', 'c', 'b'), 'cache': ('C:\\\\', 'b', 'c'), 'goma_cache': ('C:\\\\', 'b', 'c', 'goma_cache'), 'start_dir': ('C:\\\\', 'b', 'FakeTestingCWD'), 'cleanup': ('C:\\\\', 'b', 'cleanup'), 'git_cache': ('C:\\\\', 'b', 'c', 'git_cache'), 'root': ('C:\\\\', 'b', 'FakeTestingCWD'), 'tmp_base': ('C:\\\\',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
+      "@@@STEP_LOG_END@result@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "recipe_result": null,
+    "status_code": 0
+  }
+]

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/{example.py → examples/full.py}

@@ -14,9 +14,10 @@ DEPS = [
 
 
 def RunSteps(api):
-  api.step('show cache path', [])
+  api.step('show paths', [])
   api.step.active_result.presentation.logs['result'] = [
     'base_paths: %r' % (api.path.c.base_paths,),
+    'default_git_cache_dir: %r' % (api.infra_paths.default_git_cache_dir,),
   ]
 
 

data/vendor/depot_tools/recipes/recipe_modules/infra_paths/path_config.py

@@ -13,11 +13,13 @@ def infra_common(c):
 
 @CONFIG_CTX(includes=['infra_common'])
 def infra_buildbot(c):
+  """Used on BuildBot by "annotated_run"."""
   c.base_paths['root'] = c.START_DIR[:-4]
   c.base_paths['cache'] = c.base_paths['root'] + (
       'build', 'slave', 'cache')
   c.base_paths['git_cache'] = c.base_paths['root'] + (
       'build', 'slave', 'cache_dir')
+  c.base_paths['cleanup'] = c.START_DIR[:-1] + ('build.dead',)
   c.base_paths['goma_cache'] = c.base_paths['root'] + (
       'build', 'slave', 'goma_cache')
   for token in ('build_internal', 'build', 'depot_tools'):
@@ -26,6 +28,7 @@ def infra_buildbot(c):
 
 @CONFIG_CTX(includes=['infra_common'])
 def infra_kitchen(c):
+  """Used on BuildBot by "remote_run" when NOT running Kitchen."""
   c.base_paths['root'] = c.START_DIR
   # TODO(phajdan.jr): have one cache dir, let clients append suffixes.
 
@@ -36,23 +39,29 @@ def infra_kitchen(c):
   if c.PLATFORM in ('linux', 'mac'):
     c.base_paths['cache'] = ('/', 'b', 'c')
     c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
-    for path in ('git_cache', 'goma_cache', 'goma_deps_cache'):
+    for path in ('git_cache', 'goma_cache'):
       c.base_paths[path] = c.base_paths['cache'] + (path,)
   elif b_dir:
     c.base_paths['cache'] = b_dir + ('c',)
     c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
-    for path in ('git_cache', 'goma_cache', 'goma_deps_cache'):
+    for path in ('git_cache', 'goma_cache'):
       c.base_paths[path] = c.base_paths['cache'] + (path,)
   else:  # pragma: no cover
     c.base_paths['cache'] = c.base_paths['root'] + ('c',)
     c.base_paths['builder_cache'] = c.base_paths['cache'] + ('b',)
     c.base_paths['git_cache'] = c.base_paths['root'] + ('cache_dir',)
-    for path in ('goma_cache', 'goma_deps_cache'):
+    for path in ('goma_cache',):
       c.base_paths[path] = c.base_paths['cache'] + (path,)
 
 
 @CONFIG_CTX()
 def infra_generic(c):
+  """Used by Kitchen runs on both SwarmBucket and "remote_run"+Kitchen.
+
+  The default path values (ones not set explicitly here) are either installed by
+  Kitchen directly, or are recipe engine defaults. Note that in "kitchen",
+  the "start_dir" is ephemeral.
+  """
   c.base_paths['builder_cache'] = c.base_paths['cache'] + ('builder',)
   c.base_paths['git_cache'] = c.base_paths['cache'] + ('git',)
   c.base_paths['goma_cache'] = c.base_paths['cache'] + ('goma',)

data/vendor/depot_tools/recipes/recipe_modules/presubmit/__init__.py

@@ -1,4 +1,5 @@
 DEPS = [
+  'recipe_engine/context',
   'recipe_engine/path',
   'recipe_engine/python',
   'recipe_engine/step',

data/vendor/depot_tools/recipes/recipe_modules/presubmit/api.py

@@ -14,11 +14,11 @@ class PresubmitApi(recipe_api.RecipeApi):
 
     name = kwargs.pop('name', 'presubmit')
 
-    env = self.m.step.get_from_context('env', {})
+    env = self.m.context.env
     env.setdefault('PATH', '%(PATH)s')
     env['PATH'] = self.m.path.pathsep.join([
         env['PATH'], str(self._module.PACKAGE_REPO_ROOT)])
 
-    with self.m.step.context({'env': env}):
+    with self.m.context(env=env):
       return self.m.python(
           name, self.presubmit_support_path, list(args), **kwargs)

data/vendor/depot_tools/recipes/recipe_modules/presubmit/{example.expected → examples/full.expected}/basic.json

@@ -6,7 +6,7 @@
       "RECIPE_PACKAGE_REPO[depot_tools]/presubmit_support.py"
     ],
     "env": {
-      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "presubmit"
   },

data/vendor/depot_tools/recipes/recipe_modules/rietveld/__init__.py

@@ -4,7 +4,3 @@ DEPS = [
   'recipe_engine/python',
   'recipe_engine/step',
 ]
-
-
-# TODO(phajdan.jr): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

data/vendor/depot_tools/recipes/recipe_modules/rietveld/examples/full.expected/no_auth.json

@@ -0,0 +1,27 @@
+[
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "RECIPE_PACKAGE_REPO[depot_tools]/apply_issue.py",
+      "-r",
+      "[START_DIR]/foo/bar",
+      "-i",
+      "1",
+      "-p",
+      "1",
+      "-s",
+      "http://review_tool.url",
+      "--no-auth"
+    ],
+    "name": "apply_issue",
+    "~followup_annotations": [
+      "@@@STEP_LINK@Applied issue 1@http://review_tool.url/1@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "recipe_result": null,
+    "status_code": 0
+  }
+]

data/vendor/depot_tools/recipes/recipe_modules/rietveld/{example.py → examples/full.py}

@@ -12,7 +12,8 @@ DEPS = [
 
 def RunSteps(api):
   api.path['checkout'] = api.path['start_dir']
-  api.rietveld.apply_issue('foo', 'bar', authentication='oauth2')
+  api.rietveld.apply_issue(
+      'foo', 'bar', authentication=api.properties.get('authentication'))
   api.rietveld.calculate_issue_root({'project': ['']})
 
 
@@ -21,10 +22,17 @@ def GenTests(api):
       issue=1,
       patchset=1,
       rietveld='http://review_tool.url',
+      authentication='oauth2',
+  )
+  yield api.test('no_auth') + api.properties(
+      issue=1,
+      patchset=1,
+      rietveld='http://review_tool.url',
   )
   yield api.test('buildbot') + api.properties(
       path_config='buildbot',
       issue=1,
       patchset=1,
       rietveld='http://review_tool.url',
+      authentication='oauth2',
   )

data/vendor/depot_tools/recipes/recipe_modules/tryserver/__init__.py

@@ -3,18 +3,16 @@
 # found in the LICENSE file.
 
 DEPS = [
+  'gerrit',
   'git',
   'git_cl',
+  'recipe_engine/context',
   'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
   'recipe_engine/python',
   'recipe_engine/raw_io',
-  'rietveld',
   'recipe_engine/step',
+  'rietveld',
 ]
-
-
-# TODO(phajdan): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

data/vendor/depot_tools/recipes/recipe_modules/tryserver/api.py

@@ -9,10 +9,6 @@ import hashlib
 from recipe_engine import recipe_api
 
 
-PATCH_STORAGE_RIETVELD = 'rietveld'
-PATCH_STORAGE_GIT = 'git'
-
-
 class TryserverApi(recipe_api.RecipeApi):
   def __init__(self, *args, **kwargs):
     super(TryserverApi, self).__init__(*args, **kwargs)
@@ -43,84 +39,10 @@ class TryserverApi(recipe_api.RecipeApi):
 
   @property
   def is_patch_in_git(self):
-    return (self.m.properties.get('patch_storage') == PATCH_STORAGE_GIT and
+    return (self.m.properties.get('patch_storage') == 'git' and
             self.m.properties.get('patch_repo_url') and
             self.m.properties.get('patch_ref'))
 
-  def _apply_patch_step(self, patch_file=None, patch_content=None, root=None):
-    assert not (patch_file and patch_content), (
-        'Please only specify either patch_file or patch_content, not both!')
-    patch_cmd = [
-        'patch',
-        '--dir', root or self.m.path['checkout'],
-        '--force',
-        '--forward',
-        '--remove-empty-files',
-        '--strip', '0',
-    ]
-    if patch_file:
-      patch_cmd.extend(['--input', patch_file])
-
-    self.m.step('apply patch', patch_cmd,
-                      stdin=patch_content)
-
-  def apply_from_git(self, cwd):
-    """Downloads patch from given git repo and ref and applies it"""
-    # TODO(nodir): accept these properties as parameters
-    patch_repo_url = self.m.properties['patch_repo_url']
-    patch_ref = self.m.properties['patch_ref']
-
-    patch_dir = self.m.path.mkdtemp('patch')
-    try:
-      build_path = self.m.path['build']
-    except KeyError:
-      raise self.m.step.StepFailure(
-          'path["build"] is not defined. '
-          'Possibly this is a LUCI build. '
-          'tryserver.apply_from_git is not supported in LUCI builds.')
-
-    git_setup_py = build_path.join('scripts', 'slave', 'git_setup.py')
-    git_setup_args = ['--path', patch_dir, '--url', patch_repo_url]
-    patch_path = patch_dir.join('patch.diff')
-
-    self.m.python('patch git setup', git_setup_py, git_setup_args)
-    with self.m.step.context({'cwd': patch_dir}):
-      self.m.git('fetch', 'origin', patch_ref, name='patch fetch')
-      self.m.git('clean', '-f', '-d', '-x', name='patch clean')
-      self.m.git('checkout', '-f', 'FETCH_HEAD', name='patch git checkout')
-    self._apply_patch_step(patch_file=patch_path, root=cwd)
-    self.m.step('remove patch', ['rm', '-rf', patch_dir])
-
-  def determine_patch_storage(self):
-    """Determines patch_storage automatically based on properties."""
-    storage = self.m.properties.get('patch_storage')
-    if storage:
-      return storage
-
-    if self.can_apply_issue:
-      return PATCH_STORAGE_RIETVELD
-
-  def maybe_apply_issue(self, cwd=None, authentication=None):
-    """If we're a trybot, apply a codereview issue.
-
-    Args:
-      cwd: If specified, apply the patch from the specified directory.
-      authentication: authentication scheme whenever apply_issue.py is called.
-        This is only used if the patch comes from Rietveld. Possible values:
-        None, 'oauth2' (see also api.rietveld.apply_issue.)
-    """
-    storage = self.determine_patch_storage()
-
-    if storage == PATCH_STORAGE_RIETVELD:
-      return self.m.rietveld.apply_issue(
-          self.m.rietveld.calculate_issue_root(),
-          authentication=authentication)
-    elif storage == PATCH_STORAGE_GIT:
-      return self.apply_from_git(cwd)
-    else:
-      # Since this method is "maybe", we don't raise an Exception.
-      pass
-
   def get_files_affected_by_patch(self, patch_root=None, **kwargs):
     """Returns list of paths to files affected by the patch.
 
@@ -138,9 +60,9 @@ class TryserverApi(recipe_api.RecipeApi):
     # removed.
     if patch_root is None:
       return self._old_get_files_affected_by_patch()
-    with self.m.step.context({
-        'cwd': self.m.step.get_from_context(
-            'cwd', self.m.path['start_dir'].join(patch_root))}):
+
+    cwd = self.m.context.cwd or self.m.path['start_dir'].join(patch_root)
+    with self.m.context(cwd=cwd):
       step_result = self.m.git('diff', '--cached', '--name-only',
                                name='git diff to analyze patch',
                                stdout=self.m.raw_io.output(),
@@ -158,11 +80,10 @@ class TryserverApi(recipe_api.RecipeApi):
 
 
   def _old_get_files_affected_by_patch(self):
-    context = {}
     issue_root = self.m.rietveld.calculate_issue_root()
-    if issue_root:
-      context['cwd'] = self.m.path['checkout'].join(issue_root)
-    with self.m.step.context(context):
+    cwd = self.m.path['checkout'].join(issue_root) if issue_root else None
+
+    with self.m.context(cwd=cwd):
       step_result = self.m.git('diff', '--cached', '--name-only',
                                name='git diff to analyze patch',
                                stdout=self.m.raw_io.output(),
@@ -265,17 +186,19 @@ class TryserverApi(recipe_api.RecipeApi):
     git-footers documentation for more information.
     """
     if patch_text is None:
-      codereview = None
-      if not self.can_apply_issue: #pragma: no cover
-        raise recipe_api.StepFailure("Cannot get tags from gerrit yet.")
-      else:
-        codereview = 'rietveld'
-        patch = (
-            self.m.properties['rietveld'].strip('/') + '/' +
+      if self.is_gerrit_issue:
+        patch_text = self.m.gerrit.get_change_description(
+            self.m.properties['patch_gerrit_url'],
+            self.m.properties['patch_issue'],
+            self.m.properties['patch_set'])
+      elif self.can_apply_issue:
+        patch_url = (
+            self.m.properties['rietveld'].rstrip('/') + '/' +
             str(self.m.properties['issue']))
-
-      patch_text = self.m.git_cl.get_description(
-          patch=patch, codereview=codereview).stdout
+        patch_text = self.m.git_cl.get_description(
+            patch_url=patch_url, codereview='rietveld').stdout
+      else:  # pragma: no cover
+        raise recipe_api.StepFailure('Unknown patch storage.')
 
     result = self.m.python(
         'parse description', self.package_repo_resource('git_footers.py'),
@@ -287,3 +210,5 @@ class TryserverApi(recipe_api.RecipeApi):
     """Gets a specific tag from a CL description"""
     return self.get_footers(patch_text).get(tag, [])
 
+  def normalize_footer_name(self, footer):
+    return '-'.join([ word.title() for word in footer.strip().split('-') ])

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch.json

@@ -0,0 +1,56 @@
+[
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "RECIPE_PACKAGE_REPO[depot_tools]/gerrit_client.py",
+      "changes",
+      "--host",
+      "https://chromium-review.googlesource.com",
+      "--json_file",
+      "/path/to/tmp/json",
+      "--limit",
+      "1",
+      "-p",
+      "change=456789",
+      "-o",
+      "ALL_REVISIONS",
+      "-o",
+      "ALL_COMMITS"
+    ],
+    "env": {
+      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    },
+    "infra_step": true,
+    "name": "gerrit changes",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output@[@@@",
+      "@@@STEP_LOG_LINE@json.output@  {@@@",
+      "@@@STEP_LOG_LINE@json.output@    \"_number\": \"91827\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"branch\": \"master\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"change_id\": \"Ideadbeef\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"has_review_started\": false, @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"project\": \"chromium/src\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"revisions\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@      \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@        \"_number\": \"1\", @@@",
+      "@@@STEP_LOG_LINE@json.output@        \"commit\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@          \"message\": \"Change commit message\"@@@",
+      "@@@STEP_LOG_LINE@json.output@        }@@@",
+      "@@@STEP_LOG_LINE@json.output@      }@@@",
+      "@@@STEP_LOG_LINE@json.output@    }, @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"status\": \"NEW\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"subject\": \"Change title\"@@@",
+      "@@@STEP_LOG_LINE@json.output@  }@@@",
+      "@@@STEP_LOG_LINE@json.output@]@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "reason": "Error querying for CL description: host:'https://chromium-review.googlesource.com' change:456789; patchset:12",
+    "recipe_result": null,
+    "status_code": 1
+  }
+]