libv8 5.1.281.59.1 → 5.2.361.43.0

data/vendor/depot_tools/owners_finder.py

@@ -23,7 +23,7 @@ class OwnersFinder(object):
   indentation = 0
 
   def __init__(self, files, local_root, author,
-               fopen, os_path, glob,
+               fopen, os_path,
                email_postfix='@chromium.org',
                disable_color=False):
     self.email_postfix = email_postfix
@@ -34,7 +34,7 @@ class OwnersFinder(object):
       self.COLOR_GREY = ''
       self.COLOR_RESET = ''
 
-    self.db = owners_module.Database(local_root, fopen, os_path, glob)
+    self.db = owners_module.Database(local_root, fopen, os_path)
     self.db.load_data_needed_for(files)
 
     self.os_path = os_path
@@ -43,28 +43,15 @@ class OwnersFinder(object):
 
     filtered_files = files
 
-    # Eliminate files that author himself can review.
-    if author:
-      if author in self.db.owned_by:
-        for dir_name in self.db.owned_by[author]:
-          filtered_files = [
-              file_name for file_name in filtered_files
-              if not file_name.startswith(dir_name)]
-
-        filtered_files = list(filtered_files)
-
-    # Eliminate files that everyone can review.
-    if owners_module.EVERYONE in self.db.owned_by:
-      for dir_name in self.db.owned_by[owners_module.EVERYONE]:
-        filtered_files = filter(
-            lambda file_name: not file_name.startswith(dir_name),
-            filtered_files)
+    # Eliminate files that the author can review.
+    filtered_files = list(self.db.files_not_covered_by(
+      filtered_files, [author] if author else []))
 
     # If some files are eliminated.
     if len(filtered_files) != len(files):
       files = filtered_files
       # Reload the database.
-      self.db = owners_module.Database(local_root, fopen, os_path, glob)
+      self.db = owners_module.Database(local_root, fopen, os_path)
       self.db.load_data_needed_for(files)
 
     self.all_possible_owners = self.db.all_possible_owners(files, None)

data/vendor/depot_tools/presubmit_canned_checks.py

@@ -1170,7 +1170,8 @@ def CheckGNFormatted(input_api, output_api):
   affected_files = input_api.AffectedFiles(
       include_deletes=False,
       file_filter=lambda x: x.LocalPath().endswith('.gn') or
-                            x.LocalPath().endswith('.gni'))
+                            x.LocalPath().endswith('.gni') or
+                            x.LocalPath().endswith('.typemap'))
   warnings = []
   for f in affected_files:
     cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]

data/vendor/depot_tools/presubmit_support.py

@@ -16,7 +16,7 @@ import cpplint
 import cPickle  # Exposed through the API.
 import cStringIO  # Exposed through the API.
 import contextlib
-import fnmatch
+import fnmatch  # Exposed through the API.
 import glob
 import inspect
 import itertools
@@ -244,13 +244,10 @@ class GerritAccessor(object):
     return self.GetChangeInfo(issue)['owner']['email']
 
   def GetChangeReviewers(self, issue, approving_only=True):
-    # Gerrit has 'approved' sub-section, but it only lists 1 approver.
-    # So, if we look only for approvers, we have to look at all anyway.
-    # Also, assume LGTM means Code-Review label == 2. Other configurations
-    # aren't supported.
-    return [r['email']
-            for r in self.GetChangeInfo(issue)['labels']['Code-Review']['all']
-            if not approving_only or '2' == str(r.get('value', 0))]
+    cr = self.GetChangeInfo(issue)['labels']['Code-Review']
+    max_value = max(int(k) for k in cr['values'].keys())
+    return [r['email'] for r in cr['all']
+            if not approving_only or r.get('value', 0) == max_value]
 
 
 class OutputApi(object):
@@ -348,6 +345,7 @@ class InputApi(object):
     self.cPickle = cPickle
     self.cpplint = cpplint
     self.cStringIO = cStringIO
+    self.fnmatch = fnmatch
     self.glob = glob.glob
     self.json = json
     self.logging = logging.getLogger('PRESUBMIT')
@@ -389,7 +387,7 @@ class InputApi(object):
     # TODO(dpranke): figure out a list of all approved owners for a repo
     # in order to be able to handle wildcard OWNERS files?
     self.owners_db = owners.Database(change.RepositoryRoot(),
-        fopen=file, os_path=self.os_path, glob=self.glob)
+        fopen=file, os_path=self.os_path)
     self.verbose = verbose
     self.Command = CommandData
 
@@ -1828,4 +1826,4 @@ if __name__ == '__main__':
     sys.exit(main())
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
-    sys.exit(1)
+    sys.exit(2)

data/vendor/depot_tools/recipe_modules/bot_update/api.py

@@ -57,12 +57,14 @@ class BotUpdateApi(recipe_api.RecipeApi):
                       patch=True, update_presentation=True,
                       force=False, patch_root=None, no_shallow=False,
                       with_branch_heads=False, refs=None,
-                      patch_oauth2=False,
+                      patch_oauth2=False, use_site_config_creds=True,
                       output_manifest=True, clobber=False,
                       root_solution_revision=None, rietveld=None, issue=None,
                       patchset=None, gerrit_no_reset=False, **kwargs):
     """
     Args:
+      use_site_config_creds: If the oauth2 credentials are in the buildbot
+        site_config. See crbug.com/624212 for more information.
       gclient_config: The gclient configuration to use when running bot_update.
         If omitted, the current gclient configuration is used.
       rietveld: The rietveld server to use. If omitted, will infer from
@@ -119,10 +121,16 @@ class BotUpdateApi(recipe_api.RecipeApi):
     # Point to the oauth2 auth files if specified.
     # These paths are where the bots put their credential files.
     if patch_oauth2:
-      email_file = self.m.path['build'].join(
-          'site_config', '.rietveld_client_email')
-      key_file = self.m.path['build'].join(
-          'site_config', '.rietveld_secret_key')
+      # TODO(martiniss): remove this hack :(. crbug.com/624212
+      if use_site_config_creds:
+        email_file = self.m.path['build'].join(
+            'site_config', '.rietveld_client_email')
+        key_file = self.m.path['build'].join(
+            'site_config', '.rietveld_secret_key')
+      else: #pragma: no cover
+        #TODO(martiniss): make this use path.join, so it works on windows
+        email_file = '/creds/rietveld/client_email'
+        key_file = '/creds/rietveld/secret_key'
     else:
       email_file = key_file = None
 
@@ -223,61 +231,67 @@ class BotUpdateApi(recipe_api.RecipeApi):
       name += ' - %s' % suffix
 
     # Ah hah! Now that everything is in place, lets run bot_update!
+    step_result = None
     try:
       # 87 and 88 are the 'patch failure' codes for patch download and patch
       # apply, respectively. We don't actually use the error codes, and instead
       # rely on emitted json to determine cause of failure.
-      self(name, cmd, step_test_data=step_test_data,
+      step_result = self(name, cmd, step_test_data=step_test_data,
            ok_ret=(0, 87, 88), **kwargs)
+    except self.m.step.StepFailure as f:
+      step_result = f.result
+      raise
     finally:
-      step_result = self.m.step.active_result
-      self._last_returned_properties = step_result.json.output.get(
-          'properties', {})
-
-      if update_presentation:
-        # Set properties such as got_revision.
-        for prop_name, prop_value in self.last_returned_properties.iteritems():
-          step_result.presentation.properties[prop_name] = prop_value
-      # Add helpful step description in the step UI.
-      if 'step_text' in step_result.json.output:
-        step_text = step_result.json.output['step_text']
-        step_result.presentation.step_text = step_text
-      # Add log line output.
-      if 'log_lines' in step_result.json.output:
-        for log_name, log_lines in step_result.json.output['log_lines']:
-          step_result.presentation.logs[log_name] = log_lines.splitlines()
-
-      # Set the "checkout" path for the main solution.
-      # This is used by the Chromium module to figure out where to look for
-      # the checkout.
-      # If there is a patch failure, emit another step that said things failed.
-      if step_result.json.output.get('patch_failure'):
-        return_code = step_result.json.output.get('patch_apply_return_code')
-        if return_code == 3:
-          # This is download failure, hence an infra failure.
-          # Sadly, python.failing_step doesn't support kwargs.
-          self.m.python.inline(
-              'Patch failure',
-              ('import sys;'
-               'print "Patch download failed. See bot_update step for details";'
-               'sys.exit(1)'),
-              infra_step=True,
-              step_test_data=lambda: self.m.raw_io.test_api.output(
-                'Patch download failed. See bot_update step for details',
-                retcode=1)
-              )
-        else:
-          # This is actual patch failure.
-          self.m.tryserver.set_patch_failure_tryjob_result()
-          self.m.python.failing_step(
-              'Patch failure', 'Check the bot_update step for details')
-
-      # bot_update actually just sets root to be the folder name of the
-      # first solution.
-      if step_result.json.output['did_run']:
-        co_root = step_result.json.output['root']
-        cwd = kwargs.get('cwd', self.m.path['slave_build'])
-        if 'checkout' not in self.m.path:
-          self.m.path['checkout'] = cwd.join(*co_root.split(self.m.path.sep))
+      if step_result:
+        self._last_returned_properties = step_result.json.output.get(
+            'properties', {})
+
+        if update_presentation:
+          # Set properties such as got_revision.
+          for prop_name, prop_value in (
+              self.last_returned_properties.iteritems()):
+            step_result.presentation.properties[prop_name] = prop_value
+        # Add helpful step description in the step UI.
+        if 'step_text' in step_result.json.output:
+          step_text = step_result.json.output['step_text']
+          step_result.presentation.step_text = step_text
+        # Add log line output.
+        if 'log_lines' in step_result.json.output:
+          for log_name, log_lines in step_result.json.output['log_lines']:
+            step_result.presentation.logs[log_name] = log_lines.splitlines()
+
+        # Set the "checkout" path for the main solution.
+        # This is used by the Chromium module to figure out where to look for
+        # the checkout.
+        # If there is a patch failure, emit another step that said things
+        # failed.
+        if step_result.json.output.get('patch_failure'):
+          return_code = step_result.json.output.get('patch_apply_return_code')
+          if return_code == 3:
+            # This is download failure, hence an infra failure.
+            # Sadly, python.failing_step doesn't support kwargs.
+            self.m.python.inline(
+                'Patch failure',
+                ('import sys;'
+                 'print "Patch download failed. See bot_update step for'
+                 ' details";sys.exit(1)'),
+                infra_step=True,
+                step_test_data=lambda: self.m.raw_io.test_api.output(
+                  'Patch download failed. See bot_update step for details',
+                  retcode=1)
+                )
+          else:
+            # This is actual patch failure.
+            self.m.tryserver.set_patch_failure_tryjob_result()
+            self.m.python.failing_step(
+                'Patch failure', 'Check the bot_update step for details')
+
+        # bot_update actually just sets root to be the folder name of the
+        # first solution.
+        if step_result.json.output['did_run']:
+          co_root = step_result.json.output['root']
+          cwd = kwargs.get('cwd', self.m.path['slave_build'])
+          if 'checkout' not in self.m.path:
+            self.m.path['checkout'] = cwd.join(*co_root.split(self.m.path.sep))
 
     return step_result

data/vendor/depot_tools/recipe_modules/bot_update/example.expected/tryjob_fail.json

@@ -55,6 +55,7 @@
   {
     "name": "$result",
     "reason": "Infra Failure: Step('bot_update') returned 1",
+    "recipe_result": null,
     "status_code": 1
   }
 ]

data/vendor/depot_tools/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json

@@ -76,6 +76,7 @@
   {
     "name": "$result",
     "reason": "Step('Patch failure') failed with return_code 1",
+    "recipe_result": null,
     "status_code": 1
   }
 ]

data/vendor/depot_tools/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

@@ -76,6 +76,7 @@
   {
     "name": "$result",
     "reason": "Infra Failure: Step('Patch failure') returned 1",
+    "recipe_result": null,
     "status_code": 1
   }
 ]

data/vendor/depot_tools/recipe_modules/bot_update/resources/bot_update.py

@@ -250,6 +250,8 @@ RECOGNIZED_PATHS = {
         CHROMIUM_SRC_URL,
     '/chrome/trunk/src/tools/cros.DEPS':
         CHROMIUM_GIT_HOST + '/chromium/src/tools/cros.DEPS.git',
+    '/chrome-internal/trunk/src-internal':
+        'https://chrome-internal.googlesource.com/chrome/src-internal.git',
 }
 RECOGNIZED_PATHS.update(internal_data.get('RECOGNIZED_PATHS', {}))
 

data/vendor/depot_tools/recipe_modules/gclient/api.py

@@ -32,23 +32,6 @@ class RevisionFallbackChain(RevisionResolver):
             self._default)
 
 
-class ProjectRevisionResolver(RevisionResolver):
-  """Revision resolver that takes into account the project."""
-  def __init__(self, project, parent_got_revision=None):
-    self.project = project
-    self.parent_got_revision = parent_got_revision or 'parent_got_revision'
-
-  # TODO(phajdan.jr): Move to proper repo and add coverage.
-  def resolve(self, properties):  # pragma: no cover
-    """Resolve the revision if project matches, otherwise default to HEAD."""
-    if properties.get('project') == self.project:
-      return (properties.get(self.parent_got_revision) or
-              properties.get('revision') or
-              'HEAD')
-    return (properties.get(self.parent_got_revision) or
-            'HEAD')
-
-
 def jsonish_to_python(spec, is_top=False):
   """Turn a json spec into a python parsable object.
 

data/vendor/depot_tools/recipe_modules/gclient/config.py

@@ -252,14 +252,6 @@ def blink(c):
   del c.solutions[0].custom_deps
   c.revisions['src/third_party/WebKit'] = 'HEAD'
 
-@config_ctx(includes=['chromium'])
-def blink_or_chromium(c):
-  c.solutions[0].revision = gclient_api.ProjectRevisionResolver('chromium')
-  del c.solutions[0].custom_deps
-  c.revisions['src/third_party/WebKit'] = \
-      gclient_api.ProjectRevisionResolver(
-          'webkit', parent_got_revision='parent_got_webkit_revision')
-
 # TODO(phajdan.jr): Move to proper repo and add coverage.
 @config_ctx(includes=['chromium'])
 def blink_merged(c):  # pragma: no cover
@@ -564,7 +556,9 @@ def infra(c):
 
   p = c.patch_projects
   p['luci-py'] = ('infra/luci', 'HEAD')
+  # TODO(phajdan.jr): remove recipes-py when it's not used for project name.
   p['recipes-py'] = ('infra/recipes-py', 'HEAD')
+  p['recipe_engine'] = ('infra/recipes-py', 'HEAD')
 
 @config_ctx(config_vars={'GIT_MODE': True})
 def infra_internal(c):  # pragma: no cover
@@ -688,3 +682,10 @@ def valgrind(c):  # pragma: no cover
   """Add Valgrind binaries to the gclient solution."""
   c.solutions[0].custom_deps['src/third_party/valgrind'] = \
     ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries')
+
+@config_ctx(includes=['chromium'])
+def chromedriver(c):
+  """Add Selenium Java tests to the gclient solution."""
+  c.solutions[0].custom_deps[
+      'src/chrome/test/chromedriver/third_party/java_tests'] = (
+          ChromiumGitURL(c, 'chromium', 'deps', 'webdriver'))

data/vendor/depot_tools/recipe_modules/gclient/example.py

@@ -13,11 +13,11 @@ TEST_CONFIGS = [
   'android',
   'android_bare',
   'blink',
-  'blink_or_chromium',
   'boringssl',
   'build_internal',
   'build_internal_scripts_slave',
   'catapult',
+  'chromedriver',
   'chrome_internal',
   'chromium',
   'chromium_lkcr',

data/vendor/depot_tools/recipe_modules/git/api.py

@@ -16,7 +16,7 @@ class GitApi(recipe_api.RecipeApi):
 
   def __call__(self, *args, **kwargs):
     """Return a git command step."""
-    name = kwargs.pop('name', 'git '+args[0])
+    name = kwargs.pop('name', 'git ' + args[0])
     infra_step = kwargs.pop('infra_step', True)
     if 'cwd' not in kwargs:
       kwargs.setdefault('cwd', self.m.path['checkout'])
@@ -45,7 +45,8 @@ class GitApi(recipe_api.RecipeApi):
         'ensure git tooling on windows',
         [self.package_repo_resource('bootstrap', 'win', 'win_tools.bat')],
         infra_step=True,
-        cwd=self.package_repo_resource())
+        cwd=self.package_repo_resource(),
+        timeout=300)
     self.initialized_win_git = True
 
   def fetch_tags(self, remote_name=None, **kwargs):
@@ -132,8 +133,10 @@ class GitApi(recipe_api.RecipeApi):
                curl_trace_file=None, can_fail_build=True,
                set_got_revision=False, remote_name=None,
                display_fetch_size=None, file_name=None,
-               submodule_update_recursive=True):
-    """Returns an iterable of steps to perform a full git checkout.
+               submodule_update_recursive=True,
+               use_git_cache=False):
+    """Performs a full git checkout and returns sha1 of checked out revision.
+
     Args:
       url (str): url of remote repo to use as upstream
       ref (str): ref to fetch and check out
@@ -156,6 +159,13 @@ class GitApi(recipe_api.RecipeApi):
       file_name (str): optional path to a single file to checkout.
       submodule_update_recursive (bool): if True, updates submodules
           recursively.
+      use_git_cache (bool): if True, git cache will be used for this checkout.
+          WARNING, this is EXPERIMENTAL!!! This wasn't tested with:
+           * submodules
+           * since origin url is modified
+             to a local path, may cause problem with scripts that do
+             "git fetch origin" or "git push origin".
+           * arbitrary refs such refs/whatever/not-fetched-by-default-to-cache
 
     Returns: If the checkout was successful, this returns the commit hash of
       the checked-out-repo. Otherwise this returns None.
@@ -198,6 +208,12 @@ class GitApi(recipe_api.RecipeApi):
         self.resource('git_setup.py'),
         git_setup_args)
 
+    if use_git_cache:
+      self('retry', 'cache', 'fetch', '-c', self.m.path['git_cache'],
+           cwd=dir_path,
+           name='fetch cache',
+           can_fail_build=can_fail_build)
+
     # There are five kinds of refs we can be handed:
     # 0) None. In this case, we default to properties['branch'].
     # 1) A 40-character SHA1 hash.

data/vendor/depot_tools/recipe_modules/git/example.expected/can_fail_build.json

@@ -148,6 +148,7 @@
   {
     "name": "$result",
     "reason": "Infra Failure: Step('git status can_fail_build') returned 1",
+    "recipe_result": null,
     "status_code": 1
   }
 ]

data/vendor/depot_tools/recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json

@@ -97,6 +97,7 @@
   {
     "name": "$result",
     "reason": "count-objects failed: invalid literal for long() with base 10: 'xxx'",
+    "recipe_result": null,
     "status_code": 1
   }
 ]