libv8-node 18.13.0.1-x86_64-darwin → 20.2.0.0-x86_64-darwin

data/vendor/v8/include/v8-value-serializer.h

@@ -8,6 +8,7 @@
 #include <stddef.h>
 #include <stdint.h>
 
+#include <memory>
 #include <utility>
 
 #include "v8-local-handle.h"  // NOLINT(build/include_directory)
@@ -26,8 +27,37 @@ class Value;
 
 namespace internal {
 struct ScriptStreamingData;
+class SharedObjectConveyorHandles;
+class ValueDeserializer;
+class ValueSerializer;
 }  // namespace internal
 
+/**
+ * A move-only class for managing the lifetime of shared value conveyors used
+ * by V8 to keep JS shared values alive in transit when serialized.
+ *
+ * This class is not directly constructible and is always passed to a
+ * ValueSerializer::Delegate via ValueSerializer::SetSharedValueConveyor.
+ *
+ * The embedder must not destruct the SharedValueConveyor until the associated
+ * serialized data will no longer be deserialized.
+ */
+class V8_EXPORT SharedValueConveyor final {
+ public:
+  SharedValueConveyor(SharedValueConveyor&&) noexcept;
+  ~SharedValueConveyor();
+
+  SharedValueConveyor& operator=(SharedValueConveyor&&) noexcept;
+
+ private:
+  friend class internal::ValueSerializer;
+  friend class internal::ValueDeserializer;
+
+  explicit SharedValueConveyor(Isolate* isolate);
+
+  std::unique_ptr<internal::SharedObjectConveyorHandles> private_;
+};
+
 /**
  * Value serialization compatible with the HTML structured clone algorithm.
  * The format is backward-compatible (i.e. safe to store to disk).
@@ -69,20 +99,20 @@ class V8_EXPORT ValueSerializer {
         Isolate* isolate, Local<WasmModuleObject> module);
 
     /**
-     * Returns whether shared values are supported. GetSharedValueId is only
-     * called if SupportsSharedValues() returns true.
-     */
-    virtual bool SupportsSharedValues() const;
-
-    /**
-     * Called when the ValueSerializer serializes a value that is shared across
-     * Isolates. The embedder must return an ID for the object. This function
-     * must be idempotent for the same object. When deserializing, the ID will
-     * be passed to ValueDeserializer::Delegate::GetSharedValueFromId as
-     * |shared_value_id|.
+     * Called when the first shared value is serialized. All subsequent shared
+     * values will use the same conveyor.
+     *
+     * The embedder must ensure the lifetime of the conveyor matches the
+     * lifetime of the serialized data.
+     *
+     * If the embedder supports serializing shared values, this method should
+     * return true. Otherwise the embedder should throw an exception and return
+     * false.
+     *
+     * This method is called at most once per serializer.
      */
-    virtual Maybe<uint32_t> GetSharedValueId(Isolate* isolate,
-                                             Local<Value> shared_value);
+    virtual bool AdoptSharedValueConveyor(Isolate* isolate,
+                                          SharedValueConveyor&& conveyor);
 
     /**
      * Allocates memory for the buffer of at least the size provided. The actual
@@ -196,17 +226,10 @@ class V8_EXPORT ValueDeserializer {
         Isolate* isolate, uint32_t clone_id);
 
     /**
-     * Returns whether shared values are supported. GetSharedValueFromId is only
-     * called if SupportsSharedValues() returns true.
-     */
-    virtual bool SupportsSharedValues() const;
-
-    /**
-     * Get a value shared across Isolates given a shared_value_id provided by
-     * ValueSerializer::Delegate::GetSharedValueId.
+     * Get the SharedValueConveyor previously provided by
+     * ValueSerializer::Delegate::AdoptSharedValueConveyor.
      */
-    virtual MaybeLocal<Value> GetSharedValueFromId(Isolate* isolate,
-                                                   uint32_t shared_value_id);
+    virtual const SharedValueConveyor* GetSharedValueConveyor(Isolate* isolate);
   };
 
   ValueDeserializer(Isolate* isolate, const uint8_t* data, size_t size);

data/vendor/v8/include/v8-value.h

@@ -244,6 +244,11 @@ class V8_EXPORT Value : public Data {
    */
   bool IsWeakSet() const;
 
+  /**
+   * Returns true if this value is a WeakRef.
+   */
+  bool IsWeakRef() const;
+
   /**
    * Returns true if this value is an ArrayBuffer.
    */
@@ -339,6 +344,11 @@ class V8_EXPORT Value : public Data {
    */
   bool IsWasmModuleObject() const;
 
+  /**
+   * Returns true if this value is the WasmNull object.
+   */
+  bool IsWasmNull() const;
+
   /**
    * Returns true if the value is a Module Namespace Object.
    */
@@ -464,10 +474,14 @@ bool Value::IsUndefined() const {
 bool Value::QuickIsUndefined() const {
   using A = internal::Address;
   using I = internal::Internals;
-  A obj = *reinterpret_cast<const A*>(this);
+  A obj = internal::ValueHelper::ValueAsAddress(this);
+#if V8_STATIC_ROOTS_BOOL
+  return I::is_identical(obj, I::StaticReadOnlyRoot::kUndefinedValue);
+#else
   if (!I::HasHeapObjectTag(obj)) return false;
   if (I::GetInstanceType(obj) != I::kOddballType) return false;
   return (I::GetOddballKind(obj) == I::kUndefinedOddballKind);
+#endif  // V8_STATIC_ROOTS_BOOL
 }
 
 bool Value::IsNull() const {
@@ -481,10 +495,14 @@ bool Value::IsNull() const {
 bool Value::QuickIsNull() const {
   using A = internal::Address;
   using I = internal::Internals;
-  A obj = *reinterpret_cast<const A*>(this);
+  A obj = internal::ValueHelper::ValueAsAddress(this);
+#if V8_STATIC_ROOTS_BOOL
+  return I::is_identical(obj, I::StaticReadOnlyRoot::kNullValue);
+#else
   if (!I::HasHeapObjectTag(obj)) return false;
   if (I::GetInstanceType(obj) != I::kOddballType) return false;
   return (I::GetOddballKind(obj) == I::kNullOddballKind);
+#endif  // V8_STATIC_ROOTS_BOOL
 }
 
 bool Value::IsNullOrUndefined() const {
@@ -496,13 +514,17 @@ bool Value::IsNullOrUndefined() const {
 }
 
 bool Value::QuickIsNullOrUndefined() const {
+#if V8_STATIC_ROOTS_BOOL
+  return QuickIsNull() || QuickIsUndefined();
+#else
   using A = internal::Address;
   using I = internal::Internals;
-  A obj = *reinterpret_cast<const A*>(this);
+  A obj = internal::ValueHelper::ValueAsAddress(this);
   if (!I::HasHeapObjectTag(obj)) return false;
   if (I::GetInstanceType(obj) != I::kOddballType) return false;
   int kind = I::GetOddballKind(obj);
   return kind == I::kNullOddballKind || kind == I::kUndefinedOddballKind;
+#endif  // V8_STATIC_ROOTS_BOOL
 }
 
 bool Value::IsString() const {
@@ -516,9 +538,14 @@ bool Value::IsString() const {
 bool Value::QuickIsString() const {
   using A = internal::Address;
   using I = internal::Internals;
-  A obj = *reinterpret_cast<const A*>(this);
+  A obj = internal::ValueHelper::ValueAsAddress(this);
   if (!I::HasHeapObjectTag(obj)) return false;
+#if V8_STATIC_ROOTS_BOOL && !V8_MAP_PACKING
+  return I::CheckInstanceMapRange(obj, I::StaticReadOnlyRoot::kFirstStringMap,
+                                  I::StaticReadOnlyRoot::kLastStringMap);
+#else
   return (I::GetInstanceType(obj) < I::kFirstNonstringType);
+#endif  // V8_STATIC_ROOTS_BOOL
 }
 
 }  // namespace v8

data/vendor/v8/include/v8-version.h

@@ -8,10 +8,10 @@
 // These macros define the version number for the current version.
 // NOTE these macros are used by some of the tool scripts and the build
 // system so their names cannot be changed without changing the scripts.
-#define V8_MAJOR_VERSION 10
-#define V8_MINOR_VERSION 2
-#define V8_BUILD_NUMBER 154
-#define V8_PATCH_LEVEL 23
+#define V8_MAJOR_VERSION 11
+#define V8_MINOR_VERSION 3
+#define V8_BUILD_NUMBER 244
+#define V8_PATCH_LEVEL 8
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

data/vendor/v8/include/v8-wasm.h

@@ -5,6 +5,7 @@
 #ifndef INCLUDE_V8_WASM_H_
 #define INCLUDE_V8_WASM_H_
 
+#include <functional>
 #include <memory>
 #include <string>
 
@@ -130,19 +131,6 @@ class V8_EXPORT WasmStreaming final {
  public:
   class WasmStreamingImpl;
 
-  /**
-   * Client to receive streaming event notifications.
-   */
-  class Client {
-   public:
-    virtual ~Client() = default;
-    /**
-     * Passes the fully compiled module to the client. This can be used to
-     * implement code caching.
-     */
-    virtual void OnModuleCompiled(CompiledWasmModule compiled_module) = 0;
-  };
-
   explicit WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl);
 
   ~WasmStreaming();
@@ -156,7 +144,7 @@ class V8_EXPORT WasmStreaming final {
   /**
    * {Finish} should be called after all received bytes where passed to
    * {OnBytesReceived} to tell V8 that there will be no more bytes. {Finish}
-   * does not have to be called after {Abort} has been called already.
+   * must not be called after {Abort} has been called already.
    * If {can_use_compiled_module} is true and {SetCompiledModuleBytes} was
    * previously called, the compiled module bytes can be used.
    * If {can_use_compiled_module} is false, the compiled module bytes previously
@@ -168,6 +156,7 @@ class V8_EXPORT WasmStreaming final {
    * Abort streaming compilation. If {exception} has a value, then the promise
    * associated with streaming compilation is rejected with that value. If
    * {exception} does not have value, the promise does not get rejected.
+   * {Abort} must not be called repeatedly, or after {Finish}.
    */
   void Abort(MaybeLocal<Value> exception);
 
@@ -183,10 +172,11 @@ class V8_EXPORT WasmStreaming final {
   bool SetCompiledModuleBytes(const uint8_t* bytes, size_t size);
 
   /**
-   * Sets the client object that will receive streaming event notifications.
-   * This must be called before {OnBytesReceived}, {Finish}, or {Abort}.
+   * Sets a callback which is called whenever a significant number of new
+   * functions are ready for serialization.
    */
-  void SetClient(std::shared_ptr<Client> client);
+  void SetMoreFunctionsCanBeSerializedCallback(
+      std::function<void(CompiledWasmModule)>);
 
   /*
    * Sets the UTF-8 encoded source URL for the {Script} object. This must be
@@ -206,52 +196,6 @@ class V8_EXPORT WasmStreaming final {
   std::unique_ptr<WasmStreamingImpl> impl_;
 };
 
-// TODO(mtrofin): when streaming compilation is done, we can rename this
-// to simply WasmModuleObjectBuilder
-class V8_EXPORT WasmModuleObjectBuilderStreaming final {
- public:
-  explicit WasmModuleObjectBuilderStreaming(Isolate* isolate);
-  /**
-   * The buffer passed into OnBytesReceived is owned by the caller.
-   */
-  void OnBytesReceived(const uint8_t*, size_t size);
-  void Finish();
-  /**
-   * Abort streaming compilation. If {exception} has a value, then the promise
-   * associated with streaming compilation is rejected with that value. If
-   * {exception} does not have value, the promise does not get rejected.
-   */
-  void Abort(MaybeLocal<Value> exception);
-  Local<Promise> GetPromise();
-
-  ~WasmModuleObjectBuilderStreaming() = default;
-
- private:
-  WasmModuleObjectBuilderStreaming(const WasmModuleObjectBuilderStreaming&) =
-      delete;
-  WasmModuleObjectBuilderStreaming(WasmModuleObjectBuilderStreaming&&) =
-      default;
-  WasmModuleObjectBuilderStreaming& operator=(
-      const WasmModuleObjectBuilderStreaming&) = delete;
-  WasmModuleObjectBuilderStreaming& operator=(
-      WasmModuleObjectBuilderStreaming&&) = default;
-  Isolate* isolate_ = nullptr;
-
-#if V8_CC_MSVC
-  /**
-   * We don't need the static Copy API, so the default
-   * NonCopyablePersistentTraits would be sufficient, however,
-   * MSVC eagerly instantiates the Copy.
-   * We ensure we don't use Copy, however, by compiling with the
-   * defaults everywhere else.
-   */
-  Persistent<Promise, CopyablePersistentTraits<Promise>> promise_;
-#else
-  Persistent<Promise> promise_;
-#endif
-  std::shared_ptr<internal::wasm::StreamingDecoder> streaming_decoder_;
-};
-
 }  // namespace v8
 
 #endif  // INCLUDE_V8_WASM_H_

data/vendor/v8/include/v8-weak-callback-info.h

@@ -63,13 +63,6 @@ enum class WeakCallbackType {
    * Passes the first two internal fields of the object back to the callback.
    */
   kInternalFields,
-  /**
-   * Passes a user-defined void* parameter back to the callback. Will do so
-   * before the object is actually reclaimed, allowing it to be resurrected. In
-   * this case it is not possible to set a second-pass callback.
-   */
-  kFinalizer V8_ENUM_DEPRECATED("Resurrecting finalizers are deprecated "
-                                "and will not be supported going forward.")
 };
 
 template <class T>