libreconv 0.9.3 → 0.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 771ed18ef3438a2fbe8aa0a213c57c97a7631e1d8ab25e63fbd791d0884ea81b
-  data.tar.gz: 568a8dacb50e126a828843dd142a3ad0209bd0daee230d5ec355566a7e9a1ed9
+  metadata.gz: 5ae94a53817b7bd0f69b71501286d2ecef0f6e4fa698d6a73175fdd0b9c9c1db
+  data.tar.gz: 0af95f4eaafc34508dafa929de52f678fc4d227fe3de1ad6b53195c385ca9b47
 SHA512:
-  metadata.gz: fb1894b92d6c3f96b4e8955724969e7da080ef82db3d68495e87030f9210ba363b617c29e76efac5dc79428a91fafe108b31b746cab175268bd338c375fa8359
-  data.tar.gz: 7d7b25767c5467cd52a7446bd7f1c2d76219c985233167294337386c83e1f6a039e01bca6926517d9480907530b5feeddcf028b5f654871c01641f61ff8cd6f8
+  metadata.gz: 53a3ac9d20908d5aecba062984c31461ccafc2defe9fb55432a77b540a24d6274e001b7107885b45eb77890ac7c2da5d0cfa0a2f075b820a36f2d3862e41f009
+  data.tar.gz: f3880d9db0000edbd39479b128b40a9f4357274ef05f75093bdd90bdda6220202d9e2313595c28059027f4b60e186aa277d32a3c6149031211dadd7d78ace707

data/.editorconfig

@@ -0,0 +1,15 @@
+# Editor configuration, see https://editorconfig.org
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+end_of_line = lf
+insert_final_newline = true
+max_line_length = 100
+trim_trailing_whitespace = true
+
+[*.md]
+max_line_length = off
+trim_trailing_whitespace = false

data/.gitignore

@@ -1,23 +1,20 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-.idea/
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
 
-TODO.md
+# rspec failure tracking
+.rspec_status
 
-spec/.DS_Store
+/Gemfile.lock
+/.ruby-version
+*.gem
+/vendor/bundle
 
+# Misc.
 .DS_Store
+/.idea/

data/.rspec

@@ -1,2 +1,4 @@
 --color
---format progress
+--format documentation
+--require spec_helper
+--order rand

data/.rubocop.yml

@@ -1,25 +1,23 @@
 require: rubocop-rspec
 
-Metrics/AbcSize:
-  # Max: 25
-  Enabled: false
+AllCops:
+  TargetRubyVersion: 2.3
 
-Metrics/MethodLength:
-  # Max: 20
+Style/Documentation:
   Enabled: false
 
-Metrics/CyclomaticComplexity:
-  # Max: 10
-  Enabled: false
+Metrics/LineLength:
+  Max: 100
 
-Metrics/BlockLength:
-  Enabled: false
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%w': '[]'
 
-Metrics/PerceivedComplexity:
+Style/ExpandPathArguments:
   Enabled: false
 
-RSpec/ExampleLength:
+Style/Encoding:
   Enabled: false
 
-Style/Documentation:
+Layout/EndOfLine:
   Enabled: false

data/.travis.yml

@@ -1,7 +1,14 @@
+sudo: false
 language: ruby
+cache: bundler
 rvm:
-  - 2.2.0
-  - 2.5.3
+  - 1.9.3
+  - 2.2
+  - 2.3
+  - 2.5
+  - jruby
 before_install:
   - sudo apt-get update -qq
-  - sudo apt-get install libreoffice
+  - sudo apt-get install libreoffice-core libreoffice-writer libreoffice-calc libreoffice-impress -y --no-install-recommends
+before_script: bundle exec rubocop
+script: bundle exec rake

data/Gemfile

@@ -4,10 +4,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in libreconv.gemspec
 gemspec
-
-group :development, :test do
-  gem 'pry-byebug'
-  gem 'rubocop', require: false
-  gem 'rubocop-rspec', require: false
-  gem 'webmock'
-end

data/README.md

@@ -9,7 +9,9 @@ Convert office documents using LibreOffice / OpenOffice to one of their supporte
 
 Add this line to your application's Gemfile:
 
-    gem 'libreconv'
+```ruby
+gem 'libreconv'
+```
 
 And then execute:
 
@@ -21,7 +23,7 @@ Or install it yourself as:
 
 ## Usage
 
-You need to install Libreoffice or Openoffice on your system to use this gem. The code has been tested with Libreoffice 6.1.3.
+You need to install LibreOffice or OpenOffice on your system to use this gem. The code has been tested with LibreOffice 6.1.3.
 
 ```ruby
 require 'libreconv'
@@ -41,7 +43,7 @@ Libreconv.convert('http://myserver.com/123/document.docx', '/Users/ricn/pdf_docu
 Libreconv.convert('https://mybucket.s3.amazonaws.com/myserver/123/document.docx?X-Amz-Expires=456&X-Amz-Signature=abc', '/Users/ricn/pdf_documents/doc.pdf')
 
 # Converts document.docx to document.pdf
-# If you for some reason can't have soffice in your PATH you can specifiy the file path to the soffice binary
+# If you for some reason can't have soffice in your PATH you can specify the file path to the soffice binary
 Libreconv.convert('document.docx', '/Users/ricn/pdf_documents', '/Applications/LibreOffice.app/Contents/MacOS/soffice')
 
 # Converts document.docx to my_document_as.html
@@ -49,9 +51,15 @@ Libreconv.convert('document.docx', '/Users/ricn/pdf_documents/my_document_as.htm
 
 # Converts document.docx to my_document_as.pdf using writer_pdf_Export filter
 Libreconv.convert('document.docx', '/Users/ricn/pdf_documents/my_document_as.pdf', nil, 'pdf:writer_pdf_Export')
-
 ```
 
+## Development
+
+After checking out the repo, run `bundle install` to install dependencies. Then, run `bundle exec rake` to run the tests.
+You can also run `irb -r bundler/setup -r libreconv` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`.
+
 ## Credits
 
 The following people have contributed ideas, documentation, or code to Libreconv:
@@ -69,3 +77,7 @@ The following people have contributed ideas, documentation, or code to Libreconv
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/libreconv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Libreconv
-  VERSION = '0.9.3'
+  VERSION = '0.9.5'
 end

data/lib/libreconv.rb

@@ -7,110 +7,130 @@ require 'tmpdir'
 require 'securerandom'
 require 'open3'
 
+# Convert office documents using LibreOffice / OpenOffice to one of their supported formats.
 module Libreconv
   class ConversionFailedError < StandardError; end
 
-  SOURCE_TYPES = {
-    file: 1,
-    url: 2
-  }.freeze
-
+  # @param [String] source          Path or URL of the source file.
+  # @param [String] target          Target file path.
+  # @param [String] soffice_command Path to the soffice binary.
+  # @param [String] convert_to      Format to convert to (default: 'pdf').
+  # @raise [IOError]                If invalid source file/URL or soffice command not found.
+  # @raise [URI::Error]             When URI parsing error.
+  # @raise [Net::ProtocolError]     If source URL checking failed.
+  # @raise [ConversionFailedError]  When soffice command execution error.
   def self.convert(source, target, soffice_command = nil, convert_to = nil)
     Converter.new(source, target, soffice_command, convert_to).convert
   end
 
   class Converter
+    # @return [String]
     attr_accessor :soffice_command
 
+    # @param [String] source          Path or URL of the source file.
+    # @param [String] target          Target file path.
+    # @param [String] soffice_command Path to the soffice binary.
+    # @param [String] convert_to      Format to convert to (default: 'pdf').
+    # @raise [IOError]                If invalid source file/URL or soffice command not found.
+    # @raise [URI::Error]             When URI parsing error.
+    # @raise [Net::ProtocolError]     If source URL checking failed.
     def initialize(source, target, soffice_command = nil, convert_to = nil)
-      @source = source
+      @source = check_source_type(source)
       @target = target
-      @soffice_command =
-        soffice_command ||
-        which('soffice') ||
-        which('soffice.bin')
+      @soffice_command = soffice_command || which('soffice') || which('soffice.bin')
       @convert_to = convert_to || 'pdf'
-      @source_type = check_source_type
-
-      # If the URL contains GET params, the '&' could break when
-      # being used as an argument to soffice. Wrap it in single
-      # quotes to escape it. Then strip them from the target
-      # temp file name.
-      @escaped_source =
-        if @source_type == 1
-          @source
-        else
-          "'#{@source}'"
-        end
-      @escaped_source_path =
-        if @source_type == 1
-          @source
-        else
-          URI.parse(@source).path
-        end
 
       ensure_soffice_exists
     end
 
+    # @raise [ConversionFailedError]  When soffice command execution error.
     def convert
-      pipe_uuid = SecureRandom.uuid
+      tmp_pipe_path = File.join(Dir.tmpdir, "soffice-pipe-#{SecureRandom.uuid}")
 
       Dir.mktmpdir do |target_path|
-        accept_args = [
-          "pipe,name=soffice-pipe-#{pipe_uuid}",
-          'url',
-          'StarOffice.ServiceManager'
-        ].join(';')
-
-        command = [
-          soffice_command,
-          "--accept=\"#{accept_args}\"",
-          "-env:UserInstallation=file:///tmp/soffice-dir-#{pipe_uuid}",
-          '--headless',
-          '--convert-to',
-          @convert_to,
-          @escaped_source,
-          '--outdir',
-          target_path
-        ]
-
-        output, error, status = Open3.capture3(
-          {
-            'HOME' => ENV['HOME'],
-            'PATH' => ENV['PATH'],
-            'LANG' => ENV['LANG'],
-            'LD_LIBRARY_PATH' => ENV['LD_LIBRARY_PATH']
-          },
-          *command,
-          unsetenv_others: true
-        )
-        if !status.success?
-          raise ConversionFailedError,
-                "Conversion failed! Output: #{output.strip.inspect}, " \
-                "Error: #{error.strip.inspect}"
-        end
+        command = build_command(tmp_pipe_path, target_path)
+        target_tmp_file = execute_command(command, target_path)
 
-        target_tmp_file = "#{target_path}/" \
-          "#{File.basename(@escaped_source_path, '.*')}." \
-          "#{File.basename(@convert_to, ':*')}"
         FileUtils.cp target_tmp_file, @target
-        FileUtils.rm_rf("/tmp/soffice-dir-#{pipe_uuid}")
       end
+    ensure
+      FileUtils.rm_rf tmp_pipe_path if File.exist?(tmp_pipe_path)
     end
 
     private
 
+    # @param [Array<String>] command
+    # @param [String] target_path
+    # @return [String]
+    # @raise [ConversionFailedError]  When soffice command execution error.
+    def execute_command(command, target_path)
+      output, error, status =
+        if RUBY_PLATFORM =~ /java/
+          Open3.capture3(*command)
+        else
+          Open3.capture3(command_env, *command, unsetenv_others: true)
+        end
+
+      target_tmp_file = File.join(target_path, target_filename)
+      return target_tmp_file if status.success? && File.exist?(target_tmp_file)
+
+      raise ConversionFailedError,
+            "Conversion failed! Output: #{output.strip.inspect}, Error: #{error.strip.inspect}"
+    end
+
+    # @return [Hash]
+    def command_env
+      Hash[%w[HOME PATH LANG LD_LIBRARY_PATH SYSTEMROOT TEMP].map { |k| [k, ENV[k]] }]
+    end
+
+    # @param [String] tmp_pipe_path
+    # @param [String] target_path
+    # @return [Array<String>]
+    def build_command(tmp_pipe_path, target_path)
+      [
+        soffice_command,
+        "--accept=\"pipe,name=#{File.basename(tmp_pipe_path)};url;StarOffice.ServiceManager\"",
+        "-env:UserInstallation=#{build_file_uri(tmp_pipe_path)}",
+        '--headless',
+        '--convert-to', @convert_to,
+        escaped_source,
+        '--outdir', target_path
+      ]
+    end
+
+    # If the URL contains GET params, the '&' could break when being used as an argument to soffice.
+    # Wrap it in single quotes to escape it. Then strip them from the target temp file name.
+    # @return [String]
+    def escaped_source
+      # TODO: @source.is_a?(URI::Generic) ? "'#{@source}'" : @source
+      @source.to_s
+    end
+
+    # @return [String]
+    def escaped_source_path
+      @source.is_a?(URI::Generic) ? @source.path : @source
+    end
+
+    # @return [String]
+    def target_filename
+      File.basename(escaped_source_path, '.*') + '.' + File.basename(@convert_to, ':*')
+    end
+
+    # @raise [IOError] If soffice headless command line tool not found.
     def ensure_soffice_exists
       return if soffice_command && File.exist?(soffice_command)
 
-      raise IOError, "Can't find Libreoffice or Openoffice executable."
+      raise IOError, 'Can\'t find LibreOffice or OpenOffice executable.'
     end
 
+    # @param [String] cmd
+    # @return [String, nil]
     def which(cmd)
       exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
+
       ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
         exts.each do |ext|
-          exe = File.join(path, "#{cmd}#{ext}")
+          exe = File.expand_path("#{cmd}#{ext}", path)
           return exe if File.executable? exe
         end
       end
@@ -118,20 +138,44 @@ module Libreconv
       nil
     end
 
-    def check_source_type
-      if File.exist?(@source) && !File.directory?(@source)
-        return SOURCE_TYPES[:file]
-      end
-      if URI(@source).scheme == 'http' &&
-         Net::HTTP.get_response(URI(@source)).is_a?(Net::HTTPSuccess)
-        return SOURCE_TYPES[:url]
+    # @param [String] source
+    # @return [String, URI::HTTP]
+    # @raise [IOError]            If invalid source file/URL.
+    # @raise [URI::Error]         When URI parsing error.
+    # @raise [Net::ProtocolError] If source URL checking failed.
+    def check_source_type(source)
+      if File.exist?(source)
+        return source unless File.directory?(source)
+      elsif (uri = check_valid_url(source))
+        return uri
       end
-      if URI(@source).scheme == 'https' &&
-         Net::HTTP.get_response(URI(@source)).is_a?(Net::HTTPSuccess)
-        return SOURCE_TYPES[:url]
+
+      raise IOError, "Source (#{source}) is neither a file nor a URL."
+    end
+
+    # @param [String] url
+    # @return [URI::HTTP, false, nil]
+    # @raise [URI::Error]         When URI parsing error.
+    # @raise [Net::ProtocolError] If source URL checking failed.
+    def check_valid_url(url)
+      uri = URI(url)
+      return false unless uri.is_a?(URI::HTTP)
+
+      Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == 'https') do |http|
+        response = http.head(uri.request_uri)
+        return check_valid_url(response['location']) if response.is_a?(Net::HTTPRedirection)
+
+        return response.is_a?(Net::HTTPSuccess) ? uri : nil
       end
+    end
+
+    # @param [String] path
+    # @return [String]
+    def build_file_uri(path)
+      separators = /[#{Regexp.quote "#{File::SEPARATOR}#{File::ALT_SEPARATOR}"}]/
+      unsafe = Regexp.new("[^#{URI::PATTERN::UNRESERVED}/?:]")
 
-      raise IOError, "Source (#{@source}) is neither a file nor a URL."
+      'file:///' + URI::DEFAULT_PARSER.escape(path.gsub(separators, '/').sub(%r{^/+}, ''), unsafe)
     end
   end
 end

data/libreconv.gemspec

@@ -1,6 +1,7 @@
+# encoding: UTF-8
 # frozen_string_literal: true
 
-lib = File.expand_path('lib', __dir__)
+lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'libreconv/version'
 
@@ -9,16 +10,22 @@ Gem::Specification.new do |spec|
   spec.version       = Libreconv::VERSION
   spec.authors       = ['Richard Nyström', 'Nathan Broadbent']
   spec.email         = ['nathan@formapi.io']
+
   spec.description   = 'Convert office documents to PDF using LibreOffice.'
   spec.summary       = 'Convert office documents to PDF.'
   spec.homepage      = 'https://github.com/FormAPI/libreconv'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.files         = Dir.chdir(File.expand_path('../', __FILE__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  end
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
+
   spec.add_development_dependency 'bundler', '>= 0'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.8.0'
+  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'webmock'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: libreconv
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.5
 platform: ruby
 authors:
 - Richard Nyström
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-07 00:00:00.000000000 Z
+date: 2019-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -45,14 +45,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Convert office documents to PDF using LibreOffice.
 email:
 - nathan@formapi.io
@@ -60,26 +102,18 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".editorconfig"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".ruby-version"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/libreconv.rb
 - lib/libreconv/version.rb
 - libreconv.gemspec
-- spec/fixtures/doc.doc
-- spec/fixtures/docx.docx
-- spec/fixtures/ppt.ppt
-- spec/fixtures/pptx.pptx
-- spec/fixtures/soffice
-- spec/libreconv_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/FormAPI/libreconv
 licenses:
 - MIT
@@ -104,11 +138,4 @@ rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Convert office documents to PDF.
-test_files:
-- spec/fixtures/doc.doc
-- spec/fixtures/docx.docx
-- spec/fixtures/ppt.ppt
-- spec/fixtures/pptx.pptx
-- spec/fixtures/soffice
-- spec/libreconv_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.ruby-version

@@ -1 +0,0 @@
-2.5.3

data/Gemfile.lock

@@ -1,78 +0,0 @@
-PATH
-  remote: .
-  specs:
-    libreconv (0.9.1)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    ast (2.4.0)
-    byebug (10.0.2)
-    coderay (1.1.2)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
-    hashdiff (0.3.7)
-    jaro_winkler (1.5.1)
-    method_source (0.9.2)
-    parallel (1.12.1)
-    parser (2.5.3.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.2)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.6.0)
-      byebug (~> 10.0)
-      pry (~> 0.10)
-    public_suffix (3.0.3)
-    rainbow (3.0.0)
-    rake (12.3.2)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    rubocop (0.61.1)
-      jaro_winkler (~> 1.5.1)
-      parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 4.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.4.0)
-    rubocop-rspec (1.30.1)
-      rubocop (>= 0.60.0)
-    ruby-progressbar (1.10.0)
-    safe_yaml (1.0.4)
-    unicode-display_width (1.4.0)
-    webmock (3.4.2)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-      hashdiff
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler
-  libreconv!
-  pry-byebug
-  rake
-  rspec (~> 3.8.0)
-  rubocop
-  rubocop-rspec
-  webmock
-
-BUNDLED WITH
-   1.17.1

data/spec/libreconv_spec.rb

@@ -1,111 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe Libreconv do
-  let(:docx_file) { fixture_path('docx.docx') }
-  let(:doc_file) { fixture_path('doc.doc') }
-  let(:pptx_file) { fixture_path('pptx.pptx') }
-  let(:ppt_file) { fixture_path('ppt.ppt') }
-  let(:target_path) { '/tmp/libreconv' }
-  let(:url) { 'http://s3.amazonaws.com/libreconv-test/docx.docx' }
-
-  before do
-    FileUtils.mkdir_p target_path
-  end
-
-  after do
-    FileUtils.rm_rf target_path
-  end
-
-  describe Libreconv::Converter do
-    describe '#new' do
-      it 'raises error if soffice command does not exists' do
-        expect do
-          Libreconv::Converter.new(
-            doc_file, '/target', '/Whatever/soffice'
-          )
-        end.to raise_error(IOError)
-      end
-
-      it 'raises error if source does not exists' do
-        expect do
-          Libreconv::Converter.new(
-            fixture_path('nonsense.txt'), '/target'
-          )
-        end.to raise_error(IOError)
-      end
-    end
-
-    describe '#convert' do
-      it 'converts a docx do pdf specifying target_file' do
-        target_file = "#{target_path}/#{File.basename(doc_file, '.doc')}.pdf"
-        converter = Libreconv::Converter.new(doc_file, target_file)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it 'converts a doc to pdf' do
-        target_file = "#{target_path}/#{File.basename(doc_file, '.doc')}.pdf"
-        converter = Libreconv::Converter.new(doc_file, target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it 'converts a docx to pdf' do
-        target_file = "#{target_path}/#{File.basename(docx_file, '.docx')}.pdf"
-        converter = Libreconv::Converter.new(docx_file, target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it 'converts a pptx to pdf' do
-        target_file = "#{target_path}/#{File.basename(pptx_file, '.pptx')}.pdf"
-        converter = Libreconv::Converter.new(pptx_file, target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it 'converts a ppt to pdf' do
-        target_file = "#{target_path}/#{File.basename(ppt_file, '.ppt')}.pdf"
-        converter = Libreconv::Converter.new(ppt_file, target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      # it 'raises ConversionFailedError when URL cannot be loaded' do
-      #   stub_request(:get, url)
-      #   expect do
-      #     converter = Libreconv::Converter.new(url, target_path)
-      #     converter.convert
-      #   end.to raise_error(
-      #     Libreconv::ConversionFailedError,
-      #     /Conversion failed/
-      #   )
-      # end
-    end
-
-    describe '#soffice_command' do
-      it 'returns the user specified command path' do
-        # Just faking that the command is present here
-        cmd = fixture_path('soffice')
-        converter = Libreconv::Converter.new(doc_file, '/target', cmd)
-        expect(converter.soffice_command).to eq cmd
-      end
-
-      it 'returns the command found in path' do
-        cmd = `which soffice`.strip
-        converter = Libreconv::Converter.new(doc_file, '/target')
-        expect(converter.soffice_command).to eq cmd
-      end
-    end
-  end
-
-  describe '#convert' do
-    it 'converts a file to pdf' do
-      target_file = "#{target_path}/#{File.basename(doc_file, '.doc')}.pdf"
-      described_class.convert(doc_file, target_path)
-      expect(File.file?(target_file)).to eq true
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-require 'libreconv'
-require 'pry-byebug'
-require 'webmock/rspec'
-
-def fixture_path(*paths)
-  File.expand_path(File.join(File.dirname(__FILE__), 'fixtures', *paths))
-end
-
-RSpec.configure do |config|
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-
-  config.order = 'random'
-end