libreconv 0.9.1 → 0.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 522fce89fe66792d062925292ab1104b4c4d4c7e
-  data.tar.gz: 7c2f41f839955d1900417339bdf4be23833debaf
+SHA256:
+  metadata.gz: 5ae94a53817b7bd0f69b71501286d2ecef0f6e4fa698d6a73175fdd0b9c9c1db
+  data.tar.gz: 0af95f4eaafc34508dafa929de52f678fc4d227fe3de1ad6b53195c385ca9b47
 SHA512:
-  metadata.gz: 8d9b40454b77418914765b032a54e6c41f1e995a28ac411d61f13f558ea14ce740ee7414a5b2e700bb3d7d8fb7467e30e461698e4add05e45d712fdd11178a3e
-  data.tar.gz: 4913f63b22d7da58a2eec6a3f5f909e10a4f074e1cfe51d32a872b43a8ec7c604d44702ba4101af0c3a7c505706845b4a6ec3598f702c9e23328eb65e2e7a30a
+  metadata.gz: 53a3ac9d20908d5aecba062984c31461ccafc2defe9fb55432a77b540a24d6274e001b7107885b45eb77890ac7c2da5d0cfa0a2f075b820a36f2d3862e41f009
+  data.tar.gz: f3880d9db0000edbd39479b128b40a9f4357274ef05f75093bdd90bdda6220202d9e2313595c28059027f4b60e186aa277d32a3c6149031211dadd7d78ace707

data/.editorconfig

@@ -0,0 +1,15 @@
+# Editor configuration, see https://editorconfig.org
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+end_of_line = lf
+insert_final_newline = true
+max_line_length = 100
+trim_trailing_whitespace = true
+
+[*.md]
+max_line_length = off
+trim_trailing_whitespace = false

data/.gitignore

@@ -1,24 +1,20 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-.idea/
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
 
-TODO.md
+# rspec failure tracking
+.rspec_status
 
-spec/.DS_Store
+/Gemfile.lock
+/.ruby-version
+*.gem
+/vendor/bundle
 
+# Misc.
 .DS_Store
+/.idea/

data/.rspec

@@ -1,2 +1,4 @@
 --color
---format progress
+--format documentation
+--require spec_helper
+--order rand

data/.rubocop.yml

@@ -0,0 +1,23 @@
+require: rubocop-rspec
+
+AllCops:
+  TargetRubyVersion: 2.3
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 100
+
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%w': '[]'
+
+Style/ExpandPathArguments:
+  Enabled: false
+
+Style/Encoding:
+  Enabled: false
+
+Layout/EndOfLine:
+  Enabled: false

data/.travis.yml

@@ -1,10 +1,14 @@
+sudo: false
 language: ruby
+cache: bundler
 rvm:
-  - 2.1.1
-  - 2.2.2
-notifications:
-  recipients:
-    - ricn@rny.io
+  - 1.9.3
+  - 2.2
+  - 2.3
+  - 2.5
+  - jruby
 before_install:
   - sudo apt-get update -qq
-  - sudo apt-get install libreoffice
+  - sudo apt-get install libreoffice-core libreoffice-writer libreoffice-calc libreoffice-impress -y --no-install-recommends
+before_script: bundle exec rubocop
+script: bundle exec rake

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in libreconv.gemspec

data/README.md

@@ -2,15 +2,16 @@
 
 Convert office documents using LibreOffice / OpenOffice to one of their supported formats.
 
-[![Code Climate](https://codeclimate.com/github/ricn/libreconv.png)](https://codeclimate.com/github/ricn/libreconv)
-[![Build Status](https://travis-ci.org/ricn/libreconv.png?branch=master)](https://travis-ci.org/ricn/libreconv)
+[![Build Status](https://travis-ci.org/FormAPI/libreconv.png?branch=master)](https://travis-ci.org/FormAPI/libreconv)
 [![Gem Version](https://badge.fury.io/rb/libreconv.svg)](http://badge.fury.io/rb/libreconv)
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'libreconv'
+```ruby
+gem 'libreconv'
+```
 
 And then execute:
 
@@ -22,7 +23,7 @@ Or install it yourself as:
 
 ## Usage
 
-You need to install Libreoffice or Openoffice on your system to use this gem. The code has been tested with Libreoffice 4.2.
+You need to install LibreOffice or OpenOffice on your system to use this gem. The code has been tested with LibreOffice 6.1.3.
 
 ```ruby
 require 'libreconv'
@@ -38,8 +39,11 @@ Libreconv.convert('document.docx', '/Users/ricn/pdf_documents')
 # You can also convert a source file directly from an URL
 Libreconv.convert('http://myserver.com/123/document.docx', '/Users/ricn/pdf_documents/doc.pdf')
 
+# You cal pass a URL with GET params like this S3 example
+Libreconv.convert('https://mybucket.s3.amazonaws.com/myserver/123/document.docx?X-Amz-Expires=456&X-Amz-Signature=abc', '/Users/ricn/pdf_documents/doc.pdf')
+
 # Converts document.docx to document.pdf
-# If you for some reason can't have soffice in your PATH you can specifiy the file path to the soffice binary
+# If you for some reason can't have soffice in your PATH you can specify the file path to the soffice binary
 Libreconv.convert('document.docx', '/Users/ricn/pdf_documents', '/Applications/LibreOffice.app/Contents/MacOS/soffice')
 
 # Converts document.docx to my_document_as.html
@@ -47,19 +51,33 @@ Libreconv.convert('document.docx', '/Users/ricn/pdf_documents/my_document_as.htm
 
 # Converts document.docx to my_document_as.pdf using writer_pdf_Export filter
 Libreconv.convert('document.docx', '/Users/ricn/pdf_documents/my_document_as.pdf', nil, 'pdf:writer_pdf_Export')
-
 ```
 
+## Development
+
+After checking out the repo, run `bundle install` to install dependencies. Then, run `bundle exec rake` to run the tests.
+You can also run `irb -r bundler/setup -r libreconv` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`.
+
 ## Credits
 
 The following people have contributed ideas, documentation, or code to Libreconv:
 
 * Richard Nyström
+* Nathan Broadbent
 
 ## Contributing
 
+* Install LibreOffice on Linux: `sudo apt-get install libreoffice`
+* Install LibreOffice on Mac: `brew cask install libreoffice`
+
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/libreconv.rb

@@ -1,68 +1,181 @@
-require "libreconv/version"
-require "uri"
-require "net/http"
-require "tmpdir"
-require "spoon"
+# frozen_string_literal: true
 
+require 'libreconv/version'
+require 'uri'
+require 'net/http'
+require 'tmpdir'
+require 'securerandom'
+require 'open3'
+
+# Convert office documents using LibreOffice / OpenOffice to one of their supported formats.
 module Libreconv
+  class ConversionFailedError < StandardError; end
 
+  # @param [String] source          Path or URL of the source file.
+  # @param [String] target          Target file path.
+  # @param [String] soffice_command Path to the soffice binary.
+  # @param [String] convert_to      Format to convert to (default: 'pdf').
+  # @raise [IOError]                If invalid source file/URL or soffice command not found.
+  # @raise [URI::Error]             When URI parsing error.
+  # @raise [Net::ProtocolError]     If source URL checking failed.
+  # @raise [ConversionFailedError]  When soffice command execution error.
   def self.convert(source, target, soffice_command = nil, convert_to = nil)
     Converter.new(source, target, soffice_command, convert_to).convert
   end
 
   class Converter
+    # @return [String]
     attr_accessor :soffice_command
 
+    # @param [String] source          Path or URL of the source file.
+    # @param [String] target          Target file path.
+    # @param [String] soffice_command Path to the soffice binary.
+    # @param [String] convert_to      Format to convert to (default: 'pdf').
+    # @raise [IOError]                If invalid source file/URL or soffice command not found.
+    # @raise [URI::Error]             When URI parsing error.
+    # @raise [Net::ProtocolError]     If source URL checking failed.
     def initialize(source, target, soffice_command = nil, convert_to = nil)
-      @source = source
+      @source = check_source_type(source)
       @target = target
-      @target_path = Dir.tmpdir
-      @soffice_command = soffice_command
-      @convert_to = convert_to || "pdf"
-      determine_soffice_command
-      check_source_type
-
-      unless @soffice_command && File.exists?(@soffice_command)
-        raise IOError, "Can't find Libreoffice or Openoffice executable."
-      end
+      @soffice_command = soffice_command || which('soffice') || which('soffice.bin')
+      @convert_to = convert_to || 'pdf'
+
+      ensure_soffice_exists
     end
 
+    # @raise [ConversionFailedError]  When soffice command execution error.
     def convert
-      orig_stdout = $stdout.clone
-      $stdout.reopen File.new('/dev/null', 'w')
-      pid = Spoon.spawnp(@soffice_command, "--headless", "--convert-to", @convert_to, @source, "--outdir", @target_path)
-      Process.waitpid(pid)
-      $stdout.reopen orig_stdout
-      target_tmp_file = "#{@target_path}/#{File.basename(@source, ".*")}.#{File.basename(@convert_to, ":*")}"
-      FileUtils.cp target_tmp_file, @target
+      tmp_pipe_path = File.join(Dir.tmpdir, "soffice-pipe-#{SecureRandom.uuid}")
+
+      Dir.mktmpdir do |target_path|
+        command = build_command(tmp_pipe_path, target_path)
+        target_tmp_file = execute_command(command, target_path)
+
+        FileUtils.cp target_tmp_file, @target
+      end
+    ensure
+      FileUtils.rm_rf tmp_pipe_path if File.exist?(tmp_pipe_path)
     end
 
     private
 
-    def determine_soffice_command
-      unless @soffice_command
-        @soffice_command ||= which("soffice")
-        @soffice_command ||= which("soffice.bin")
-      end
+    # @param [Array<String>] command
+    # @param [String] target_path
+    # @return [String]
+    # @raise [ConversionFailedError]  When soffice command execution error.
+    def execute_command(command, target_path)
+      output, error, status =
+        if RUBY_PLATFORM =~ /java/
+          Open3.capture3(*command)
+        else
+          Open3.capture3(command_env, *command, unsetenv_others: true)
+        end
+
+      target_tmp_file = File.join(target_path, target_filename)
+      return target_tmp_file if status.success? && File.exist?(target_tmp_file)
+
+      raise ConversionFailedError,
+            "Conversion failed! Output: #{output.strip.inspect}, Error: #{error.strip.inspect}"
+    end
+
+    # @return [Hash]
+    def command_env
+      Hash[%w[HOME PATH LANG LD_LIBRARY_PATH SYSTEMROOT TEMP].map { |k| [k, ENV[k]] }]
+    end
+
+    # @param [String] tmp_pipe_path
+    # @param [String] target_path
+    # @return [Array<String>]
+    def build_command(tmp_pipe_path, target_path)
+      [
+        soffice_command,
+        "--accept=\"pipe,name=#{File.basename(tmp_pipe_path)};url;StarOffice.ServiceManager\"",
+        "-env:UserInstallation=#{build_file_uri(tmp_pipe_path)}",
+        '--headless',
+        '--convert-to', @convert_to,
+        escaped_source,
+        '--outdir', target_path
+      ]
+    end
+
+    # If the URL contains GET params, the '&' could break when being used as an argument to soffice.
+    # Wrap it in single quotes to escape it. Then strip them from the target temp file name.
+    # @return [String]
+    def escaped_source
+      # TODO: @source.is_a?(URI::Generic) ? "'#{@source}'" : @source
+      @source.to_s
+    end
+
+    # @return [String]
+    def escaped_source_path
+      @source.is_a?(URI::Generic) ? @source.path : @source
+    end
+
+    # @return [String]
+    def target_filename
+      File.basename(escaped_source_path, '.*') + '.' + File.basename(@convert_to, ':*')
     end
 
+    # @raise [IOError] If soffice headless command line tool not found.
+    def ensure_soffice_exists
+      return if soffice_command && File.exist?(soffice_command)
+
+      raise IOError, 'Can\'t find LibreOffice or OpenOffice executable.'
+    end
+
+    # @param [String] cmd
+    # @return [String, nil]
     def which(cmd)
       exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
+
       ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
         exts.each do |ext|
-          exe = File.join(path, "#{cmd}#{ext}")
+          exe = File.expand_path("#{cmd}#{ext}", path)
           return exe if File.executable? exe
         end
       end
 
-      return nil
+      nil
     end
 
-    def check_source_type
-      return if File.exists?(@source) && !File.directory?(@source) #file
-      return if URI(@source).scheme == "http" && Net::HTTP.get_response(URI(@source)).is_a?(Net::HTTPSuccess) #http
-      return if URI(@source).scheme == "https" && Net::HTTP.get_response(URI(@source)).is_a?(Net::HTTPSuccess) #https
-      raise IOError, "Source (#{@source}) is neither a file nor an URL."
+    # @param [String] source
+    # @return [String, URI::HTTP]
+    # @raise [IOError]            If invalid source file/URL.
+    # @raise [URI::Error]         When URI parsing error.
+    # @raise [Net::ProtocolError] If source URL checking failed.
+    def check_source_type(source)
+      if File.exist?(source)
+        return source unless File.directory?(source)
+      elsif (uri = check_valid_url(source))
+        return uri
+      end
+
+      raise IOError, "Source (#{source}) is neither a file nor a URL."
+    end
+
+    # @param [String] url
+    # @return [URI::HTTP, false, nil]
+    # @raise [URI::Error]         When URI parsing error.
+    # @raise [Net::ProtocolError] If source URL checking failed.
+    def check_valid_url(url)
+      uri = URI(url)
+      return false unless uri.is_a?(URI::HTTP)
+
+      Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == 'https') do |http|
+        response = http.head(uri.request_uri)
+        return check_valid_url(response['location']) if response.is_a?(Net::HTTPRedirection)
+
+        return response.is_a?(Net::HTTPSuccess) ? uri : nil
+      end
+    end
+
+    # @param [String] path
+    # @return [String]
+    def build_file_uri(path)
+      separators = /[#{Regexp.quote "#{File::SEPARATOR}#{File::ALT_SEPARATOR}"}]/
+      unsafe = Regexp.new("[^#{URI::PATTERN::UNRESERVED}/?:]")
+
+      'file:///' + URI::DEFAULT_PARSER.escape(path.gsub(separators, '/').sub(%r{^/+}, ''), unsafe)
     end
   end
-end
+end

data/lib/libreconv/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Libreconv
-  VERSION = "0.9.1"
+  VERSION = '0.9.5'
 end

data/libreconv.gemspec

@@ -1,24 +1,31 @@
-# coding: utf-8
+# encoding: UTF-8
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'libreconv/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "libreconv"
+  spec.name          = 'libreconv'
   spec.version       = Libreconv::VERSION
-  spec.authors       = ["Richard Nyström"]
-  spec.email         = ["ricny046@gmail.com"]
-  spec.description   = %q{ Convert office documents to PDF using LibreOffice. }
-  spec.summary       = %q{ Convert office documents to PDF. }
-  spec.homepage      = "https://github.com/ricn/libreconv"
-  spec.license       = "MIT"
+  spec.authors       = ['Richard Nyström', 'Nathan Broadbent']
+  spec.email         = ['nathan@formapi.io']
+
+  spec.description   = 'Convert office documents to PDF using LibreOffice.'
+  spec.summary       = 'Convert office documents to PDF.'
+  spec.homepage      = 'https://github.com/FormAPI/libreconv'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = Dir.chdir(File.expand_path('../', __FILE__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  end
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-  spec.add_dependency "spoon"
-  spec.add_development_dependency "bundler", ">= 0"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.2.0"
+  spec.require_paths = ['lib']
+
+  spec.add_development_dependency 'bundler', '>= 0'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'webmock'
 end

metadata

@@ -1,81 +1,112 @@
 --- !ruby/object:Gem::Specification
 name: libreconv
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.5
 platform: ruby
 authors:
 - Richard Nyström
+- Nathan Broadbent
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-01 00:00:00.000000000 Z
+date: 2019-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: spoon
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
-description: ' Convert office documents to PDF using LibreOffice. '
+        version: '0'
+description: Convert office documents to PDF using LibreOffice.
 email:
-- ricny046@gmail.com
+- nathan@formapi.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".editorconfig"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -83,14 +114,7 @@ files:
 - lib/libreconv.rb
 - lib/libreconv/version.rb
 - libreconv.gemspec
-- spec/fixtures/doc.doc
-- spec/fixtures/docx.docx
-- spec/fixtures/ppt.ppt
-- spec/fixtures/pptx.pptx
-- spec/fixtures/soffice
-- spec/libreconv_spec.rb
-- spec/spec_helper.rb
-homepage: https://github.com/ricn/libreconv
+homepage: https://github.com/FormAPI/libreconv
 licenses:
 - MIT
 metadata: {}
@@ -100,25 +124,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Convert office documents to PDF.
-test_files:
-- spec/fixtures/doc.doc
-- spec/fixtures/docx.docx
-- spec/fixtures/ppt.ppt
-- spec/fixtures/pptx.pptx
-- spec/fixtures/soffice
-- spec/libreconv_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/spec/libreconv_spec.rb

@@ -1,100 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe Libreconv do
-
-  before(:all) do
-    @docx_file = file_path("docx.docx")
-    @doc_file = file_path("doc.doc")
-    @pptx_file = file_path("pptx.pptx")
-    @ppt_file = file_path("ppt.ppt")
-    @target_path = "/tmp/libreconv"
-    @url = "http://s3.amazonaws.com/libreconv-test/docx.docx"
-  end
-
-  before(:each) do
-    FileUtils.mkdir_p @target_path
-  end
-
-  after(:each) do
-    FileUtils.rm_rf @target_path
-  end
-
-  describe Libreconv::Converter do
-    describe "#new" do
-      it "should raise error if soffice command does not exists" do
-        expect { Libreconv::Converter.new(@doc_file, "/target", "/Whatever/soffice") }.to raise_error(IOError)
-      end
-
-      it "should raise error if source does not exists" do
-        expect { Libreconv::Converter.new(file_path("nonsense.txt"), "/target") }.to raise_error(IOError)
-      end
-    end
-
-    describe "#convert" do
-      it "should convert a docx do pdf specifying target_file" do
-        target_file = "#{@target_path}/#{File.basename(@doc_file, ".doc")}.pdf"
-        converter = Libreconv::Converter.new(@doc_file, target_file)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it "should convert a doc to pdf" do
-        target_file = "#{@target_path}/#{File.basename(@doc_file, ".doc")}.pdf"
-        converter = Libreconv::Converter.new(@doc_file, @target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it "should convert a docx to pdf" do
-        target_file = "#{@target_path}/#{File.basename(@docx_file, ".docx")}.pdf"
-        converter = Libreconv::Converter.new(@docx_file, @target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it "should convert a pptx to pdf" do
-        target_file = "#{@target_path}/#{File.basename(@pptx_file, ".pptx")}.pdf"
-        converter = Libreconv::Converter.new(@pptx_file, @target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it "should convert a ppt to pdf" do
-        target_file = "#{@target_path}/#{File.basename(@ppt_file, ".ppt")}.pdf"
-        converter = Libreconv::Converter.new(@ppt_file, @target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-
-      it "should convert a docx to pdf specifying an URL as source" do
-        target_file = "#{@target_path}/docx.pdf"
-        converter = Libreconv::Converter.new(@url, @target_path)
-        converter.convert
-        expect(File.file?(target_file)).to eq true
-      end
-    end
-
-    describe "#soffice_command" do
-      it "should return the user specified command path" do
-        cmd = file_path("soffice") # just faking that the command is present here
-        converter = Libreconv::Converter.new(@doc_file, "/target", cmd)
-        expect(converter.soffice_command).to eq cmd
-      end
-
-      it "should return the command found in path" do
-        cmd = `which soffice`.strip
-        converter = Libreconv::Converter.new(@doc_file, "/target")
-        expect(converter.soffice_command).to eq cmd
-      end
-    end
-
-    describe ".convert" do
-      it "should convert a file to pdf" do
-        target_file = "#{@target_path}/#{File.basename(@doc_file, ".doc")}.pdf"
-        Libreconv.convert(@doc_file, @target_path)
-        expect(File.file?(target_file)).to eq true
-      end
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,12 +0,0 @@
-require 'libreconv'
-
-def file_path( *paths )
-  File.expand_path(File.join(File.dirname(__FILE__), 'fixtures', *paths))
-end
-
-RSpec.configure do |config|
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-
-  config.order = 'random'
-end