librato-rails 1.3.0 → 1.4.0.beta

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8edc380bcb2f20518999f643e9c7d13174d84db6
-  data.tar.gz: da5c0130f153953623836aab0638a97f2ce4fc09
+  metadata.gz: 1c7c4407bf104ae1a886609fabd08ea91cf7ba00
+  data.tar.gz: e0cc032c61007289314f3dff3b3081c3fc24ce60
 SHA512:
-  metadata.gz: de8fa725eb2a36317341c01b9ee6b4855a74e64cbcdb2840be949d3259b8a8c490fb15053721c7b558bc8beabde9f1d1bfedb1e50641eef0134eaf1e3fd9508b
-  data.tar.gz: 7e0f2ba4b6220a55d8597f12d95037e0d9a5981c527ea7ff550c4eb3989eb46e0ec6272fca60570817b45f59c046c16e5f1f25caa9bbc4184025aadad8f16538
+  metadata.gz: 859cd5eecec13557f4956c2234c014df43ff10ee289be07b264eda36dd08aea4f60219eaa017f2a9ac9866fca93161e74f273410e95c687e49ee6710cc722f46
+  data.tar.gz: fa224bf0ca51abf18e0aa388dcb48d1aed3b130ff765bf72b92aa5f663dffd0c89e2bd211705008350ea7bdc70fa91cb96574614dd9ad8b830c6b194e801239d

data.tar.gz.sig

@@ -1,3 +1 @@
-OU�'�C�d!���N'�v�b�@+j?-���2����/�hD�ٲ��|������b��T�Sy�Po'�#����IJ1E7��k�Q���j7Z��l�<��I��e>�����=�o�%(9
-f�\u�;�
-?��F��X�����'���9�Rn����[�_�)��Y�n�B�|l�74�鲜�B����G��l�.!���E����Vv+q�{RC���(�2��>j���A�j�)u*�|��}�nǍ�Ų�w
+|7Ԣ���#�o~�˩�3�R�A�ϺP����i�tF�a
Q߫~���ȡ)!v�|�#�� XJ�7�&��a���2�

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### Version 1.4.0.beta
+* Add support to instrument all controller actions, e.g., `instrument_action :all`.
+
 ### Version 1.3.0
 * Add support for configurable metric suites
 

data/README.md

@@ -5,19 +5,17 @@ librato-rails
 
 `librato-rails` will report key statistics for your Rails app to [Librato](https://metrics.librato.com/) and allow you to easily track your own custom metrics. Metrics are delivered asynchronously behind the scenes so they won't affect performance of your requests.
 
-Rails versions 3.0 or greater are supported on Ruby 1.9.2 and above.
+Rails versions 3.0 or greater are supported on Ruby 1.9.3 and above.
 
 Verified combinations of Ruby/Rails are available in our [build matrix](http://travis-ci.org/librato/librato-rails).
 
 ## Quick Start
 
->Note: If you have not yet enabled Rails on the [Librato integrations page](https://metrics.librato.com/integrations) within your account, do this first. This will automatically set up a Rails and Rack Space, displaying many useful performance metrics.
+> Note: If you have not yet enabled Rails on the [Librato integrations page](https://metrics.librato.com/integrations) within your account, do this first. This will automatically set up Rails and Rack Spaces, displaying many useful performance metrics.
 
-Installing `librato-rails` and relaunching your application will automatically start the reporting of metrics to your Librato account.
+Installing `librato-rails` and relaunching your application will automatically start the reporting of built-in performance metrics to your Librato account.
 
-After installation `librato-rails` will detect your environment and start reporting available performance information for your application.
-
-Custom metrics can also be added easily:
+Once installed, custom metrics can also be added easily:
 
 ```ruby
 # keep counts of key events
@@ -64,49 +62,7 @@ Alternately you can provide `LIBRATO_USER` and `LIBRATO_TOKEN` environment varia
 
 Note that if a config file is present, _all environment variables will be ignored_.
 
-For more information on combining config files and environment variables, see the [full configuration docs](https://github.com/librato/librato-rails/wiki/Configuration).
-
-##### Metric Suites
-
-The metrics recorded by `librato-rails` are organized into named metric suites that can be selectively enabled/disabled:
-
-* `rack`: The `rack.request.total`, `rack.request.time`, `rack.request.slow`, and `rack.request.queue.time` metrics
-* `rack_status`: All of the `rack.request.status.*` metrics
-* `rack_method`: All of the `rack.request.method.*` metrics
-* `rails_action`: All of the `rails.action.*` metrics reported by the `instrument_action` helper
-* `rails_cache`: All of the `rails.cache.*` metrics
-* `rails_controller`: The `rails.request.total`, `rails.request.exceptions`, `rails.request.slow` and `rails.request.time.*` metrics
-* `rails_job`: All of the `rails.job.*` metrics
-* `rails_mail`: All of the `rails.mail.*` metrics
-* `rails_method`: All of the `rails.request.method.*` metrics
-* `rails_render`: All of the `rails.view.*` metrics
-* `rails_sql`: All of the `rails.sql.*` metrics
-* `rails_status`: All of the `rails.request.status.*` metrics
-
-All of the metric suites listed above are enabled by default.
-
-The metric suites can be configured via either the `LIBRATO_SUITES` environment variable or the `config/librato.yml` configuration file. The configuration syntax is the same regardless of which configuration method you use.
-
-```bash
-  LIBRATO_SUITES="rails_controller,rails_sql"  # use ONLY the rails_controller and rails_sql suites
-  LIBRATO_SUITES="+foo,+bar"                   # + prefix indicates that you want the default suites plus foo and bar
-  LIBRATO_SUITES="-rails_render"               # - prefix indicates that you want the default suites removing rails_render
-  LIBRATO_SUITES="+foo,-rack_status"           # Use all default suites except for rack_status while also adding foo
-  LIBRATO_SUITES="all"                         # Enable all suites
-  LIBRATO_SUITES="none"                        # Disable all suites
-  LIBRATO_SUITES=""                            # Use only the default suites (same as if env var is absent)
-```
-
-Note that you should EITHER specify an explict list of suites to enable OR add/subtract individual suites from the default list (using the +/- prefixes). If you try to mix these two forms a `Librato::Rack::InvalidSuiteConfiguration` error will be raised.
-
-Configuring the metric suites via the `config/librato.yml` file would look like this:
-
-```yaml
-production:
-  user: name@example.com
-  token: abc123
-  suites: 'all'
-```
+To see all config options or for information on combining config files and environment variables see the [full configuration docs](https://github.com/librato/librato-rails/wiki/Configuration).
 
 ##### Running on Heroku
 
@@ -122,13 +78,73 @@ Full information on configuration options is available on the [configuration wik
 
 If Heroku idles your application, measurements will not be sent until it receives another request and is restarted. If you see intermittent gaps in your measurements during periods of low traffic, this is the most likely cause.
 
-Please note that a Paid Plan is required for tracking Custom Metrics in Heroku. Choose a Librato add-on plan here (https://elements.heroku.com/addons/librato#pricing).
+If you are using Librato as a Heroku addon, [a paid plan](https://elements.heroku.com/addons/librato#pricing) is required for reporting custom metrics with librato-rails. You can view more about available addon levels [here](https://elements.heroku.com/addons/librato#pricing).
 
 ## Automatic Measurements
 
 After installing `librato-rails` and restarting your app you will see a number of new metrics appear in your Librato account. These track request performance, sql queries, mail handling, and other key stats.
 
-Built-in performance metrics will start with either `rack` or `rails`, depending on the level they are being sampled from. For example: `rails.request.total` is the total number of requests rails has received each minute.
+Built-in performance metrics will start with either `rails` or `rack`, depending on the level they are being sampled from. For example: `rails.request.total` is the total number of requests rails has received each minute.
+
+The metrics automatically recorded by `librato-rails` are organized into named metric suites that can be selectively enabled/disabled:
+
+#### Rails Suites
+
+###### Request Metrics
+
+* *rails_controller*: Metrics which provide a high level overview of request performance including `rails.request.total`, `rails.request.time`, `rails.request.time.db`, `rails.request.time.view`, and `rails.request.slow`
+* *rails_method*: `rails.request.method.*` metrics (GET, POST, etc)
+* *rails_status*: `rails.request.status.*` metrics broken out by individual status codes and class (200, 2xx, etc)
+* *rails_action*: `rails.action.*` metrics specific to individual controller actions via the [instrument_action](#instrument_action-experimental) helper
+
+###### System-Specific Metrics
+
+* *rails_cache*: `rails.cache.*` metrics including reads, writes, hits & deletes
+* *rails_job*: `rails.job.*` metrics including jobs queued, started & performed (Rails 4.2+)
+* *rails_mail*: `rails.mail.*` metrics including mail sent / received
+* *rails_render*: `rails.view.*` metrics including time to render individual templates & partials
+* *rails_sql*: `rails.sql.*` metrics, including SELECT / INSERT / UPDATE / DELETEs as well as total query operations
+
+#### Rack Suites
+
+Rack measurements are taken from the very beginning of your [rack middleware stack](http://guides.rubyonrails.org/rails_on_rack.html). They include all time spent in your ruby process (not just in Rails proper). They will also show requests that are handled entirely in middleware and don't appear in the `rails` suites above.
+
+* *rack*: The `rack.request.total`, `rack.request.time`, `rack.request.slow`, and `rack.request.queue.time` metrics
+* *rack_method*: `rack.request.method.*` metrics (GET, POST, etc)
+* *rack_status*: `rack.request.status.*` metrics metrics broken out by individual status codes and class (200, 2xx, etc)
+
+###### Queue Time
+
+The `rack.request.queue.time` metric will show you queuing time (the time between your load balancer receiving a request & your application process starting to work on it) if your load balancer sets `HTTP_X_REQUEST_START` or `HTTP_X_QUEUE_START`.
+
+#### Default Suites
+
+All of the rails & rack suites listed above are enabled by default.
+
+#### Suite Configuration
+
+Suites can be configured via either the `LIBRATO_SUITES` environment variable or the `suites` setting in a `config/librato.yml` configuration file. The syntax is the same regardless of configuration method.
+
+```bash
+  LIBRATO_SUITES="rails_controller,rails_sql"  # use ONLY the rails_controller & rails_sql suites
+  LIBRATO_SUITES="+foo,+bar"                   # + prefix: default suites plus foo & bar
+  LIBRATO_SUITES="-rails_render"               # - prefix: default suites removing rails_render
+  LIBRATO_SUITES="+foo,-rack_status"           # Default suites except for rack_status, also add foo
+  LIBRATO_SUITES="all"                         # Enable all suites
+  LIBRATO_SUITES="none"                        # Disable all suites
+  LIBRATO_SUITES=""                            # Use only the default suites (same as if env var is absent)
+```
+
+Note that you should specify **either** an explict list of suites to enable **or** add/subtract individual suites from the default list (using the +/- prefixes). If you try to mix these two forms a `Librato::Rack::InvalidSuiteConfiguration` error will be raised.
+
+Configuring the metric suites via the `config/librato.yml` file would look like this:
+
+```yaml
+production:
+  user: name@example.com
+  token: abc123
+  suites: 'rails_controller,rails_status,rails_sql,rack'
+```
 
 ## Custom Measurements
 
@@ -192,7 +208,7 @@ Librato.timing 'twitter.lookup.time' do
 end
 ```
 
-#### percentiles
+###### Percentiles
 
 By defaults timings will send the average, sum, max and min for every minute. If you want to send percentiles as well you can specify them inline while instrumenting:
 
@@ -238,7 +254,8 @@ Symbols can be used interchangably with strings for metric names.
 
 `librato-rails` also has special helpers which are available inside your controllers:
 
-#### instrument_action (experimental)
+#### instrument_action
+_experimental_, this interface may change:
 
 Use when you want to profile execution time or request volume for a specific controller action:
 
@@ -252,6 +269,22 @@ class CommentController < ApplicationController
 end
 ```
 
+Optionally, you can instrument all controller actions:
+
+```ruby
+class ArticlesController < ApplicationController
+  instrument_action :all
+
+  def create
+    # ...
+  end
+
+  def show
+    # ...
+  end
+end
+```
+
 Once you instrument an action, `librato-rails` will start reporting a set of metrics specific to that action including:
 
 * rails.action.request.total     (# of requests)
@@ -366,4 +399,4 @@ If you are debugging setting up `librato-rails` locally you can set `flush_inter
 
 ## Copyright
 
-Copyright (c) 2012-2014 [Librato Inc.](http://librato.com) See LICENSE for details.
+Copyright (c) 2012-2016 [Librato Inc.](http://librato.com) See LICENSE for details.

data/lib/librato/rails/helpers/controller.rb

@@ -10,7 +10,12 @@ module Librato
           end
         end
 
+        def inherited(other)
+          super
+          Subscribers.inherit_watches(self.to_s, other.to_s)
+        end
+
       end
     end
   end
-end
+end

data/lib/librato/rails/railtie.rb

@@ -5,7 +5,7 @@ module Librato
       # don't have any custom http vars anymore, check if hostname is UUID
       on_heroku = Socket.gethostname =~ /[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}/i
 
-      config.before_configuration do 
+      config.before_configuration do
         # make configuration proxy for config inside Rails
         config.librato_rails = Configuration.new
 

data/lib/librato/rails/subscribers.rb

@@ -13,7 +13,20 @@ module Librato
 
       def self.watch_controller_action(controller, action)
         @watches ||= []
-        @watches << "#{controller}##{action}".freeze
+
+        watch =
+          if action == :all
+            "#{controller}".freeze
+          else
+            "#{controller}##{action}".freeze
+          end
+
+        @watches << watch
+      end
+
+      def self.inherit_watches(base, descendant)
+        @watches ||= []
+        @watches << descendant.freeze if @watches.include?(base)
       end
     end
   end

data/lib/librato/rails/subscribers/action.rb

@@ -14,7 +14,7 @@ module Librato
         format = "all" if format == "*/*"
         exception = event.payload[:exception]
 
-        if @watches && @watches.index("#{controller}##{action}")
+        if @watches && (@watches.index(controller) || @watches.index("#{controller}##{action}"))
           source = "#{controller}.#{action}.#{format}"
           collector.group 'rails.action.request' do |r|
 

data/lib/librato/rails/version.rb

@@ -1,5 +1,5 @@
 module Librato
   module Rails
-    VERSION = "1.3.0"
+    VERSION = "1.4.0.beta"
   end
 end

data/test/dummy/app/controllers/application_controller.rb

@@ -1,8 +1,8 @@
 class ApplicationController < ActionController::Base
   protect_from_forgery
-  
+  instrument_action :all
   #after_filter :flush_metrics_rails
-  
+
   # manually flush per request
   def flush_metrics_rails
     Librato::Rails.flush

data/test/dummy/app/controllers/base_controller.rb

@@ -0,0 +1,11 @@
+class BaseController < ApplicationController
+  instrument_action :all
+
+  def action_1
+    render nothing: true
+  end
+
+  def action_2
+    render nothing: true
+  end
+end

data/test/dummy/app/controllers/derived_controller.rb

@@ -0,0 +1,9 @@
+class DerivedController < IntermediateController
+  def action_1
+    render nothing: true
+  end
+
+  def action_2
+    render nothing: true
+  end
+end

data/test/dummy/app/controllers/instrument_action_controller.rb

@@ -10,7 +10,7 @@ class InstrumentActionController < ApplicationController
     end
   end
 
-  def not_instrumented
+  def not
     render nothing: true
   end
 

data/test/dummy/app/controllers/intermediate_controller.rb

@@ -0,0 +1,5 @@
+class IntermediateController < BaseController
+  def action_1
+    render nothing: true
+  end
+end

data/test/dummy/config/routes.rb

@@ -20,6 +20,12 @@ Dummy::Application.routes.draw do
   get 'instrument/inst' => 'instrument_action#inst', :as => :instrument_action
   get 'instrument/not'  => 'instrument_action#not',  :as => :not_instrumented
 
+  get 'base/action_1'         => 'base#action_1',         :as => :base_action_1
+  get 'base/action_2'         => 'base#action_2',         :as => :base_action_2
+  get 'intermediate/action_1' => 'intermediate#action_1', :as => :intermediate_action_1
+  get 'derived/action_1'      => 'derived#action_1',      :as => :derived_action_1
+  get 'derived/action_2'      => 'derived#action_2',      :as => :derived_action_2
+
   # The priority is based upon order of creation:
   # first created -> highest priority.
 

data/test/integration/instrument_action_test.rb

@@ -19,4 +19,34 @@ class InstrumentActionTest < ActiveSupport::IntegrationCase
     assert_equal 1, counters.fetch("#{base}.total", source: source)
   end
 
+  test 'instrument all controller actions' do
+    visit base_action_1_path
+    visit base_action_2_path
+
+    metric = 'rails.action.request.time'
+
+    assert_equal 1, aggregate.fetch(metric, source: 'BaseController.action_1.html')[:count]
+    assert_equal 1, aggregate.fetch(metric, source: 'BaseController.action_2.html')[:count]
+  end
+
+  test 'instrument all controller actions for inherited controllers' do
+    visit intermediate_action_1_path
+    visit derived_action_1_path
+    visit derived_action_2_path
+
+    metric = 'rails.action.request.time'
+
+    assert_equal 1, aggregate.fetch(metric, source: 'IntermediateController.action_1.html')[:count]
+    assert_equal 1, aggregate.fetch(metric, source: 'DerivedController.action_1.html')[:count]
+    assert_equal 1, aggregate.fetch(metric, source: 'DerivedController.action_2.html')[:count]
+  end
+
+  test 'instrument all controller actions for all controllers' do
+    visit not_instrumented_path
+
+    metric = 'rails.action.request.time'
+
+    assert_equal 1, aggregate.fetch(metric, source: 'InstrumentActionController.not.html')[:count]
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: librato-rails
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0.beta
 platform: ruby
 authors:
 - Matt Sanders
@@ -29,34 +29,34 @@ cert_chain:
   hvjx0WJP8pzZMJPKJBRZQXJO5ifEPyKjZyMi5XMHmrtDclHLj3sx4RAvEZjGWkRP
   JSQ=
   -----END CERTIFICATE-----
-date: 2016-04-21 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
@@ -77,42 +77,42 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.3
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
 description: Report key app statistics to the Librato Metrics service and easily track
@@ -123,18 +123,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- CHANGELOG.md
-- FAQ.md
-- LICENSE
-- README.md
-- Rakefile
-- lib/librato-rails.rb
-- lib/librato/rails.rb
 - lib/librato/rails/configuration.rb
-- lib/librato/rails/helpers.rb
 - lib/librato/rails/helpers/controller.rb
+- lib/librato/rails/helpers.rb
 - lib/librato/rails/railtie.rb
-- lib/librato/rails/subscribers.rb
 - lib/librato/rails/subscribers/action.rb
 - lib/librato/rails/subscribers/cache.rb
 - lib/librato/rails/subscribers/controller.rb
@@ -144,11 +136,17 @@ files:
 - lib/librato/rails/subscribers/render.rb
 - lib/librato/rails/subscribers/sql.rb
 - lib/librato/rails/subscribers/status.rb
+- lib/librato/rails/subscribers.rb
 - lib/librato/rails/tracker.rb
 - lib/librato/rails/version.rb
 - lib/librato/rails/version_specifier.rb
-- test/dummy/README.rdoc
-- test/dummy/Rakefile
+- lib/librato/rails.rb
+- lib/librato-rails.rb
+- LICENSE
+- Rakefile
+- README.md
+- CHANGELOG.md
+- FAQ.md
 - test/dummy/app/assets/javascripts/application.js
 - test/dummy/app/assets/javascripts/home.js
 - test/dummy/app/assets/javascripts/status.js
@@ -156,9 +154,12 @@ files:
 - test/dummy/app/assets/stylesheets/home.css
 - test/dummy/app/assets/stylesheets/status.css
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/base_controller.rb
 - test/dummy/app/controllers/cache_controller.rb
+- test/dummy/app/controllers/derived_controller.rb
 - test/dummy/app/controllers/home_controller.rb
 - test/dummy/app/controllers/instrument_action_controller.rb
+- test/dummy/app/controllers/intermediate_controller.rb
 - test/dummy/app/controllers/render_controller.rb
 - test/dummy/app/controllers/status_controller.rb
 - test/dummy/app/controllers/user_controller.rb
@@ -175,7 +176,6 @@ files:
 - test/dummy/app/views/render/template.html.erb
 - test/dummy/app/views/status/code.html.erb
 - test/dummy/app/views/user_mailer/welcome_email.text.erb
-- test/dummy/config.ru
 - test/dummy/config/application.rb
 - test/dummy/config/boot.rb
 - test/dummy/config/database.yml
@@ -193,6 +193,7 @@ files:
 - test/dummy/config/locales/en.yml
 - test/dummy/config/routes.rb
 - test/dummy/config/unicorn.rb
+- test/dummy/config.ru
 - test/dummy/db/migrate/20120719231810_create_users.rb
 - test/dummy/db/schema.rb
 - test/dummy/extras/dummy_job.rb
@@ -200,6 +201,8 @@ files:
 - test/dummy/public/422.html
 - test/dummy/public/500.html
 - test/dummy/public/favicon.ico
+- test/dummy/Rakefile
+- test/dummy/README.rdoc
 - test/dummy/script/rails
 - test/fixtures/config/empty.yml
 - test/fixtures/config/librato.yml
@@ -227,17 +230,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Use Librato Metrics with your Rails 3 app
@@ -249,9 +252,12 @@ test_files:
 - test/dummy/app/assets/stylesheets/home.css
 - test/dummy/app/assets/stylesheets/status.css
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/base_controller.rb
 - test/dummy/app/controllers/cache_controller.rb
+- test/dummy/app/controllers/derived_controller.rb
 - test/dummy/app/controllers/home_controller.rb
 - test/dummy/app/controllers/instrument_action_controller.rb
+- test/dummy/app/controllers/intermediate_controller.rb
 - test/dummy/app/controllers/render_controller.rb
 - test/dummy/app/controllers/status_controller.rb
 - test/dummy/app/controllers/user_controller.rb