librato-rack 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e87682af9b37ced1a2ba02d00b6635cad23e645
-  data.tar.gz: b127abcd2ec03184ef80cd8a370c5f8fef4bac5a
+  metadata.gz: 486a5fc1c305930b8c60e71454c762936ce7d708
+  data.tar.gz: b6b876efe328ce7b4b45318c54cff89857f78bdf
 SHA512:
-  metadata.gz: 53bdbf9cc39ccefe383e6688a282ffd417f7b4a70f6d402bb51b2e77a9029591bc09e6beccc4fc1d0d772400314afd6fb2bed73b5ab6e73c449a1d96dad63529
-  data.tar.gz: 39101eb721b0b5412874eb88d119a42d48b1037616143b4e3d55176b232fec687f011e21bb73ebc52660c54c8ee690723023dfa02fd4c57f0794a03f520145df
+  metadata.gz: c1542c83e18eaadd2c555161ecdddfa83f2e63377fd4bc0b33b87693860f9088602ae04ae579e8fc318a3ac810f8ae5f08e1a3cf98ddd710d8a18906db98a90d
+  data.tar.gz: bfcae24e6b77da4644cabf0a7f8217ef681ba1ada3a8ebc9a757c447330f8c2f998a661ca7fd7c70437b29bac8d17cdfff0b345860267d8e3d28e05f4de650ab

data/lib/librato/rack.rb

@@ -50,7 +50,7 @@ module Librato
     EOS
 
     RECORD_RACK_METHOD_BODY = <<-'EOS'
-      method_tags = { method: http_method.downcase! }
+      method_tags = { method: http_method.downcase }
       tracker.increment "rack.request.method", tags: method_tags, inherit_tags: true
       tracker.timing "rack.request.method.time", duration, tags: method_tags, inherit_tags: true
     EOS

data/lib/librato/rack/version.rb

@@ -1,5 +1,5 @@
 module Librato
   class Rack
-    VERSION = "2.0.3"
+    VERSION = "2.0.4"
   end
 end

data/test/integration/queue_wait_test.rb

@@ -19,19 +19,25 @@ class QueueWaitTest < Minitest::Test
   def test_milliseconds
     get '/milli'
 
+    # give jruby a bit more time since it can be slow
+    delta = defined?(JRUBY_VERSION) ? 5 : 4
+
     # puts "milli: #{aggregate["rack.request.queue.time"].inspect}"
     assert_equal 1, aggregate["rack.request.queue.time"][:count],
       'should track total queue time'
-    assert_in_delta 5, aggregate["rack.request.queue.time"][:sum], 4
+    assert_in_delta 5, aggregate["rack.request.queue.time"][:sum], delta
   end
 
   def test_microseconds
     get '/micro'
 
+    # give jruby a bit more time since it can be slow
+    delta = defined?(JRUBY_VERSION) ? 6 : 4
+
     # puts "micro: #{aggregate["rack.request.queue.time"].inspect}"
     assert_equal 1, aggregate["rack.request.queue.time"][:count],
       'should track total queue time'
-    assert_in_delta 10, aggregate["rack.request.queue.time"][:sum], 4
+    assert_in_delta 10, aggregate["rack.request.queue.time"][:sum], delta
   end
 
   def test_queue_start
@@ -46,20 +52,13 @@ class QueueWaitTest < Minitest::Test
   def test_with_t
     get '/with_t'
 
-    # puts "micro: #{aggregate["rack.request.queue.time"].inspect}"
-    assert_equal 1, aggregate["rack.request.queue.time"][:count],
-      'should track total queue time'
-    assert_in_delta 20, aggregate["rack.request.queue.time"][:sum], 6
-  end
-
-  def test_with_period
-    get '/with_period'
-
     # give jruby a bit more time since it can be slow
     delta = defined?(JRUBY_VERSION) ? 10 : 6
+
+    # puts "micro: #{aggregate["rack.request.queue.time"].inspect}"
     assert_equal 1, aggregate["rack.request.queue.time"][:count],
       'should track total queue time'
-    assert_in_delta 25, aggregate["rack.request.queue.time"][:sum], delta
+    assert_in_delta 20, aggregate["rack.request.queue.time"][:sum], delta
   end
 
   def test_with_period

data/test/integration/request_test.rb

@@ -61,6 +61,13 @@ class RequestTest < Minitest::Test
     assert_equal 1, aggregate.fetch("rack.request.method.time", tags: @tags.merge({ method: "post" }))[:count]
   end
 
+  def test_request_method_not_mutated
+    get '/', {}, {'REQUEST_METHOD' => "GET".freeze}
+
+    assert_equal 1, counters.fetch("rack.request.method", tags: @tags.merge({ method: "GET" }))[:value]
+    assert_equal 1, aggregate.fetch("rack.request.method.time", tags: @tags.merge({ method: "get" }))[:count]
+  end
+
   def test_track_exceptions
     begin
       get '/exception'

metadata

@@ -1,41 +1,24 @@
 --- !ruby/object:Gem::Specification
 name: librato-rack
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Matt Sanders
 autorequire: 
 bindir: bin
 cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDLjCCAhagAwIBAgIBADANBgkqhkiG9w0BAQUFADA9MQ0wCwYDVQQDDARydWJ5
-  MRcwFQYKCZImiZPyLGQBGRYHbGlicmF0bzETMBEGCgmSJomT8ixkARkWA2NvbTAe
-  Fw0xNzAxMTExODI3MDdaFw0xODAxMTExODI3MDdaMD0xDTALBgNVBAMMBHJ1Ynkx
-  FzAVBgoJkiaJk/IsZAEZFgdsaWJyYXRvMRMwEQYKCZImiZPyLGQBGRYDY29tMIIB
-  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA58LirwsWnKL1uuClQ0uwA1XL
-  GpxDuFzSosipiPkzZY3hiHazC8SHDREZQXlm7ITX/o+dueNoB7dt0BR3RPVipH7V
-  7cvbCUaZNjEXR5Lal6PsmUsbMTrddkvj3e7flmJv+kMj+teeJ7MDeJTU5wXXV9pD
-  ThiCDILJMF5CdP8Jru4rSBOP6RmmzYU+0cN5+5pt9xqrycA+Poo2ZuoUMCMsSBvl
-  PimM3PPvoWTuE41GTn/bLoOVoXQmdwZIbwUSVH8rCDjZSlttOst+xrBw4KG0dYUp
-  2UvEe8iCyqEMQ8fEZ7EXuP2WMVICutFbz8Pt4hIMq+OTnDX+mIfma7GvPaKAFwID
-  AQABozkwNzAJBgNVHRMEAjAAMB0GA1UdDgQWBBQBSxu9Jj4VTrXTpLujPwk9Kzwp
-  2jALBgNVHQ8EBAMCBLAwDQYJKoZIhvcNAQEFBQADggEBACvNsw1pGv72xp3LiDlZ
-  0tphNP/85RcYyJMklslG3tIYblyo71xHW1UbK5ArUK6k0BN43MuDn3pqLJQttVmi
-  bUdA3yYi13GeSrrAMlr4nH8Yt/Bn/XpZGliouJUBwh1BjG6dSj1iuR4/9pt9/LtO
-  QTdIc+07qGspypT0Uh/w/BodEcGuAaZZFlkU9vottTe6wWNnM6hfRExiSIsr+oVe
-  s8s83ObshjuSzjOqS56IBtNlPEL+D6ghjZZLP3lS6l9p70Pcpcl+IcE4veqZmmKC
-  sGepgRclC6UbZh+yQ3alXVghM2qsonAwI/rTNmFJN9kQn6nP9+f1Uf/qZFNcjn4L
-  9bg=
-  -----END CERTIFICATE-----
-date: 2017-06-23 00:00:00.000000000 Z
+- certs/librato-public.pem
+date: 2018-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: librato-metrics
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.0
   type: :runtime
@@ -43,6 +26,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.0
 - !ruby/object:Gem::Dependency
@@ -63,14 +49,14 @@ dependencies:
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 description: Rack middleware to report key app statistics and custom instrumentation
@@ -145,32 +131,32 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Use Librato Metrics with your rack application
 test_files:
-- test/apps/basic.ru
-- test/apps/custom.ru
-- test/apps/custom_suites.ru
-- test/apps/no_stats.ru
-- test/apps/queue_wait.ru
-- test/integration/custom_test.rb
-- test/integration/no_stats_test.rb
-- test/integration/no_suites_test.rb
-- test/integration/queue_wait_test.rb
-- test/integration/request_test.rb
-- test/integration/suites_test.rb
-- test/remote/tracker_test.rb
-- test/support/environment_helpers.rb
-- test/test_helper.rb
-- test/unit/collector/aggregator_test.rb
+- test/unit/collector_test.rb
 - test/unit/collector/counter_cache_test.rb
 - test/unit/collector/group_test.rb
-- test/unit/collector_test.rb
+- test/unit/collector/aggregator_test.rb
 - test/unit/rack/configuration/suites_test.rb
-- test/unit/rack/configuration_test.rb
 - test/unit/rack/logger_test.rb
 - test/unit/rack/tracker_test.rb
-- test/unit/rack/validating_queue_test.rb
+- test/unit/rack/configuration_test.rb
 - test/unit/rack/worker_test.rb
+- test/unit/rack/validating_queue_test.rb
+- test/integration/no_stats_test.rb
+- test/integration/queue_wait_test.rb
+- test/integration/request_test.rb
+- test/integration/custom_test.rb
+- test/integration/no_suites_test.rb
+- test/integration/suites_test.rb
+- test/support/environment_helpers.rb
+- test/test_helper.rb
+- test/apps/queue_wait.ru
+- test/apps/custom_suites.ru
+- test/apps/custom.ru
+- test/apps/no_stats.ru
+- test/apps/basic.ru
+- test/remote/tracker_test.rb

checksums.yaml.gz.sig

@@ -1,2 +0,0 @@
-s@��[�W����
�X�O���b�`HN�����*�=���
-6!C�j��=�F��U���^�^�~eU�"�Kݦ�x��,��1��鑜L>�����x�u�$�ڳ�~N�c����T�
%��E�h�ì>���z�����aZ8sb/�

data.tar.gz.sig

@@ -1,2 +0,0 @@
-�&���}}�I����*H��!����Fm!|���A"��´ޠi��l�-wPO�7ܩ�H&�
C���6i�!��x;��n�v\��86�f���TY��yf
S<�MD���A% �=���<�1~a
-���X�'�Nİ�����"��߯��o�X���V�u�����<,�����Ȍ�H|�D����d��\aFh7���

metadata.gz.sig

@@ -1,4 +0,0 @@
-�SY��c�	�]�;ql�}z���Z����l�A�U:����7��O暣�
-iD�����)��9���T�)'����M�!( ]�z<�~�Jظ��
-b�����
-CRęA;�tZ)l��ۅ?��5�G"	j���~Z�����1q�vk:�#H��Ū1����m��gR?o�ޥ���*:���j��rP��GR��-�td��F&Y�L�K�0�ο�Q�Q�����m�.�5ǎ��n	꾛��%?X�ֹ���f�wϑD