librato-metrics 2.1.0 → 2.1.1

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Changelog
 
+### Version 2.1.1
+* Fix `#empty?` to check queued payload (#137, Cyril David)
+
 ### Version 2.1.0
 * Add support for tagged measurements (#121)
 

data/README.md

@@ -5,6 +5,12 @@ Librato Metrics
 
 A convenient Ruby wrapper for the Librato Metrics API.
 
+---
+
+**NOTE:** Starting with version 2.1.0 librato-metrics requires a Librato account that [supports tagged metrics](https://www.librato.com/docs/kb/faq/account_questions/tags_or_sources/). If your Librato account doesn't yet support tagged metrics please use the [1.6.1 version](https://rubygems.org/gems/librato-metrics/versions/1.6.1).
+
+---
+
 This gem provides granular control for scripting interactions with the Metrics core API. It is well suited for integrations, scripts, workers & background jobs. If you want to submit from a web app, take at look at [librato-rails](https://github.com/librato/librato-rails) and/or [librato-rack](https://github.com/librato/librato-rack).
 
 ## Installation
@@ -334,4 +340,4 @@ We also maintain a set of [examples of common uses](https://github.com/librato/l
 
 ## Copyright
 
-Copyright (c) 2011-2016 [Librato Inc.](http://librato.com) See LICENSE for details.
+Copyright (c) 2011-2017 [Librato Inc.](http://librato.com) See LICENSE for details.

data/lib/librato/metrics/processor.rb

@@ -40,7 +40,7 @@ module Librato
       #
       # @return Boolean
       def submit
-        return true if self.queued.empty?
+        return true if self.empty?
         options = {per_request: @per_request}
         if persister.persist(self.client, self.queued, options)
           @last_submit_time = Time.now

data/lib/librato/metrics/queue.rb

@@ -75,7 +75,7 @@ module Librato
       #
       # @return Boolean
       def empty?
-        @queued.empty?
+        gauges.empty? && counters.empty? && measurements.empty?
       end
 
       # Remove all queued metrics

data/lib/librato/metrics/version.rb

@@ -1,5 +1,5 @@
 module Librato
   module Metrics
-    VERSION = "2.1.0"
+    VERSION = "2.1.1"
   end
 end

data/spec/unit/metrics/queue_spec.rb

@@ -301,6 +301,11 @@ module Librato
           subject.add foo: {type: :gauge, value: 121212}
           expect(subject.empty?).to be false
         end
+
+        it "returns true when nothing merged" do
+          subject.merge!(Librato::Metrics::Aggregator.new)
+          expect(subject.empty?).to be true
+        end
       end
 
       describe "#gauges" do
@@ -313,6 +318,14 @@ module Librato
         it "returns [] when no queued gauges" do
           expect(subject.gauges).to be_empty
         end
+
+        context "when there are no metrics" do
+          it "it does not persist and returns true" do
+            subject.merge!(Librato::Metrics::Aggregator.new)
+            subject.persister.return_value(false)
+            expect(subject.submit).to be true
+          end
+        end
       end
 
       describe "#last_submit_time" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: librato-metrics
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -36,7 +36,7 @@ cert_chain:
   alpaTFAzbFM2bDlwNzBQY3BjbCtJY0U0dmVxWm1tS0MKc0dlcGdSY2xDNlVi
   WmgreVEzYWxYVmdoTTJxc29uQXdJL3JUTm1GSk45a1FuNm5QOStmMVVmL3Fa
   Rk5jam40TAo5Ymc9Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
-date: 2017-01-25 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday