library_stdnums 1.3.0 → 1.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 64b7af58d62d20a1ff99b68af015614c53af9ff2
+  data.tar.gz: fcb1f9146bd02f860291116f1e99eb610ca78187
+SHA512:
+  metadata.gz: 211779b362a5fadc4cfb5b2743ddf28eaea4f199fa53aecba82a4c4e19ef45ae8a33f14292054ebd407f21897314c773169ed2c6952bfadd54a9de6b14f35b83
+  data.tar.gz: e44854b87dc3c53c9cbc9d6825a11c343110aca5bb865ebf23c49f3d788df6f42adee5dea12156cedceb116fa2859d7b2ca7bbcb3ffbc5f9d4c73078ab0229f3

data/ChangeLog.md

@@ -1,3 +1,6 @@
+* 1.4.0 (2013.10.23)
+  * Simplified gemfile/spec process
+  * Fixed backwards logic for ISBN.at_least_trying? and added tests
 * 1.3.0 (2013.05.24)
   * Added #at_least_trying? to do a basic syntax check for ISSN/ISBN
   * Overload #valid? for ISBN/ISSN such that it returns 'nil' for bad syntax and

data/Gemfile

@@ -1,14 +1,4 @@
-source :rubygems
+source 'https://rubygems.org/'
 
 gemspec
 
-group :development do
-  gem 'bundler',  '~> 1.0'
-  gem 'rake',  '~> 0.8'
-  gem 'minitest'
-end
-
-group :documentation do
-  gem 'kramdown'
-  gem 'yard',  '~> 0.7'
-end

data/lib/library_stdnums.rb

@@ -54,7 +54,7 @@ module StdNum
     
     # Does it even look like an ISBN?
     def self.at_least_trying? isbn
-      return !(reduce_to_basics(isbn, [10,13]))
+      reduce_to_basics(isbn, [10,13]) ? true : false
     end
     
 

data/lib/library_stdnums/version.rb

@@ -1,4 +1,4 @@
-module LibraryStdnums
+module StdNum
   # library_stdnums version
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/library_stdnums.gemspec

@@ -1,60 +1,29 @@
 # encoding: utf-8
 
-require 'yaml'
-
-Gem::Specification.new do |gem|
-  gemspec = YAML.load_file('gemspec.yml')
-
-  gem.name    = gemspec.fetch('name')
-  gem.version = gemspec.fetch('version') do
-                  lib_dir = File.join(File.dirname(__FILE__),'lib')
-                  $LOAD_PATH << lib_dir unless $LOAD_PATH.include?(lib_dir)
-
-                  require 'library_stdnums/version'
-                  LibraryStdnums::VERSION
-                end
-
-  gem.summary     = gemspec['summary']
-  gem.description = gemspec['description']
-  gem.licenses    = Array(gemspec['license'])
-  gem.authors     = Array(gemspec['authors'])
-  gem.email       = gemspec['email']
-  gem.homepage    = gemspec['homepage']
-
-  glob = lambda { |patterns| gem.files & Dir[*patterns] }
-
-  gem.files = `git ls-files`.split($/)
-  gem.files = glob[gemspec['files']] if gemspec['files']
-
-  gem.executables = gemspec.fetch('executables') do
-    glob['bin/*'].map { |path| File.basename(path) }
-  end
-  gem.default_executable = gem.executables.first if Gem::VERSION < '1.7.'
-
-  gem.extensions       = glob[gemspec['extensions'] || 'ext/**/extconf.rb']
-  gem.test_files       = glob[gemspec['test_files'] || 'spec/{**/}*_spec.rb}']
-  gem.extra_rdoc_files = glob[gemspec['extra_doc_files'] || '*.{txt,md}']
-
-  gem.require_paths = Array(gemspec.fetch('require_paths') {
-    %w[ext lib].select { |dir| File.directory?(dir) }
-  })
-
-  gem.requirements              = gemspec['requirements']
-  gem.required_ruby_version     = gemspec['required_ruby_version']
-  gem.required_rubygems_version = gemspec['required_rubygems_version']
-  gem.post_install_message      = gemspec['post_install_message']
-
-  split = lambda { |string| string.split(/,\s*/) }
-
-  if gemspec['dependencies']
-    gemspec['dependencies'].each do |name,versions|
-      gem.add_dependency(name,split[versions])
-    end
-  end
-
-  if gemspec['development_dependencies']
-    gemspec['development_dependencies'].each do |name,versions|
-      gem.add_development_dependency(name,split[versions])
-    end
-  end
+
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'library_stdnums/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "library_stdnums"
+  spec.version       = StdNum::VERSION
+  spec.authors       = ["Bill Dueber"]
+  spec.email         = ["none@nowhere.org"]
+  spec.summary       =  "A simple set of module functions to normalize, validate, and convert common library standard numbers"
+  spec.homepage      = "https://github.com/billdueber/library_stdnums"
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files`.split($/)
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  spec.extra_rdoc_files = spec.files.grep(%r{^doc/})
+
+  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "yard"
 end
+
+

data/spec/library_stdnums_spec.rb

@@ -64,6 +64,18 @@ describe "ISBN" do
   it "finds a good number valid" do
     StdNum::ISBN.valid?('9780306406157').must_equal true
   end
+  
+  it "says a good number is trying" do
+    StdNum::ISBN.at_least_trying?('9780306406157').must_equal true
+  end
+  
+  it "says bad data is not trying" do
+    StdNum::ISBN.at_least_trying?('978006406157').must_equal false
+    StdNum::ISBN.at_least_trying?('406157').must_equal false
+    StdNum::ISBN.at_least_trying?('$22').must_equal false
+    StdNum::ISBN.at_least_trying?('hello').must_equal false
+  end
+    
 
   it "finds a bad number invalid" do
     StdNum::ISBN.valid?('9780306406154').must_equal false

metadata

@@ -1,57 +1,77 @@
 --- !ruby/object:Gem::Specification
 name: library_stdnums
 version: !ruby/object:Gem::Version
-  version: 1.3.0
-  prerelease: 
+  version: 1.4.0
 platform: ruby
 authors:
 - Bill Dueber
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-05-24 00:00:00.000000000 Z
+date: 2013-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+        version: '1.3'
   prerelease: false
+  type: :development
+- !ruby/object:Gem::Dependency
+  name: rake
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: yard
+        version: '0'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0'
+  prerelease: false
   type: :development
+- !ruby/object:Gem::Dependency
+  name: minitest
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   prerelease: false
+  type: :development
+- !ruby/object:Gem::Dependency
+  name: yard
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0.7'
-description: A simple set of module functions to normalize, validate, and convert
-  common library standard numbers
-email: bill@dueber.com
+        version: '0'
+  prerelease: false
+  type: :development
+description:
+email:
+- none@nowhere.org
 executables: []
 extensions: []
-extra_rdoc_files:
-- ChangeLog.md
-- LICENSE.txt
-- README.md
+extra_rdoc_files: []
 files:
 - .gitignore
 - .travis.yml
@@ -61,7 +81,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemspec.yml
 - lib/library_stdnums.rb
 - lib/library_stdnums/version.rb
 - library_stdnums.gemspec
@@ -70,27 +89,28 @@ files:
 homepage: https://github.com/billdueber/library_stdnums
 licenses:
 - MIT
-post_install_message: 
+metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.23
-signing_key: 
-specification_version: 3
-summary: Normalize and validate ISBN / ISSN/ LCCN
-test_files: []
-has_rdoc: 
+rubyforge_project:
+rubygems_version: 2.1.9
+signing_key:
+specification_version: 4
+summary: A simple set of module functions to normalize, validate, and convert common library standard numbers
+test_files:
+- spec/library_stdnums_spec.rb
+- spec/spec_helper.rb
+has_rdoc:

data/gemspec.yml

@@ -1,11 +0,0 @@
-name: library_stdnums
-summary: "Normalize and validate ISBN / ISSN/ LCCN"
-description: "A simple set of module functions to normalize, validate, and convert common library standard numbers"
-license: MIT
-authors: Bill Dueber
-email: bill@dueber.com
-homepage: https://github.com/billdueber/library_stdnums
-
-development_dependencies:
-  bundler: ~> 1.0
-  yard: ~> 0.7