library_stdnums 1.2.0 → 1.3.0

data/ChangeLog.md

@@ -1,3 +1,7 @@
+* 1.3.0 (2013.05.24)
+  * Added #at_least_trying? to do a basic syntax check for ISSN/ISBN
+  * Overload #valid? for ISBN/ISSN such that it returns 'nil' for bad syntax and
+    'false' for good-looking syntax, but bad checkdigit
 * 1.2.0 (2012.07.24)
   * Added a bunch of tests for LCCN normalization from perl module Business::LCCN
     (http://search.cpan.org/~anirvan/Business-LCCN/)

data/lib/library_stdnums.rb

@@ -51,6 +51,12 @@ module StdNum
   # Validate, convert, and normalize ISBNs (10-digit or 13-digit)
   module ISBN
     extend Helpers
+    
+    # Does it even look like an ISBN?
+    def self.at_least_trying? isbn
+      return !(reduce_to_basics(isbn, [10,13]))
+    end
+    
 
     # Compute check digits for 10 or 13-digit ISBNs. See algorithm at
     # http://en.wikipedia.org/wiki/International_Standard_Book_Number
@@ -86,11 +92,13 @@ module StdNum
     # Check to see if the checkdigit is correct
     # @param [String] isbn The ISBN (we'll try to clean it up if possible)
     # @param [Boolean] preprocessed Set to true if the ISBN has already been through reduce_to_basics
-    # @return [Boolean] Whether or not the checkdigit is correct
+    # @return [Boolean] Whether or not the checkdigit is correct. Sneakily, return 'nil' for 
+    #  values that don't even look like ISBNs, and 'false' for those that look possible but
+    #  don't normalize / have bad checkdigits
     def self.valid? isbn, preprocessed = false
       return nil if isbn.nil?
       isbn = reduce_to_basics(isbn, [10,13]) unless preprocessed
-      return false unless isbn
+      return nil unless isbn
       return false unless isbn[-1..-1] == self.checkdigit(isbn, true)
       return true
     end
@@ -171,6 +179,13 @@ module StdNum
   module ISSN
     extend Helpers
 
+
+    # Does it even look like an ISSN?
+    def self.at_least_trying? isbn
+      return !(reduce_to_basics(issn, 8))
+    end
+
+
     # Compute the checkdigit of an ISSN
     # @param [String] issn The ISSN (we'll try to clean it up if possible)
     # @param [Boolean] preprocessed Set to true if the number has already been through reduce_to_basic
@@ -195,11 +210,13 @@ module StdNum
     # Check to see if the checkdigit is correct
     # @param [String] issn The ISSN (we'll try to clean it up if possible)
     # @param [Boolean] preprocessed Set to true if the number has already been through reduce_to_basic
-    # @return [Boolean] Whether or not the checkdigit is correct
+    # @return [Boolean] Whether or not the checkdigit is correct. Sneakily, return 'nil' for 
+    #  values that don't even look like ISBNs, and 'false' for those that look possible but
+    #  don't normalize / have bad checkdigits
 
     def self.valid? issn, preprocessed = false
       issn = reduce_to_basics issn, 8 unless preprocessed
-      return false unless issn
+      return nil unless issn
       return issn[-1..-1] == self.checkdigit(issn, true)
     end
 

data/lib/library_stdnums/version.rb

@@ -1,4 +1,4 @@
 module LibraryStdnums
   # library_stdnums version
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: library_stdnums
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-25 00:00:00.000000000 Z
+date: 2013-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -88,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Normalize and validate ISBN / ISSN/ LCCN