librarian 0.0.5 → 0.0.6

data/lib/librarian/chef/source/local.rb

@@ -45,6 +45,8 @@ module Librarian
           end
 
           def fetch_manifest!
+            expect_manifest
+
             read_manifest(name, manifest_path(found_path))
           end
 
@@ -67,6 +69,13 @@ module Librarian
             FileUtils.cp_r(found_path, install_path)
           end
 
+        private
+
+          def expect_manifest
+            return if found_path && manifest_path(found_path)
+            raise Error, "No metadata file found for #{name} from #{source}! If this should be a cookbook, you might consider contributing a metadata file upstream or forking the cookbook to add your own metadata file."
+          end
+
         end
 
         def manifest_class

data/lib/librarian/manifest_set.rb

@@ -78,8 +78,10 @@ module Librarian
       until names.empty?
         name = names.shift
         manifest = index.delete(name)
-        manifest.dependencies.each do |dependency|
-          names << dependency.name
+        if manifest
+          manifest.dependencies.each do |dependency|
+            names << dependency.name
+          end
         end
       end
       self

data/lib/librarian/version.rb

@@ -1,3 +1,3 @@
 module Librarian
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/chef/git_source_spec.rb

@@ -168,6 +168,28 @@ module Librarian
 
         end
 
+        context "missing a metadata" do
+          git_path = tmp_path.join('big-git-repo')
+
+          it "should explain the problem" do
+            repo_path = tmp_path.join("repo/resolve")
+            repo_path.rmtree if repo_path.exist?
+            repo_path.mkpath
+            repo_path.join("cookbooks").mkpath
+            cheffile = Helpers.strip_heredoc(<<-CHEFFILE)
+              cookbook "sample",
+                :git => #{git_path.to_s.inspect}
+            CHEFFILE
+            repo_path.join("Cheffile").open("wb") { |f| f.write(cheffile) }
+            Chef.stub!(:project_path) { repo_path }
+
+            expect { Chef.resolve! }.
+              to raise_error(Librarian::Error, /no metadata file found/i)
+            repo_path.join("Cheffile.lock").should_not be_exist
+            repo_path.join("cookbooks/sample").should_not be_exist
+          end
+        end
+
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: librarian
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-17 00:00:00.000000000Z
+date: 2011-09-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
-  requirement: &25703580 !ruby/object:Gem::Requirement
+  requirement: &22746980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *25703580
+  version_requirements: *22746980
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &25703120 !ruby/object:Gem::Requirement
+  requirement: &22746540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *25703120
+  version_requirements: *22746540
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &25702660 !ruby/object:Gem::Requirement
+  requirement: &22746080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *25702660
+  version_requirements: *22746080
 - !ruby/object:Gem::Dependency
   name: aruba
-  requirement: &25702220 !ruby/object:Gem::Requirement
+  requirement: &22745600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *25702220
+  version_requirements: *22745600
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &25701800 !ruby/object:Gem::Requirement
+  requirement: &22745180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *25701800
+  version_requirements: *22745180
 - !ruby/object:Gem::Dependency
   name: chef
-  requirement: &25701280 !ruby/object:Gem::Requirement
+  requirement: &22705600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0.10'
   type: :runtime
   prerelease: false
-  version_requirements: *25701280
+  version_requirements: *22705600
 description: Librarian
 email:
 - y_feldblum@yahoo.com