libmf 0.2.0 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58c3cf0afbb36ff976cb7641104f363795499023ce04c859beedf17bccaaffa1
-  data.tar.gz: '09a6b70c631ae252b24bd83c3cbb08ff3a9468d6b174b0255cf8223aaf77ea4d'
+  metadata.gz: ca5a2bbda585f7e2f57630d20dfb6cf6091ab33e90227edd277c457af7f8dac7
+  data.tar.gz: 3f8a1612c831223e552cf5af4172f31080d297f2e3f059624d66790613333890
 SHA512:
-  metadata.gz: ad1aad8cdb571fd5fa99aa121a67cf172f6686b793a89a82b555005116378a07772c6675e20308f8575419d618edfa368c0adef738da06847f0c06e860ab650e
-  data.tar.gz: 87f4260c2bccc5f5da8c44497d656fd367467b1d403de6584d802700359f455e55e7f9cbf71db515a5252012e27ace4cf52f5e284528b05a1a6b0be72c693a0d
+  metadata.gz: 6d8cf1bf142c4e365c2b01a10c5e407d331d24d8410f8ee2b262c6ca6c94dfe129c5ac0a3dc6ae97e0739884aaeec9483c39546714975a8e9929c8a63799f15c
+  data.tar.gz: 80356261c846d506160df89424b9f67d070908e1cc1f9c583e83cbbec5b7ebce272acb5146e447dd1394bb7c5d3268bf00837dc0814eb5ccb23d8c23c53efae3

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 0.2.4 (2021-08-05)
+
+- Fixed memory leak
+
+## 0.2.3 (2021-03-14)
+
+- Added ARM shared library for Linux
+
+## 0.2.2 (2021-02-04)
+
+- Reduced allocations
+- Improved ARM detection
+
+## 0.2.1 (2020-12-28)
+
+- Added ARM shared library for Mac
+
 ## 0.2.0 (2020-03-26)
 
 - Changed to BSD 3-Clause license to match LIBMF

data/LICENSE.txt

@@ -1,6 +1,7 @@
 BSD 3-Clause License
 
-Copyright (c) 2019-2020, Andrew Kane
+Copyright (c) 2014-2015, The LIBMF Project
+Copyright (c) 2019-2021, Andrew Kane
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

data/README.md

@@ -4,7 +4,7 @@
 
 Check out [Disco](https://github.com/ankane/disco) for higher-level collaborative filtering
 
-[![Build Status](https://travis-ci.org/ankane/libmf.svg?branch=master)](https://travis-ci.org/ankane/libmf) [![Build status](https://ci.appveyor.com/api/projects/status/92fbip1bd8sjd2tj/branch/master?svg=true)](https://ci.appveyor.com/project/ankane/libmf/branch/master)
+[![Build Status](https://github.com/ankane/libmf/workflows/build/badge.svg?branch=master)](https://github.com/ankane/libmf/actions)
 
 ## Installation
 
@@ -39,14 +39,19 @@ Make predictions
 model.predict(row_index, column_index)
 ```
 
-Get the bias and latent factors
+Get the latent factors (these approximate the training matrix)
 
 ```ruby
-model.bias
 model.p_factors
 model.q_factors
 ```
 
+Get the bias (average of all elements in the training matrix)
+
+```ruby
+model.bias
+```
+
 Save the model to a file
 
 ```ruby

data/lib/libmf.rb

@@ -15,9 +15,17 @@ module Libmf
     if Gem.win_platform?
       "mf.dll"
     elsif RbConfig::CONFIG["host_os"] =~ /darwin/i
-      "libmf.dylib"
+      if RbConfig::CONFIG["host_cpu"] =~ /arm/i
+        "libmf.arm64.dylib"
+      else
+        "libmf.dylib"
+      end
     else
-      "libmf.so"
+      if RbConfig::CONFIG["host_cpu"] =~ /aarch64/i
+        "libmf.arm64.so"
+      else
+        "libmf.so"
+      end
     end
   vendor_lib = File.expand_path("../vendor/#{lib_name}", __dir__)
   self.ffi_lib = [vendor_lib]

data/lib/libmf/ffi.rb

@@ -43,15 +43,22 @@ module Libmf
         :b, :float,
         :p, :pointer,
         :q, :pointer
+
+      def self.release(pointer)
+        unless pointer.null?
+          ref = ::FFI::MemoryPointer.new(:pointer).write_pointer(pointer)
+          FFI.mf_destroy_model(ref)
+        end
+      end
     end
 
     attach_function :mf_get_default_param, [], Parameter.by_value
     attach_function :mf_read_problem, [:string], Problem.by_value
     attach_function :mf_save_model, [Model.by_ref, :string], :int
-    attach_function :mf_load_model, [:string], Model.by_ref
-    attach_function :mf_destroy_model, [Model.by_ref], :void
-    attach_function :mf_train, [Problem.by_ref, Parameter.by_value], Model.by_ref
-    attach_function :mf_train_with_validation, [Problem.by_ref, Problem.by_ref, Parameter.by_value], Model.by_ref
+    attach_function :mf_load_model, [:string], Model.auto_ptr
+    attach_function :mf_destroy_model, [:pointer], :void
+    attach_function :mf_train, [Problem.by_ref, Parameter.by_value], Model.auto_ptr
+    attach_function :mf_train_with_validation, [Problem.by_ref, Problem.by_ref, Parameter.by_value], Model.auto_ptr
     attach_function :mf_predict, [Model.by_ref, :int, :int], :float
     attach_function :mf_cross_validation, [Problem.by_ref, :int, Parameter.by_value], :double
   end

data/lib/libmf/model.rb

@@ -111,10 +111,11 @@ module Libmf
 
       # TODO do in C for better performance
       # can use FIX2INT() and RFLOAT_VALUE() instead of pack
+      # and write directly to C string
       buffer = String.new
+      pack_format = "iif"
       data.each do |row|
-        row[0, 2].pack("i*".freeze, buffer: buffer)
-        row[2, 1].pack("f".freeze, buffer: buffer)
+        row.pack(pack_format, buffer: buffer)
       end
 
       r = ::FFI::MemoryPointer.new(FFI::Node, data.size)

data/lib/libmf/version.rb

@@ -1,3 +1,3 @@
 module Libmf
-  VERSION = "0.2.0"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: libmf
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.4
 platform: ruby
 authors:
 - Andrew Kane
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-26 00:00:00.000000000 Z
+date: 2021-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -24,78 +24,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
-  name: benchmark-ips
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: numo-narray
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: 
-email: andrew@chartkick.com
+description:
+email: andrew@ankane.org
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -110,6 +40,8 @@ files:
 - vendor/COPYRIGHT
 - vendor/demo/real_matrix.te.txt
 - vendor/demo/real_matrix.tr.txt
+- vendor/libmf.arm64.dylib
+- vendor/libmf.arm64.so
 - vendor/libmf.dylib
 - vendor/libmf.so
 - vendor/mf.dll
@@ -117,7 +49,7 @@ homepage: https://github.com/ankane/libmf
 licenses:
 - BSD-3-Clause
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -132,8 +64,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: Large-scale sparse matrix factorization for Ruby
 test_files: []